)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"d4445299e3a4417ea14fba18c2ea937fd05f7c97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b89c778e_7354eebc","updated":"2023-04-04 18:43:24.000000000","message":"Adding downstream results:\n(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_vdpa\nThe specified regex doesn\u0027t match with anything(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_vdpa\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAColdMigration.test_guest_creation_with_vdpa_port [23.076184s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAColdMigration.test_revert_vdpa_cold_migration [124.214394s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAColdMigration.test_vdpa_cold_migration [121.267677s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAResizeInstance.test_guest_creation_with_vdpa_port [18.825955s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAResizeInstance.test_vdpa_to_standard_resize [108.608575s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPASmokeTests.test_guest_creation_with_vdpa_port [17.687240s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 6 tests in 422.5280 sec.\n - Passed: 6\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 413.6800 sec.","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c9d78c2342aba68a981a717c61287a9289c7a01d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3412199_963cffdf","updated":"2023-04-03 16:19:13.000000000","message":"recheck no avaiable build logs\n\nthis looks ok overall.\n\nit would be nice to add shelve and maybe evacuate to get full coverage.","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5c41faea2ba15099765a33f7bb48c27083d7e451","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fef643fc_4000bfbe","updated":"2023-04-05 16:46:34.000000000","message":"upgrading to +2 based on upstream and down stream ci results","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"063c42e23ab64fb8cd9db7123ea97c480e43349e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88f45b22_5e36f657","updated":"2023-04-05 21:12:07.000000000","message":"Downstream results:\n(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_vdpa\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAColdMigration.test_guest_creation_with_vdpa_port [27.779967s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAColdMigration.test_revert_vdpa_cold_migration [132.982280s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAColdMigration.test_vdpa_cold_migration [112.843137s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAResizeInstance.test_guest_creation_with_vdpa_port [26.055431s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPAResizeInstance.test_vdpa_to_standard_resize [123.190142s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_vdpa.VDPASmokeTests.test_guest_creation_with_vdpa_port [20.082489s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 6 tests in 451.8436 sec.\n - Passed: 6\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 442.9334 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (6 tests) \u003d\u003e 0:07:31.843649\n","commit_id":"f31b8d85b661a6b0f200511e915e3c1ada2a83e8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"55e8730612bce7b7e563dc4a730cdda1aabc9454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0aa950bc_720ca04c","updated":"2023-04-14 16:01:02.000000000","message":"See inline, I didn\u0027t make myself clear. That being said, I\u0027ve strung you along long enough at this point, LGTM","commit_id":"f31b8d85b661a6b0f200511e915e3c1ada2a83e8"}],"whitebox_tempest_plugin/api/compute/test_vdpa.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c9d78c2342aba68a981a717c61287a9289c7a01d","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        waiters.wait_for_server_status(self.servers_client, server_id,"},{"line_number":110,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if revert:"},{"line_number":113,"context_line":"            self.admin_servers_client.revert_resize_server(server_id)"},{"line_number":114,"context_line":"            assert_func \u003d self.assertEqual"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            self.admin_servers_client.confirm_resize_server(server_id)"},{"line_number":117,"context_line":"            assert_func \u003d self.assertNotEqual"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":120,"context_line":"                                       server_id, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7fa7c8d6_bb417f46","line":117,"range":{"start_line":112,"start_character":8,"end_line":117,"end_character":45},"updated":"2023-04-03 16:19:13.000000000","message":"nit: i would prefer to define this where you invoke the assert or just put it inline.\n\nhttps://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/822354/8\n\ni.e.\n\n        if revert:\n            self.admin_servers_client.revert_resize_server(server_id)\n            self.assertEqual(src_host, dst_host)\n        else:\n            self.admin_servers_client.confirm_resize_server(server_id)\n            self.assertNotEqual(src_host, dst_host)\n            \nthis add more complexity then is reqired","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9c3c19714850385bdc6235e91dca255611560757","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        waiters.wait_for_server_status(self.servers_client, server_id,"},{"line_number":110,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if revert:"},{"line_number":113,"context_line":"            self.admin_servers_client.revert_resize_server(server_id)"},{"line_number":114,"context_line":"            assert_func \u003d self.assertEqual"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            self.admin_servers_client.confirm_resize_server(server_id)"},{"line_number":117,"context_line":"            assert_func \u003d self.assertNotEqual"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":120,"context_line":"                                       server_id, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f506d25_517b2c0f","line":117,"range":{"start_line":112,"start_character":8,"end_line":117,"end_character":45},"in_reply_to":"3ccd6082_243415ff","updated":"2023-04-05 16:59:02.000000000","message":"Ack","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5e06410ba7582574e616781bc24ab83fe0d7039b","unresolved":true,"context_lines":[{"line_number":109,"context_line":"        waiters.wait_for_server_status(self.servers_client, server_id,"},{"line_number":110,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if revert:"},{"line_number":113,"context_line":"            self.admin_servers_client.revert_resize_server(server_id)"},{"line_number":114,"context_line":"            assert_func \u003d self.assertEqual"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            self.admin_servers_client.confirm_resize_server(server_id)"},{"line_number":117,"context_line":"            assert_func \u003d self.assertNotEqual"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":120,"context_line":"                                       server_id, \u0027ACTIVE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ccd6082_243415ff","line":117,"range":{"start_line":112,"start_character":8,"end_line":117,"end_character":45},"in_reply_to":"7fa7c8d6_bb417f46","updated":"2023-04-05 16:54:25.000000000","message":"+1","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5e06410ba7582574e616781bc24ab83fe0d7039b","unresolved":true,"context_lines":[{"line_number":158,"context_line":"            port[\u0027port\u0027][\u0027id\u0027]"},{"line_number":159,"context_line":"        )"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_revert_vdpa_cold_migration(self):"},{"line_number":162,"context_line":"        port \u003d self._create_port_from_vnic_type("},{"line_number":163,"context_line":"            net\u003dself.network,"},{"line_number":164,"context_line":"            vnic_type\u003d\u0027vdpa\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc32f1cc_7658291e","line":161,"updated":"2023-04-05 16:54:25.000000000","message":"Could we not unify this method and the one above, call it something like _test_vdpa_cold_migration(revert\u003dFalse), inline _cold_migrate_server(), and call it from two \"real\" test methods, test_vdpa_cold_migration() that leaves the revert kwarg at its default value, and test_vdpa_revert() that passes revert\u003dTrue?","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9c3c19714850385bdc6235e91dca255611560757","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            port[\u0027port\u0027][\u0027id\u0027]"},{"line_number":159,"context_line":"        )"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_revert_vdpa_cold_migration(self):"},{"line_number":162,"context_line":"        port \u003d self._create_port_from_vnic_type("},{"line_number":163,"context_line":"            net\u003dself.network,"},{"line_number":164,"context_line":"            vnic_type\u003d\u0027vdpa\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7168e788_375e8995","line":161,"in_reply_to":"dc32f1cc_7658291e","updated":"2023-04-05 16:59:02.000000000","message":"Yeah I see what you mean, sounds good to me let me make those changes.","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"}],"whitebox_tempest_plugin/api/compute/test_vgpu.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"55e8730612bce7b7e563dc4a730cdda1aabc9454","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        if CONF.compute.min_compute_nodes \u003c 2:"},{"line_number":323,"context_line":"            msg \u003d \"Need two or more compute nodes to execute cold migration\""},{"line_number":324,"context_line":"            raise cls.skipException(msg)"},{"line_number":325,"context_line":"        if not CONF.compute_feature_enabled.vgpu_cold_migration_supported:"},{"line_number":326,"context_line":"            msg \u003d \"vGPU Cold Migration support needed in order to run tests\""},{"line_number":327,"context_line":"            raise cls.skipException(msg)"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"09e38153_ae1c9164","line":325,"updated":"2023-04-14 16:01:02.000000000","message":"I didn\u0027t meant to move this in the same patch as the new VDPA movement tests, just that in retrospect it should have been in compute_feature_enabled, and should be moved in a subsequent patch.","commit_id":"f31b8d85b661a6b0f200511e915e3c1ada2a83e8"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5e06410ba7582574e616781bc24ab83fe0d7039b","unresolved":true,"context_lines":[{"line_number":287,"context_line":"        help\u003d\"The NUMA Node ID that has affinity to the NIC connected to the \""},{"line_number":288,"context_line":"             \"physnet defined in \u0027sriov_physnet\u0027\"),"},{"line_number":289,"context_line":"    cfg.BoolOpt("},{"line_number":290,"context_line":"        \u0027vgpu_cold_migration_supported\u0027,"},{"line_number":291,"context_line":"        default\u003dFalse,"},{"line_number":292,"context_line":"        help\u003d\u0027Cold migration and resize supported for guest instances \u0027"},{"line_number":293,"context_line":"             \u0027with vGPU devices\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ea34a06_e3de73dc","line":290,"updated":"2023-04-05 16:54:25.000000000","message":"This should have gone into compute_features below...","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9c3c19714850385bdc6235e91dca255611560757","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        help\u003d\"The NUMA Node ID that has affinity to the NIC connected to the \""},{"line_number":288,"context_line":"             \"physnet defined in \u0027sriov_physnet\u0027\"),"},{"line_number":289,"context_line":"    cfg.BoolOpt("},{"line_number":290,"context_line":"        \u0027vgpu_cold_migration_supported\u0027,"},{"line_number":291,"context_line":"        default\u003dFalse,"},{"line_number":292,"context_line":"        help\u003d\u0027Cold migration and resize supported for guest instances \u0027"},{"line_number":293,"context_line":"             \u0027with vGPU devices\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"fbe00583_0f06ea7e","line":290,"in_reply_to":"5ea34a06_e3de73dc","updated":"2023-04-05 16:59:02.000000000","message":"Ack","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5e06410ba7582574e616781bc24ab83fe0d7039b","unresolved":true,"context_lines":[{"line_number":297,"context_line":"        help\u003d\u0027Dictionary mapping of the vGPU custom traits to the unique \u0027"},{"line_number":298,"context_line":"             \u0027subsystem id that corresponds with the vGPU device e.g. \u0027"},{"line_number":299,"context_line":"             \u0027CUSTOM_NVIDIA_11:nvidia-319,CUSTOM_NVIDIA_12:nvidia-320\u0027),"},{"line_number":300,"context_line":"    cfg.BoolOpt("},{"line_number":301,"context_line":"        \u0027vdpa_cold_migration_supported\u0027,"},{"line_number":302,"context_line":"        default\u003dFalse,"},{"line_number":303,"context_line":"        help\u003d\u0027Cold migration and resize supported for guest instances \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"4df400f5_67cc65c0","line":300,"updated":"2023-04-05 16:54:25.000000000","message":"I suppose this is here because of the vgpu one above, but it should really go below","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"9c3c19714850385bdc6235e91dca255611560757","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        help\u003d\u0027Dictionary mapping of the vGPU custom traits to the unique \u0027"},{"line_number":298,"context_line":"             \u0027subsystem id that corresponds with the vGPU device e.g. \u0027"},{"line_number":299,"context_line":"             \u0027CUSTOM_NVIDIA_11:nvidia-319,CUSTOM_NVIDIA_12:nvidia-320\u0027),"},{"line_number":300,"context_line":"    cfg.BoolOpt("},{"line_number":301,"context_line":"        \u0027vdpa_cold_migration_supported\u0027,"},{"line_number":302,"context_line":"        default\u003dFalse,"},{"line_number":303,"context_line":"        help\u003d\u0027Cold migration and resize supported for guest instances \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"14561e26_f61067be","line":300,"in_reply_to":"4df400f5_67cc65c0","updated":"2023-04-05 16:59:02.000000000","message":"Ack","commit_id":"f35c94c25c3190c646b50a2749da0d8c26b34483"}]}