)]}'
{"id":"openstack%2Fwhitebox-tempest-plugin~885413","triplet_id":"openstack%2Fwhitebox-tempest-plugin~master~I62f519db8709c23824a0fee1a6ce63ab3bf1f9e2","project":"openstack/whitebox-tempest-plugin","branch":"master","topic":"vlan_id_int","attention_set":{},"removed_from_attention_set":{"8864":{"account":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"last_update":"2023-06-08 20:09:07.000000000","reason":"\u003cGERRIT_ACCOUNT_8864\u003e replied on the change","reason_account":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}},"34309":{"account":{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"},"last_update":"2023-06-07 19:41:42.000000000","reason":"Change was abandoned"},"31033":{"account":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"last_update":"2023-06-08 22:15:54.000000000","reason":"Change was submitted"},"29455":{"account":{"_account_id":29455,"name":"Jason Grosso","email":"jgrosso@redhat.com","username":"jgrosso"},"last_update":"2023-06-07 19:41:42.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I62f519db8709c23824a0fee1a6ce63ab3bf1f9e2","subject":"Convert the XML vlan value found from str to int","status":"MERGED","created":"2023-06-06 21:13:38.000000000","updated":"2023-06-08 22:15:54.000000000","submitted":"2023-06-08 22:15:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"885413-vlan_id_int","meta_rev_id":"088721f860fa0386f489550f91c8e9e35c6b2781","_number":885413,"virtual_id_number":885413,"owner":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-06-08 22:15:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":2,"date":"2023-06-08 20:09:07.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"all":[{"value":1,"date":"2023-06-08 20:09:07.000000000","_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"},{"_account_id":29455,"name":"Jason Grosso","email":"jgrosso@redhat.com","username":"jgrosso"}],"reviewers":{"REVIEWER":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29455,"name":"Jason Grosso","email":"jgrosso@redhat.com","username":"jgrosso"},{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-06-06 21:14:36.000000000","updated_by":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"reviewer":{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"},"state":"REVIEWER"},{"updated":"2023-06-06 21:14:36.000000000","updated_by":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"reviewer":{"_account_id":29455,"name":"Jason Grosso","email":"jgrosso@redhat.com","username":"jgrosso"},"state":"REVIEWER"},{"updated":"2023-06-06 21:14:36.000000000","updated_by":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"REVIEWER"},{"updated":"2023-06-06 22:22:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"640cf90aad760fc2a933d040742d7fdfc4b95978","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2023-06-06 21:13:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"13cd73cb2745cb6ca4653bf712b1c418b3505b5e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-06 22:22:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e33a7bd8c9bc4f25b33f55a18521d425\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1f5b5fb79c8741338c9c8546ae3d537a : SUCCESS in 2m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/dc29f0327946474da41a64edfc35c837 : SUCCESS in 3m 03s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/672a0942dd1b4d558b40eec9f2d5fc9d : SUCCESS in 2m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cbb3a237992d41a2993c578da29d3335 : SUCCESS in 3m 16s\n- whitebox-devstack-multinode https://zuul.opendev.org/t/openstack/build/e34e1a3809c14cecb8abd40de18069fb : SUCCESS in 1h 07m 29s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/0f5f6d8bf8e0419ebe3241d56c689dd8 : SUCCESS in 2m 50s","accounts_in_message":[],"_revision_number":1},{"id":"6ff4fb81c3de8afa7c045e7cd2ee44ec6c4f6d96","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2023-06-07 17:04:57.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d8adce59e9c1a92925f9fd63c7012952198bb522","tag":"autogenerated:gerrit:abandon","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2023-06-07 19:41:42.000000000","message":"Abandoned\n\nI believe there is a better solution for this upstream and would also like to get better root cause of what is happening.","accounts_in_message":[],"_revision_number":1},{"id":"a71740109dfd5d211d8729ff3354a101bdd05ee4","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2023-06-07 19:42:58.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ef4e28c83243155b5c7f6d5f39ad451103de4093","tag":"autogenerated:gerrit:restore","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2023-06-08 20:02:59.000000000","message":"Restored","accounts_in_message":[],"_revision_number":1},{"id":"7ba550b5ae0134283fafb76fe5abc3e114c41769","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"date":"2023-06-08 20:03:05.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:TRIVIAL_REBASE OR is:MIN\")\n* Verified+1\n","accounts_in_message":[],"_revision_number":2},{"id":"a378986ed379738c593bc899de1b72e90e3ec2ff","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2023-06-08 20:09:07.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"86db1750c2aa0f4bd8e7848a4f05aa3ecd890140","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-08 21:08:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/597611d318774236b91e736a21159590\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1a8226d872c743009fc3c1b804c42427 : SUCCESS in 2m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8e591208c19d49a4b83be699724daa3f : SUCCESS in 2m 50s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/c6986beef7b6404e9b1ba62f228fccda : SUCCESS in 2m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/093d3182d6454bce97019818a60193da : SUCCESS in 3m 47s\n- whitebox-devstack-multinode https://zuul.opendev.org/t/openstack/build/e7ef2a88f10045efa4cf0e26d8e855b2 : SUCCESS in 1h 04m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6679aa9b3eb24490812bf9c14c3fce60 : SUCCESS in 2m 54s","accounts_in_message":[],"_revision_number":2},{"id":"bb2943e26a070c073e19f60788621e052193c326","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-08 21:08:34.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c750a9c838c9610c76f774d974f8b154c1a8cd0b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-08 22:15:53.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7768425eeac24aef875e07c9ec3f5217\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/23ef37c6b36d4c868640447c2e8617da : SUCCESS in 2m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a72a0c25625c4cac9cd529dffd930810 : SUCCESS in 2m 38s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/19d958b515e146f1bbeaaa0a37046f75 : SUCCESS in 3m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/950452cbdde94d2eba92923709c25bab : SUCCESS in 2m 35s\n- whitebox-devstack-multinode https://zuul.opendev.org/t/openstack/build/702917d47aaf4a99a71d0e5face0771e : SUCCESS in 1h 06m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/686223f28eef499a83ded01536a72e3e : SUCCESS in 2m 48s","accounts_in_message":[],"_revision_number":2},{"id":"088721f860fa0386f489550f91c8e9e35c6b2781","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-06-08 22:15:54.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"401cb527c6eb4c3705768e3681c4b383ce44f796","revisions":{"1a99651e8cd47f9a063c1590244bca687ea37d3e":{"kind":"REWORK","_number":1,"created":"2023-06-06 21:13:38.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/13/885413/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/13/885413/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/13/885413/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/13/885413/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/13/885413/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/13/885413/1"}}},"commit":{"parents":[{"commit":"8a8248857818b8507382b0d012f43387b7c525dc","subject":"Add socket affinity testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/8a8248857818b8507382b0d012f43387b7c525dc"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2023-06-06 21:11:16.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2023-06-06 21:11:18.000000000","tz":-240},"subject":"Convert found vlan to int","message":"Convert found vlan to int\n\nStarting with 17 the vlan id stored in guest xml is a str, e.g.:\n\n    \u003cinterface type\u003d\u0027hostdev\u0027 managed\u003d\u0027yes\u0027\u003e\n      \u003cmac address\u003d\u0027fa:16:3e:5f:c6:99\u0027/\u003e\n      \u003cdriver name\u003d\u0027vfio\u0027/\u003e\n      \u003csource\u003e\n        \u003caddress type\u003d\u0027pci\u0027 domain\u003d\u00270x0000\u0027 bus\u003d\u00270x22\u0027 slot\u003d\u00270x06\u0027 function\u003d\u00270x7\u0027/\u003e\n      \u003c/source\u003e\n      \u003cvlan\u003e\n        \u003ctag id\u003d\u00272000\u0027/\u003e\n      \u003c/vlan\u003e\n      \u003calias name\u003d\u0027hostdev0\u0027/\u003e\n\nTo keep backwords compatibility with older versions when checking vlan,\nexplicitly cast to int when making the comparison.\n\nChange-Id: I62f519db8709c23824a0fee1a6ce63ab3bf1f9e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/1a99651e8cd47f9a063c1590244bca687ea37d3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/1a99651e8cd47f9a063c1590244bca687ea37d3e"}]},"branch":"refs/heads/master"},"401cb527c6eb4c3705768e3681c4b383ce44f796":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-06-08 20:03:05.000000000","uploader":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"ref":"refs/changes/13/885413/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/whitebox-tempest-plugin","ref":"refs/changes/13/885413/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/13/885413/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/13/885413/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/13/885413/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/whitebox-tempest-plugin refs/changes/13/885413/2"}}},"commit":{"parents":[{"commit":"8a8248857818b8507382b0d012f43387b7c525dc","subject":"Add socket affinity testing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/8a8248857818b8507382b0d012f43387b7c525dc"}]}],"author":{"name":"James Parker","email":"jparker@redhat.com","date":"2023-06-06 21:11:16.000000000","tz":-240},"committer":{"name":"James Parker","email":"jparker@redhat.com","date":"2023-06-08 20:02:35.000000000","tz":-240},"subject":"Convert the XML vlan value found from str to int","message":"Convert the XML vlan value found from str to int\n\nTo update that created a vlan ID parameter for SR-IOV (sriov_vlan_id)\n[1], introduces the parameter as an int. When checking the vlan tag in\nthe guest it will return as a str causing the check to fail e.g.:\n\n\"testtools.matchers._impl.MismatchError: 2000 !\u003d \u00272000\u0027: Interface should have have vlan tag 2000 but instead it is tagged with 2000\"\n\nCasting the vlan tag found in the XML as an int to ensure the check\nmatches.\n\n[1] https://opendev.org/openstack/whitebox-tempest-plugin/commit/f7104a681d2e808642ea65132a2a3ad6997a614f\n\nChange-Id: I62f519db8709c23824a0fee1a6ce63ab3bf1f9e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/401cb527c6eb4c3705768e3681c4b383ce44f796"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/whitebox-tempest-plugin/commit/401cb527c6eb4c3705768e3681c4b383ce44f796"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}