)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"854afd9da6eec3f53edf1fb0ceeabcab2b04fdbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f68c8d1_28fcc01f","updated":"2024-02-16 19:50:47.000000000","message":"recheck","commit_id":"a9085266cf64ab5fd187fe71f2a656d0c9a74c81"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3beca3c96eedfacc44538821cfcf9f1427b58b8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c0189cdc_41a9e891","updated":"2024-02-20 16:30:56.000000000","message":"I think the nit inline is worth fixing, and then a question","commit_id":"c528091f2690a277c6ca1cf806df03f933429a93"}],"whitebox_tempest_plugin/api/compute/test_viommu_devices.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3beca3c96eedfacc44538821cfcf9f1427b58b8d","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        super(ViommuTestTQ35ViaImage, self).setUp()"},{"line_number":31,"context_line":"        self.viommu_intel_flavor \u003d self.create_flavor("},{"line_number":32,"context_line":"            extra_specs\u003d{\"hw:viommu_model\": \u0027intel\u0027})"},{"line_number":33,"context_line":"        self.viommu_image_id \u003d self.copy_default_image(hw_machine_type\u003d\u0027q35\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _get_iommu_xml_element(self, server):"},{"line_number":36,"context_line":"        root \u003d self.get_server_xml(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"66cf7a82_7e8d783d","line":33,"updated":"2024-02-20 16:30:56.000000000","message":"nit: technically this is a q35_image_id, not viommu, I\u0027d rather it be referred to what it is.","commit_id":"c528091f2690a277c6ca1cf806df03f933429a93"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"3beca3c96eedfacc44538821cfcf9f1427b58b8d","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        self._assert_viommu_not_present(server)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class VIommuTestQ35viaComputeHost(ViommuTestTQ35ViaImage):"},{"line_number":83,"context_line":"    \"\"\"Test the creation of guests with attached Virtual IOMMU intel devices."},{"line_number":84,"context_line":"    Q35 is is configured on the compute hosts via [libvirt]/hw_machine_type"},{"line_number":85,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"f632260c_272b80b8","line":82,"updated":"2024-02-20 16:30:56.000000000","message":"Is this actually valuable? Seems to be this just tests the default machine type config option.\n\nI guess if we really a test for that, we can have a different test that just takes a declaration of the machine type that was set, and then asserts that it\u0027s reflected correctly in the XML.\n\nBut I\u0027m not convinced we need this here...","commit_id":"c528091f2690a277c6ca1cf806df03f933429a93"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"6227f36b1283242a112f1dba80ecfcb7aecca945","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self._assert_viommu_not_present(server)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"class VIommuTestQ35viaComputeHost(ViommuTestTQ35ViaImage):"},{"line_number":83,"context_line":"    \"\"\"Test the creation of guests with attached Virtual IOMMU intel devices."},{"line_number":84,"context_line":"    Q35 is is configured on the compute hosts via [libvirt]/hw_machine_type"},{"line_number":85,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"14aa6f13_a5e4d85d","line":82,"in_reply_to":"f632260c_272b80b8","updated":"2024-02-20 17:32:50.000000000","message":"That works for me, I think Image is enough coverage.","commit_id":"c528091f2690a277c6ca1cf806df03f933429a93"}]}