)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9d8e0d53445a75e6091b7db28c589739ce9e6220","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    hooks:"},{"line_number":8,"context_line":"      - id: twine-check"},{"line_number":9,"context_line":"        name: twine-check"},{"line_number":10,"context_line":"        entry: tools/twine-check.sh"},{"line_number":11,"context_line":"        language: python"},{"line_number":12,"context_line":"        types: [python]"},{"line_number":13,"context_line":"        additional_dependencies: [twine]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1e1a8a6b_24448f00","line":10,"updated":"2024-04-16 07:16:51.000000000","message":"pre-commit runs everytime we make/amend commit.\nwill this like build in every comit ?","commit_id":"558c3e6d775880d1b1ef949b84d536e5a35a9023"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"49fd1a7ac12f9e723c4eb6eb968f263c245f2320","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    hooks:"},{"line_number":8,"context_line":"      - id: twine-check"},{"line_number":9,"context_line":"        name: twine-check"},{"line_number":10,"context_line":"        entry: tools/twine-check.sh"},{"line_number":11,"context_line":"        language: python"},{"line_number":12,"context_line":"        types: [python]"},{"line_number":13,"context_line":"        additional_dependencies: [twine]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6532adc4_64596b43","line":10,"in_reply_to":"1e1a8a6b_24448f00","updated":"2024-04-16 08:57:26.000000000","message":"yes but this is very fast\nwe could consider moving this to a tox env but it takes less than 2 seconds locally\n\nreal    0m1.333s\nuser    0m8.160s\nsys     0m1.708s","commit_id":"558c3e6d775880d1b1ef949b84d536e5a35a9023"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9d8e0d53445a75e6091b7db28c589739ce9e6220","unresolved":true,"context_lines":[{"line_number":57,"context_line":"        args: [--enable\u003ddefault-role]"},{"line_number":58,"context_line":"        files: ^README.rst"},{"line_number":59,"context_line":"        types: [rst]"},{"line_number":60,"context_line":"  - repo: https://github.com/openstack/bashate.git"},{"line_number":61,"context_line":"    rev: 2.1.1"},{"line_number":62,"context_line":"    hooks:"},{"line_number":63,"context_line":"      - id: bashate"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0e615811_4ae86903","line":60,"updated":"2024-04-16 07:16:51.000000000","message":"do we need this if we have above pre-commit hooks, seems redundant from project description. because we have all what we need already above.","commit_id":"558c3e6d775880d1b1ef949b84d536e5a35a9023"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"49fd1a7ac12f9e723c4eb6eb968f263c245f2320","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        args: [--enable\u003ddefault-role]"},{"line_number":58,"context_line":"        files: ^README.rst"},{"line_number":59,"context_line":"        types: [rst]"},{"line_number":60,"context_line":"  - repo: https://github.com/openstack/bashate.git"},{"line_number":61,"context_line":"    rev: 2.1.1"},{"line_number":62,"context_line":"    hooks:"},{"line_number":63,"context_line":"      - id: bashate"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ca623bdd_ea6f04db","line":60,"in_reply_to":"0e615811_4ae86903","updated":"2024-04-16 08:57:26.000000000","message":"bashate is for python so this is to lint the devstack plugin.","commit_id":"558c3e6d775880d1b1ef949b84d536e5a35a9023"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9d8e0d53445a75e6091b7db28c589739ce9e6220","unresolved":true,"context_lines":[{"line_number":65,"context_line":"        # Run bashate check for all bash scripts"},{"line_number":66,"context_line":"        # Ignores the following rules:"},{"line_number":67,"context_line":"        # E006: Line longer than 79 columns (as many scripts use jinja"},{"line_number":68,"context_line":"        #       templating, this is very difficult)"},{"line_number":69,"context_line":"        # E040: Syntax error determined using `bash -n` (as many scripts"},{"line_number":70,"context_line":"        #       use jinja templating, this will often fail and the syntax"},{"line_number":71,"context_line":"        #       error will be discovered in execution anyway)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6b7dc707_c56aba10","line":68,"updated":"2024-04-16 07:16:51.000000000","message":"instead of ignoring all files, can we just check for *.py files.","commit_id":"558c3e6d775880d1b1ef949b84d536e5a35a9023"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"49fd1a7ac12f9e723c4eb6eb968f263c245f2320","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # Run bashate check for all bash scripts"},{"line_number":66,"context_line":"        # Ignores the following rules:"},{"line_number":67,"context_line":"        # E006: Line longer than 79 columns (as many scripts use jinja"},{"line_number":68,"context_line":"        #       templating, this is very difficult)"},{"line_number":69,"context_line":"        # E040: Syntax error determined using `bash -n` (as many scripts"},{"line_number":70,"context_line":"        #       use jinja templating, this will often fail and the syntax"},{"line_number":71,"context_line":"        #       error will be discovered in execution anyway)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0fbf877c_ab4bbabd","line":68,"in_reply_to":"6b7dc707_c56aba10","updated":"2024-04-16 08:57:26.000000000","message":"bashate is for checking bash/shell scripts not python\n\nthese are comming form the nova-operator config we dont have jinia here but we dont need to enforce line lienght today","commit_id":"558c3e6d775880d1b1ef949b84d536e5a35a9023"}],".zuul.yaml":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"925431b234bb6bfb9e9dd0a2a26d95d37033b87d","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- project:"},{"line_number":167,"context_line":"    templates:"},{"line_number":168,"context_line":"      - check-requirements"},{"line_number":169,"context_line":"      - publish-to-pypi"},{"line_number":170,"context_line":"    check:"},{"line_number":171,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d0b6524b_585ecaa6","line":168,"updated":"2024-04-15 16:04:42.000000000","message":"prediction: we\u0027re going to explode on this so hard XD","commit_id":"b4b662c2f5198475f6e416f59f23d972b97e78c7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"091e28317f17c9d12a957d43d641517d324fe065","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- project:"},{"line_number":167,"context_line":"    templates:"},{"line_number":168,"context_line":"      - check-requirements"},{"line_number":169,"context_line":"      - publish-to-pypi"},{"line_number":170,"context_line":"    check:"},{"line_number":171,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f8f1fe17_f8345b3a","line":168,"in_reply_to":"d0b6524b_585ecaa6","updated":"2024-04-15 17:27:57.000000000","message":"maybe that technially not required but we should be running it.\nwe will see what happens when zuul reports","commit_id":"b4b662c2f5198475f6e416f59f23d972b97e78c7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cc4497fc7476063c3bb97360be3979e671d8611e","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- project:"},{"line_number":167,"context_line":"    templates:"},{"line_number":168,"context_line":"      - check-requirements"},{"line_number":169,"context_line":"      - publish-to-pypi"},{"line_number":170,"context_line":"    check:"},{"line_number":171,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5d577f1a_dba95c92","line":168,"in_reply_to":"d4c1f45b_acbc1b43","updated":"2024-04-19 18:04:38.000000000","message":"Done","commit_id":"b4b662c2f5198475f6e416f59f23d972b97e78c7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bc5c260d450d0993851a167a387be9456b593ca0","unresolved":true,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"- project:"},{"line_number":167,"context_line":"    templates:"},{"line_number":168,"context_line":"      - check-requirements"},{"line_number":169,"context_line":"      - publish-to-pypi"},{"line_number":170,"context_line":"    check:"},{"line_number":171,"context_line":"      jobs:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d4c1f45b_acbc1b43","line":168,"in_reply_to":"f8f1fe17_f8345b3a","updated":"2024-04-15 18:21:26.000000000","message":"hum ok we should fix the requirements issues but lets do that in a different patch\n\nthe publish job failed because of a syntax error\nim going to configure precommit and fix that and update the patch","commit_id":"b4b662c2f5198475f6e416f59f23d972b97e78c7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9d8e0d53445a75e6091b7db28c589739ce9e6220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c6d58360_7dcf9ffc","updated":"2024-04-16 07:16:51.000000000","message":"thanks for adding pre-commit.","commit_id":"558c3e6d775880d1b1ef949b84d536e5a35a9023"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"792618a92f5d3579219e5946d3c0f8eb1525db9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3ee8853b_7dd816c8","updated":"2024-04-18 17:31:43.000000000","message":"Took me a while, but I finally put words on what made me uncomfortable with this approach: it\u0027s adding a bunch of stuff that nobody except Sean understands (yes, I realise that the concept of \"learning\" exists), and we\u0027ll be on the hook to maintain if Sean happens to not be around. I\u0027d rather we do the bare minimum to make `publish-to-pypi` happy. We can revisit pre-commit and local twine in a separate patch.","commit_id":"f27525c0ee1e921931a9377b55246948361cba6a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f706784933924f0e13ae405b7c1e3a58239a430c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"196d17c4_629b9785","updated":"2024-04-18 19:36:35.000000000","message":"ok ill split the patch tomorrow","commit_id":"f27525c0ee1e921931a9377b55246948361cba6a"}]}