)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bfec0eaff2596a65bfbbd1ae9c0cf4c936f8851d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"the fact that the DB had the PCI allocation of the device as 2 after"},{"line_number":11,"context_line":"migration instead of 1. This is due to the DB simply not updating in"},{"line_number":12,"context_line":"time before the check is done."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Looking at Amit\u0027s working for evactuation [1] it makes sense to follow a"},{"line_number":15,"context_line":"similar approach and have a waiter check the DB until it updates versus"},{"line_number":16,"context_line":"doing a one time check."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"19fa997f_792b4fed","line":13,"updated":"2024-05-08 10:57:03.000000000","message":"this makes sense for compatibility with older releases.\n\nin newer release the db is updated prior to the live migration completing\nin older release the db would have had the devices in claimed but not allocated until the perodic task ran to update the db.\n\nhaving awaiter will work in both cases so im ok with this approch","commit_id":"ca2e4befe66e3be740251b41fa44735c5f641b27"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"88b3bccbda42b2f80dbab98cd77421ee0803712e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0be2363e_a14f5cbf","updated":"2024-05-07 19:52:27.000000000","message":"Downstream results:\n(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_direct_live_migration [26.662546s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_macvtap_live_migration [35.018224s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 2 tests in 61.6858 sec.\n - Passed: 2\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 61.6808 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (2 tests) \u003d\u003e 0:01:01.685811","commit_id":"13299b8566915f916172529f181c50bd2ca003a1"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"12ce49746997977f66262035ca77c1fc12f24e69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c81b282_5504918d","updated":"2024-05-07 21:48:17.000000000","message":"recheck","commit_id":"ca2e4befe66e3be740251b41fa44735c5f641b27"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"14616a6b003f743050a684032a788dd67c2f5045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c4c4ed47_0cd75934","updated":"2024-05-08 13:26:48.000000000","message":"Follow up results:\n(overcloud) [stack@undercloud-0 tempest-dir]$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_direct_live_migration [31.743548s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_macvtap_live_migration [41.330462s] ... ok\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 2 tests in 73.0805 sec.\n - Passed: 2\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 73.0740 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (2 tests) \u003d\u003e 0:01:13.080456","commit_id":"2ae480517a4d63a930f2b3e53c3aa954f187fbf7"}],"whitebox_tempest_plugin/api/compute/test_sriov.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bfec0eaff2596a65bfbbd1ae9c0cf4c936f8851d","unresolved":true,"context_lines":[{"line_number":704,"context_line":"            if pci_allocated_count \u003d\u003d 1:"},{"line_number":705,"context_line":"                break"},{"line_number":706,"context_line":"            time.sleep(self.os_admin.services_client.build_interval + 1)"},{"line_number":707,"context_line":"        else:"},{"line_number":708,"context_line":"            raise lib_exc.TimeoutException("},{"line_number":709,"context_line":"                pci_allocated_count, 1, \u0027Total allocated pci devices after \u0027"},{"line_number":710,"context_line":"                \u0027migration should be 1 but instead is %s\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"2ed52faf_a1f7311a","line":707,"updated":"2024-05-08 10:57:03.000000000","message":"the else is not wrong but its very rarely used\n\nyou could just remove it \ndedent the raise and replace the break with a return.\n\nthis is valid however just not very pythonic.","commit_id":"ca2e4befe66e3be740251b41fa44735c5f641b27"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"e722d93d5e4eacbc0ccb06cd3b22f8895290e1ba","unresolved":true,"context_lines":[{"line_number":704,"context_line":"            if pci_allocated_count \u003d\u003d 1:"},{"line_number":705,"context_line":"                break"},{"line_number":706,"context_line":"            time.sleep(self.os_admin.services_client.build_interval + 1)"},{"line_number":707,"context_line":"        else:"},{"line_number":708,"context_line":"            raise lib_exc.TimeoutException("},{"line_number":709,"context_line":"                pci_allocated_count, 1, \u0027Total allocated pci devices after \u0027"},{"line_number":710,"context_line":"                \u0027migration should be 1 but instead is %s\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"c100fde1_627db321","line":707,"in_reply_to":"2ed52faf_a1f7311a","updated":"2024-05-08 13:19:35.000000000","message":"I\u0027ll update it since the exception message it not valid anyways and I need to change it.","commit_id":"ca2e4befe66e3be740251b41fa44735c5f641b27"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"0a84985b3e4a0dce0d2d72e41b83848e3e6cc533","unresolved":false,"context_lines":[{"line_number":704,"context_line":"            if pci_allocated_count \u003d\u003d 1:"},{"line_number":705,"context_line":"                break"},{"line_number":706,"context_line":"            time.sleep(self.os_admin.services_client.build_interval + 1)"},{"line_number":707,"context_line":"        else:"},{"line_number":708,"context_line":"            raise lib_exc.TimeoutException("},{"line_number":709,"context_line":"                pci_allocated_count, 1, \u0027Total allocated pci devices after \u0027"},{"line_number":710,"context_line":"                \u0027migration should be 1 but instead is %s\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"b594a451_ee266a01","line":707,"in_reply_to":"c100fde1_627db321","updated":"2024-05-08 15:03:13.000000000","message":"Done","commit_id":"ca2e4befe66e3be740251b41fa44735c5f641b27"}]}