)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"dbfc708f75ae51d8f6a225efdb453b3716f14792","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4439effd_df5185c8","updated":"2024-06-24 07:34:19.000000000","message":"diff\nUEFI\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\n  \u003cos firmware\u003d\u0027efi\u0027\u003e                                                                                                                                                                                                                                         \n    \u003ctype arch\u003d\u0027x86_64\u0027 machine\u003d\u0027pc-q35-rhel9.4.0\u0027\u003ehvm\u003c/type\u003e                                                                                                                                                                                                 \n    \u003cfirmware\u003e                                                                                                                                                                                                                                                \n      \u003cfeature enabled\u003d\u0027no\u0027 name\u003d\u0027enrolled-keys\u0027/\u003e                                                                             \n      \u003cfeature enabled\u003d\u0027no\u0027 name\u003d\u0027secure-boot\u0027/\u003e                                                                               \n    \u003c/firmware\u003e                                                \n    \u003cloader readonly\u003d\u0027yes\u0027 secure\u003d\u0027no\u0027 type\u003d\u0027pflash\u0027\u003e/usr/share/edk2/ovmf/OVMF_CODE.fd\u003c/loader\u003e                                \n    \u003cnvram template\u003d\u0027/usr/share/edk2/ovmf/OVMF_VARS.fd\u0027\u003e/var/lib/libvirt/qemu/nvram/instance-00000173_VARS.fd\u003c/nvram\u003e          \n    \u003cboot dev\u003d\u0027hd\u0027/\u003e                                       \n    \u003csmbios mode\u003d\u0027sysinfo\u0027/\u003e                              \n  \u003c/os\u003e                                                                                                                                                                                                                                                       \n\nNON-UEFI\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n  \u003cos\u003e                                                                                                                                                                                                                                                        \n    \u003ctype arch\u003d\u0027x86_64\u0027 machine\u003d\u0027pc-i440fx-rhel7.6.0\u0027\u003ehvm\u003c/type\u003e                                                                                                                                                                                                  \u003cboot dev\u003d\u0027hd\u0027/\u003e                                                                                                                                                                                                                                              \u003csmbios mode\u003d\u0027sysinfo\u0027/\u003e                                                                                                   \n  \u003c/os\u003e","commit_id":"d55a3426f3b4acd4cd5d19da41ea39cd7b92e5cf"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"4de17cbb578f102444c73b20e215c2bf1ad257d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99cc41bf_68dea649","updated":"2024-06-24 09:12:32.000000000","message":"rebuild undefine the domain first.\nthere is revert patch for it in master.\nhttps://review.opendev.org/c/openstack/nova/+/922354\n\nwe need check again if results changes after revert and this bug reflect\nhttps://bugs.launchpad.net/nova/+bug/1997352","commit_id":"d55a3426f3b4acd4cd5d19da41ea39cd7b92e5cf"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3b870da4e76114261dc93f7f675da2c230ffd204","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"76c59e3a_ac46487d","updated":"2024-07-02 06:49:03.000000000","message":"though this works, but rebuild from uefi to non-uefi fails in reality,\n\nI don\u0027t think cirros is a correct image for this test, \nwe should use ubuntu or other real image for this ?\n\nerror msg we get with ubuntu image is `\u0027message\u0027: \u0027UEFI is not supported\u0027`","commit_id":"d55a3426f3b4acd4cd5d19da41ea39cd7b92e5cf"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"49e131b8655b93b175ac26818d336c8e466fd25e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ad9e807_180c029b","in_reply_to":"3cf20c7d_3eceefd4","updated":"2024-07-02 10:12:36.000000000","message":"ack, my doubt is because of bug (https://bugzilla.redhat.com/show_bug.cgi?id\u003d2292196), added upstream bug, and revert (https://review.opendev.org/c/openstack/nova/+/922354).\nbecause even though rebuild is passing here, but failing for real customer.\n\nbut sure here we are testing with correct properties with minimal image.","commit_id":"d55a3426f3b4acd4cd5d19da41ea39cd7b92e5cf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b6ef42cc7966fc8b771db788deb8a0b3a9241bc6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3cf20c7d_3eceefd4","in_reply_to":"76c59e3a_ac46487d","updated":"2024-07-02 09:51:13.000000000","message":"the image should not matter only the metaadata on the image in glance\n\nthe image would need to be built for both legacy and uefi booting which cirros and the ubuntu cloud images are but the image in the guest wont change the xml generated or how qemu boots.\n\nusing cirros is fine for testing provided the image is tagged with hw_frimware_type\u003duefi","commit_id":"d55a3426f3b4acd4cd5d19da41ea39cd7b92e5cf"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d63a9ad1a167e11f92eb451ad9557aaddb19bea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2ac79be_19e7c9f3","updated":"2024-07-23 10:34:16.000000000","message":"LGTM! If we can get a FUP to fix the tiny nits, that\u0027d be great!","commit_id":"48ff84e3b5c05bcd1ea583dd01dabf901db702f2"}],"whitebox_tempest_plugin/api/compute/test_uefi.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5364e3769330ea0a36d9e959557e941704418dc7","unresolved":true,"context_lines":[{"line_number":86,"context_line":"            server[\u0027id\u0027], os_element, secure_boot\u003dFalse)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        # rebuild same instance with non-uefi image"},{"line_number":89,"context_line":"        non_uefi_image_id \u003d self.copy_default_image()"},{"line_number":90,"context_line":"        server \u003d self.servers_client.rebuild_server("},{"line_number":91,"context_line":"            server[\u0027id\u0027], image_ref\u003dnon_uefi_image_id)[\u0027server\u0027]"},{"line_number":92,"context_line":"        waiters.wait_for_server_status(self.servers_client,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6f6edf6_2a0cfe64","line":89,"updated":"2024-06-28 14:42:10.000000000","message":"Instead of copying the default image, we can get its ID in the same way that `create_test_server()` in tempest/common/compute.py does it:\n\n        if image_id is None:\n            image_id \u003d CONF.compute.image_ref","commit_id":"d55a3426f3b4acd4cd5d19da41ea39cd7b92e5cf"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d63a9ad1a167e11f92eb451ad9557aaddb19bea0","unresolved":true,"context_lines":[{"line_number":91,"context_line":"            server[\u0027id\u0027], image_ref\u003dnon_uefi_image_id)[\u0027server\u0027]"},{"line_number":92,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":93,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":94,"context_line":"        domain2 \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":95,"context_line":"        os_element2 \u003d domain2.find(\"./os\")"},{"line_number":96,"context_line":"        self.assertIsNone(os_element2.find(\u0027nvram\u0027))"},{"line_number":97,"context_line":"        self.assertEmpty(os_element2.items())"}],"source_content_type":"text/x-python","patch_set":2,"id":"579e296d_65c143d5","line":94,"updated":"2024-07-23 10:34:16.000000000","message":"No need for the 2 suffix, you can overwrite `domain` here.","commit_id":"48ff84e3b5c05bcd1ea583dd01dabf901db702f2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d63a9ad1a167e11f92eb451ad9557aaddb19bea0","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":93,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":94,"context_line":"        domain2 \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":95,"context_line":"        os_element2 \u003d domain2.find(\"./os\")"},{"line_number":96,"context_line":"        self.assertIsNone(os_element2.find(\u0027nvram\u0027))"},{"line_number":97,"context_line":"        self.assertEmpty(os_element2.items())"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"303eb8d0_5e8fc279","line":95,"updated":"2024-07-23 10:34:16.000000000","message":"And here.","commit_id":"48ff84e3b5c05bcd1ea583dd01dabf901db702f2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d63a9ad1a167e11f92eb451ad9557aaddb19bea0","unresolved":true,"context_lines":[{"line_number":101,"context_line":"            server[\u0027id\u0027], image_ref\u003duefi_image_id)[\u0027server\u0027]"},{"line_number":102,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":103,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":104,"context_line":"        domain3 \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":105,"context_line":"        os_element3 \u003d domain3.find(\"./os\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self._validate_uefi_os_xml_elements("}],"source_content_type":"text/x-python","patch_set":2,"id":"f25a6738_dfe2f484","line":104,"updated":"2024-07-23 10:34:16.000000000","message":"Ditto - re: 3 suffix","commit_id":"48ff84e3b5c05bcd1ea583dd01dabf901db702f2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"d63a9ad1a167e11f92eb451ad9557aaddb19bea0","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":103,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":104,"context_line":"        domain3 \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":105,"context_line":"        os_element3 \u003d domain3.find(\"./os\")"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        self._validate_uefi_os_xml_elements("},{"line_number":108,"context_line":"            server[\u0027id\u0027], os_element3, secure_boot\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d2e25fb3_e99f91a8","line":105,"updated":"2024-07-23 10:34:16.000000000","message":"And here.","commit_id":"48ff84e3b5c05bcd1ea583dd01dabf901db702f2"}]}