)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5b3dddb0cbd148e5d6addea732620f0e8db5c4f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Amit Uniyal \u003cauniyal@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-24 06:27:30 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"verify tls in guest VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5f2ae58b909fb005be9bf1a88d55d9a2ff452e46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"af56fb04_79f9f0e4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"updated":"2024-07-24 10:49:27.000000000","message":"also this si not really what your doign your\nverifyting that the vnc console is exported such that it can use tls\nvia the vencrypt feature","commit_id":"696e73150c037bf5c0115cd489fa6578eb2cdd1b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"7dd109db833690be09f3680d3037ed9e6011ce50","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amit Uniyal \u003cauniyal@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2024-07-24 06:27:30 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"verify tls in guest VM"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I5f2ae58b909fb005be9bf1a88d55d9a2ff452e46"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"2aab9402_047ea5a7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"in_reply_to":"af56fb04_79f9f0e4","updated":"2024-07-25 06:13:42.000000000","message":"Acknowledged","commit_id":"696e73150c037bf5c0115cd489fa6578eb2cdd1b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"ff41d7d47df117dfd7d00313cf4fb7e5dcd8eb03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a811ba06_d85fcf3a","updated":"2024-07-10 13:07:59.000000000","message":"recheck \nbecause of timeout we are getting exit_status as 124 and not 0 manually as well, its coming from https://github.com/openstack/tempest/blob/master/tempest/lib/common/ssh.py#L237\n\nbut in my local test, `SSHExecCommandFailed is not getting caught` I think its because overall SSH is successful (which is again not correct, so thinking to update tempest ssh lib to allow to have bad exit status as well), but lets run this once, may be it works as its working for me locally.","commit_id":"787f0356bb30f79d29a52a7cc7f9f2b288b6e8cd"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"98de477c917d77380953c73c2caa0f367291aa3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"af683239_d38a0bc1","updated":"2024-07-25 19:28:09.000000000","message":"This looks OK to me","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"}],"whitebox_tempest_plugin/api/compute/test_console_encryption.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"132e79bc459853a22df7b438ee8d4b105d91c46e","unresolved":true,"context_lines":[{"line_number":57,"context_line":"sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":58,"context_line":"sock.connect((\"ip_placeholder\", port_placeholder))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"content \u003d \"GET / HTTPS/1.1\\\\n\\\\n\""},{"line_number":61,"context_line":"sock.sendall(content.encode())"},{"line_number":62,"context_line":"sleep(0.5)"},{"line_number":63,"context_line":"sock.shutdown(socket.SHUT_WR)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff8fd033_edd82d55","line":60,"range":{"start_line":60,"start_character":10,"end_line":60,"end_character":33},"updated":"2024-07-10 07:39:22.000000000","message":"right now works for both HTTP and HTTPS !!","commit_id":"bb3e160d2dd8c076e545862188d80ab391790ae9"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"cf72ea86819ed1ccca53251edfff56a1f9f2ef58","unresolved":false,"context_lines":[{"line_number":57,"context_line":"sock \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":58,"context_line":"sock.connect((\"ip_placeholder\", port_placeholder))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"content \u003d \"GET / HTTPS/1.1\\\\n\\\\n\""},{"line_number":61,"context_line":"sock.sendall(content.encode())"},{"line_number":62,"context_line":"sleep(0.5)"},{"line_number":63,"context_line":"sock.shutdown(socket.SHUT_WR)"}],"source_content_type":"text/x-python","patch_set":1,"id":"704b410a_e1c430ea","line":60,"range":{"start_line":60,"start_character":10,"end_line":60,"end_character":33},"in_reply_to":"ff8fd033_edd82d55","updated":"2024-07-23 06:57:00.000000000","message":"Done","commit_id":"bb3e160d2dd8c076e545862188d80ab391790ae9"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"549179a5b38a50694646655d4664856033e73166","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ec504533_75689194","line":93,"updated":"2024-07-19 06:51:31.000000000","message":"```\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.10/site-packages/whitebox_tempest_plugin/api/compute/test_console_encryption.py\", line 85, in test_003\n    sock \u003d socket.create_connection(address\u003d(self.ip, self.port))\n  File \"/usr/lib/python3.10/socket.py\", line 845, in create_connection\n    raise err\n  File \"/usr/lib/python3.10/socket.py\", line 833, in create_connection\n    sock.connect(sa)\nConnectionRefusedError: [Errno 111] Connection refused\n\n\n```","commit_id":"53b17982c8c74474c287878a4cdc83e66fdbb275"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"64428ac1f444354f5c80e3bcd474f2463ddffcc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"04523a6f_01793efe","line":93,"in_reply_to":"ec504533_75689194","updated":"2024-07-24 10:29:32.000000000","message":"Done","commit_id":"53b17982c8c74474c287878a4cdc83e66fdbb275"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"cf72ea86819ed1ccca53251edfff56a1f9f2ef58","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        #       \"dir\":\"/etc/pki/qemu\","},{"line_number":51,"context_line":"        #       \"endpoint\":\"server\","},{"line_number":52,"context_line":"        #       \"verify-peer\":true}\u0027 \\"},{"line_number":53,"context_line":"        data2 \u003d list(map(lambda x: \u0027tls\u0027 in x, data))"},{"line_number":54,"context_line":"        self.assertTrue(any(data2))"}],"source_content_type":"text/x-python","patch_set":7,"id":"6f187c54_ae214671","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":13},"updated":"2024-07-23 06:57:00.000000000","message":"this could be a better name, I\u0027ll update if this required respin","commit_id":"3c4e23492ca91f121d75e45260dc51c666979d2f"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"64428ac1f444354f5c80e3bcd474f2463ddffcc4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        #       \"dir\":\"/etc/pki/qemu\","},{"line_number":51,"context_line":"        #       \"endpoint\":\"server\","},{"line_number":52,"context_line":"        #       \"verify-peer\":true}\u0027 \\"},{"line_number":53,"context_line":"        data2 \u003d list(map(lambda x: \u0027tls\u0027 in x, data))"},{"line_number":54,"context_line":"        self.assertTrue(any(data2))"}],"source_content_type":"text/x-python","patch_set":7,"id":"b10c3d22_d84cc7ce","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":13},"in_reply_to":"6f187c54_ae214671","updated":"2024-07-24 10:29:32.000000000","message":"Done","commit_id":"3c4e23492ca91f121d75e45260dc51c666979d2f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5b5f47bad6ca1a5c347a3f7b0b8e6f451328c7c6","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep \\\"qom-type\\\"\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":8,"id":"851cbb08_9d4f18ea","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":33},"updated":"2024-07-23 20:02:17.000000000","message":"This works with the current instance log but I think it may be better to grep for something more specifically related to the console, such as \"vnc\".\n\nThe \"qom-type\" is related to the general QEMU object model [1] and used to represent a variety of things, and \"tls\" isn\u0027t necessarily always related to only the console [2].\n\nThe combination of \"vnc\" and \"tls\" would make a clear test that means to check encryption for the console.\n\n[1] https://qemu-project.gitlab.io/qemu/devel/qom.html\n[2] https://www.qemu.org/docs/master/system/tls.html","commit_id":"480216a26b36462a724054bfa30960caa6dc4042"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cae47dd822c581c621ce9cd93e26519888aa04d0","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep \\\"qom-type\\\"\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":8,"id":"4feaec5a_9cbce949","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":33},"in_reply_to":"7b904e64_43428463","updated":"2024-07-24 13:35:57.000000000","message":"Done","commit_id":"480216a26b36462a724054bfa30960caa6dc4042"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c856f1c4d0076fc77873744dfa551d891a7db111","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep \\\"qom-type\\\"\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":8,"id":"b2ccec7d_e72f72c9","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":33},"in_reply_to":"851cbb08_9d4f18ea","updated":"2024-07-23 20:34:56.000000000","message":"yep i agree \n\ni think we can grep for \"vnc-tls\"\n\nand we should also consider asserting that verify-peer is true\n\nthat is technially configurable but we hard code it in our new installer i think we can make that configurabel or hard code it here too and just skip this in devstack until we have time to add support for this in devstack properly.","commit_id":"480216a26b36462a724054bfa30960caa6dc4042"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"64428ac1f444354f5c80e3bcd474f2463ddffcc4","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep \\\"qom-type\\\"\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":8,"id":"7b904e64_43428463","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":33},"in_reply_to":"996aee43_6274a194","updated":"2024-07-24 10:29:32.000000000","message":"ack, thanks, updated.","commit_id":"480216a26b36462a724054bfa30960caa6dc4042"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c649866096a885d943f0e3d840d9fbf4378b603c","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep \\\"qom-type\\\"\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":8,"id":"996aee43_6274a194","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":33},"in_reply_to":"a776f36a_0ac9cd8e","updated":"2024-07-24 09:51:51.000000000","message":"no but we do not supprot spice downstram and we dont test with it in devstack upstream.\n\nthis is a vnc only feature so this test case is never valid to run with spice","commit_id":"480216a26b36462a724054bfa30960caa6dc4042"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2627dd9cbf6636e45b5b64dd96801fd2306760bc","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep \\\"qom-type\\\"\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":8,"id":"a776f36a_0ac9cd8e","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":33},"in_reply_to":"b2ccec7d_e72f72c9","updated":"2024-07-24 08:48:44.000000000","message":"ack, but will it be same if operator configure spice instead of vnc console right ?","commit_id":"480216a26b36462a724054bfa30960caa6dc4042"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"64428ac1f444354f5c80e3bcd474f2463ddffcc4","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep vnc\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":9,"id":"dca3f547_1acc82db","line":42,"updated":"2024-07-24 10:29:32.000000000","message":"intentionally only grep-ing for vnc from log file, because I don\u0027t want to fail the test while executing ssh cmd, but later on tls verification.","commit_id":"ff2ea0337855a6d4cc591c6c7ed07d9ccba8743c"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"7dd109db833690be09f3680d3037ed9e6011ce50","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep vnc\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":9,"id":"c86ec839_185cf4a7","line":42,"in_reply_to":"dca3f547_1acc82db","updated":"2024-07-25 06:13:42.000000000","message":"Done","commit_id":"ff2ea0337855a6d4cc591c6c7ed07d9ccba8743c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25e8503770bcae36e0404bfb490f0d0a07755ea2","unresolved":true,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep vnc\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"}],"source_content_type":"text/x-python","patch_set":9,"id":"582c257d_1fe7180d","line":42,"in_reply_to":"dca3f547_1acc82db","updated":"2024-07-24 20:24:54.000000000","message":"by the way this can be\n\n        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027\n              f\u0027| grep vnc\u0027\n              \nie just using string conatination.\n\nbut it also could jsut be\n\nf\u0027grep \"vnc\" /var/log/libvirt/qemu/{self.instance}.log\u0027","commit_id":"ff2ea0337855a6d4cc591c6c7ed07d9ccba8743c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f5b3dddb0cbd148e5d6addea732620f0e8db5c4f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"CONF \u003d config.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestConsoleEncryption(base.BaseWhiteboxComputeTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"88a10bd9_3db5c78b","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":27},"updated":"2024-07-24 10:49:27.000000000","message":"you should rename this since your meant to be explicitly testing vencypt\nnot console encryption in general.","commit_id":"696e73150c037bf5c0115cd489fa6578eb2cdd1b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cae47dd822c581c621ce9cd93e26519888aa04d0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"CONF \u003d config.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestConsoleEncryption(base.BaseWhiteboxComputeTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7ddb7d01_7054269b","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":27},"in_reply_to":"88a10bd9_3db5c78b","updated":"2024-07-24 13:35:57.000000000","message":"Done","commit_id":"696e73150c037bf5c0115cd489fa6578eb2cdd1b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25e8503770bcae36e0404bfb490f0d0a07755ea2","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep vnc\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"},{"line_number":46,"context_line":"        # -object \u0027{"}],"source_content_type":"text/x-python","patch_set":11,"id":"adb62265_0fe9ccd0","line":43,"updated":"2024-07-24 20:24:54.000000000","message":"instead of calling splitlines() keep this as a single string\n\nand just do \n\nself.assertIn(\u0027vnc-tls\u0027,data)\nself.assertIn(\u0027\"verify-peer\":true\u0027, data)","commit_id":"fad7db3dbf3a6dfe527425ab83ed9bccdda87b26"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"7dd109db833690be09f3680d3037ed9e6011ce50","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep vnc\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"},{"line_number":46,"context_line":"        # -object \u0027{"}],"source_content_type":"text/x-python","patch_set":11,"id":"7fd913df_70d453ca","line":43,"in_reply_to":"041539af_2afa6ed1","updated":"2024-07-25 06:13:42.000000000","message":"I just didn\u0027t want to write a loop for single substring, hence lambda and then map seems good option.\nbut we can simplify it.\ndone.","commit_id":"fad7db3dbf3a6dfe527425ab83ed9bccdda87b26"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8596d1157845b6d1c50519db45ea6d5613cf2bf8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep vnc\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"},{"line_number":46,"context_line":"        # -object \u0027{"}],"source_content_type":"text/x-python","patch_set":11,"id":"b1aa61b3_ee0618ae","line":43,"in_reply_to":"7fd913df_70d453ca","updated":"2024-07-26 04:49:14.000000000","message":"Done","commit_id":"fad7db3dbf3a6dfe527425ab83ed9bccdda87b26"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0f57a4700bd146490508a9ccc65ba8cd9c7f5e32","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep vnc\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"},{"line_number":46,"context_line":"        # -object \u0027{"}],"source_content_type":"text/x-python","patch_set":11,"id":"d1a7757a_416f089f","line":43,"in_reply_to":"adb62265_0fe9ccd0","updated":"2024-07-24 21:00:03.000000000","message":"I think keeping it as a single string would be too broad though, because that would pass in a case where the `vnc-tls` line does not have `\"verify-peer\":true` but some other `--object` line in the log does. Maybe that\u0027s not currently a thing but I can see the reasoning to assert that both `vnc-tls` and `\"verify-peer\":true` exist in the same `--object` line.","commit_id":"fad7db3dbf3a6dfe527425ab83ed9bccdda87b26"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1ef9843c94e49572231237dce6d2c6bbdf1feaa6","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    def test_via_qemu_logs(self):"},{"line_number":41,"context_line":"        cmd \u003d f\u0027cat /var/log/libvirt/qemu/{self.instance}.log\u0027"},{"line_number":42,"context_line":"        cmd +\u003d \u0027| grep vnc\u0027"},{"line_number":43,"context_line":"        data \u003d self.ssh_cl.execute(cmd, sudo\u003dTrue).splitlines()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        # qemu logs should have tls object"},{"line_number":46,"context_line":"        # -object \u0027{"}],"source_content_type":"text/x-python","patch_set":11,"id":"041539af_2afa6ed1","line":43,"in_reply_to":"d1a7757a_416f089f","updated":"2024-07-24 21:14:03.000000000","message":"ya i can see your point\n\nim try to avoid havign to parse the command line properly and loading the json blob from the object so i guess using map in this context is ok\n\n\nit still feels like we shold be able to epess this more simply but im not entirly agaisnt the current code.","commit_id":"fad7db3dbf3a6dfe527425ab83ed9bccdda87b26"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b2e382102f839701770f10388e4c29873ee72650","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        #       \"verify-peer\":true}\u0027"},{"line_number":52,"context_line":"        # -vnc \u0027[::0]:0,tls-creds\u003dvnc-tls-creds0,audiodev\u003daudio1\u0027"},{"line_number":53,"context_line":"        tls_objects \u003d list(map("},{"line_number":54,"context_line":"            lambda obj: \u0027vnc-tls\u0027 in obj or \u0027\"verify-peer\":true\u0027 in obj, data)"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.assertTrue(any(tls_objects))"}],"source_content_type":"text/x-python","patch_set":11,"id":"2ac37b8a_cb7081e7","line":54,"range":{"start_line":54,"start_character":41,"end_line":54,"end_character":43},"updated":"2024-07-24 19:37:38.000000000","message":"This should be `and` no? Otherwise it\u0027s not requiring that verify-peer is also set to true (it would short circuit).","commit_id":"fad7db3dbf3a6dfe527425ab83ed9bccdda87b26"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25e8503770bcae36e0404bfb490f0d0a07755ea2","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        #       \"verify-peer\":true}\u0027"},{"line_number":52,"context_line":"        # -vnc \u0027[::0]:0,tls-creds\u003dvnc-tls-creds0,audiodev\u003daudio1\u0027"},{"line_number":53,"context_line":"        tls_objects \u003d list(map("},{"line_number":54,"context_line":"            lambda obj: \u0027vnc-tls\u0027 in obj or \u0027\"verify-peer\":true\u0027 in obj, data)"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.assertTrue(any(tls_objects))"}],"source_content_type":"text/x-python","patch_set":11,"id":"43b3b6fb_fe8f1b65","line":54,"range":{"start_line":54,"start_character":41,"end_line":54,"end_character":43},"in_reply_to":"2ac37b8a_cb7081e7","updated":"2024-07-24 20:24:54.000000000","message":"correct. \nso in our new installer this is hardcoded, if we have tls enabeld we also verify the peer. arguably however we should have config option to node if vencrypt is enabeld and if peer validation is enabeld.\n\nim personally not a fan or using a map and lambda for this by the way.\n\nits overcomplicating a simple substring check","commit_id":"fad7db3dbf3a6dfe527425ab83ed9bccdda87b26"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"7dd109db833690be09f3680d3037ed9e6011ce50","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        #       \"verify-peer\":true}\u0027"},{"line_number":52,"context_line":"        # -vnc \u0027[::0]:0,tls-creds\u003dvnc-tls-creds0,audiodev\u003daudio1\u0027"},{"line_number":53,"context_line":"        tls_objects \u003d list(map("},{"line_number":54,"context_line":"            lambda obj: \u0027vnc-tls\u0027 in obj or \u0027\"verify-peer\":true\u0027 in obj, data)"},{"line_number":55,"context_line":"        )"},{"line_number":56,"context_line":"        self.assertTrue(any(tls_objects))"}],"source_content_type":"text/x-python","patch_set":11,"id":"c579b618_45a05025","line":54,"range":{"start_line":54,"start_character":41,"end_line":54,"end_character":43},"in_reply_to":"43b3b6fb_fe8f1b65","updated":"2024-07-25 06:13:42.000000000","message":"Done","commit_id":"fad7db3dbf3a6dfe527425ab83ed9bccdda87b26"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"98de477c917d77380953c73c2caa0f367291aa3a","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(TestVencrypt, cls).skip_checks()"},{"line_number":28,"context_line":"        if not CONF.compute_feature_enabled.ssl_only:"},{"line_number":29,"context_line":"            raise cls.skipException(\"TLS is not enabled\")"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"26aaf39a_6d143810","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":32},"updated":"2024-07-25 19:28:09.000000000","message":"Just FYI with python3 you can just do `super()` (and not have to make names match).","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8596d1157845b6d1c50519db45ea6d5613cf2bf8","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(TestVencrypt, cls).skip_checks()"},{"line_number":28,"context_line":"        if not CONF.compute_feature_enabled.ssl_only:"},{"line_number":29,"context_line":"            raise cls.skipException(\"TLS is not enabled\")"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"828cf520_88d30ccd","line":27,"range":{"start_line":27,"start_character":8,"end_line":27,"end_character":32},"in_reply_to":"26aaf39a_6d143810","updated":"2024-07-26 04:49:14.000000000","message":"Acknowledged, thanks","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"68eb5673cf80b2190ca14a0331eaf752ec53ef04","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(TestVencrypt, cls).skip_checks()"},{"line_number":28,"context_line":"        if not CONF.compute_feature_enabled.ssl_only:"},{"line_number":29,"context_line":"            raise cls.skipException(\"TLS is not enabled\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"c30c1efd_fb19fc6c","line":28,"updated":"2024-07-26 08:59:53.000000000","message":"there are several other thing that ssl_only could mean like assert that we do live migration with tls\n\nwe will want to follow up wiht adding devstack support for this at some point so i want to use a more descriptive name for now","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06130752a9043738d066d84453418fc42d801cfd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def skip_checks(cls):"},{"line_number":27,"context_line":"        super(TestVencrypt, cls).skip_checks()"},{"line_number":28,"context_line":"        if not CONF.compute_feature_enabled.ssl_only:"},{"line_number":29,"context_line":"            raise cls.skipException(\"TLS is not enabled\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3eb8786d_aeb5f533","line":28,"in_reply_to":"c30c1efd_fb19fc6c","updated":"2024-07-26 09:29:29.000000000","message":"Done","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"68eb5673cf80b2190ca14a0331eaf752ec53ef04","unresolved":true,"context_lines":[{"line_number":53,"context_line":"        tls_objects \u003d ["},{"line_number":54,"context_line":"            \u0027vnc-tls\u0027 in obj and \u0027\"verify-peer\":true\u0027 in obj for obj in data"},{"line_number":55,"context_line":"        ]"},{"line_number":56,"context_line":"        self.assertTrue(any(tls_objects))"}],"source_content_type":"text/x-python","patch_set":12,"id":"b11d3536_251ecf54","line":56,"updated":"2024-07-26 08:59:53.000000000","message":"this is simpler to read so +1","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06130752a9043738d066d84453418fc42d801cfd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        tls_objects \u003d ["},{"line_number":54,"context_line":"            \u0027vnc-tls\u0027 in obj and \u0027\"verify-peer\":true\u0027 in obj for obj in data"},{"line_number":55,"context_line":"        ]"},{"line_number":56,"context_line":"        self.assertTrue(any(tls_objects))"}],"source_content_type":"text/x-python","patch_set":12,"id":"06b3fcac_0a33f0ac","line":56,"in_reply_to":"b11d3536_251ecf54","updated":"2024-07-26 09:29:29.000000000","message":"Acknowledged","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e7e441ff1510d842af302397ecc58c39c57d32fd","unresolved":true,"context_lines":[{"line_number":348,"context_line":"    cfg.BoolOpt(\u0027cpu_power_management\u0027,"},{"line_number":349,"context_line":"                default\u003dFalse,"},{"line_number":350,"context_line":"                help\u003d\"Libvirt CPU power management is turned on.\"),"},{"line_number":351,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":352,"context_line":"                default\u003dFalse,"},{"line_number":353,"context_line":"                help\u003d\"TLS enablement.\"),"},{"line_number":354,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"eef24c8e_24f89498","line":351,"range":{"start_line":351,"start_character":17,"end_line":351,"end_character":25},"updated":"2024-07-26 08:57:34.000000000","message":"this really should be something like this\n\n cfg.BoolOpt(\u0027vencrypt\u0027,default\u003dFalse, help\u003d\"verify vnc console tls\"),","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06130752a9043738d066d84453418fc42d801cfd","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    cfg.BoolOpt(\u0027cpu_power_management\u0027,"},{"line_number":349,"context_line":"                default\u003dFalse,"},{"line_number":350,"context_line":"                help\u003d\"Libvirt CPU power management is turned on.\"),"},{"line_number":351,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":352,"context_line":"                default\u003dFalse,"},{"line_number":353,"context_line":"                help\u003d\"TLS enablement.\"),"},{"line_number":354,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"bc9ffbe4_0ab01572","line":351,"range":{"start_line":351,"start_character":17,"end_line":351,"end_character":25},"in_reply_to":"eef24c8e_24f89498","updated":"2024-07-26 09:29:29.000000000","message":"Done","commit_id":"05a27a613a59068c71fa05057d25095a8a1b7749"}]}