)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"54550ac92b8430ba9b2ffcf776c784a8807712f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7d2c8f6_0a4ad22f","updated":"2024-07-23 10:35:57.000000000","message":"Sean\u0027s nits can be addressed in a FUP.","commit_id":"66f6c71cd0a5766c3b44aa47baf8be18b8bef9ad"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"bb54fdb44195ebaccd8313a3e7533fd0169109aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d0d8a6ce_c6e07b03","updated":"2024-07-22 20:49:33.000000000","message":"Testing Downstream against RHOSO18:\n(.venv) sh-5.1$ tempest run --serial --regex whitebox_tempest_plugin.api.compute.test_sriov\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVAttachAndDetach.test_sriov_direct_attach_detach_port [142.393781s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVAttachAndDetach.test_sriov_direct_physical_attach_detach_port [133.569573s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVAttachAndDetach.test_sriov_macvtap_attach_detach_port [123.802011s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_direct_live_migration [72.180526s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVMigration.test_sriov_macvtap_live_migration [73.918894s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithFlavor.test_sriov_affinity_preferred_with_flavor [63.901672s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithFlavor.test_sriov_affinity_required_with_flavor [46.848231s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithImagePolicy.test_sriov_affinity_preferred_with_image [73.758285s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithImagePolicy.test_sriov_affinity_required_with_image [48.771399s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithPortPolicy.test_sriov_affinity_port_policy_precedence_flavor [62.892760s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithPortPolicy.test_sriov_affinity_port_policy_precedence_image [64.092328s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithPortPolicy.test_sriov_affinity_preferred_with_port_policy [57.490831s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithPortPolicy.test_sriov_affinity_required_with_port_policy [43.212597s] ... ok\n{0} whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithPortPolicy.test_sriov_mixed_affinity_port_policies [61.452356s] ... ok\n{0} setUpClass (whitebox_tempest_plugin.api.compute.test_sriov.SRIOVNumaAffinityWithSocketPolicy) ... SKIPPED: Requires socket_topology parameter to be set in order to execute test cases.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 15 tests in 1125.3044 sec.\n - Passed: 14\n - Skipped: 1\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 1068.2852 sec.\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nWorker Balance\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n - Worker 0 (15 tests) \u003d\u003e 0:18:45.304385","commit_id":"66f6c71cd0a5766c3b44aa47baf8be18b8bef9ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0695b4e3c88a5691f8cf24b0e81391a0c5692f04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f0a98089_a1bc0a89","updated":"2024-07-23 09:14:47.000000000","message":"minor nits but i think this is fine to proceed with.","commit_id":"66f6c71cd0a5766c3b44aa47baf8be18b8bef9ad"}],"whitebox_tempest_plugin/api/compute/test_sriov.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0695b4e3c88a5691f8cf24b0e81391a0c5692f04","unresolved":true,"context_lines":[{"line_number":1007,"context_line":"    @testtools.skipUnless(CONF.whitebox_hardware.sriov_vf_product_id,"},{"line_number":1008,"context_line":"                          \"Requires sriov NIC\u0027s VF Prodcut ID\")"},{"line_number":1009,"context_line":"    @testtools.skipUnless(CONF.whitebox_hardware.sriov_nic_vendor_id,"},{"line_number":1010,"context_line":"                          \"Requires sriov NIC\u0027s VF ID\")"},{"line_number":1011,"context_line":"    def test_sriov_direct_attach_detach_port(self):"},{"line_number":1012,"context_line":"        \"\"\"Verify sriov direct port can be attached/detached from live guest"},{"line_number":1013,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"839b1358_be804222","line":1010,"updated":"2024-07-23 09:14:47.000000000","message":"ack this makes sense","commit_id":"66f6c71cd0a5766c3b44aa47baf8be18b8bef9ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0695b4e3c88a5691f8cf24b0e81391a0c5692f04","unresolved":true,"context_lines":[{"line_number":1016,"context_line":"    @testtools.skipUnless(CONF.whitebox_hardware.macvtap_virtio_product_id,"},{"line_number":1017,"context_line":"                          \"Requires sriov NIC\u0027s virtio product ID\")"},{"line_number":1018,"context_line":"    @testtools.skipUnless(CONF.whitebox_hardware.macvtap_virtio_vendor_id,"},{"line_number":1019,"context_line":"                          \"Requires sriov NIC\u0027s virtio vendor ID\")"},{"line_number":1020,"context_line":"    def test_sriov_macvtap_attach_detach_port(self):"},{"line_number":1021,"context_line":"        \"\"\"Verify sriov macvtap port can be attached/detached from live guest"},{"line_number":1022,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ddc5332f_33041819","line":1019,"updated":"2024-07-23 09:14:47.000000000","message":"and this is fully updated to refelct the new options +1","commit_id":"66f6c71cd0a5766c3b44aa47baf8be18b8bef9ad"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0695b4e3c88a5691f8cf24b0e81391a0c5692f04","unresolved":true,"context_lines":[{"line_number":220,"context_line":"    cfg.StrOpt("},{"line_number":221,"context_line":"        \u0027macvtap_virtio_vendor_id\u0027,"},{"line_number":222,"context_line":"        default\u003dNone,"},{"line_number":223,"context_line":"        help\u003d\u0027The vendor id of the virtio interface device\u0027),"},{"line_number":224,"context_line":"    cfg.StrOpt("},{"line_number":225,"context_line":"        \u0027macvtap_virtio_product_id\u0027,"},{"line_number":226,"context_line":"        default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a695b6b2_d3ca8739","line":223,"updated":"2024-07-23 09:14:47.000000000","message":"nit i woudl add the virtio-net product id \u00271af4\u0027 here in the help text since it will always be that.","commit_id":"66f6c71cd0a5766c3b44aa47baf8be18b8bef9ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0695b4e3c88a5691f8cf24b0e81391a0c5692f04","unresolved":true,"context_lines":[{"line_number":224,"context_line":"    cfg.StrOpt("},{"line_number":225,"context_line":"        \u0027macvtap_virtio_product_id\u0027,"},{"line_number":226,"context_line":"        default\u003dNone,"},{"line_number":227,"context_line":"        help\u003d\u0027The product id of the virtio interface device\u0027),"},{"line_number":228,"context_line":"    cfg.ListOpt("},{"line_number":229,"context_line":"        \u0027smt_hosts\u0027,"},{"line_number":230,"context_line":"        default\u003d[],"}],"source_content_type":"text/x-python","patch_set":3,"id":"8384d580_09dd046f","line":227,"updated":"2024-07-23 09:14:47.000000000","message":"nit: same here it would be nice to document the product id we expect \n\u00271af4\u0027","commit_id":"66f6c71cd0a5766c3b44aa47baf8be18b8bef9ad"}]}