)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c418d895f6ae8e0b5db06fb6932cd6a870d11799","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Validate update [1] where vTPM creation was not possible after restartin"},{"line_number":10,"context_line":"g the nova libvirt service."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://code.engineering.redhat.com/gerrit/c/openstack-tripleo-heat-templates/+/451875"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5895602b33c78698beec363fbc00bca876b3cefa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a9a5948_228adcc9","line":12,"updated":"2024-08-27 20:49:15.000000000","message":"let\u0027s not reference downstream private links here. if we have a bugzilla that\u0027s at least half-public, or even better a launchpad bug, let\u0027s link that.","commit_id":"ad82c2487b9729e544797109df18d0acc3c57605"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"f3e42858da298e6b1d8bb5cf5eed358ba875d5e5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Validate update [1] where vTPM creation was not possible after restartin"},{"line_number":10,"context_line":"g the nova libvirt service."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://code.engineering.redhat.com/gerrit/c/openstack-tripleo-heat-templates/+/451875"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5895602b33c78698beec363fbc00bca876b3cefa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"21efde96_8669f9e7","line":12,"in_reply_to":"12e00b00_390cd4c1","updated":"2024-08-28 01:59:42.000000000","message":"Done","commit_id":"ad82c2487b9729e544797109df18d0acc3c57605"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"82a85a5bdb17426d0f145e7888e64e3e686a07d6","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Validate update [1] where vTPM creation was not possible after restartin"},{"line_number":10,"context_line":"g the nova libvirt service."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://code.engineering.redhat.com/gerrit/c/openstack-tripleo-heat-templates/+/451875"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5895602b33c78698beec363fbc00bca876b3cefa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"12e00b00_390cd4c1","line":12,"in_reply_to":"5a9a5948_228adcc9","updated":"2024-08-27 20:53:49.000000000","message":"bahh I clicked the BZ link thinking it was going upstream and didn\u0027t check the url, yes let me find something upstream.","commit_id":"ad82c2487b9729e544797109df18d0acc3c57605"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b8f209f5dd14796fa5cc711f64142e980a3ab06e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fa2979ba_8876155a","updated":"2024-08-27 18:36:50.000000000","message":"Noice. +A will wait until CI is happey.","commit_id":"ad82c2487b9729e544797109df18d0acc3c57605"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c418d895f6ae8e0b5db06fb6932cd6a870d11799","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"183cb803_2e634953","updated":"2024-08-27 20:49:15.000000000","message":"for the commit message","commit_id":"51808d62ce9fa1f2a796ab4ba483aac77476b04b"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"01ab6f18aceb233ccac63b2091175dda82d39a80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7c64c335_c251c3e2","updated":"2024-09-11 00:27:38.000000000","message":"I don\u0027t want to block on the docstring comment, but please fix it in a fup.","commit_id":"6b729ca1d341534ba297e699fabd4ed58532391d"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"d4348fd2f67868c9819cee1784866181d43f573b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e2b80da9_b600a071","updated":"2024-08-29 17:03:30.000000000","message":"recheck","commit_id":"6b729ca1d341534ba297e699fabd4ed58532391d"}],"whitebox_tempest_plugin/api/compute/test_vtpm.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c418d895f6ae8e0b5db06fb6932cd6a870d11799","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.services import clients"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from whitebox_tempest_plugin.api.compute import base"},{"line_number":21,"context_line":"from whitebox_tempest_plugin.services.clients import NovaServiceManager"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"124438d2_ba6e0512","line":21,"updated":"2024-08-27 20:49:15.000000000","message":"nit: can we import clients as wb_clients or something?","commit_id":"51808d62ce9fa1f2a796ab4ba483aac77476b04b"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"82a85a5bdb17426d0f145e7888e64e3e686a07d6","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest.lib.services import clients"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from whitebox_tempest_plugin.api.compute import base"},{"line_number":21,"context_line":"from whitebox_tempest_plugin.services.clients import NovaServiceManager"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"26d817b7_09b58499","line":21,"in_reply_to":"124438d2_ba6e0512","updated":"2024-08-27 20:53:49.000000000","message":"Acknowledged","commit_id":"51808d62ce9fa1f2a796ab4ba483aac77476b04b"}],"whitebox_tempest_plugin/services/clients.py":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"923db7428c357465a8c9f7d8ba29a69c6f8aa706","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        return json.loads(output)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ServiceManager(SSHClient):"},{"line_number":116,"context_line":"    \"\"\"A client to manipulate services. Currently supported operations are:"},{"line_number":117,"context_line":"    - configuration changes"},{"line_number":118,"context_line":"    - restarting"}],"source_content_type":"text/x-python","patch_set":6,"id":"f4969a63_8336b1b5","line":115,"updated":"2024-08-28 14:50:49.000000000","message":"Why write a new service manager instead of just using this existing generic service manager? As far as I can tell, you never tried using this one, and iterated on NovaServiceManager (which was never going to work for a non-Nova service like libvirt)","commit_id":"643b668af30ad6887b0c561bf376c350868b5121"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"e22adad73b28c5cef26b949a0e6a8c84ba3cc6b6","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        return json.loads(output)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"class ServiceManager(SSHClient):"},{"line_number":116,"context_line":"    \"\"\"A client to manipulate services. Currently supported operations are:"},{"line_number":117,"context_line":"    - configuration changes"},{"line_number":118,"context_line":"    - restarting"}],"source_content_type":"text/x-python","patch_set":6,"id":"f6345938_bffcbab6","line":115,"in_reply_to":"f4969a63_8336b1b5","updated":"2024-08-28 15:16:06.000000000","message":"I wanted to use the ServiceManager and it is what the new service is inheriting from.  My concern is the stop/start from ServiceManager does not provide any underlying status check for the service.  I was hoping to get an indication that libvirt is back up fully after the stop/start call before attempting to create the instance. I\u0027m not against using purely the ServiceManager here, I\u0027d just like having status checks on the service before progressing.","commit_id":"643b668af30ad6887b0c561bf376c350868b5121"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"01ab6f18aceb233ccac63b2091175dda82d39a80","unresolved":true,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"class VirtQEMUdManager(ServiceManager):"},{"line_number":271,"context_line":"    \"\"\"A services manager for Nova services that uses Nova\u0027s service API to be"},{"line_number":272,"context_line":"    smarter about stopping and restarting services."},{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"05db6e3f_b60f0424","line":271,"updated":"2024-09-11 00:27:38.000000000","message":"Besides the fact that this is copy/paste from the NovaServiceManager, we need an explanation here of what\u0027s happening - namely that stopping libvirtd is detected by nova-compute, which disables itself, and re-enables itself once libvirtd is started back up again. Hence stopping/starting libvirtd, but waiting for nova-compute in the Nova API.","commit_id":"6b729ca1d341534ba297e699fabd4ed58532391d"}]}