)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"eea35636c8e308d1e10a2368d6b3239268981dc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b4e1d9d1_ee9b17da","updated":"2024-09-25 14:32:55.000000000","message":"recheck","commit_id":"d86cabff1ce6325b1003e94f6b1589b1281097f8"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"04b86c2cd65ba05643c393e206eb61770ef3468b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2762adc0_a74d1d19","updated":"2024-09-26 15:39:07.000000000","message":"aah, you respin already.","commit_id":"04943d627e14a4725249c22a37df73e654c1359f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"2a33df97d32f175957ed792fb487918313a9c31d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ac753c18_12c14e4a","in_reply_to":"079db965_7ba339d1","updated":"2024-09-30 22:53:47.000000000","message":"Done","commit_id":"04943d627e14a4725249c22a37df73e654c1359f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"ce5a8980768272d8428742028e975908a24bb382","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"079db965_7ba339d1","in_reply_to":"2762adc0_a74d1d19","updated":"2024-09-26 19:38:05.000000000","message":"No worries, I need to retest anyways so I\u0027ll incorporate it in my next check.","commit_id":"04943d627e14a4725249c22a37df73e654c1359f"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"e9d11ff9d570c70b1717eacd1a4eed7a8bf792cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"66f8ab87_19352e7d","updated":"2024-10-01 19:12:15.000000000","message":"recheck","commit_id":"51698629b8b75586d792ab339c16c5368f1890ad"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"89fabfc39f550adbba232b6962b514b77562020a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75d03146_048832b0","updated":"2024-10-01 16:31:17.000000000","message":"recheck","commit_id":"51698629b8b75586d792ab339c16c5368f1890ad"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a394bf7f3a78b62121e90d8ca5c60b43b29d2203","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"65c8deff_ae871c8b","updated":"2024-10-07 11:54:56.000000000","message":"Compute did stopped successfully, then there are no more log written for compute  some reason.\n\nfrom syslogs,\nafter stoping compute service, soon it says `session closed for user tempest`\n\nthis seems suspicious\nhttps://zuul.opendev.org/t/openstack/build/8429b418312b4b748320b6b9c5cb6fef/log/controller/logs/syslog.txt#4329","commit_id":"561515618cb4a28b5b70e9708d78bc7349dbf523"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"40ddfc6fc1102c5ebad8646dd955859cd4286e8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8af6a911_8e089188","in_reply_to":"65c8deff_ae871c8b","updated":"2024-10-07 20:02:57.000000000","message":"Thanks Amit, it looks like teh service timeout check was just set extremely high on the controlplane side of things.","commit_id":"561515618cb4a28b5b70e9708d78bc7349dbf523"},{"author":{"_account_id":29455,"name":"Jason Grosso","email":"jgrosso@redhat.com","username":"jgrosso"},"change_message_id":"cdea94032d57a94af5cee6ba98344ccc7a30a910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"035b3e5c_0174c3a5","updated":"2024-10-07 20:00:38.000000000","message":"James just trying to understand does is the with statement saying to check the libvirt section for the image_type \u003d default before we do anything?","commit_id":"261de3a03640287797243bcdccd971e1f342e50b"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"4633e3f000b974eabfa3a1e9ca7e2d93018b6f22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"735965d0_1aed87ee","in_reply_to":"035b3e5c_0174c3a5","updated":"2024-10-07 20:04:59.000000000","message":"Yes the with statement updates all the nova.conf for all computes in the deployment specifically libvirt/image_type\u003ddefault. When all actions are finalized within the scope of the with statement it reverts the computes back to it\u0027s original configuration.","commit_id":"261de3a03640287797243bcdccd971e1f342e50b"}],"whitebox_tempest_plugin/api/compute/test_rbd_direct_download.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a394bf7f3a78b62121e90d8ca5c60b43b29d2203","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            raise cls.skipException(skip_msg)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_rbd_logs_and_conf(self):"},{"line_number":41,"context_line":"        with self.config_all_computes("},{"line_number":42,"context_line":"            (\u0027libvirt\u0027, \u0027images_type\u0027, \u0027default\u0027),"},{"line_number":43,"context_line":"        ):"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"            base_server \u003d self.create_test_server(wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":46,"context_line":"            image \u003d self.create_image_from_server("},{"line_number":47,"context_line":"                base_server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"14982d59_c16bf30b","line":44,"range":{"start_line":41,"start_character":7,"end_line":44,"end_character":0},"updated":"2024-10-07 11:54:56.000000000","message":"how this works is, this updates conf on run time (like we set flags in functional tests)\n```\n[libvirt]\nimage_type \u003d default\n```\nand restart compute agent at service-host.\n\nonce test is done, it reset the data as per initial values, and restart compute service.\n\ndefined here: https://github.com/openstack/whitebox-tempest-plugin/blob/5cbfbdf9d24978e93794ace7e2eead1fbbb42041/whitebox_tempest_plugin/services/clients.py#L141\n\n\nright now its timing out on compute service first restart.","commit_id":"561515618cb4a28b5b70e9708d78bc7349dbf523"}],"whitebox_tempest_plugin/services/clients.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"123b5bfa809083263f6709136c20f335580c651b","unresolved":true,"context_lines":[{"line_number":93,"context_line":"            command \u003d \u0027sh -c \"zgrep \\\u0027%s\\\u0027 /var/log/nova/*\"\u0027 % query_string"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            unit \u003d CONF.whitebox_nova_compute.journalctl_unit"},{"line_number":96,"context_line":"            command \u003d \u0027journalctl -u %s -g \\\u0027%s\\\u0027\u0027 % (unit, query_string)"},{"line_number":97,"context_line":"            if CONF.whitebox_nova_compute.containerized_service_logs:"},{"line_number":98,"context_line":"                services_dict \u003d self.host_parameters.get(\u0027services\u0027, {})"},{"line_number":99,"context_line":"                nova_compute_srvc \u003d services_dict.get(\u0027nova-compute\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"594c7d44_837ef50e","line":96,"range":{"start_line":96,"start_character":22,"end_line":96,"end_character":73},"updated":"2024-09-26 15:38:44.000000000","message":"this works.\nso I was holding, but if you are going to respin,  can we use f-string instead, thats more readable\ncmd \u003d f\"journalctl -u {unit} -g {query_string}\"","commit_id":"d86cabff1ce6325b1003e94f6b1589b1281097f8"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"2a33df97d32f175957ed792fb487918313a9c31d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            command \u003d \u0027sh -c \"zgrep \\\u0027%s\\\u0027 /var/log/nova/*\"\u0027 % query_string"},{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            unit \u003d CONF.whitebox_nova_compute.journalctl_unit"},{"line_number":96,"context_line":"            command \u003d \u0027journalctl -u %s -g \\\u0027%s\\\u0027\u0027 % (unit, query_string)"},{"line_number":97,"context_line":"            if CONF.whitebox_nova_compute.containerized_service_logs:"},{"line_number":98,"context_line":"                services_dict \u003d self.host_parameters.get(\u0027services\u0027, {})"},{"line_number":99,"context_line":"                nova_compute_srvc \u003d services_dict.get(\u0027nova-compute\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"064415c4_2ba96526","line":96,"range":{"start_line":96,"start_character":22,"end_line":96,"end_character":73},"in_reply_to":"594c7d44_837ef50e","updated":"2024-09-30 22:53:47.000000000","message":"Done","commit_id":"d86cabff1ce6325b1003e94f6b1589b1281097f8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b973782d06ed77af1e58fc2ff76e1d24807d567c","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            unit \u003d CONF.whitebox_nova_compute.journalctl_unit"},{"line_number":96,"context_line":"            command \u003d \u0027journalctl -u %s -g \\\u0027%s\\\u0027\u0027 % (unit, query_string)"},{"line_number":97,"context_line":"            if CONF.whitebox_nova_compute.containerized_service_logs:"},{"line_number":98,"context_line":"                services_dict \u003d self.host_parameters.get(\u0027services\u0027, {})"},{"line_number":99,"context_line":"                nova_compute_srvc \u003d services_dict.get(\u0027nova-compute\u0027)"},{"line_number":100,"context_line":"                container_name \u003d nova_compute_srvc.get(\u0027container_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"67dee9f4_b9fc0511","line":97,"updated":"2024-09-26 14:32:05.000000000","message":"Do we need this new config options? Two lines down we\u0027re checking for the presence of `container_name` in nodes.yaml for this host, wouldn\u0027t its presence be enough? IOW, if `container_name` is present, use it, otherwise assume uncontainerized.","commit_id":"d86cabff1ce6325b1003e94f6b1589b1281097f8"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"2f93a2e7456102a67916892edf628b94be7887aa","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            unit \u003d CONF.whitebox_nova_compute.journalctl_unit"},{"line_number":96,"context_line":"            command \u003d \u0027journalctl -u %s -g \\\u0027%s\\\u0027\u0027 % (unit, query_string)"},{"line_number":97,"context_line":"            if CONF.whitebox_nova_compute.containerized_service_logs:"},{"line_number":98,"context_line":"                services_dict \u003d self.host_parameters.get(\u0027services\u0027, {})"},{"line_number":99,"context_line":"                nova_compute_srvc \u003d services_dict.get(\u0027nova-compute\u0027)"},{"line_number":100,"context_line":"                container_name \u003d nova_compute_srvc.get(\u0027container_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"719e9017_242aa629","line":97,"in_reply_to":"67dee9f4_b9fc0511","updated":"2024-09-26 15:15:54.000000000","message":"Good point, I think that would work.  We do not have any tests that need to access  information or execute commands from within the nova_compute container on the computes so removing the container name from nodes.yaml should not be a problem.  Let me give that approach a try upstream/downstream.","commit_id":"d86cabff1ce6325b1003e94f6b1589b1281097f8"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"2a33df97d32f175957ed792fb487918313a9c31d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            unit \u003d CONF.whitebox_nova_compute.journalctl_unit"},{"line_number":96,"context_line":"            command \u003d \u0027journalctl -u %s -g \\\u0027%s\\\u0027\u0027 % (unit, query_string)"},{"line_number":97,"context_line":"            if CONF.whitebox_nova_compute.containerized_service_logs:"},{"line_number":98,"context_line":"                services_dict \u003d self.host_parameters.get(\u0027services\u0027, {})"},{"line_number":99,"context_line":"                nova_compute_srvc \u003d services_dict.get(\u0027nova-compute\u0027)"},{"line_number":100,"context_line":"                container_name \u003d nova_compute_srvc.get(\u0027container_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"814cc8ae_efb19c6f","line":97,"in_reply_to":"719e9017_242aa629","updated":"2024-09-30 22:53:47.000000000","message":"Done","commit_id":"d86cabff1ce6325b1003e94f6b1589b1281097f8"}]}