)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"4bb95642ab36d14e05afdfcb33e11295214593fb","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-09-10 13:46:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nova offlines all unused cpu\u0027s from the dedicated set except for the core cpu 0. updating the test to exclude the cpu 0 so as to pass the failing test cases for this reason."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1943df7ffeea08e479820c3a87af869e1d9dbec9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"6daadf60_402c886e","line":8,"updated":"2024-09-11 10:19:54.000000000","message":"can you please divide this into header and msg, this do not look good in git log.\n\nI suggest:\nDiscard the cpu-0 from dedicated set\n\n\u003cyour-full-mgs\u003e","commit_id":"115600c9dc867dd0b775f6c6a4683827ba0a64a9"},{"author":{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"},"change_message_id":"d57ed98ced5ecc8e1ccaadf05a9cdc6898d079c3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-09-10 13:46:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nova offlines all unused cpu\u0027s from the dedicated set except for the core cpu 0. updating the test to exclude the cpu 0 so as to pass the failing test cases for this reason."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1943df7ffeea08e479820c3a87af869e1d9dbec9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c174cd27_35a5b9f5","line":8,"in_reply_to":"6daadf60_402c886e","updated":"2024-09-11 20:43:05.000000000","message":"Done","commit_id":"115600c9dc867dd0b775f6c6a4683827ba0a64a9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"4bb95642ab36d14e05afdfcb33e11295214593fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b09ef1c1_bf7cdd56","updated":"2024-09-11 10:19:54.000000000","message":"Change seems correct, soft -1 to highlight that commit msg should be updated.","commit_id":"115600c9dc867dd0b775f6c6a4683827ba0a64a9"},{"author":{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"},"change_message_id":"237404c538814d76f34fe9e853ac7160cb7e85a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"add6aff1_2e8f941f","updated":"2024-09-10 20:28:12.000000000","message":"recheck","commit_id":"115600c9dc867dd0b775f6c6a4683827ba0a64a9"},{"author":{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"},"change_message_id":"d57ed98ced5ecc8e1ccaadf05a9cdc6898d079c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"43d67967_fc53ebe3","in_reply_to":"b09ef1c1_bf7cdd56","updated":"2024-09-11 20:43:05.000000000","message":"Changed the messaging","commit_id":"115600c9dc867dd0b775f6c6a4683827ba0a64a9"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"c75362518fcfd765e136e17fd1a66ee0983ae901","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c7cd6712_746b4a68","updated":"2024-09-12 23:50:10.000000000","message":"LGTM","commit_id":"0ead5a9bc78ecaada7a4cd631086526ae71aafbf"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"bd828a27d9428f389079b3b379b96de5dbac5f79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aa92100e_f8265734","updated":"2024-09-16 21:08:24.000000000","message":"recheck","commit_id":"0ead5a9bc78ecaada7a4cd631086526ae71aafbf"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8c62e71ea586209580d59d1f3c6c95e6790e0e24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f5f29a67_e77d2ff5","updated":"2024-09-12 06:22:41.000000000","message":"thanks for update, change does whats said in commit msg.\nand as mentioned in jira here https://issues.redhat.com/browse/OSPRH-9520\n\nso lgtm.","commit_id":"0ead5a9bc78ecaada7a4cd631086526ae71aafbf"}],"whitebox_tempest_plugin/api/compute/test_cpu_state_mgmt.py":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"045a7f7f0edc318130d0cbe742b8de09ac168345","unresolved":true,"context_lines":[{"line_number":42,"context_line":"                                        self.os_admin.services_client)"},{"line_number":43,"context_line":"        dedicated_cpus \u003d sm.get_cpu_dedicated_set()"},{"line_number":44,"context_line":"        shared_cpus \u003d sm.get_cpu_shared_set()"},{"line_number":45,"context_line":"        dedicated_cpus.remove(0)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if len(dedicated_cpus) \u003c 2:"},{"line_number":48,"context_line":"            raise self.skipException(\u0027Multiple dedicated CPUs required\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0cdc379_71abe3af","line":45,"updated":"2024-09-04 13:48:45.000000000","message":"I recommend trying .discard instead of .remove which will not raise an exception if 0 is missing from the dedicated list.  Also add a small note saying this discard action is being done because Nova will not offline CPU 0 regardless of it being in the dedicated set so to avoid any false failures, removing it from cpus that need to be checked.","commit_id":"cfcab2aefd7c2aab7df46123d27f8d8132f05931"},{"author":{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"},"change_message_id":"68dfac43c35a7067aac175a9dc024c8a576b2ff5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                        self.os_admin.services_client)"},{"line_number":43,"context_line":"        dedicated_cpus \u003d sm.get_cpu_dedicated_set()"},{"line_number":44,"context_line":"        shared_cpus \u003d sm.get_cpu_shared_set()"},{"line_number":45,"context_line":"        dedicated_cpus.remove(0)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        if len(dedicated_cpus) \u003c 2:"},{"line_number":48,"context_line":"            raise self.skipException(\u0027Multiple dedicated CPUs required\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f4063173_7d4cf323","line":45,"in_reply_to":"c0cdc379_71abe3af","updated":"2024-09-09 20:30:58.000000000","message":"Acknowledged","commit_id":"cfcab2aefd7c2aab7df46123d27f8d8132f05931"},{"author":{"_account_id":34309,"name":"Sreelakshmi Menon Kovili","display_name":"Sree","email":"skovili@redhat.com","username":"sreekovili"},"change_message_id":"d930d4e19a401717c7273a0c20ce18d707dc3f8c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                        self.os_admin.services_client)"},{"line_number":43,"context_line":"        dedicated_cpus \u003d sm.get_cpu_dedicated_set()"},{"line_number":44,"context_line":"        shared_cpus \u003d sm.get_cpu_shared_set()"},{"line_number":45,"context_line":"        #Nova offlines all unused cpu\u0027s from the dedicated set except for cpu0."},{"line_number":46,"context_line":"        # Hence modifying to exclude it avoid false test failures."},{"line_number":47,"context_line":"        dedicated_cpus.discard(0)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"735b0b58_457fb7e9","line":45,"in_reply_to":"32db82e7_e39a284b","updated":"2024-09-10 14:38:40.000000000","message":"\u003e pep8: E265 block comment should start with \u0027# \u0027\n\nPlease fix.","commit_id":"90cb3c3ed364928017c8ed616130f461fe1cd203"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"4bb95642ab36d14e05afdfcb33e11295214593fb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                                        self.os_admin.services_client)"},{"line_number":43,"context_line":"        dedicated_cpus \u003d sm.get_cpu_dedicated_set()"},{"line_number":44,"context_line":"        shared_cpus \u003d sm.get_cpu_shared_set()"},{"line_number":45,"context_line":"        # Nova offlines all unused cpu\u0027s from the dedicated set except for cpu0"},{"line_number":46,"context_line":"        # Hence modifying to exclude it avoid false test failures."},{"line_number":47,"context_line":"        dedicated_cpus.discard(0)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8a36f9ee_1acc0033","line":45,"range":{"start_line":45,"start_character":64,"end_line":45,"end_character":79},"updated":"2024-09-11 10:19:54.000000000","message":"because CPU-0 is not hot pluggable.","commit_id":"115600c9dc867dd0b775f6c6a4683827ba0a64a9"}]}