)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"c3677ef42a9223d1610167c9fe2514365676d9fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d1857e4f_c4b788d4","updated":"2025-07-28 13:52:41.000000000","message":"LGTM","commit_id":"86f5a22af12f7c972ba23d3f9db224b7f3053634"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"40422b4123165e0ef912f8e6403b955c4e347b06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b8ff2d00_093fe237","updated":"2025-07-26 03:29:07.000000000","message":"test is passing, this is good to go https://zuul.opendev.org/t/openstack/build/247dfa26acb74f2984c4a9429b6f4806/log/job-output.txt#36599","commit_id":"86f5a22af12f7c972ba23d3f9db224b7f3053634"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3efef1d7cb7267cc9c196195a8eaeee5fdf7b56e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a84c1624_9b37b7cf","updated":"2025-07-30 00:09:08.000000000","message":"for context of other we spoke about this a bit on #openstack-qa and i ask to simplify this initial test and then ad 2 others later to test BFV form iso\nand attaching cinder volume create form iso or similarly.\n\nbasically have this simplified basic test that no dep on cinder to run and then add dedicated tests that use cinder in addition to that later.\n\nthis way even without cinder we can verify the basic support and we can expand form there.\n\nso +2 form me thansk gmann","commit_id":"19f39aba511ddf6ecddd0e7dd5ae2440e57bdbbd"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ba0732d22ead2f32b97244fcca3c9db3d1a521de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a3e57ff1_328001af","updated":"2025-07-31 21:45:01.000000000","message":"forgot to post my draft reply.","commit_id":"19f39aba511ddf6ecddd0e7dd5ae2440e57bdbbd"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"29c9a5a35f3c08c1841737b6570d6010d4248d14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"09813f84_8e3421ba","updated":"2025-07-30 17:11:34.000000000","message":"recheck","commit_id":"19f39aba511ddf6ecddd0e7dd5ae2440e57bdbbd"}],"whitebox_tempest_plugin/api/compute/test_iso_image.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"69288a5778d176e405d4fa9cb435316c707ad2eb","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        3. Create volume"},{"line_number":62,"context_line":"        4. Boot instance from iso image and with keypair"},{"line_number":63,"context_line":"        5. Check if server booted from iso image is via cdrom"},{"line_number":64,"context_line":"        5. Attach volume to instance"},{"line_number":65,"context_line":"        6. Reboot instance"},{"line_number":66,"context_line":"        7. Check if server booted from iso image is via cdrom"},{"line_number":67,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"e724f7a4_66a1ef2e","line":64,"updated":"2025-07-28 22:54:03.000000000","message":"this wont actully alter the boot order.\nwe can do this test but its not strictly required.","commit_id":"86f5a22af12f7c972ba23d3f9db224b7f3053634"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9bb1abe9f3aeb454747b0b2cdd9c68b5d2b84607","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        3. Create volume"},{"line_number":62,"context_line":"        4. Boot instance from iso image and with keypair"},{"line_number":63,"context_line":"        5. Check if server booted from iso image is via cdrom"},{"line_number":64,"context_line":"        5. Attach volume to instance"},{"line_number":65,"context_line":"        6. Reboot instance"},{"line_number":66,"context_line":"        7. Check if server booted from iso image is via cdrom"},{"line_number":67,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"60c58ee5_a5c5675a","line":64,"in_reply_to":"e724f7a4_66a1ef2e","updated":"2025-07-29 03:04:45.000000000","message":"Yeah, I know but I wanted to test the cinder volume attach code path also if anything missed for iso image","commit_id":"86f5a22af12f7c972ba23d3f9db224b7f3053634"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"69288a5778d176e405d4fa9cb435316c707ad2eb","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":83,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.attach_volume(server, volume)"},{"line_number":86,"context_line":"        self.reboot_server(server[\u0027id\u0027], type\u003d\u0027HARD\u0027)"},{"line_number":87,"context_line":"        domain_xml \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":88,"context_line":"        boot_from_cdrom \u003d domain_xml.find(\"./devices/disk[@device\u003d\u0027cdrom\u0027]\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"2a0c0150_63098c3e","line":85,"updated":"2025-07-28 22:54:03.000000000","message":"ok so this is using \nhttps://github.com/openstack/tempest/blob/6158cc5cdc922dfdd67236766f0fdb8b36ff3703/tempest/api/compute/base.py#L589-L636\n\nthis will internally wait for the attach whic is good unfortulaly its also addign a cleanup to delet ethe voulme and wait for that which is even less related to the scope of this test then usign a volume is in the frist place.\n\nthis teast shoudl really be able to run without cinder.\n\nesacilly since we are not making any meaining full assertion about the volume in the test.","commit_id":"86f5a22af12f7c972ba23d3f9db224b7f3053634"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9bb1abe9f3aeb454747b0b2cdd9c68b5d2b84607","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":83,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.attach_volume(server, volume)"},{"line_number":86,"context_line":"        self.reboot_server(server[\u0027id\u0027], type\u003d\u0027HARD\u0027)"},{"line_number":87,"context_line":"        domain_xml \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":88,"context_line":"        boot_from_cdrom \u003d domain_xml.find(\"./devices/disk[@device\u003d\u0027cdrom\u0027]\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"f5a0c149_9e1e1cfe","line":85,"in_reply_to":"2a0c0150_63098c3e","updated":"2025-07-29 03:04:45.000000000","message":"As we are doing attach, it will cleanup to detach the volume. My main purpose to test volume attachment is if nova or cinder missing anything specific to iso image/cdrom device.\n\nI know we can test it without cinder but I think no harm in testing volume attachment also.","commit_id":"86f5a22af12f7c972ba23d3f9db224b7f3053634"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ba0732d22ead2f32b97244fcca3c9db3d1a521de","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        waiters.wait_for_volume_resource_status(self.volumes_client,"},{"line_number":83,"context_line":"                                                volume[\u0027id\u0027], \u0027available\u0027)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.attach_volume(server, volume)"},{"line_number":86,"context_line":"        self.reboot_server(server[\u0027id\u0027], type\u003d\u0027HARD\u0027)"},{"line_number":87,"context_line":"        domain_xml \u003d self.get_server_xml(server[\u0027id\u0027])"},{"line_number":88,"context_line":"        boot_from_cdrom \u003d domain_xml.find(\"./devices/disk[@device\u003d\u0027cdrom\u0027]\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"8fdb84c2_bea3a654","line":85,"in_reply_to":"f5a0c149_9e1e1cfe","updated":"2025-07-31 21:45:01.000000000","message":"Discussed it on IRC and I agree now not to include the volume attachment operation in this test scope.","commit_id":"86f5a22af12f7c972ba23d3f9db224b7f3053634"}]}