)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e856325907ca598947218ebc6fd192154a723754","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Add test case that confirms flavor metadata is now present within the"},{"line_number":10,"context_line":"guest XML [1]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/openstack/nova/commit/93b90d2b6a58df26f6fbf0ff0fe20cf37fcbf8af"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I99a57883940bc299de8fe7676139a5f8f87569e5"},{"line_number":15,"context_line":"Signed-off-by: jamepark4 \u003cjparker@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ece6e54a_c10f8771","line":12,"updated":"2025-11-04 17:06:29.000000000","message":"the flavor id and metadata is added by this commit instead https://github.com/openstack/nova/commit/619cd0a9c733125d8c2bac10c8b0b40e00bd2594#diff-486ddc37ce8e7c105a51566dd2cffbda034f28fae7eaad2e74abf470ab296352R6253","commit_id":"67318c54c300d6cb7785c8ec830a17946b1c62d7"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"2c162b63d5679f461a15c23ea3ff4c88e7141ef7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add test case that confirms flavor metadata is now present within the"},{"line_number":10,"context_line":"guest XML [1]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[1] https://github.com/openstack/nova/commit/93b90d2b6a58df26f6fbf0ff0fe20cf37fcbf8af"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I99a57883940bc299de8fe7676139a5f8f87569e5"},{"line_number":15,"context_line":"Signed-off-by: jamepark4 \u003cjparker@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7bf7b5fd_5a2dfa25","line":12,"in_reply_to":"ece6e54a_c10f8771","updated":"2025-11-04 17:09:04.000000000","message":"Acknowledged","commit_id":"67318c54c300d6cb7785c8ec830a17946b1c62d7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"c0dbfbe9fb0a4bce7117a6ce418561b836f079f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"36f96721_725a061b","updated":"2025-09-11 13:27:47.000000000","message":"Confirmed this is working downstream as well.","commit_id":"ce26f995abba1f5c28d3bd9d2ab9709d3005f585"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e856325907ca598947218ebc6fd192154a723754","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ced084c_fd173657","updated":"2025-11-04 17:06:29.000000000","message":"Overall looks good but I have two small requests.","commit_id":"67318c54c300d6cb7785c8ec830a17946b1c62d7"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"d4e093541b73cd139a05b6978aaf1a3fa7264367","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6d9eb1ae_d142e069","updated":"2025-09-17 15:28:42.000000000","message":"Thanks James, LGTM","commit_id":"67318c54c300d6cb7785c8ec830a17946b1c62d7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2d8231c376bf333bc763115988a299b2549dcc25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34f7b9b8_36feb61a","updated":"2025-11-07 10:13:35.000000000","message":"Thanks looks good to me","commit_id":"5b4c0669d3418898ac21fa27b03ab6c4222a8c94"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b75fd1de5afdec8d3f5af0def2263acfbdfbe21b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"367ee657_2638d885","updated":"2025-11-04 23:06:32.000000000","message":"lgtm, test is passing - https://zuul.opendev.org/t/openstack/build/ecc19e2a3a1e4be0b69ab4743c13c7f1/log/job-output.txt#36149\n\nI will wait for gibi re-review if any more feedback otherwise I will approve it tomorrow.","commit_id":"5b4c0669d3418898ac21fa27b03ab6c4222a8c94"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"982ae7a9063e4c21c3574f075f660045b9b38536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2cb1b03d_94f94202","updated":"2025-11-07 17:13:02.000000000","message":"merging it. thanks","commit_id":"5b4c0669d3418898ac21fa27b03ab6c4222a8c94"}],"whitebox_tempest_plugin/api/compute/test_flavor_metadata.py":[{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"b1a5f3ec63d1da63300b76c36dc5acd70baa1ad6","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from whitebox_tempest_plugin.api.compute import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestFlavorMetadata(base.BaseWhiteboxComputeTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed30d6e2_57ef02bf","line":24,"updated":"2025-09-17 14:41:38.000000000","message":"is this required as it is not being used anywhere ?","commit_id":"ce26f995abba1f5c28d3bd9d2ab9709d3005f585"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"f4132d4ee54123d877cbe594a1b2db5c62b2853a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from whitebox_tempest_plugin.api.compute import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestFlavorMetadata(base.BaseWhiteboxComputeTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"573a83c7_3a7a5d58","line":24,"in_reply_to":"a1ca2254_e028291d","updated":"2025-09-17 15:09:54.000000000","message":"Done","commit_id":"ce26f995abba1f5c28d3bd9d2ab9709d3005f585"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"66d150870e15d332a556520a8f34452fe3dfbc61","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from whitebox_tempest_plugin.api.compute import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestFlavorMetadata(base.BaseWhiteboxComputeTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1ca2254_e028291d","line":24,"in_reply_to":"ed30d6e2_57ef02bf","updated":"2025-09-17 15:01:25.000000000","message":"No I\u0027m not using this it can be removed.","commit_id":"ce26f995abba1f5c28d3bd9d2ab9709d3005f585"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"b1a5f3ec63d1da63300b76c36dc5acd70baa1ad6","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        flv_metadata_id \u003d flavor_element.attrib.get(\u0027id\u0027)"},{"line_number":45,"context_line":"        msg \u003d (\"The expected flavor metadata name %s was not found and instead\""},{"line_number":46,"context_line":"               \" found %s\", name, flv_metadata_name)"},{"line_number":47,"context_line":"        self.assertEqual(flavor[\u0027id\u0027], flv_metadata_id, msg)"},{"line_number":48,"context_line":"        msg \u003d (\"The expected flavor metadata id %s was not found and instead\""},{"line_number":49,"context_line":"               \" found %s\", flavor[\u0027id\u0027], flv_metadata_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f454e9b_8c695eed","line":47,"updated":"2025-09-17 14:41:38.000000000","message":"I think we need two asserts here one for id and other one for name as you have two msg","commit_id":"ce26f995abba1f5c28d3bd9d2ab9709d3005f585"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"66d150870e15d332a556520a8f34452fe3dfbc61","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        flv_metadata_id \u003d flavor_element.attrib.get(\u0027id\u0027)"},{"line_number":45,"context_line":"        msg \u003d (\"The expected flavor metadata name %s was not found and instead\""},{"line_number":46,"context_line":"               \" found %s\", name, flv_metadata_name)"},{"line_number":47,"context_line":"        self.assertEqual(flavor[\u0027id\u0027], flv_metadata_id, msg)"},{"line_number":48,"context_line":"        msg \u003d (\"The expected flavor metadata id %s was not found and instead\""},{"line_number":49,"context_line":"               \" found %s\", flavor[\u0027id\u0027], flv_metadata_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"54b2bc22_389c1f36","line":47,"in_reply_to":"4f454e9b_8c695eed","updated":"2025-09-17 15:01:25.000000000","message":"I somehow deleted my second assert before committing thanks for catching this.","commit_id":"ce26f995abba1f5c28d3bd9d2ab9709d3005f585"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"f4132d4ee54123d877cbe594a1b2db5c62b2853a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        flv_metadata_id \u003d flavor_element.attrib.get(\u0027id\u0027)"},{"line_number":45,"context_line":"        msg \u003d (\"The expected flavor metadata name %s was not found and instead\""},{"line_number":46,"context_line":"               \" found %s\", name, flv_metadata_name)"},{"line_number":47,"context_line":"        self.assertEqual(flavor[\u0027id\u0027], flv_metadata_id, msg)"},{"line_number":48,"context_line":"        msg \u003d (\"The expected flavor metadata id %s was not found and instead\""},{"line_number":49,"context_line":"               \" found %s\", flavor[\u0027id\u0027], flv_metadata_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8ab5fe46_04054001","line":47,"in_reply_to":"54b2bc22_389c1f36","updated":"2025-09-17 15:09:54.000000000","message":"Done","commit_id":"ce26f995abba1f5c28d3bd9d2ab9709d3005f585"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e856325907ca598947218ebc6fd192154a723754","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d176acd_68445696","line":49,"updated":"2025-11-04 17:06:29.000000000","message":"It would be nice to assert that extra_spec is included as well.","commit_id":"67318c54c300d6cb7785c8ec830a17946b1c62d7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b75fd1de5afdec8d3f5af0def2263acfbdfbe21b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f02f2d0_6e60bc80","line":49,"in_reply_to":"148f068a_9f5a3e1e","updated":"2025-11-04 23:06:32.000000000","message":"Done","commit_id":"67318c54c300d6cb7785c8ec830a17946b1c62d7"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"2c162b63d5679f461a15c23ea3ff4c88e7141ef7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1c80b8d_32d4ae02","line":49,"in_reply_to":"9d176acd_68445696","updated":"2025-11-04 17:09:04.000000000","message":"Good idea, will include a check for that as well.","commit_id":"67318c54c300d6cb7785c8ec830a17946b1c62d7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d7282746d0ec3859b3ae858f1f9e958e4b1911ea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"148f068a_9f5a3e1e","line":49,"in_reply_to":"b1c80b8d_32d4ae02","updated":"2025-11-04 17:15:24.000000000","message":"though this + extra spec lgtm. but any particular reason of not asserting on all flavor fields for example vcpu etc?","commit_id":"67318c54c300d6cb7785c8ec830a17946b1c62d7"}]}