)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"373ac49b5466fb0f109109caa84bb9b803de35a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d7f005e2_d09a6513","updated":"2026-03-24 15:06:20.000000000","message":"recheck","commit_id":"a282b26544b51cd10dc1d3492f82d6264b5cd73d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"da216e0ae9c154e2a772e6ca222c52b8fba2da1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7328b23e_ae5f23b2","updated":"2026-03-24 16:48:22.000000000","message":"| This change is ready for review.\n\nThis seems automatically done when posting the review comments which is not good. there should be way to add comment but still keep change in WIP.","commit_id":"a282b26544b51cd10dc1d3492f82d6264b5cd73d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6e64d2da9f1dcf37749c834fce86ea0bef3e8073","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"accd77b5_49230a4a","in_reply_to":"7328b23e_ae5f23b2","updated":"2026-03-24 16:56:09.000000000","message":"When I have used WIP on my own changes I found that when posting comments there are two options: a blue button that says \"SEND AND START REVIEW\" and a link that says \"SEND AS WIP\" that is _not_ a blue button and it keeps the change in WIP.","commit_id":"a282b26544b51cd10dc1d3492f82d6264b5cd73d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"27c710e134fd3c2727521c17ad04fb6e3971215b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"efb2b89e_3badcb91","in_reply_to":"accd77b5_49230a4a","updated":"2026-03-24 16:58:48.000000000","message":"ah, i can see now \"SEND AS WIP\" but in very light grey color :) and that is why i missed it. thanks. I will check it in future.","commit_id":"a282b26544b51cd10dc1d3492f82d6264b5cd73d"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"c881a7d2e85f9631eb1536ea72e4509f1da7230d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2f66daa8_46b5e07c","updated":"2026-03-24 20:26:03.000000000","message":"Kicked off full downstream suite to verify there are no other issues, will convert off WIP when I get the results.","commit_id":"769f5a42ef75f7219fd40e5a212dfc5725b56df9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"03e83807664fc6a50011d97dabf0b97fb1af3b55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ccb6ccf4_9f100a1e","updated":"2026-03-26 15:14:51.000000000","message":"Lgtm, thanks","commit_id":"fd4cef0a5596831e61714e600d15da81a3f1b093"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"5f53995867d873438cdc5bd5f83b1810ca91ea7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c48d37c9_4e211db8","updated":"2026-03-26 11:59:24.000000000","message":"Related downstream tests are passing, moving to review.","commit_id":"fd4cef0a5596831e61714e600d15da81a3f1b093"}],"whitebox_tempest_plugin/api/compute/test_vtpm.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"772ae8dc1270cfb779931e8c7720b03a029034fd","unresolved":true,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        In this case the libvirt secret needs to be ephemeral\u003dno and private\u003dno"},{"line_number":213,"context_line":"        allowing it to be read back from libvirt."},{"line_number":214,"context_line":"        \"\"\""},{"line_number":215,"context_line":"        vtpm_model \u003d \u0027tpm-tis\u0027"},{"line_number":216,"context_line":"        vtpm_version \u003d \u00271.2\u0027"},{"line_number":217,"context_line":"        flavor_specs \u003d {\u0027hw:tpm_version\u0027: vtpm_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"676ae0b5_029365fb","line":214,"updated":"2026-03-19 23:00:12.000000000","message":"Alternatively, you could do a if not getattr(CONF.compute_feature_enabled, \u0027vtpm_live_migration\u0027, False) then raise a skipException. I\u0027m not sure if there\u0027s a potential downside to doing that. I guess it could be considered bad to write it that way just to accommodate downstream.\n\nIt doesn\u0027t seem good IMHO to remove the use of the flag entirely bc given the flag, one using Tempest upstream would expect if vTPM live migration is disabled it shouldn\u0027t be running any vTPM live migration tests.\n\nI don\u0027t have any other ideas at the moment but maybe someone else will.","commit_id":"7f40061496ef0dde513a339ea230b1cf124ca94d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3151217d64edf6426db7f43544ecd28f92a4c9f","unresolved":true,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        In this case the libvirt secret needs to be ephemeral\u003dno and private\u003dno"},{"line_number":213,"context_line":"        allowing it to be read back from libvirt."},{"line_number":214,"context_line":"        \"\"\""},{"line_number":215,"context_line":"        vtpm_model \u003d \u0027tpm-tis\u0027"},{"line_number":216,"context_line":"        vtpm_version \u003d \u00271.2\u0027"},{"line_number":217,"context_line":"        flavor_specs \u003d {\u0027hw:tpm_version\u0027: vtpm_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"b06b0136_7234e143","line":214,"in_reply_to":"676ae0b5_029365fb","updated":"2026-03-23 19:30:30.000000000","message":"I agree with Mel, we should not remove the flag, otherwise it will run these tests on the env where vTPM live migration is not set up.\n\nThe proper way to handle the dependency on the latest Tempest is via defining the tempest min required version in requirements.txt. That way, we will be able to properly convey what tempest version is required as min. This is how other tempest plugins does. \n\nI have released the new version of Tempest, which includes the new config option vtpm_live_migration - https://review.opendev.org/c/openstack/releases/+/981620  In this case, requirements.txt can have tempest \u003e\u003d46.2.0\n\nBut to handle this case specially, there are two ways:\n1. Have https://review.opendev.org/c/openstack/tempest/+/957475 in downstream\n2. Temporary solution: As I do not see any direct dependency of this test on tempest other than this config option, it is better whitebox-tempest-plugin add its own config and a todo to remove later once required tempest version 46.2.0 is min supported one (I mean when tempest master stop supporting releases \u003cgazpacho)","commit_id":"7f40061496ef0dde513a339ea230b1cf124ca94d"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"ea2e0c29d79c32d76ca86360464c79baecfe9573","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        In this case the libvirt secret needs to be ephemeral\u003dno and private\u003dno"},{"line_number":213,"context_line":"        allowing it to be read back from libvirt."},{"line_number":214,"context_line":"        \"\"\""},{"line_number":215,"context_line":"        vtpm_model \u003d \u0027tpm-tis\u0027"},{"line_number":216,"context_line":"        vtpm_version \u003d \u00271.2\u0027"},{"line_number":217,"context_line":"        flavor_specs \u003d {\u0027hw:tpm_version\u0027: vtpm_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9af593c1_30e90d80","line":214,"in_reply_to":"b06b0136_7234e143","updated":"2026-03-23 20:26:26.000000000","message":"I agree with Mel\u0027s proposed option as well. Talking with @gmaan.os14@gmail.com I think I will repurpose this commit to just add the parameter here and proceed with a follow up commit to add a minimum tempest requirement.","commit_id":"7f40061496ef0dde513a339ea230b1cf124ca94d"}],"whitebox_tempest_plugin/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3f3cba884aace7b9724f0c3a26f817860ec039fe","unresolved":true,"context_lines":[{"line_number":363,"context_line":"                     \u0027[libvirt]/swtpm_user\u003dtss\u0027"},{"line_number":364,"context_line":"                     \u0027[libvirt]/swtpm_group\u003dtss\u0027"},{"line_number":365,"context_line":"                     \u0027[key_manager]/backend\u003dbarbican\u0027),"},{"line_number":366,"context_line":"    cfg.BoolOpt(\u0027vtpm_live_migration_supported\u0027,"},{"line_number":367,"context_line":"                default\u003dTrue,"},{"line_number":368,"context_line":"                help\u003d\u0027Live migration is supported with guests using vTPM\u0027),"},{"line_number":369,"context_line":"    cfg.BoolOpt(\u0027vdpa_cold_migration_supported\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8b8f4ea7_13500b6c","line":366,"range":{"start_line":366,"start_character":0,"end_line":366,"end_character":48},"updated":"2026-03-24 16:47:16.000000000","message":"just one thing, can you please add a TODO here about this is temporary config added to solve if latest tempest is not used. At the end we should use the tempest config \u0027vtpm_live_migration\u0027","commit_id":"a282b26544b51cd10dc1d3492f82d6264b5cd73d"},{"author":{"_account_id":31033,"name":"James Parker","email":"jparker@redhat.com","username":"jparker"},"change_message_id":"f1f0a2651087d8066587d5c59382c54170c2a598","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                     \u0027[libvirt]/swtpm_user\u003dtss\u0027"},{"line_number":364,"context_line":"                     \u0027[libvirt]/swtpm_group\u003dtss\u0027"},{"line_number":365,"context_line":"                     \u0027[key_manager]/backend\u003dbarbican\u0027),"},{"line_number":366,"context_line":"    cfg.BoolOpt(\u0027vtpm_live_migration_supported\u0027,"},{"line_number":367,"context_line":"                default\u003dTrue,"},{"line_number":368,"context_line":"                help\u003d\u0027Live migration is supported with guests using vTPM\u0027),"},{"line_number":369,"context_line":"    cfg.BoolOpt(\u0027vdpa_cold_migration_supported\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5813a4e0_495f5e26","line":366,"range":{"start_line":366,"start_character":0,"end_line":366,"end_character":48},"in_reply_to":"8b8f4ea7_13500b6c","updated":"2026-03-24 17:09:28.000000000","message":"Done","commit_id":"a282b26544b51cd10dc1d3492f82d6264b5cd73d"}]}