)]}'
{"specs/queens/delayed-queues.rst":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e6e48306b9189b1aee8edfdca515edd29f64f984","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"A delay queue is a queue with a delayed attribute."},{"line_number":23,"context_line":"All messages sent to the queue can not be immediately claimed"},{"line_number":24,"context_line":"and must wait for a delay ttl. The delay ttl can be set as"},{"line_number":25,"context_line":"a metadata when the queue is created."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"It would facilitate an auditing observer process, the auditor"},{"line_number":28,"context_line":"would be guaranteed to see messages before they were claimed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_d77387b0","line":25,"range":{"start_line":24,"start_character":31,"end_line":25,"end_character":37},"updated":"2017-10-23 01:24:49.000000000","message":"The delay ttl can be set or update as a queue\u0027s metadata.","commit_id":"b32c797674a93e50b7d98abb80a79d040dc77ca2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e6e48306b9189b1aee8edfdca515edd29f64f984","unresolved":false,"context_lines":[{"line_number":33,"context_line":"1.Add a new attributes for queue\u0027s metadata: ``_default_message_delay_ttl``."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":36,"context_line":"  900 secodes (15 mins).It will be storage in backend DB."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"2.Add a new attributes for message\u0027s request body: ``delay_ttl``."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_575f970d","line":36,"range":{"start_line":36,"start_character":23,"end_line":36,"end_character":24},"updated":"2017-10-23 01:24:49.000000000","message":"missed a blank","commit_id":"b32c797674a93e50b7d98abb80a79d040dc77ca2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e6e48306b9189b1aee8edfdca515edd29f64f984","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":36,"context_line":"  900 secodes (15 mins).It will be storage in backend DB."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"2.Add a new attributes for message\u0027s request body: ``delay_ttl``."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  When post messages to queue, can add ``delay_ttl`` like ``ttl``."},{"line_number":41,"context_line":"  The message\u0027s ``delay_ttl`` has a higher priority."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_77b9732c","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":49},"updated":"2017-10-23 01:24:49.000000000","message":"It\u0027s a new message attribute, not only for request body. Right? Please make it clear here.","commit_id":"b32c797674a93e50b7d98abb80a79d040dc77ca2"},{"author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"change_message_id":"20decd6e0192f8ffb456a24c1677a926152febf6","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"#. Add mongodb support."},{"line_number":85,"context_line":"#. Add redis support."},{"line_number":86,"context_line":"#. Add swift support."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Dependencies"},{"line_number":89,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f4b6375_7208fdd8","line":86,"updated":"2017-10-26 01:32:13.000000000","message":"#. Add release note for this feature\n#. Update API reference\n#. Add user/developer document for this feature\n#. Change unit, functional and tempest tests accordingly.","commit_id":"2160f75709d37d2be79dc7d0a7f886d662e7ff92"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"12f134707da7b1c8947ef0f4dfd8acb113a32ab5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   If message with ``delay`` attribute sent to a delayed queue, then Zaqar will"},{"line_number":56,"context_line":"   use the message\u0027s delay seconds value instead of the delayed queue\u0027s delay"},{"line_number":57,"context_line":"   seconds value."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Specific implementation steps:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for queue\u0027s metadata."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f4b6375_78fc543d","line":58,"updated":"2017-10-26 10:51:31.000000000","message":"what will happen if a delay message sent to a normal queue?\nI think you should add this uncommon scenario as well.","commit_id":"873f496c330e420ae182e7378d89697a5c996427"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"12f134707da7b1c8947ef0f4dfd8acb113a32ab5","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  When post messages to queue, user can add ``delay_ttl`` like ``ttl``."},{"line_number":69,"context_line":"  The message\u0027s ``delay_ttl`` has a higher priority. "},{"line_number":70,"context_line":"  "},{"line_number":71,"context_line":"3. Add a new message attribute ``delay_expires``."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  The attribute ``delay_expires`` is a expires timestamp. It can be saved"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f4b6375_7891f4f0","line":70,"updated":"2017-10-26 10:51:31.000000000","message":"please remove the blanks.","commit_id":"873f496c330e420ae182e7378d89697a5c996427"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"12f134707da7b1c8947ef0f4dfd8acb113a32ab5","unresolved":false,"context_lines":[{"line_number":79,"context_line":"3. Make sure the message can not be claimed until the delay ttl"},{"line_number":80,"context_line":"   is expired."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"4. If the queue is a normal queue means the \u0027delayed queues\u0027 feature wasn\u0027s"},{"line_number":83,"context_line":"   being used, it is necessary to ensure that it is close to zero overhead."},{"line_number":84,"context_line":"    "},{"line_number":85,"context_line":"5. Support for mongo, redis and swift."}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f4b6375_98af1029","line":82,"range":{"start_line":82,"start_character":69,"end_line":82,"end_character":75},"updated":"2017-10-26 10:51:31.000000000","message":"wasn\u0027t","commit_id":"873f496c330e420ae182e7378d89697a5c996427"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2489d2ef967a54a651aaa8d52e6ead1b871b225b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   it will not have a delay feature when it is sent to the normal queue."},{"line_number":64,"context_line":"   Zaqar does not perform conditional filtering on the ``delay`` attribute"},{"line_number":65,"context_line":"   when get/claim messages. This means the delay feature does not affect"},{"line_number":66,"context_line":"   the performance of normal queue."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specific implementation steps:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f4b6375_832d3fff","line":66,"updated":"2017-10-27 14:20:29.000000000","message":"How about raising 400 error when send a normal message to a normal queue? While I don\u0027t have a correct answer. Thought?","commit_id":"9fa154506ca115b4656c55b23ab770bc38d65f39"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"b1de7bd0eb08f0370202132aff2fd4436b5c1477","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   it will not have a delay feature when it is sent to the normal queue."},{"line_number":64,"context_line":"   Zaqar does not perform conditional filtering on the ``delay`` attribute"},{"line_number":65,"context_line":"   when get/claim messages. This means the delay feature does not affect"},{"line_number":66,"context_line":"   the performance of normal queue."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specific implementation steps:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f4b6375_35ea2fac","line":66,"in_reply_to":"3f4b6375_832d3fff","updated":"2017-10-28 04:07:33.000000000","message":"When the normal message is sent to the normal queue, it is similar with the original logic, not because the delay feature to raising 400 error.","commit_id":"9fa154506ca115b4656c55b23ab770bc38d65f39"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2489d2ef967a54a651aaa8d52e6ead1b871b225b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for queue\u0027s metadata."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":73,"context_line":"  900 secodes (15 mins). It will be storage in backend DB."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f4b6375_e324f30e","line":73,"range":{"start_line":73,"start_character":47,"end_line":73,"end_character":57},"updated":"2017-10-27 14:20:29.000000000","message":"\"the storage backend\" is better if it needs another PS.","commit_id":"9fa154506ca115b4656c55b23ab770bc38d65f39"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"b1de7bd0eb08f0370202132aff2fd4436b5c1477","unresolved":false,"context_lines":[{"line_number":70,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for queue\u0027s metadata."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":73,"context_line":"  900 secodes (15 mins). It will be storage in backend DB."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":76,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"3f4b6375_15cf3358","line":73,"range":{"start_line":73,"start_character":47,"end_line":73,"end_character":57},"in_reply_to":"3f4b6375_e324f30e","updated":"2017-10-28 04:07:33.000000000","message":"Done","commit_id":"9fa154506ca115b4656c55b23ab770bc38d65f39"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6c7bdfbc9a3355388480053a0a5bff828fc3e8eb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Generally, a new attribute of queue named ``delay``. If it\u0027s shown, then zaqar"},{"line_number":36,"context_line":"will take the queue as a delayed queue, otherwise, it\u0027s a normal queue."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"All messages sent to the delayed queue can not be immediately claimed and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_d199a1d0","line":35,"range":{"start_line":35,"start_character":44,"end_line":35,"end_character":49},"updated":"2017-10-30 02:14:29.000000000","message":"I think it should be \"_default_message_delay_ttl\" based on your code.","commit_id":"ac98a9924927b99ba27f0ceefc840ab92bc036f2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6c7bdfbc9a3355388480053a0a5bff828fc3e8eb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Proposed change"},{"line_number":33,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Generally, a new attribute of queue named ``delay``. If it\u0027s shown, then zaqar"},{"line_number":36,"context_line":"will take the queue as a delayed queue, otherwise, it\u0027s a normal queue."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"All messages sent to the delayed queue can not be immediately claimed and"}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_51adb1e8","line":35,"range":{"start_line":35,"start_character":51,"end_line":35,"end_character":53},"updated":"2017-10-30 02:14:29.000000000","message":"will be added.","commit_id":"ac98a9924927b99ba27f0ceefc840ab92bc036f2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"32d3eb56a6b10618faaa828cae35751124284fa1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"   the message is a normal message or a message with a ``delay`` attribute,"},{"line_number":63,"context_line":"   it will not have a delay feature when it is sent to the normal queue."},{"line_number":64,"context_line":"   Zaqar does not perform conditional filtering on the ``delay`` attribute"},{"line_number":65,"context_line":"   when get/claim messages. This means the delay feature does not affect"},{"line_number":66,"context_line":"   the performance of normal queue."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specific implementation steps:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_d6df62d4","line":66,"range":{"start_line":65,"start_character":57,"end_line":66,"end_character":35},"updated":"2017-10-28 10:08:14.000000000","message":"good to be. :)","commit_id":"ac98a9924927b99ba27f0ceefc840ab92bc036f2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"994fae8f5aaa1cc2f519935d800340dc570864af","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specific implementation steps:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for queue\u0027s metadata."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":73,"context_line":"  900 secodes (15 mins). It will be storage in the backend."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_91db294e","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":51},"updated":"2017-10-30 01:59:14.000000000","message":"More thinking here:\nnow we use the format \"_xxx\" for the queue\u0027s reserved metadata. The reserved metadata means that it has a default value(this default value is from config option) if users don\u0027t set.\nSo for the usage here, I think  \"_default_message_delay_ttl\" should not be used like this.\n\nMy suggestion:\n1. Create a new reserved metadata: \"_max_message_delay_ttl\" for queue.(You have done it in the patch, Please mention it in the spec)\n2. Create a new property (NOTE: it\u0027s not a reserved metadata) \"delay\" for queue. The value is boolean.","commit_id":"ac98a9924927b99ba27f0ceefc840ab92bc036f2"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"6a6586e61f800e71c7c9d2942632498a3a679d91","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specific implementation steps:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for queue\u0027s metadata."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":73,"context_line":"  900 secodes (15 mins). It will be storage in the backend."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_e8d6ef27","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":51},"in_reply_to":"3f4b6375_07625bd9","updated":"2017-10-30 07:23:06.000000000","message":"Yes, You said this way is also no problem, I tend to the above key1:value1, but no matter what way we need to reach a consensus, otherwise the change to change did not make much sense.","commit_id":"ac98a9924927b99ba27f0ceefc840ab92bc036f2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"735a63f0bf4280c5f24535a69c87878d54d25924","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specific implementation steps:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for queue\u0027s metadata."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":73,"context_line":"  900 secodes (15 mins). It will be storage in the backend."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_07625bd9","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":51},"in_reply_to":"3f4b6375_2caaded1","updated":"2017-10-30 03:55:58.000000000","message":"what I think the queue in db should be:\n\nqueue:\n{\n    name:XX\n    count:XX\n    metadata:\n    {\n        ke1:value1, \n        reserved_metadata_key1:reserved_metadata_value1\n    }\n    delay:\n    {\n        is_delay:True/False\n        delay_ttl:XX\n    }\n}","commit_id":"ac98a9924927b99ba27f0ceefc840ab92bc036f2"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6c7bdfbc9a3355388480053a0a5bff828fc3e8eb","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specific implementation steps:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for queue\u0027s metadata."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":73,"context_line":"  900 secodes (15 mins). It will be storage in the backend."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_71d42dbe","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":51},"in_reply_to":"3f4b6375_91db294e","updated":"2017-10-30 02:14:29.000000000","message":"I prefer to use \"_message_delay_ttl\", by default, it\u0027s 0(or None?), means current queue is not a delayed queue, any other positive value means this is a delayed queue.","commit_id":"ac98a9924927b99ba27f0ceefc840ab92bc036f2"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"e21dea2723d30e7db386740ddee802473e56b63b","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Specific implementation steps:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for queue\u0027s metadata."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":73,"context_line":"  900 secodes (15 mins). It will be storage in the backend."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f4b6375_2caaded1","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":51},"in_reply_to":"3f4b6375_91db294e","updated":"2017-10-30 02:47:40.000000000","message":"In fact, I am more inclined to not a reserved attribute, just a common metadata attribute. Because not all queues will have this attribute. But this property must be an int type.","commit_id":"ac98a9924927b99ba27f0ceefc840ab92bc036f2"},{"author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"change_message_id":"7316f2855f3065d52484cfb77b63305c40281413","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"3. Message sent to normal queue"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"   A normal queue is a queue with the ``_default_message_delay_ttl`` value of 0."},{"line_number":66,"context_line":"   Whether the message is a normal message or a message with a ``delay_ttl``"},{"line_number":67,"context_line":"   attribute, it will not have a delay feature when it is sent to the normal queue."},{"line_number":68,"context_line":"   Zaqar does not perform conditional filtering on the ``delay_expires`` attribute"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f4b6375_ff2adf29","line":65,"updated":"2017-11-01 08:43:34.000000000","message":"value of 0 ?  may be value of None","commit_id":"8270cff1303cb264f939f1e3f7c63a9dd21ccf0d"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"337c40401c3459b3097adc2f97cb1daa5c3fb303","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"3. Message sent to normal queue"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"   A normal queue is a queue with the ``_default_message_delay_ttl`` value of 0."},{"line_number":66,"context_line":"   Whether the message is a normal message or a message with a ``delay_ttl``"},{"line_number":67,"context_line":"   attribute, it will not have a delay feature when it is sent to the normal queue."},{"line_number":68,"context_line":"   Zaqar does not perform conditional filtering on the ``delay_expires`` attribute"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f4b6375_37053bc3","line":65,"in_reply_to":"3f4b6375_ff2adf29","updated":"2017-11-01 10:50:49.000000000","message":"The design here is really 0, equal to 0 means that the delayed queues feature is turned off.","commit_id":"8270cff1303cb264f939f1e3f7c63a9dd21ccf0d"},{"author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"change_message_id":"7316f2855f3065d52484cfb77b63305c40281413","unresolved":false,"context_lines":[{"line_number":74,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for all queue\u0027s metadata."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":77,"context_line":"  900 secodes (15 mins), and the default value is 0. It will be storage in"},{"line_number":78,"context_line":"  the backend."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f4b6375_df21634f","line":77,"updated":"2017-11-01 08:43:34.000000000","message":"typo: seconds","commit_id":"8270cff1303cb264f939f1e3f7c63a9dd21ccf0d"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"337c40401c3459b3097adc2f97cb1daa5c3fb303","unresolved":false,"context_lines":[{"line_number":74,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for all queue\u0027s metadata."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":77,"context_line":"  900 secodes (15 mins), and the default value is 0. It will be storage in"},{"line_number":78,"context_line":"  the backend."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3f4b6375_770293b6","line":77,"in_reply_to":"3f4b6375_df21634f","updated":"2017-11-01 10:50:49.000000000","message":"Done","commit_id":"8270cff1303cb264f939f1e3f7c63a9dd21ccf0d"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"64a2078422d946c65b4547fa57f0611bb28d1b19","unresolved":false,"context_lines":[{"line_number":51,"context_line":"1. Normal message sent to delayed queue"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   If a normal message without ``delay_ttl`` attribute sent to a delayed queue,"},{"line_number":54,"context_line":"   then the message will be add the ``delay_expires`` attribute and turn to be a"},{"line_number":55,"context_line":"   delayed message."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"2. Delay message sent to delayed queue"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f4b6375_4e3b6ec7","line":54,"range":{"start_line":54,"start_character":28,"end_line":54,"end_character":62},"updated":"2017-11-02 02:14:54.000000000","message":"here I think you should mention that the message will use the queue\u0027s default delay ttl.","commit_id":"d9f2b79f69e28eeb20210ff6cfdab2746ee621f4"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"5a8542c5d5e1f91812538bec5e83d7fa4c537b39","unresolved":false,"context_lines":[{"line_number":51,"context_line":"1. Normal message sent to delayed queue"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   If a normal message without ``delay_ttl`` attribute sent to a delayed queue,"},{"line_number":54,"context_line":"   then the message will be add the ``delay_expires`` attribute and turn to be a"},{"line_number":55,"context_line":"   delayed message."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"2. Delay message sent to delayed queue"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f4b6375_b4059012","line":54,"range":{"start_line":54,"start_character":28,"end_line":54,"end_character":62},"in_reply_to":"3f4b6375_4e3b6ec7","updated":"2017-11-02 02:59:36.000000000","message":"Done","commit_id":"d9f2b79f69e28eeb20210ff6cfdab2746ee621f4"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"64a2078422d946c65b4547fa57f0611bb28d1b19","unresolved":false,"context_lines":[{"line_number":74,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for all queue\u0027s metadata."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":77,"context_line":"  900 seconds (15 mins), and the default value is 0. It will be storage in"},{"line_number":78,"context_line":"  the backend."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f4b6375_8e2a8629","line":77,"range":{"start_line":77,"start_character":1,"end_line":77,"end_character":5},"updated":"2017-11-02 02:14:54.000000000","message":"So _max_message_delay_ttl should be added as well.","commit_id":"d9f2b79f69e28eeb20210ff6cfdab2746ee621f4"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"5a8542c5d5e1f91812538bec5e83d7fa4c537b39","unresolved":false,"context_lines":[{"line_number":74,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for all queue\u0027s metadata."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  The value of the ``_default_message_delay_ttl`` metadata ranges from 0 to"},{"line_number":77,"context_line":"  900 seconds (15 mins), and the default value is 0. It will be storage in"},{"line_number":78,"context_line":"  the backend."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f4b6375_940a941d","line":77,"range":{"start_line":77,"start_character":1,"end_line":77,"end_character":5},"in_reply_to":"3f4b6375_8e2a8629","updated":"2017-11-02 02:59:36.000000000","message":"Done","commit_id":"d9f2b79f69e28eeb20210ff6cfdab2746ee621f4"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0d2b7b4834db667a12ca3f600a8848fff791cb18","unresolved":false,"context_lines":[{"line_number":125,"context_line":"----------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Target Milestone for completion:"},{"line_number":128,"context_line":"  Queens-Q1"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Work Items"},{"line_number":131,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f4b6375_6ea2aa9c","line":128,"updated":"2017-11-02 02:18:18.000000000","message":"Should we target it to Q-2 or Q-3?","commit_id":"d9f2b79f69e28eeb20210ff6cfdab2746ee621f4"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"5a8542c5d5e1f91812538bec5e83d7fa4c537b39","unresolved":false,"context_lines":[{"line_number":125,"context_line":"----------"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"Target Milestone for completion:"},{"line_number":128,"context_line":"  Queens-Q1"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"Work Items"},{"line_number":131,"context_line":"----------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"3f4b6375_7413985d","line":128,"in_reply_to":"3f4b6375_6ea2aa9c","updated":"2017-11-02 02:59:36.000000000","message":"Done","commit_id":"d9f2b79f69e28eeb20210ff6cfdab2746ee621f4"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"64702d96b8674f722d73af9cf0632d10b8d80d50","unresolved":false,"context_lines":[{"line_number":40,"context_line":"must wait for a delay ttl. The delay ttl can be set or update as a metadata"},{"line_number":41,"context_line":"when the queue is created."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Then, when user get or claim messages, Zaqar will take ``delay_expires``"},{"line_number":44,"context_line":"as a query condition, which is as below:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":" Delay_expires \u003d Message Create + Delay TTL"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_2803baba","line":43,"range":{"start_line":43,"start_character":57,"end_line":43,"end_character":70},"updated":"2017-11-13 22:10:55.000000000","message":"I could miss something, but based on understanding, \"delay_expires\" is a field of message, that\u0027s the \u0027d\u0027 in your mongoDB patch, right? If so, it\u0027s not same as \"_default_message_delay_ttl\" and \"delay_ttl\", which may confuse reviewers.","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"64702d96b8674f722d73af9cf0632d10b8d80d50","unresolved":false,"context_lines":[{"line_number":40,"context_line":"must wait for a delay ttl. The delay ttl can be set or update as a metadata"},{"line_number":41,"context_line":"when the queue is created."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Then, when user get or claim messages, Zaqar will take ``delay_expires``"},{"line_number":44,"context_line":"as a query condition, which is as below:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":" Delay_expires \u003d Message Create + Delay TTL"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_48d8367e","line":43,"updated":"2017-11-13 22:10:55.000000000","message":"should we explicitly say \"when user get or claim messages on a delayed queue\"?","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"25112c1168e6226a26177c95f2f75c10a3426b91","unresolved":false,"context_lines":[{"line_number":40,"context_line":"must wait for a delay ttl. The delay ttl can be set or update as a metadata"},{"line_number":41,"context_line":"when the queue is created."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Then, when user get or claim messages, Zaqar will take ``delay_expires``"},{"line_number":44,"context_line":"as a query condition, which is as below:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":" Delay_expires \u003d Message Create + Delay TTL"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_bdf3659e","line":43,"range":{"start_line":43,"start_character":57,"end_line":43,"end_character":70},"in_reply_to":"1f485f77_2803baba","updated":"2017-11-14 02:10:59.000000000","message":"yes, there is really confusion here. I will change it right away.","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"25112c1168e6226a26177c95f2f75c10a3426b91","unresolved":false,"context_lines":[{"line_number":40,"context_line":"must wait for a delay ttl. The delay ttl can be set or update as a metadata"},{"line_number":41,"context_line":"when the queue is created."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Then, when user get or claim messages, Zaqar will take ``delay_expires``"},{"line_number":44,"context_line":"as a query condition, which is as below:"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":" Delay_expires \u003d Message Create + Delay TTL"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_9dee69b2","line":43,"in_reply_to":"1f485f77_48d8367e","updated":"2017-11-14 02:10:59.000000000","message":"Done","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"64702d96b8674f722d73af9cf0632d10b8d80d50","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"1. Normal message sent to delayed queue"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   If a normal message without ``delay_ttl`` attribute sent to a delayed queue,"},{"line_number":54,"context_line":"   then the message will use the queue\u0027s default delay ttl, and add the"},{"line_number":55,"context_line":"   ``delay_expires`` attribute turn to be a delayed message."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_089a3e6d","line":53,"range":{"start_line":53,"start_character":33,"end_line":53,"end_character":42},"updated":"2017-11-13 22:10:55.000000000","message":"I\u0027d like to get comments from a native English speaker about this, because it\u0027s a new attribute for message body and it could be hard to migrate in the future if it\u0027s not proper. Generally, TTL means Time To Live. But for this attribute, actually, we\u0027re talking about the delay seconds which is not a time to live, but visible.","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"25112c1168e6226a26177c95f2f75c10a3426b91","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"1. Normal message sent to delayed queue"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   If a normal message without ``delay_ttl`` attribute sent to a delayed queue,"},{"line_number":54,"context_line":"   then the message will use the queue\u0027s default delay ttl, and add the"},{"line_number":55,"context_line":"   ``delay_expires`` attribute turn to be a delayed message."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_1d5f1973","line":53,"range":{"start_line":53,"start_character":33,"end_line":53,"end_character":42},"in_reply_to":"1f485f77_089a3e6d","updated":"2017-11-14 02:10:59.000000000","message":"Yes, from this perspective, it is not accurate enough. I think here changed `delay_time` will be better. right?","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"83af99b00b72adef5b085eb4f7bc9de8f0ad4fd1","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"1. Normal message sent to delayed queue"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"   If a normal message without ``delay_ttl`` attribute sent to a delayed queue,"},{"line_number":54,"context_line":"   then the message will use the queue\u0027s default delay ttl, and add the"},{"line_number":55,"context_line":"   ``delay_expires`` attribute turn to be a delayed message."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_6e1cfe11","line":53,"range":{"start_line":53,"start_character":33,"end_line":53,"end_character":42},"in_reply_to":"1f485f77_1d5f1973","updated":"2017-11-14 20:44:13.000000000","message":"ok, just use \u0027delay_seconds\u0027 like SQS, or just \"delay\"","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"64702d96b8674f722d73af9cf0632d10b8d80d50","unresolved":false,"context_lines":[{"line_number":54,"context_line":"   then the message will use the queue\u0027s default delay ttl, and add the"},{"line_number":55,"context_line":"   ``delay_expires`` attribute turn to be a delayed message."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"2. Delay message sent to delayed queue"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"   If message with ``delay_ttl`` attribute sent to a delayed queue, then Zaqar will"},{"line_number":60,"context_line":"   use the message\u0027s delay seconds value instead of the delayed queue\u0027s delay"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_88386e3d","line":57,"updated":"2017-11-13 22:10:55.000000000","message":"Could we reword it as \"Message with attribute `delay_ttl` sent to a delayed queue\"?","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"25112c1168e6226a26177c95f2f75c10a3426b91","unresolved":false,"context_lines":[{"line_number":54,"context_line":"   then the message will use the queue\u0027s default delay ttl, and add the"},{"line_number":55,"context_line":"   ``delay_expires`` attribute turn to be a delayed message."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"2. Delay message sent to delayed queue"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"   If message with ``delay_ttl`` attribute sent to a delayed queue, then Zaqar will"},{"line_number":60,"context_line":"   use the message\u0027s delay seconds value instead of the delayed queue\u0027s delay"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_3dd1b5ce","line":57,"in_reply_to":"1f485f77_88386e3d","updated":"2017-11-14 02:10:59.000000000","message":"Done","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"64702d96b8674f722d73af9cf0632d10b8d80d50","unresolved":false,"context_lines":[{"line_number":74,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for all queue\u0027s metadata."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  The attribute ``_default_message_delay_ttl`` default value is 0 means it is"},{"line_number":77,"context_line":"  a normal queue, and it will be storage in the backend. Its ranges from 0 to"},{"line_number":78,"context_line":"  ``max_message_delay_ttl`` seconds, the ``max_message_delay_ttl`` is configurable"},{"line_number":79,"context_line":"  and the default value is 900 (15 mins)."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_68cc126a","line":77,"range":{"start_line":77,"start_character":18,"end_line":77,"end_character":55},"updated":"2017-11-13 22:10:55.000000000","message":"It\u0027s not necessary to mention this.","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"25112c1168e6226a26177c95f2f75c10a3426b91","unresolved":false,"context_lines":[{"line_number":74,"context_line":"1. Add a new attribute ``_default_message_delay_ttl`` for all queue\u0027s metadata."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  The attribute ``_default_message_delay_ttl`` default value is 0 means it is"},{"line_number":77,"context_line":"  a normal queue, and it will be storage in the backend. Its ranges from 0 to"},{"line_number":78,"context_line":"  ``max_message_delay_ttl`` seconds, the ``max_message_delay_ttl`` is configurable"},{"line_number":79,"context_line":"  and the default value is 900 (15 mins)."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_fddafde6","line":77,"range":{"start_line":77,"start_character":18,"end_line":77,"end_character":55},"in_reply_to":"1f485f77_68cc126a","updated":"2017-11-14 02:10:59.000000000","message":"Done","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"64702d96b8674f722d73af9cf0632d10b8d80d50","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  The attribute ``_default_message_delay_ttl`` default value is 0 means it is"},{"line_number":77,"context_line":"  a normal queue, and it will be storage in the backend. Its ranges from 0 to"},{"line_number":78,"context_line":"  ``max_message_delay_ttl`` seconds, the ``max_message_delay_ttl`` is configurable"},{"line_number":79,"context_line":"  and the default value is 900 (15 mins)."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_4879562d","line":79,"range":{"start_line":79,"start_character":30,"end_line":79,"end_character":31},"updated":"2017-11-13 22:10:55.000000000","message":"seconds","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"25112c1168e6226a26177c95f2f75c10a3426b91","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  The attribute ``_default_message_delay_ttl`` default value is 0 means it is"},{"line_number":77,"context_line":"  a normal queue, and it will be storage in the backend. Its ranges from 0 to"},{"line_number":78,"context_line":"  ``max_message_delay_ttl`` seconds, the ``max_message_delay_ttl`` is configurable"},{"line_number":79,"context_line":"  and the default value is 900 (15 mins)."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_7df04d68","line":79,"range":{"start_line":79,"start_character":30,"end_line":79,"end_character":31},"in_reply_to":"1f485f77_4879562d","updated":"2017-11-14 02:10:59.000000000","message":"Done","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"64702d96b8674f722d73af9cf0632d10b8d80d50","unresolved":false,"context_lines":[{"line_number":81,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  When post messages to queue, user can add ``delay_ttl`` like ``ttl``."},{"line_number":84,"context_line":"  The message\u0027s ``delay_ttl`` has a higher priority."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"3. Add a new message attribute ``delay_expires``."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_c8e0a6cf","line":84,"updated":"2017-11-13 22:10:55.000000000","message":"What do you mean higher priority here? what happened if ttl \u003c delay_ttl?","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"83af99b00b72adef5b085eb4f7bc9de8f0ad4fd1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  When post messages to queue, user can add ``delay_ttl`` like ``ttl``."},{"line_number":84,"context_line":"  The message\u0027s ``delay_ttl`` has a higher priority."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"3. Add a new message attribute ``delay_expires``."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_8ee29a00","line":84,"in_reply_to":"1f485f77_3db89574","updated":"2017-11-14 20:44:13.000000000","message":"do you mean \"the _message_ will be deleted\"?","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"14b76cd35c991a7f19c93f7af95d11806961a545","unresolved":false,"context_lines":[{"line_number":81,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  When post messages to queue, user can add ``delay_ttl`` like ``ttl``."},{"line_number":84,"context_line":"  The message\u0027s ``delay_ttl`` has a higher priority."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"3. Add a new message attribute ``delay_expires``."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_79f13d95","line":84,"in_reply_to":"1f485f77_8ad03821","updated":"2017-11-16 01:37:58.000000000","message":"Good.","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"efd84d786fc002bb5f41d020b9397a5d98b4e57b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  When post messages to queue, user can add ``delay_ttl`` like ``ttl``."},{"line_number":84,"context_line":"  The message\u0027s ``delay_ttl`` has a higher priority."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"3. Add a new message attribute ``delay_expires``."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_8ad03821","line":84,"in_reply_to":"1f485f77_8ee29a00","updated":"2017-11-15 07:06:05.000000000","message":"If ttl\u003cdelay_ttl means the message is in a delay period and the message\u0027s ttl has expired, so the message will be deleted by backend.","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"25112c1168e6226a26177c95f2f75c10a3426b91","unresolved":false,"context_lines":[{"line_number":81,"context_line":"2. Add a new attribute just for message\u0027s request body: ``delay_ttl``."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  When post messages to queue, user can add ``delay_ttl`` like ``ttl``."},{"line_number":84,"context_line":"  The message\u0027s ``delay_ttl`` has a higher priority."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"3. Add a new message attribute ``delay_expires``."},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f485f77_3db89574","line":84,"in_reply_to":"1f485f77_c8e0a6cf","updated":"2017-11-14 02:10:59.000000000","message":"The expression here may not be accurate enough. The meaning here is that messages delay time have a higher priority than queues. When ttl \u003cdelay_ttl, the message will never be claimed, the delay will be deleted because of expiration.","commit_id":"ada6d1ad1883cca0e6a4f6c0d180967db58fa7e7"}]}
