)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"21413117d3b2dcff3ef85ba874d0df84b663e21f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Expose \u0027ssl\u0027,\u0027ssl_keyfile\u0027,\u0027ssl_certfile\u0027,\u0027ssl_cert_reqs\u0027 and \u0027ssl_ca_certs\u0027 options"},{"line_number":10,"context_line":"for maximum security. By default, ssl is not enabled except that ssl parameter was"},{"line_number":11,"context_line":"included in the mongodb uri directly, and ssl_cert_reqs \u003d CERT_REQUIRED which means"},{"line_number":12,"context_line":"user must provide the \u0027ssl_ca_certs\u0027 if ssl is enabled either by setting ssl\u003dtrue explicitly"},{"line_number":13,"context_line":"or adding the ssl parameter in the mongodb uri"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I67cb5a9b2d76625de2932c854d0a696e9118ca6b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_cccf2db2","line":12,"updated":"2014-06-18 03:28:47.000000000","message":"Nit: Lines length in the commit messages should be \u003e\u003d 72 chars\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure","commit_id":"5027e33b5853b9dbd260d4e9e0eb55638984a7fe"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"30568dc31e9d5d01999d63e0bdd6a40bf6991c7f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Expose \u0027ssl\u0027,\u0027ssl_keyfile\u0027,\u0027ssl_certfile\u0027,\u0027ssl_cert_reqs\u0027 and \u0027ssl_ca_certs\u0027 options"},{"line_number":10,"context_line":"for maximum security. By default, ssl is not enabled except that ssl parameter was"},{"line_number":11,"context_line":"included in the mongodb uri directly, and ssl_cert_reqs \u003d CERT_REQUIRED which means"},{"line_number":12,"context_line":"user must provide the \u0027ssl_ca_certs\u0027 if ssl is enabled either by setting ssl\u003dtrue explicitly"},{"line_number":13,"context_line":"or adding the ssl parameter in the mongodb uri"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I67cb5a9b2d76625de2932c854d0a696e9118ca6b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_fd401109","line":12,"in_reply_to":"1ae5cdf2_cccf2db2","updated":"2014-06-18 07:53:38.000000000","message":"Done","commit_id":"5027e33b5853b9dbd260d4e9e0eb55638984a7fe"}],"etc/marconi.conf.sample":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5a7bde273ba72b9d0245064f270db36c80668ea8","unresolved":false,"context_lines":[{"line_number":149,"context_line":"# Mongodb Connection URI. (string value)"},{"line_number":150,"context_line":"#uri\u003d\u003cNone\u003e"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"# If true, create the connection to the server using SSL with "},{"line_number":153,"context_line":"# \u0027ssl_keyfile\u0027, \u0027ssl_certfile\u0027, \u0027ssl_cert_reqs\u0027, ssl_ca_certs\u0027 "},{"line_number":154,"context_line":"# accordingly. (boolean value)"},{"line_number":155,"context_line":"#ssl\u003dfalse"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_4c123d59","line":152,"updated":"2014-06-18 03:20:52.000000000","message":"Please remove those whitespaces. Thanks.","commit_id":"5027e33b5853b9dbd260d4e9e0eb55638984a7fe"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"21413117d3b2dcff3ef85ba874d0df84b663e21f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"# Mongodb Connection URI. (string value)"},{"line_number":150,"context_line":"#uri\u003d\u003cNone\u003e"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"# If true, create the connection to the server using SSL with "},{"line_number":153,"context_line":"# \u0027ssl_keyfile\u0027, \u0027ssl_certfile\u0027, \u0027ssl_cert_reqs\u0027, ssl_ca_certs\u0027 "},{"line_number":154,"context_line":"# accordingly. (boolean value)"},{"line_number":155,"context_line":"#ssl\u003dfalse"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_2ccdf1b7","line":152,"in_reply_to":"1ae5cdf2_4c123d59","updated":"2014-06-18 03:28:47.000000000","message":"+1","commit_id":"5027e33b5853b9dbd260d4e9e0eb55638984a7fe"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"30568dc31e9d5d01999d63e0bdd6a40bf6991c7f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"# Mongodb Connection URI. (string value)"},{"line_number":150,"context_line":"#uri\u003d\u003cNone\u003e"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"# If true, create the connection to the server using SSL with "},{"line_number":153,"context_line":"# \u0027ssl_keyfile\u0027, \u0027ssl_certfile\u0027, \u0027ssl_cert_reqs\u0027, ssl_ca_certs\u0027 "},{"line_number":154,"context_line":"# accordingly. (boolean value)"},{"line_number":155,"context_line":"#ssl\u003dfalse"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_fd34914b","line":152,"in_reply_to":"1ae5cdf2_4c123d59","updated":"2014-06-18 07:53:38.000000000","message":"Thanks","commit_id":"5027e33b5853b9dbd260d4e9e0eb55638984a7fe"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"30568dc31e9d5d01999d63e0bdd6a40bf6991c7f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"# Mongodb Connection URI. (string value)"},{"line_number":150,"context_line":"#uri\u003d\u003cNone\u003e"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"# If true, create the connection to the server using SSL with "},{"line_number":153,"context_line":"# \u0027ssl_keyfile\u0027, \u0027ssl_certfile\u0027, \u0027ssl_cert_reqs\u0027, ssl_ca_certs\u0027 "},{"line_number":154,"context_line":"# accordingly. (boolean value)"},{"line_number":155,"context_line":"#ssl\u003dfalse"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1ae5cdf2_98439bae","line":152,"in_reply_to":"1ae5cdf2_4c123d59","updated":"2014-06-18 07:53:38.000000000","message":"Thanks for the review, those had been removed in the following changeset","commit_id":"5027e33b5853b9dbd260d4e9e0eb55638984a7fe"}],"marconi/queues/storage/mongodb/driver.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c4e269cc2b919c4e3a2574e42eec0814cf2ba834","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from marconi.queues.storage.mongodb import controllers"},{"line_number":25,"context_line":"from marconi.queues.storage.mongodb import options"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import ssl"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_54ed52ef","line":27,"updated":"2014-06-18 13:00:47.000000000","message":"Hi,\n\nSince this is a built-in module, you can move it at the top-group of imports. The way imports are organized is:\n\n    built-in\n\n    third-party\n\n    application\n\nThis would look something like:\n\n    import ssl\n\n    import pymongo\n    ......","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"40127a861906a8ed899b9c50de709f134d8bd312","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from marconi.queues.storage.mongodb import controllers"},{"line_number":25,"context_line":"from marconi.queues.storage.mongodb import options"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import ssl"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_75a78cbc","line":27,"in_reply_to":"1ae5cdf2_54ed52ef","updated":"2014-06-19 03:00:47.000000000","message":"thanks for the guidence","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c4e269cc2b919c4e3a2574e42eec0814cf2ba834","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    else:"},{"line_number":36,"context_line":"        MongoClient \u003d pymongo.MongoClient"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if conf.ssl or \u0027ssl\u0027 in conf.uri:"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027ssl\u0027: True}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Default to CERT_REQUIRED"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_3479a62f","line":38,"updated":"2014-06-18 13:00:47.000000000","message":"We\u0027re encouraging deployers to use the `mongodb-uri`. What do you think about removing the `ssl` flag and just relying on the URI ?","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a58c113e04d33231970b966a75d885958ed3bc78","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    else:"},{"line_number":36,"context_line":"        MongoClient \u003d pymongo.MongoClient"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if conf.ssl or \u0027ssl\u0027 in conf.uri:"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027ssl\u0027: True}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Default to CERT_REQUIRED"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_2ec12ee4","line":38,"in_reply_to":"1ae5cdf2_156f2861","updated":"2014-06-19 07:58:10.000000000","message":"FWIW, the mongodb shell has the flag because ssl was added before the mongodb uri existed. I think it\u0027s better to encourage users to use the mongodb uri as much as possible.  Since we don\u0027t allow users to specify host and port separately, it doesn\u0027t make much sense to allow them to specify the ssl flag in a separate option. \n\nAs per the other `ssl_` options, I think it\u0027d be hard to specify the cert files in the mongodb uri. I mean, it\u0027d make it very long and unreadable. \n\nOne more thought, the fewer options we have to maintain in Marconi, the better. This is useful not just to keep the config file and documentation shorter and consistent but also for future upgrades and changes. The config file will keep growing as we add more things to the project.\n\nIt mind sound silly since it\u0027s just 1 option but I really don\u0027t think it brings any consistency. Instead, I think it\u0027s pulling into marconi inconsistencies from mongodb.","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"4dfc4f706796126fde7634f5a2c78fd3d653f85a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    else:"},{"line_number":36,"context_line":"        MongoClient \u003d pymongo.MongoClient"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if conf.ssl or \u0027ssl\u0027 in conf.uri:"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027ssl\u0027: True}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Default to CERT_REQUIRED"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_42048b14","line":38,"in_reply_to":"1ae5cdf2_2ec12ee4","updated":"2014-06-19 09:32:39.000000000","message":"Done","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"40127a861906a8ed899b9c50de709f134d8bd312","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    else:"},{"line_number":36,"context_line":"        MongoClient \u003d pymongo.MongoClient"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if conf.ssl or \u0027ssl\u0027 in conf.uri:"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027ssl\u0027: True}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Default to CERT_REQUIRED"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_156f2861","line":38,"in_reply_to":"1ae5cdf2_3479a62f","updated":"2014-06-19 03:00:47.000000000","message":"I tend to check both as Kurt Griffiths said","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"c78e42b38aac5f8b9a91dcec0db3b7091586780e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    else:"},{"line_number":36,"context_line":"        MongoClient \u003d pymongo.MongoClient"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    if conf.ssl or \u0027ssl\u0027 in conf.uri:"},{"line_number":39,"context_line":"        kwargs \u003d {\u0027ssl\u0027: True}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Default to CERT_REQUIRED"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_89afaee2","line":38,"in_reply_to":"1ae5cdf2_3479a62f","updated":"2014-06-18 20:57:03.000000000","message":"IMO: I find it a bit inconsistent that you can specify it in the URI or the config, but the other ssl_* options can only be specified in the config. This is a leaky abstraction based on [1].\n\nBecause of this, it is hard to say where the system administrator is going to want to put that SSL setting. Indeed, the docs [2] show explicitly passing the --ssl flag to the mongo shell.\n\nTherefore, I think it may actually be a good thing to check both places for the setting.\n\n[1]: http://docs.mongodb.org/manual/reference/connection-string/\n\n[2]: http://docs.mongodb.org/manual/tutorial/configure-x509/#authenticate-with-a-x-509-certificate","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c4e269cc2b919c4e3a2574e42eec0814cf2ba834","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        kwargs[\u0027ssl_cert_reqs\u0027] \u003d ssl_cert_reqs"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if conf.ssl_keyfile:"},{"line_number":53,"context_line":"            kwargs[\u0027ssl_keyfile\u0027] \u003d conf.ssl_keyfile"},{"line_number":54,"context_line":"        if conf.ssl_certfile:"},{"line_number":55,"context_line":"            kwargs[\u0027ssl_certfile\u0027] \u003d conf.ssl_certfile"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_34f52683","line":52,"updated":"2014-06-18 13:00:47.000000000","message":"We should also verify that the file exists and is readable.","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"c78e42b38aac5f8b9a91dcec0db3b7091586780e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        kwargs[\u0027ssl_cert_reqs\u0027] \u003d ssl_cert_reqs"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if conf.ssl_keyfile:"},{"line_number":53,"context_line":"            kwargs[\u0027ssl_keyfile\u0027] \u003d conf.ssl_keyfile"},{"line_number":54,"context_line":"        if conf.ssl_certfile:"},{"line_number":55,"context_line":"            kwargs[\u0027ssl_certfile\u0027] \u003d conf.ssl_certfile"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_e9e03228","line":52,"in_reply_to":"1ae5cdf2_34f52683","updated":"2014-06-18 20:57:03.000000000","message":"Does MongoClient do this check for us? If so, we just need to trap the error it raises and convert it to something friendly for the user.","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a58c113e04d33231970b966a75d885958ed3bc78","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        kwargs[\u0027ssl_cert_reqs\u0027] \u003d ssl_cert_reqs"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if conf.ssl_keyfile:"},{"line_number":53,"context_line":"            kwargs[\u0027ssl_keyfile\u0027] \u003d conf.ssl_keyfile"},{"line_number":54,"context_line":"        if conf.ssl_certfile:"},{"line_number":55,"context_line":"            kwargs[\u0027ssl_certfile\u0027] \u003d conf.ssl_certfile"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_eea2e63d","line":52,"in_reply_to":"1ae5cdf2_354a6483","updated":"2014-06-19 07:58:10.000000000","message":"The message sounds pretty clear, although a more friendly message for the user may be useful as well, hence the checks I mentioned above. I\u0027m fine either way :)","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"40127a861906a8ed899b9c50de709f134d8bd312","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        kwargs[\u0027ssl_cert_reqs\u0027] \u003d ssl_cert_reqs"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if conf.ssl_keyfile:"},{"line_number":53,"context_line":"            kwargs[\u0027ssl_keyfile\u0027] \u003d conf.ssl_keyfile"},{"line_number":54,"context_line":"        if conf.ssl_certfile:"},{"line_number":55,"context_line":"            kwargs[\u0027ssl_certfile\u0027] \u003d conf.ssl_certfile"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_354a6483","line":52,"in_reply_to":"1ae5cdf2_e9e03228","updated":"2014-06-19 03:00:47.000000000","message":"All can be deferred to the MongoClient.\n\nmy manually test cases as below\n\n1. change the file permission that the user who execute the marconi-server can\u0027t read it,  IOException thrown as below\n\nIOError: [Errno 13] Permission denied: \u0027/home/norman/ssl_cert/client/client.pem\u0027\n\n2. the key file does not exist in the files system\n\nIOError: [Errno 2] No such file or directory: \u0027/home/norman/ssl_cert/client/client.pem\u0027 \n\nand in both cases, the marconi-server will not be started.\n\nso do we still need to trap the error? I thought it\u0027s already clear enough","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"4dfc4f706796126fde7634f5a2c78fd3d653f85a","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        kwargs[\u0027ssl_cert_reqs\u0027] \u003d ssl_cert_reqs"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if conf.ssl_keyfile:"},{"line_number":53,"context_line":"            kwargs[\u0027ssl_keyfile\u0027] \u003d conf.ssl_keyfile"},{"line_number":54,"context_line":"        if conf.ssl_certfile:"},{"line_number":55,"context_line":"            kwargs[\u0027ssl_certfile\u0027] \u003d conf.ssl_certfile"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_e2183778","line":52,"in_reply_to":"1ae5cdf2_eea2e63d","updated":"2014-06-19 09:32:39.000000000","message":"Ok, thanks, I will keep it as it is","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"}],"marconi/queues/storage/mongodb/options.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"c78e42b38aac5f8b9a91dcec0db3b7091586780e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"MONGODB_OPTIONS \u003d ("},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027ssl\u0027, default\u003dFalse,"},{"line_number":23,"context_line":"                help\u003d(\u0027If ``True``, create the connection to the server \u0027"},{"line_number":24,"context_line":"                      \u0027using SSL with ``ssl_keyfile``,``ssl_certfile``, \u0027"},{"line_number":25,"context_line":"                      \u0027``ssl_cert_reqs``,`ssl_ca_certs`` accordingly\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_e9b7521f","line":22,"updated":"2014-06-18 20:57:03.000000000","message":"NIT: Maybe mention that this value may alternatively be set as a query parameter in the connection URI.","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"40127a861906a8ed899b9c50de709f134d8bd312","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"MONGODB_OPTIONS \u003d ("},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    cfg.BoolOpt(\u0027ssl\u0027, default\u003dFalse,"},{"line_number":23,"context_line":"                help\u003d(\u0027If ``True``, create the connection to the server \u0027"},{"line_number":24,"context_line":"                      \u0027using SSL with ``ssl_keyfile``,``ssl_certfile``, \u0027"},{"line_number":25,"context_line":"                      \u0027``ssl_cert_reqs``,`ssl_ca_certs`` accordingly\u0027)),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_35ba64e1","line":22,"in_reply_to":"1ae5cdf2_e9b7521f","updated":"2014-06-19 03:00:47.000000000","message":"Yes, and we don\u0027t know which use prefer to use , so in the code when create the connection , I will use the conf.ssl or  \u0027ssl\u0027 in conf.url\n\nis that Ok?","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"}],"requirements-py3.txt":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c4e269cc2b919c4e3a2574e42eec0814cf2ba834","unresolved":false,"context_lines":[{"line_number":7,"context_line":"iso8601\u003e\u003d0.1.9"},{"line_number":8,"context_line":"msgpack-python"},{"line_number":9,"context_line":"posix_ipc"},{"line_number":10,"context_line":"pymongo\u003e\u003d2.5"},{"line_number":11,"context_line":"python-keystoneclient\u003e\u003d0.9.0"},{"line_number":12,"context_line":"# python-memcached has no Py3k support for now"},{"line_number":13,"context_line":"# python-memcached\u003e\u003d1.48"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_b4ccd636","line":10,"updated":"2014-06-18 13:00:47.000000000","message":"We can\u0027t update the requirements directly. We need to first update them in the global requirements repo and then sync them back. Here\u0027s the repo where this should be done: https://github.com/openstack/requirements","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"40127a861906a8ed899b9c50de709f134d8bd312","unresolved":false,"context_lines":[{"line_number":7,"context_line":"iso8601\u003e\u003d0.1.9"},{"line_number":8,"context_line":"msgpack-python"},{"line_number":9,"context_line":"posix_ipc"},{"line_number":10,"context_line":"pymongo\u003e\u003d2.5"},{"line_number":11,"context_line":"python-keystoneclient\u003e\u003d0.9.0"},{"line_number":12,"context_line":"# python-memcached has no Py3k support for now"},{"line_number":13,"context_line":"# python-memcached\u003e\u003d1.48"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_58bba5c3","line":10,"in_reply_to":"1ae5cdf2_4955a6c0","updated":"2014-06-19 03:00:47.000000000","message":"Done","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"c78e42b38aac5f8b9a91dcec0db3b7091586780e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"iso8601\u003e\u003d0.1.9"},{"line_number":8,"context_line":"msgpack-python"},{"line_number":9,"context_line":"posix_ipc"},{"line_number":10,"context_line":"pymongo\u003e\u003d2.5"},{"line_number":11,"context_line":"python-keystoneclient\u003e\u003d0.9.0"},{"line_number":12,"context_line":"# python-memcached has no Py3k support for now"},{"line_number":13,"context_line":"# python-memcached\u003e\u003d1.48"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_4955a6c0","line":10,"in_reply_to":"1ae5cdf2_b4ccd636","updated":"2014-06-18 20:57:03.000000000","message":"FYI: There is a patch for that I will merge shortly. Once that is done, you can rebase and you\u0027ll be all set.","commit_id":"6fac73529a6e077bc15c901e1a6c61491b77ca33"}]}