)]}'
{"marconi/tests/queues/storage/base.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"a02cab9ed16dc955c90f1e2f0f055a58037eb202","unresolved":false,"context_lines":[{"line_number":750,"context_line":"            self.pools_controller.create(n, w, str(i), {})"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        # Get the target pool"},{"line_number":753,"context_line":"        def _pool(pools, name):"},{"line_number":754,"context_line":"            pool \u003d [p for p in pools if p[\u0027n\u0027] \u003d\u003d name]"},{"line_number":755,"context_line":"            self.assertEqual(len(pool), 1)"},{"line_number":756,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_ec7e006a","line":753,"updated":"2014-06-23 17:42:36.000000000","message":"DRY: Since the variable \"pool\", from L739, is in scope when the method is defined, you could just reference the variable directly rather than requiring it to be passed in at L767 and L784.","commit_id":"8267f9926b786d4cf4ab18d4559467c4250b8a56"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"3ed266778dc4a5dad109244a807af45bb2bdc7e7","unresolved":false,"context_lines":[{"line_number":750,"context_line":"            self.pools_controller.create(n, w, str(i), {})"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        # Get the target pool"},{"line_number":753,"context_line":"        def _pool(pools, name):"},{"line_number":754,"context_line":"            pool \u003d [p for p in pools if p[\u0027n\u0027] \u003d\u003d name]"},{"line_number":755,"context_line":"            self.assertEqual(len(pool), 1)"},{"line_number":756,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_1effc036","line":753,"in_reply_to":"1ae5cdf2_ec7e006a","updated":"2014-06-24 02:54:06.000000000","message":"Done","commit_id":"8267f9926b786d4cf4ab18d4559467c4250b8a56"},{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"8bcb4762fc5dd232e521e68b3fed6165c48270e8","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"        res \u003d list(self.pools_controller.list())"},{"line_number":765,"context_line":"        self.assertEqual(len(res), 10)"},{"line_number":766,"context_line":"        for _, entry in enumerate(res):"},{"line_number":767,"context_line":"            n, w, u \u003d _pool(entry[\u0027name\u0027])"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"            self._pool_expects(entry, n, w, u)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_cd768ca3","line":766,"updated":"2014-06-24 06:40:16.000000000","message":"why don\u0027t replace this with just\n\nfor entry in res:\n\nsince we don\u0027t use the enumeration index? :)","commit_id":"dd37a830cd983b67b26389845bf47a7ad78fe1b6"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"58164c58147e989ac7e8ca249c5995faca943cda","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"        res \u003d list(self.pools_controller.list())"},{"line_number":765,"context_line":"        self.assertEqual(len(res), 10)"},{"line_number":766,"context_line":"        for _, entry in enumerate(res):"},{"line_number":767,"context_line":"            n, w, u \u003d _pool(entry[\u0027name\u0027])"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"            self._pool_expects(entry, n, w, u)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ed0c28ef","line":766,"in_reply_to":"1ae5cdf2_cd768ca3","updated":"2014-06-24 06:47:59.000000000","message":"ah, yes","commit_id":"dd37a830cd983b67b26389845bf47a7ad78fe1b6"},{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"8bcb4762fc5dd232e521e68b3fed6165c48270e8","unresolved":false,"context_lines":[{"line_number":780,"context_line":""},{"line_number":781,"context_line":"        res \u003d list(self.pools_controller.list(detailed\u003dTrue))"},{"line_number":782,"context_line":"        self.assertEqual(len(res), 10)"},{"line_number":783,"context_line":"        for _, entry in enumerate(res):"},{"line_number":784,"context_line":"            n, w, u \u003d _pool(entry[\u0027name\u0027])"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"            self._pool_expects(entry, n, w, u)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ad7f8068","line":783,"updated":"2014-06-24 06:40:16.000000000","message":"same here.","commit_id":"dd37a830cd983b67b26389845bf47a7ad78fe1b6"}]}
