)]}'
{"marconi/queues/storage/mongodb/driver.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"e0e17b08de73403543d3232966793b501cb2325d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            kwargs[\u0027ssl_ca_certs\u0027] \u003d conf.ssl_ca_certs"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return MongoClient(conf.uri, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    return MongoClient(conf.uri)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab895d6_8249e08d","line":61,"updated":"2014-06-29 04:52:03.000000000","message":"Q: Will MongoClient check the conf.uri? If yes, is it necessary to check it at line 39? If not, should we do something at here as well? Thanks.","commit_id":"c5106bc26b824d9a8755fa88156f1de946dad878"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"9bdb9a7d43c92c30e621e8b35fd105652b81686b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            kwargs[\u0027ssl_ca_certs\u0027] \u003d conf.ssl_ca_certs"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return MongoClient(conf.uri, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    return MongoClient(conf.uri)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab895d6_332ce84a","line":61,"in_reply_to":"dab895d6_13bb640f","updated":"2014-06-29 11:56:05.000000000","message":"confirmed from the source of the MongoClient,  if we did not provide the uri, then it will use the \u0027localhost\u0027 , it will work with conf.uri \u003d None.","commit_id":"c5106bc26b824d9a8755fa88156f1de946dad878"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7151b4fdb6d72211e1a270868587849dc5ae68b6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            kwargs[\u0027ssl_ca_certs\u0027] \u003d conf.ssl_ca_certs"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return MongoClient(conf.uri, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    return MongoClient(conf.uri)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_04587355","line":61,"in_reply_to":"dab895d6_332ce84a","updated":"2014-06-30 21:41:59.000000000","message":"Got, thanks for the clarification.","commit_id":"c5106bc26b824d9a8755fa88156f1de946dad878"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"85b09a83ba73ea9b565c260cff7054f81fab4c94","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            kwargs[\u0027ssl_ca_certs\u0027] \u003d conf.ssl_ca_certs"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        return MongoClient(conf.uri, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    return MongoClient(conf.uri)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab895d6_13bb640f","line":61,"in_reply_to":"dab895d6_8249e08d","updated":"2014-06-29 11:33:25.000000000","message":"I have not dive into the MongoClient code(I believe it will raise exception if url is None), anyway whether it check or not, we need this fix  since that\n\n1. the origin code also does the check at L34\n\n2. the truth is that we will call the lower() method with the uri since \u0027SSL\u003dtrue\u0027 also works for MongoClient , we need to make sure it\u0027s not None.","commit_id":"c5106bc26b824d9a8755fa88156f1de946dad878"}]}
