)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7916dc64dcf309e019c279186c1898927cdc1cfe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave Thomas \u003copensource@peoplemerge.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-14 23:16:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Sending this test in for review, please help clarify the scope of the blueprint.  There are many references to json, please help to isolate just those that need an update per this requirement."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If10752c7c7dd106d655e032d2b2abea685768520"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_cec16ae5","line":7,"updated":"2014-07-14 23:28:18.000000000","message":"Please follow up the recommended format of commit message, see https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"c11cf2984d97a966dff8048a49e9f94bfe4509bb"}],"marconi/queues/transport/wsgi/v1_1/messages.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e82ca822b98e87ce3f23253cc588a97b33240627","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(six.text_type(ex))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Pull out just the fields we care about"},{"line_number":153,"context_line":"        # TODO look for msgpack here?"},{"line_number":154,"context_line":"        messages \u003d wsgi_utils.filter_stream("},{"line_number":155,"context_line":"            req.stream,"},{"line_number":156,"context_line":"            req.content_length,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e4684e8a","line":153,"updated":"2014-07-11 21:45:19.000000000","message":"IMO: The msgpack deserialization will need to happen inside wsgi_utils.filter_stream","commit_id":"53ef4b9ed3524ffb6b8cef9172adc47f2e65d3fb"},{"author":{"_account_id":10181,"name":"Dave Thomas","email":"opensource@peoplemerge.com","username":"peoplemerge"},"change_message_id":"ad14144f600c834fcfb5aa52080cc2d891244b29","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(six.text_type(ex))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Pull out just the fields we care about"},{"line_number":153,"context_line":"        # TODO look for msgpack here?"},{"line_number":154,"context_line":"        messages \u003d wsgi_utils.filter_stream("},{"line_number":155,"context_line":"            req.stream,"},{"line_number":156,"context_line":"            req.content_length,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b30be122","line":153,"in_reply_to":"baada198_e4684e8a","updated":"2014-07-14 20:39:44.000000000","message":"Thanks I\u0027ll start there.","commit_id":"53ef4b9ed3524ffb6b8cef9172adc47f2e65d3fb"},{"author":{"_account_id":10181,"name":"Dave Thomas","email":"opensource@peoplemerge.com","username":"peoplemerge"},"change_message_id":"0ee9382e43d2d6075874fbfe161d7a9cc150aa8e","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(six.text_type(ex))"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        # Pull out just the fields we care about"},{"line_number":153,"context_line":"        # TODO look for msgpack here?"},{"line_number":154,"context_line":"        messages \u003d wsgi_utils.filter_stream("},{"line_number":155,"context_line":"            req.stream,"},{"line_number":156,"context_line":"            req.content_length,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_eccb9750","line":153,"updated":"2014-07-15 00:00:09.000000000","message":"from kgriffs\u0027 earlier comment: the deserialization will need to occur within the wsgi_utils.filter_stream","commit_id":"3a04e3062a2b1e6ef7aef34007f87e33c1e54520"}],"marconi/tests/functional/helpers.py":[{"author":{"_account_id":10181,"name":"Dave Thomas","email":"opensource@peoplemerge.com","username":"peoplemerge"},"change_message_id":"dc4de9da83f41b9a750bf3dd8e21c33333913229","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    headers \u003d {"},{"line_number":47,"context_line":"        \"User-Agent\": conf.headers.user_agent,"},{"line_number":48,"context_line":"        \"Accept\": \"application/json\","},{"line_number":49,"context_line":" #       \"Accept\": \"application/x-msgpack\","},{"line_number":50,"context_line":"        \"X-Project-ID\": conf.headers.project_id,"},{"line_number":51,"context_line":"        \"Client-ID\": str(uuid.uuid1()),"},{"line_number":52,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_4db8a8e5","line":49,"updated":"2014-07-16 18:48:28.000000000","message":"TODO(peoplemerge) pep8 reports comment intent failure","commit_id":"045839820f5e94fb870f5c52b79967924a6a0dcd"}],"marconi/tests/queues/transport/wsgi/v1_1/test_messages.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e82ca822b98e87ce3f23253cc588a97b33240627","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _test_post(self, sample_messages, use_msgpack\u003dFalse):"},{"line_number":73,"context_line":"        if use_msgpack:"},{"line_number":74,"context_line":"            sample_doc \u003d msgpack.Packer().pack(sample_messages)"},{"line_number":75,"context_line":"            self.headers[\u0027Content-Type\u0027] \u003d \u0027application/x-msgpack\u0027"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            sample_doc \u003d jsonutils.dumps(sample_messages)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_64b35e9a","line":74,"updated":"2014-07-11 21:45:19.000000000","message":"BUG: Set \"use_bin_type\u003dTrue\" param when instantiating Packer. Otherwise, msgpack-python will normalize both Unicode and binary strings to the str format family, losing type information, so that when unpacking you won\u0027t be able to know whether to deserialize as a wide string or a byte string.\n\nPERF: Factor out the instantiation of the Packer and Unpacker objects so it only has to be done once, rather than each time _test_post is called.","commit_id":"53ef4b9ed3524ffb6b8cef9172adc47f2e65d3fb"},{"author":{"_account_id":10181,"name":"Dave Thomas","email":"opensource@peoplemerge.com","username":"peoplemerge"},"change_message_id":"ad14144f600c834fcfb5aa52080cc2d891244b29","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def _test_post(self, sample_messages, use_msgpack\u003dFalse):"},{"line_number":73,"context_line":"        if use_msgpack:"},{"line_number":74,"context_line":"            sample_doc \u003d msgpack.Packer().pack(sample_messages)"},{"line_number":75,"context_line":"            self.headers[\u0027Content-Type\u0027] \u003d \u0027application/x-msgpack\u0027"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            sample_doc \u003d jsonutils.dumps(sample_messages)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e002e13c","line":74,"in_reply_to":"baada198_64b35e9a","updated":"2014-07-14 20:39:44.000000000","message":"Done","commit_id":"53ef4b9ed3524ffb6b8cef9172adc47f2e65d3fb"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e82ca822b98e87ce3f23253cc588a97b33240627","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_201)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if use_msgpack:"},{"line_number":84,"context_line":"            unpacker \u003d msgpack.Unpacker()"},{"line_number":85,"context_line":"            unpacker.feed(result[0])"},{"line_number":86,"context_line":"            result_doc \u003d unpacker.unpack()"},{"line_number":87,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_072e248c","line":84,"updated":"2014-07-11 21:45:19.000000000","message":"Q: encoding\u003d\u0027utf-8\u0027 may need to be passed to Unpacker(). We need to do some research on this; seems like I had to do that to get the \"caches\" decorator tests to pass. See:\n\nhttps://github.com/openstack/marconi/blob/master/marconi/common/decorators.py#L124\n\nAnd also:\n\nhttps://github.com/openstack/marconi/blob/master/tests/unit/common/test_decorators.py#L39\n\nI also recall some strangeness in writing code that worked on both py2 and py3, but I can\u0027t remember the specifics. :p","commit_id":"53ef4b9ed3524ffb6b8cef9172adc47f2e65d3fb"},{"author":{"_account_id":10181,"name":"Dave Thomas","email":"opensource@peoplemerge.com","username":"peoplemerge"},"change_message_id":"ad14144f600c834fcfb5aa52080cc2d891244b29","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_201)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if use_msgpack:"},{"line_number":84,"context_line":"            unpacker \u003d msgpack.Unpacker()"},{"line_number":85,"context_line":"            unpacker.feed(result[0])"},{"line_number":86,"context_line":"            result_doc \u003d unpacker.unpack()"},{"line_number":87,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a00f0938","line":84,"in_reply_to":"baada198_072e248c","updated":"2014-07-14 20:39:44.000000000","message":"Yes, I was looking at decorators to clean up the test organization.  The simple OO seems to do for now but I\u0027ll refactor a bit more.\n\nencoding\u003dutf-8 is definitely necessary.  That\u0027s done.\n\nAt first I thought unpack needed py27 tweaking, but I realized how unicode displays in my terminal is what\u0027s different:\n\nPython 3.3.5 (default, Jul 13 2014, 16:20:11) \n[GCC 4.8.2] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e a \u003d { u\"??\": True }\n\u003e\u003e\u003e a\n{\u0027??\u0027: True}\n\npython\nPython 2.7.8 (default, Jul 13 2014, 16:23:41) \n[GCC 4.8.2] on linux2\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e a \u003d { u\"??\": True }\n\u003e\u003e\u003e a\n{u\u0027\\u6771\\u4eac\u0027: True}","commit_id":"53ef4b9ed3524ffb6b8cef9172adc47f2e65d3fb"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e82ca822b98e87ce3f23253cc588a97b33240627","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_post_single_msgpack(self):"},{"line_number":185,"context_line":"        sample_messages \u003d ["},{"line_number":186,"context_line":"            {\u0027body\u0027: {\u0027key\u0027: \u0027value\u0027}, \u0027ttl\u0027: 200},"},{"line_number":187,"context_line":"        ]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self._test_post(sample_messages, use_msgpack\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a741f83a","line":186,"updated":"2014-07-11 21:45:19.000000000","message":"TEST: Need to be sure to add tests that include both unicode and byte strings (with prefixes of \u0027u\u0027 and \u0027b\u0027, respectively)","commit_id":"53ef4b9ed3524ffb6b8cef9172adc47f2e65d3fb"},{"author":{"_account_id":10181,"name":"Dave Thomas","email":"opensource@peoplemerge.com","username":"peoplemerge"},"change_message_id":"ad14144f600c834fcfb5aa52080cc2d891244b29","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_post_single_msgpack(self):"},{"line_number":185,"context_line":"        sample_messages \u003d ["},{"line_number":186,"context_line":"            {\u0027body\u0027: {\u0027key\u0027: \u0027value\u0027}, \u0027ttl\u0027: 200},"},{"line_number":187,"context_line":"        ]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        self._test_post(sample_messages, use_msgpack\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_801e856e","line":186,"in_reply_to":"baada198_a741f83a","updated":"2014-07-14 20:39:44.000000000","message":"Done","commit_id":"53ef4b9ed3524ffb6b8cef9172adc47f2e65d3fb"},{"author":{"_account_id":10181,"name":"Dave Thomas","email":"opensource@peoplemerge.com","username":"peoplemerge"},"change_message_id":"0ee9382e43d2d6075874fbfe161d7a9cc150aa8e","unresolved":false,"context_lines":[{"line_number":481,"context_line":"    def _get_msg_ids(self, headers):"},{"line_number":482,"context_line":"        return headers[\u0027location\u0027].rsplit(\u0027\u003d\u0027, 1)[-1].split(\u0027,\u0027)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"class TestMessagesMsgpack(MessagesBaseTest):"},{"line_number":485,"context_line":"    packer \u003d msgpack.Packer(use_bin_type\u003dTrue)"},{"line_number":486,"context_line":"    unpacker \u003d msgpack.Unpacker(encoding\u003d\u0027utf-8\u0027)"},{"line_number":487,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2c474fbd","line":484,"updated":"2014-07-15 00:00:09.000000000","message":"Is the intent to test msgpack like this or do we want it to be combined with the sqlalchemy / mongodb tests?","commit_id":"3a04e3062a2b1e6ef7aef34007f87e33c1e54520"},{"author":{"_account_id":10181,"name":"Dave Thomas","email":"opensource@peoplemerge.com","username":"peoplemerge"},"change_message_id":"667bcf87a0b8860545ebec12220d63fc7930f0d8","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        return headers[\u0027location\u0027].rsplit(\u0027\u003d\u0027, 1)[-1].split(\u0027,\u0027)"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"class TestMessagesMsgpack(MessagesBaseTest):"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def __init__(self):"},{"line_number":486,"context_line":"        self.packer \u003d msgpack.Packer(use_bin_type\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_2d98d469","line":483,"updated":"2014-07-16 18:51:04.000000000","message":"I\u0027m not sure what the intent is with the other test subclasses; specifically would we want to run a test run with TestMessagesMongoDB+JSON and TestMessagesMongoDB+Msgpack?  Or is one subclass like the way I have it now sufficient?","commit_id":"045839820f5e94fb870f5c52b79967924a6a0dcd"}]}
