)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"9e976587a6b618c7673749da908157b01f297470","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Filter out expired messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Filter out the expired messages for Sqlalchemy when listing \u0026 poping"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1349213"},{"line_number":12,"context_line":"Change-Id: I4d013a4bfd9e75a207fa5d2054f12e78d972eca6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_0d14333f","line":9,"updated":"2014-07-28 20:16:39.000000000","message":"NIT: It may be worth noting that this patch also filters out expired messages when getting a message by ID. Also, little typo \u0027poping\u0027 ---\u003e \u0027popping\u0027.","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"5836ec2492399ebff0803f8f889d47bb57e6212e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Filter out expired messages"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Filter out the expired messages for Sqlalchemy when listing \u0026 poping"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1349213"},{"line_number":12,"context_line":"Change-Id: I4d013a4bfd9e75a207fa5d2054f12e78d972eca6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_cf8ea8d0","line":9,"in_reply_to":"baada198_0d14333f","updated":"2014-07-29 03:42:01.000000000","message":"I DID NOT change the behavior that getting a message by ID which already filter out the expired ones. so IMO, it\u0027s not needed to note.\n\nI will re-organize the commit message to be more clear.\n\nthanks.","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"}],"marconi/queues/storage/sqlalchemy/messages.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"9e976587a6b618c7673749da908157b01f297470","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                        tables.Messages.c.qid \u003d\u003d tables.Queues.c.id)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            sel \u003d sel.select_from(j)"},{"line_number":313,"context_line":"            and_clause \u003d [tables.Queues.c.name \u003d\u003d queue_name,"},{"line_number":314,"context_line":"                          tables.Queues.c.project \u003d\u003d project,"},{"line_number":315,"context_line":"                          tables.Messages.c.ttl \u003e"},{"line_number":316,"context_line":"                          sfunc.now() - tables.Messages.c.created]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_adaee7e4","line":313,"updated":"2014-07-28 20:16:39.000000000","message":"DRY: Not sure if it is worth doing in this instance, but you could factor out the creation of this and_clause, since the code is identical with L169-172, above.","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"5836ec2492399ebff0803f8f889d47bb57e6212e","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                        tables.Messages.c.qid \u003d\u003d tables.Queues.c.id)"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"            sel \u003d sel.select_from(j)"},{"line_number":313,"context_line":"            and_clause \u003d [tables.Queues.c.name \u003d\u003d queue_name,"},{"line_number":314,"context_line":"                          tables.Queues.c.project \u003d\u003d project,"},{"line_number":315,"context_line":"                          tables.Messages.c.ttl \u003e"},{"line_number":316,"context_line":"                          sfunc.now() - tables.Messages.c.created]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_8f53d06a","line":313,"in_reply_to":"baada198_adaee7e4","updated":"2014-07-29 03:42:01.000000000","message":"I will try to do it, Thanks","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"}],"marconi/tests/queues/storage/base.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"9e976587a6b618c7673749da908157b01f297470","unresolved":false,"context_lines":[{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    @testing.is_slow(condition\u003dlambda self: self.gc_interval !\u003d 0)"},{"line_number":423,"context_line":"    def test_expired_messages(self):"},{"line_number":424,"context_line":"        queue_name \u003d \u0027test-expired-messages\u0027"},{"line_number":425,"context_line":"        self.queue_controller.create(queue_name, self.project)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        messages \u003d [{\u0027body\u0027: 3.14, \u0027ttl\u0027: 0}, {\u0027body\u0027: 0.618, \u0027ttl\u0027: 600}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_72374afe","line":424,"updated":"2014-07-28 20:16:39.000000000","message":"Q. Why not simply use self.queue_name ? Just curious. May be helpful to add a NOTE comment.","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"5836ec2492399ebff0803f8f889d47bb57e6212e","unresolved":false,"context_lines":[{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    @testing.is_slow(condition\u003dlambda self: self.gc_interval !\u003d 0)"},{"line_number":423,"context_line":"    def test_expired_messages(self):"},{"line_number":424,"context_line":"        queue_name \u003d \u0027test-expired-messages\u0027"},{"line_number":425,"context_line":"        self.queue_controller.create(queue_name, self.project)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        messages \u003d [{\u0027body\u0027: 3.14, \u0027ttl\u0027: 0}, {\u0027body\u0027: 0.618, \u0027ttl\u0027: 600}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_bb60d3d1","line":424,"in_reply_to":"baada198_72374afe","updated":"2014-07-29 03:42:01.000000000","message":"fixed ,use the self.queue_name","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"9e976587a6b618c7673749da908157b01f297470","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        interaction \u003d self.controller.list(queue_name,"},{"line_number":447,"context_line":"                                           project\u003dself.project)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        messages \u003d list(next(interaction))"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        self.assertEqual(len(messages), 1)"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_926cde08","line":449,"updated":"2014-07-28 20:16:39.000000000","message":"NIT/STYLE: Not a big deal, but if you like, you can remove the extra blank lines (L450 and L452) to visually group the asserts and set them off better from the call to the control.","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"5836ec2492399ebff0803f8f889d47bb57e6212e","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        interaction \u003d self.controller.list(queue_name,"},{"line_number":447,"context_line":"                                           project\u003dself.project)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"        messages \u003d list(next(interaction))"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        self.assertEqual(len(messages), 1)"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_db5d8718","line":449,"in_reply_to":"baada198_926cde08","updated":"2014-07-29 03:42:01.000000000","message":"Done","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"9e976587a6b618c7673749da908157b01f297470","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                                       project\u003dself.project)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        self.assertEqual(len(messages), 1)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        self.assertEqual(msgid, messages[0][\u0027id\u0027])"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def test_bad_id(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_72402a5f","line":461,"updated":"2014-07-28 20:16:39.000000000","message":"NIT: As above, consider removing this blank line (L461).","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"5836ec2492399ebff0803f8f889d47bb57e6212e","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                                       project\u003dself.project)"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"        self.assertEqual(len(messages), 1)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        self.assertEqual(msgid, messages[0][\u0027id\u0027])"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def test_bad_id(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_fb5a4b1d","line":461,"in_reply_to":"baada198_72402a5f","updated":"2014-07-29 03:42:01.000000000","message":"Done","commit_id":"98e2a535d8fd577d7df486887a164cb4df968c6f"}]}
