)]}'
{"doc/source/first_patch.rst":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7ecd78163b1bfeb44538ee9cf7a1524dadd81866","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"You can read more about `launchpad bugs`_ in the wiki."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":".. _`bugs list in Launchpad`: https://bugs.launchpad.net/marconi"},{"line_number":112,"context_line":".. _`launchpad bugs`: https://wiki.openstack.org/wiki/Bugs"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_a0dcf719","line":111,"updated":"2014-08-25 22:39:20.000000000","message":"Please call me Zaqar :)","commit_id":"9079df580281125fdf7a348d995e922206cf7e84"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7ecd78163b1bfeb44538ee9cf7a1524dadd81866","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Design principles"},{"line_number":136,"context_line":"#################"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Marconi lives by the following design principles:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* `DRY`_"},{"line_number":141,"context_line":"* `YAGNI`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1abeadc6_c0e1f3d1","line":138,"updated":"2014-08-25 22:39:20.000000000","message":"ditto","commit_id":"9079df580281125fdf7a348d995e922206cf7e84"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"Set up your environment"},{"line_number":40,"context_line":"------------------------"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Clone the Zaqar repository with the following git command:"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  $ git clone git://git.openstack.org/openstack/zaqar.git"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_27b7a6d9","line":42,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :\ngit command: \u003d\u003e git command::","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  $ git clone git://git.openstack.org/openstack/zaqar.git"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"For more information on how to set up the Zaqar development environment"},{"line_number":47,"context_line":"see :doc:`development-environment`."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Before writing code, you will have to do some configurations"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_67b35e9a","line":46,"updated":"2014-08-28 12:49:23.000000000","message":"For more information \u003d\u003e For information","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"to connect your local repository with Gerrit. You will only need to do this"},{"line_number":51,"context_line":"your first time setting up the development environment."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Before you start work, make sure you have git-review installed on your system."},{"line_number":54,"context_line":"You can install it with the following command."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"   $ pip install git-review"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_c7ad1233","line":53,"updated":"2014-08-28 12:49:23.000000000","message":"work \u003d\u003e working","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"your first time setting up the development environment."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Before you start work, make sure you have git-review installed on your system."},{"line_number":54,"context_line":"You can install it with the following command."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"   $ pip install git-review"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_a7cad64c","line":54,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add ::\ncommand: \u003d\u003e command::","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Git-review checks if you can authenticate to Gerrit with your SSH key."},{"line_number":59,"context_line":"It will ask your for your username. You can configure your Gerrit username so you don\u0027t have to"},{"line_number":60,"context_line":"keep re-entering it everytime you want to use git-review:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"   $ git config --global gitreview.username yourgerritusername"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_87e95ab9","line":60,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :\ngit-review: \u003d\u003e git-review::","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"It will ask your for your username. You can configure your Gerrit username so you don\u0027t have to"},{"line_number":60,"context_line":"keep re-entering it everytime you want to use git-review:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"   $ git config --global gitreview.username yourgerritusername"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"You can view your Gerrit user name in the `settings page`_."},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_676a7eee","line":62,"updated":"2014-08-28 12:49:23.000000000","message":"Please add how to configure the gitreview.email too.","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"You can view your Gerrit user name in the `settings page`_."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"You can set git-review to configure the project and install the gerrit change-id commit hook with the following command:"},{"line_number":67,"context_line":"   $ cd zaqar"},{"line_number":68,"context_line":"   $ git review -s"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_2705e679","line":66,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"If you get the error \"We don\u0027t know where your Gerrit is\", you will need to"},{"line_number":71,"context_line":"add a new git remote. The URL should be in the error message. Copy that and"},{"line_number":72,"context_line":"create the new remote. It looks something like:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"   $ git remote add gerrit ssh://\u003cusername\u003e@review.openstack.org:29418/openstack/zaqar.git"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_470ae28a","line":72,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"   $ git remote add gerrit ssh://\u003cusername\u003e@review.openstack.org:29418/openstack/zaqar.git"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"In the project directory you have a hidden .git directory and a"},{"line_number":77,"context_line":".gitreview file. You can view them with the following command:"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"   $ ls -la"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_a7f8167d","line":77,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Workflow"},{"line_number":116,"context_line":"#########"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Make sure your repo is up to date. You can update it with the following git commands:"},{"line_number":119,"context_line":"    $ git remote update"},{"line_number":120,"context_line":"    $ git checkout master"},{"line_number":121,"context_line":"    $ git pull --ff-only origin master"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_e7ee8eb4","line":118,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    $ git checkout master"},{"line_number":121,"context_line":"    $ git pull --ff-only origin master"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Create a topic branch. You can create one with the following git command:"},{"line_number":124,"context_line":"    $ git checkout -b TOPIC-BRANCH"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"If you are working on a blueprint, name your topic branch bp/BLUEPRINT where BLUEPRINT"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_272c0602","line":123,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"Design principles"},{"line_number":136,"context_line":"##################"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Zaqar lives by the following design principles:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"* `DRY`_"},{"line_number":141,"context_line":"* `YAGNI`_"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_47310259","line":138,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Read more about `making a good commit message`_."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"To submit it for review use the following git command:"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"   $ git review"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_a73f3624","line":175,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add an extra :","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This section describes how to create your first patch and upload it to"},{"line_number":18,"context_line":"Gerrit_ for reviewing."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Set up your contributor accounts"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_fb089e2e","line":18,"updated":"2014-08-29 20:23:35.000000000","message":"Could you organize the sections as in https://wiki.openstack.org/wiki/Gerrit_Workflow wiki?\n\nIt should look like\n\n- Create your contributor accounts and set up your code environment\n   - Accounts setup\n   - Git Review installation\n   - Project setup\n   - Normal workflow\n\nAnd our sections\n- Write a patch\n  - Pick or report a bug\n  - Design principles\n  - Test your code \n  - Submit the patch","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This section describes how to create your first patch and upload it to"},{"line_number":18,"context_line":"Gerrit_ for reviewing."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Set up your contributor accounts"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_db36ea51","line":18,"in_reply_to":"1abeadc6_fb089e2e","updated":"2014-09-02 19:36:15.000000000","message":"Done, but the wiki also has a SSH Setup section after project setup which I think we should keep since it goes into specifics of creating the key.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Set up your contributor accounts"},{"line_number":22,"context_line":"---------------------------------"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"You will need to create a Launchpad_ account. You will be able to login"},{"line_number":25,"context_line":"into the Gerrit_ review system with your launchpad account."},{"line_number":26,"context_line":"Before we can accept your patches, you\u0027ll will have to sign the"},{"line_number":27,"context_line":"`Contributors License Agreement`_. You may also want to `join the OpenStack Foundation`_ to gain voting rights. You may want to use the same email"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_bb7d466f","line":24,"updated":"2014-08-29 20:23:35.000000000","message":"You will need to create a Launchpad_ account. You will be able to login into the Gerrit_ review system with your launchpad account. \u003d\u003d\u003e You will need to create a Launchpad_ account to login to the Gerrit_ review system dashboard. This is also useful for automatically crediting bug fixes to you when you address them with your code commits.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Set up your contributor accounts"},{"line_number":22,"context_line":"---------------------------------"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"You will need to create a Launchpad_ account. You will be able to login"},{"line_number":25,"context_line":"into the Gerrit_ review system with your launchpad account."},{"line_number":26,"context_line":"Before we can accept your patches, you\u0027ll will have to sign the"},{"line_number":27,"context_line":"`Contributors License Agreement`_. You may also want to `join the OpenStack Foundation`_ to gain voting rights. You may want to use the same email"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_fb39ee41","line":24,"in_reply_to":"1abeadc6_bb7d466f","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"You will need to create a Launchpad_ account. You will be able to login"},{"line_number":25,"context_line":"into the Gerrit_ review system with your launchpad account."},{"line_number":26,"context_line":"Before we can accept your patches, you\u0027ll will have to sign the"},{"line_number":27,"context_line":"`Contributors License Agreement`_. You may also want to `join the OpenStack Foundation`_ to gain voting rights. You may want to use the same email"},{"line_number":28,"context_line":"for all of these accounts to avoid confussion."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_9bf16a03","line":26,"updated":"2014-08-29 20:23:35.000000000","message":"Before we can accept your patches, you\u0027ll will have to sign the `Contributors License Agreement`_. You may also want to `join the OpenStack Foundation`_ to gain voting rights. \u003d\u003e You will also have to sign the `Contributors License Agreement`_ and `join the OpenStack Foundation`_.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"You will need to create a Launchpad_ account. You will be able to login"},{"line_number":25,"context_line":"into the Gerrit_ review system with your launchpad account."},{"line_number":26,"context_line":"Before we can accept your patches, you\u0027ll will have to sign the"},{"line_number":27,"context_line":"`Contributors License Agreement`_. You may also want to `join the OpenStack Foundation`_ to gain voting rights. You may want to use the same email"},{"line_number":28,"context_line":"for all of these accounts to avoid confussion."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_3b229601","line":26,"in_reply_to":"1abeadc6_9bf16a03","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":25,"context_line":"into the Gerrit_ review system with your launchpad account."},{"line_number":26,"context_line":"Before we can accept your patches, you\u0027ll will have to sign the"},{"line_number":27,"context_line":"`Contributors License Agreement`_. You may also want to `join the OpenStack Foundation`_ to gain voting rights. You may want to use the same email"},{"line_number":28,"context_line":"for all of these accounts to avoid confussion."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Visit the the `Gerrit Workflow\u0027s account setup`_ section in the wiki"},{"line_number":31,"context_line":"to get more information on setting up your accounts."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_7b63aeb0","line":28,"updated":"2014-08-29 20:23:35.000000000","message":"You may want to use the same email for all of these accounts to avoid confussion. \u003d\u003e Is a good idea to use the same email for all of these accounts to avoid hooks errors.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":25,"context_line":"into the Gerrit_ review system with your launchpad account."},{"line_number":26,"context_line":"Before we can accept your patches, you\u0027ll will have to sign the"},{"line_number":27,"context_line":"`Contributors License Agreement`_. You may also want to `join the OpenStack Foundation`_ to gain voting rights. You may want to use the same email"},{"line_number":28,"context_line":"for all of these accounts to avoid confussion."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Visit the the `Gerrit Workflow\u0027s account setup`_ section in the wiki"},{"line_number":31,"context_line":"to get more information on setting up your accounts."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_9b7aa2ef","line":28,"in_reply_to":"1abeadc6_7b63aeb0","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":37,"context_line":".. _`Gerrit Workflow\u0027s account setup`: https://wiki.openstack.org/wiki/Gerrit_Workflow#Account_Setup"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Set up SSH"},{"line_number":41,"context_line":"###########"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"You are going to need to upload an SSH key to Gerrit to be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_4e01d203","line":40,"updated":"2014-08-29 20:23:35.000000000","message":"Add the content of this section in \u0027Account setup\u0027","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":37,"context_line":".. _`Gerrit Workflow\u0027s account setup`: https://wiki.openstack.org/wiki/Gerrit_Workflow#Account_Setup"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Set up SSH"},{"line_number":41,"context_line":"###########"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"You are going to need to upload an SSH key to Gerrit to be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_e6d4ff48","line":40,"in_reply_to":"1abeadc6_4e01d203","updated":"2014-09-02 19:36:15.000000000","message":"I think this need it\u0027s own section since I added the instructions to generate the SSH key.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Set up SSH"},{"line_number":41,"context_line":"###########"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"You are going to need to upload an SSH key to Gerrit to be"},{"line_number":44,"context_line":"able to commit changes for review. To create one::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"   $ ssh-keygen –t rsa"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_fbf5feca","line":43,"updated":"2014-08-29 20:23:35.000000000","message":"You are going to need to upload an SSH key to Gerrit \u003d\u003e You will need to create and upload a SSH key to Gerrit","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Set up SSH"},{"line_number":41,"context_line":"###########"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"You are going to need to upload an SSH key to Gerrit to be"},{"line_number":44,"context_line":"able to commit changes for review. To create one::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"   $ ssh-keygen –t rsa"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_db5b4a85","line":43,"in_reply_to":"1abeadc6_fbf5feca","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":41,"context_line":"###########"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"You are going to need to upload an SSH key to Gerrit to be"},{"line_number":44,"context_line":"able to commit changes for review. To create one::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"   $ ssh-keygen –t rsa"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_fb1c1e15","line":44,"updated":"2014-08-29 20:23:35.000000000","message":"To create one:: \u003d\u003e To create a SSH key::","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":41,"context_line":"###########"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"You are going to need to upload an SSH key to Gerrit to be"},{"line_number":44,"context_line":"able to commit changes for review. To create one::"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"   $ ssh-keygen –t rsa"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_5b4f5abd","line":44,"in_reply_to":"1abeadc6_fb1c1e15","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"   $ ssh-keygen –t rsa"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Optionally, enter a password. If you enter one, you must enter it every time you commit."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"View and copy your SSH key::"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_3bc1364e","line":48,"updated":"2014-08-29 20:23:35.000000000","message":"Optionally, enter a password. \u003d\u003e You can optionally enter a passphrase to enhance security.\nRemove \u0027If you enter one, you must enter it every time you commit.\u0027 (they can use an ssh-agent)","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"   $ ssh-keygen –t rsa"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Optionally, enter a password. If you enter one, you must enter it every time you commit."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"View and copy your SSH key::"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_7b4a5ead","line":48,"in_reply_to":"1abeadc6_3bc1364e","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":56,"context_line":".. _`upload the SSH key to Gerrit`: https://review.openstack.org/#/settings/ssh-keys"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Set up your environment"},{"line_number":60,"context_line":"------------------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Clone the Zaqar repository with the following git command::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_ae0a661d","line":59,"updated":"2014-08-29 20:23:35.000000000","message":"Set up your environment \u003d\u003e Project setup","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":56,"context_line":".. _`upload the SSH key to Gerrit`: https://review.openstack.org/#/settings/ssh-keys"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Set up your environment"},{"line_number":60,"context_line":"------------------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Clone the Zaqar repository with the following git command::"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_1b031243","line":59,"in_reply_to":"1abeadc6_ae0a661d","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":66,"context_line":"For information on how to set up the Zaqar development environment"},{"line_number":67,"context_line":"see :doc:`development-environment`."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Before writing code, you will have to do some configurations"},{"line_number":70,"context_line":"to connect your local repository with Gerrit. You will only need to do this"},{"line_number":71,"context_line":"your first time setting up the development environment."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_ee0ffe2b","line":69,"updated":"2014-08-29 20:23:35.000000000","message":"Move L69-L82 and L90 this to Git Review installation","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":66,"context_line":"For information on how to set up the Zaqar development environment"},{"line_number":67,"context_line":"see :doc:`development-environment`."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Before writing code, you will have to do some configurations"},{"line_number":70,"context_line":"to connect your local repository with Gerrit. You will only need to do this"},{"line_number":71,"context_line":"your first time setting up the development environment."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_7bf89e49","line":69,"in_reply_to":"1abeadc6_ee0ffe2b","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"You can also save some time by entering your email and your name::"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"   $ git config --global gitreview.email yourgerritemail"},{"line_number":87,"context_line":"   $ git config --global gitreview.name \"Firstname Lastname\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_fb789e2c","line":86,"updated":"2014-08-29 20:23:35.000000000","message":"Two comments here,\n\n1. The local repository configuration L86-L87 should be located under the \u0027Set up your contributor accounts\u0027 section since it\u0027s part of the credentials information.\n\n2. $ git config --global user.email \"your_email@youremail.com\"","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"You can also save some time by entering your email and your name::"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"   $ git config --global gitreview.email yourgerritemail"},{"line_number":87,"context_line":"   $ git config --global gitreview.name \"Firstname Lastname\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_9bbd426b","line":86,"in_reply_to":"1abeadc6_fb789e2c","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Pick or report a bug"},{"line_number":115,"context_line":"#####################"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"You can start tacking some bugs from the `bugs list in Launchpad`_."},{"line_number":118,"context_line":"If you find a bug you want to work on, assign yourself. Make sure to read"},{"line_number":119,"context_line":"the bug report. If you need more information, ask the reporter to provide"},{"line_number":120,"context_line":"more details through a comment on launchpad or through IRC or email."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_0ee35aa4","line":117,"updated":"2014-08-29 20:23:35.000000000","message":"tacking \u003d\u003e tackling","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Pick or report a bug"},{"line_number":115,"context_line":"#####################"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"You can start tacking some bugs from the `bugs list in Launchpad`_."},{"line_number":118,"context_line":"If you find a bug you want to work on, assign yourself. Make sure to read"},{"line_number":119,"context_line":"the bug report. If you need more information, ask the reporter to provide"},{"line_number":120,"context_line":"more details through a comment on launchpad or through IRC or email."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_3e0fe42f","line":117,"in_reply_to":"1abeadc6_0ee35aa4","updated":"2014-09-02 19:36:15.000000000","message":"Good catch.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":117,"context_line":"You can start tacking some bugs from the `bugs list in Launchpad`_."},{"line_number":118,"context_line":"If you find a bug you want to work on, assign yourself. Make sure to read"},{"line_number":119,"context_line":"the bug report. If you need more information, ask the reporter to provide"},{"line_number":120,"context_line":"more details through a comment on launchpad or through IRC or email."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If you find a bug, look through Launchpad to see if it has been reported. If it hasn\u0027t, report the bug, and"},{"line_number":123,"context_line":"ask for another developer to confirm it. You may can start working on it if another developer confirms the bug."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_4ef0f266","line":120,"updated":"2014-08-29 20:23:35.000000000","message":"launchpad \u003d\u003e Launchpad","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":117,"context_line":"You can start tacking some bugs from the `bugs list in Launchpad`_."},{"line_number":118,"context_line":"If you find a bug you want to work on, assign yourself. Make sure to read"},{"line_number":119,"context_line":"the bug report. If you need more information, ask the reporter to provide"},{"line_number":120,"context_line":"more details through a comment on launchpad or through IRC or email."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If you find a bug, look through Launchpad to see if it has been reported. If it hasn\u0027t, report the bug, and"},{"line_number":123,"context_line":"ask for another developer to confirm it. You may can start working on it if another developer confirms the bug."}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_7e308ce8","line":120,"in_reply_to":"1abeadc6_4ef0f266","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":120,"context_line":"more details through a comment on launchpad or through IRC or email."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If you find a bug, look through Launchpad to see if it has been reported. If it hasn\u0027t, report the bug, and"},{"line_number":123,"context_line":"ask for another developer to confirm it. You may can start working on it if another developer confirms the bug."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Here are some details you might want to include when filling out a bug report:"},{"line_number":126,"context_line":"* The release, or milestone, or commit ID corresponding to the software that you are running"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_8e9daa0c","line":123,"updated":"2014-08-29 20:23:35.000000000","message":"You may can \u003d\u003e You can","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":120,"context_line":"more details through a comment on launchpad or through IRC or email."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"If you find a bug, look through Launchpad to see if it has been reported. If it hasn\u0027t, report the bug, and"},{"line_number":123,"context_line":"ask for another developer to confirm it. You may can start working on it if another developer confirms the bug."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Here are some details you might want to include when filling out a bug report:"},{"line_number":126,"context_line":"* The release, or milestone, or commit ID corresponding to the software that you are running"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_9e4e106e","line":123,"in_reply_to":"1abeadc6_8e9daa0c","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":130,"context_line":"* Portions of your log files so that you include only relevant excerpts"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"In the bug comments, you can contribute instructions on how to fix a given bug,"},{"line_number":133,"context_line":"and set the status to \"Triaged\"."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"You can read more about `launchpad bugs`_ in the wiki."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_0ea8ba1e","line":133,"updated":"2014-08-29 20:23:35.000000000","message":"Remove \u0027and set the status to \"Triaged\"\u0027. Contributors shouldn\u0027t confirm their reported bugs.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":130,"context_line":"* Portions of your log files so that you include only relevant excerpts"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"In the bug comments, you can contribute instructions on how to fix a given bug,"},{"line_number":133,"context_line":"and set the status to \"Triaged\"."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"You can read more about `launchpad bugs`_ in the wiki."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_9e9c50c2","line":133,"in_reply_to":"1abeadc6_0ea8ba1e","updated":"2014-09-02 19:36:15.000000000","message":"I should probably fix that in the main OpenStack docs too.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":132,"context_line":"In the bug comments, you can contribute instructions on how to fix a given bug,"},{"line_number":133,"context_line":"and set the status to \"Triaged\"."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"You can read more about `launchpad bugs`_ in the wiki."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. _`bugs list in Launchpad`: https://bugs.launchpad.net/zaqar"},{"line_number":138,"context_line":".. _`launchpad bugs`: https://wiki.openstack.org/wiki/Bugs"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_6e684ef5","line":135,"updated":"2014-08-29 20:23:35.000000000","message":"launchpad \u003d\u003e Launchpad","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":132,"context_line":"In the bug comments, you can contribute instructions on how to fix a given bug,"},{"line_number":133,"context_line":"and set the status to \"Triaged\"."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"You can read more about `launchpad bugs`_ in the wiki."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":".. _`bugs list in Launchpad`: https://bugs.launchpad.net/zaqar"},{"line_number":138,"context_line":".. _`launchpad bugs`: https://wiki.openstack.org/wiki/Bugs"}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_5ebae823","line":135,"in_reply_to":"1abeadc6_6e684ef5","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    $ git checkout -b TOPIC-BRANCH"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"If you are working on a blueprint, name your topic branch bp/BLUEPRINT where BLUEPRINT"},{"line_number":153,"context_line":"is the name of a blueprint in launchpad (for example, \"bp/authentication\"). The general"},{"line_number":154,"context_line":"convention when working on bugs is to name the branch bug/BUG-NUMBER"},{"line_number":155,"context_line":"(for example, \"bug/1234567\")."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_ee737ee4","line":153,"updated":"2014-08-29 20:23:35.000000000","message":"launchpad \u003d\u003e Launchpad","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    $ git checkout -b TOPIC-BRANCH"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"If you are working on a blueprint, name your topic branch bp/BLUEPRINT where BLUEPRINT"},{"line_number":153,"context_line":"is the name of a blueprint in launchpad (for example, \"bp/authentication\"). The general"},{"line_number":154,"context_line":"convention when working on bugs is to name the branch bug/BUG-NUMBER"},{"line_number":155,"context_line":"(for example, \"bug/1234567\")."},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_7eb5ec2f","line":153,"in_reply_to":"1abeadc6_ee737ee4","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":154,"context_line":"convention when working on bugs is to name the branch bug/BUG-NUMBER"},{"line_number":155,"context_line":"(for example, \"bug/1234567\")."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Read more about the `Gerrit workflow`_."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":".. _`Gerrit workflow`: https://wiki.openstack.org/wiki/Gerrit_Workflow"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_4e4c729e","line":157,"updated":"2014-08-29 20:23:35.000000000","message":"Read more about this in the `Gerrit workflow`_.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":154,"context_line":"convention when working on bugs is to name the branch bug/BUG-NUMBER"},{"line_number":155,"context_line":"(for example, \"bug/1234567\")."},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Read more about the `Gerrit workflow`_."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":".. _`Gerrit workflow`: https://wiki.openstack.org/wiki/Gerrit_Workflow"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_9e837055","line":157,"in_reply_to":"1abeadc6_4e4c729e","updated":"2014-09-02 19:36:15.000000000","message":"This links to the general wiki page and not the specific commit section, so I\u0027ll change the wording to clarify.","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"}],"doc/source/first_review.rst":[{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Your first review"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The review stage is a very important part in the development process. There are many reasons to say this:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"* Getting other developers feedback minimizes the risk of adding"},{"line_number":8,"context_line":"  regressions to the code base and ensures the quality of the code being merged."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_3fdfeb3c","line":5,"updated":"2014-08-19 20:54:12.000000000","message":"Following are some of the reasons this stage is important:","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"* Getting other developers feedback minimizes the risk of adding"},{"line_number":8,"context_line":"  regressions to the code base and ensures the quality of the code being merged."},{"line_number":9,"context_line":"* It helps to build community. Everyone appreciate when their code is"},{"line_number":10,"context_line":"  reviewed, and of course they will review your code when they have their chance."},{"line_number":11,"context_line":"* It also helps developers to improve, since they are always learning from other\u0027s points of view."},{"line_number":12,"context_line":"* Its a great practice to get familiar with the code."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_dfa6f752","line":9,"updated":"2014-08-19 20:54:12.000000000","message":"Building the community encourages everyone to review code. Everyone appreciates having their code reviewed.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  regressions to the code base and ensures the quality of the code being merged."},{"line_number":9,"context_line":"* It helps to build community. Everyone appreciate when their code is"},{"line_number":10,"context_line":"  reviewed, and of course they will review your code when they have their chance."},{"line_number":11,"context_line":"* It also helps developers to improve, since they are always learning from other\u0027s points of view."},{"line_number":12,"context_line":"* Its a great practice to get familiar with the code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Everyone is encouraged to review code. It\u0027s not necessary that you know every"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_3f460b7d","line":11,"updated":"2014-08-19 20:54:12.000000000","message":"Since developers are always learning from being exposed to the points of view of others, reviews help developers to improve their coding skills","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"* It helps to build community. Everyone appreciate when their code is"},{"line_number":10,"context_line":"  reviewed, and of course they will review your code when they have their chance."},{"line_number":11,"context_line":"* It also helps developers to improve, since they are always learning from other\u0027s points of view."},{"line_number":12,"context_line":"* Its a great practice to get familiar with the code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Everyone is encouraged to review code. It\u0027s not necessary that you know every"},{"line_number":15,"context_line":"detail of the code base, you only have to understand what the code related to the fix does. :w"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_ff32d30e","line":12,"updated":"2014-08-19 20:54:12.000000000","message":"Providing a review is a great way to become familar with the code.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"* It also helps developers to improve, since they are always learning from other\u0027s points of view."},{"line_number":12,"context_line":"* Its a great practice to get familiar with the code."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Everyone is encouraged to review code. It\u0027s not necessary that you know every"},{"line_number":15,"context_line":"detail of the code base, you only have to understand what the code related to the fix does. :w"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Step by step"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_1f1dcf73","line":14,"updated":"2014-08-19 20:54:12.000000000","message":"Everyone is encourages to review code. You don\u0027t need to know every detail of the code base. You need to understand only what the code related to the fix does.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"   $ git review -d [review-id]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"The review-id is located the number in the URL (check the screenshot for more details)."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Example"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_e2195c7a","line":26,"updated":"2014-08-19 20:54:12.000000000","message":"The review-id is the number in the URL....","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. image:: images/marconi_review_id.png"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This will create a branch with the author name and will allow you to test the patch in your local environment."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Inspect the code. Is important that you consider all the good programming practices you know here."},{"line_number":37,"context_line":"* Give code location feedback. (Do you consider that some code should be better located in another place within the file, or maybe in another file? If so, suggest it the review comment and score with -1 if you think that it\u0027s that important.)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_e2307cea","line":34,"updated":"2014-08-19 20:54:12.000000000","message":"This git command creates a branch with the author\u0027s name and enables you to test the patch in your local environment.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"This will create a branch with the author name and will allow you to test the patch in your local environment."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Inspect the code. Is important that you consider all the good programming practices you know here."},{"line_number":37,"context_line":"* Give code location feedback. (Do you consider that some code should be better located in another place within the file, or maybe in another file? If so, suggest it the review comment and score with -1 if you think that it\u0027s that important.)"},{"line_number":38,"context_line":"* Give code style feedback. (Do you think that the code structure could be improved? Keep the DRY, YAGNI and KISS principles in mind.)"},{"line_number":39,"context_line":"* Give grammar/orthography feedback. Many of our contributors are not native English speakers, so its common to find some of this errors."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_22799493","line":36,"updated":"2014-08-19 20:54:12.000000000","message":"Inspect the code. Use all of the best programming practices you know as you review the code.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"This will create a branch with the author name and will allow you to test the patch in your local environment."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Inspect the code. Is important that you consider all the good programming practices you know here."},{"line_number":37,"context_line":"* Give code location feedback. (Do you consider that some code should be better located in another place within the file, or maybe in another file? If so, suggest it the review comment and score with -1 if you think that it\u0027s that important.)"},{"line_number":38,"context_line":"* Give code style feedback. (Do you think that the code structure could be improved? Keep the DRY, YAGNI and KISS principles in mind.)"},{"line_number":39,"context_line":"* Give grammar/orthography feedback. Many of our contributors are not native English speakers, so its common to find some of this errors."},{"line_number":40,"context_line":"* Make sure that:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_e25ebc11","line":37,"updated":"2014-08-19 20:54:12.000000000","message":"If so, suggest this in the review comment and score with....","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* Inspect the code. Is important that you consider all the good programming practices you know here."},{"line_number":37,"context_line":"* Give code location feedback. (Do you consider that some code should be better located in another place within the file, or maybe in another file? If so, suggest it the review comment and score with -1 if you think that it\u0027s that important.)"},{"line_number":38,"context_line":"* Give code style feedback. (Do you think that the code structure could be improved? Keep the DRY, YAGNI and KISS principles in mind.)"},{"line_number":39,"context_line":"* Give grammar/orthography feedback. Many of our contributors are not native English speakers, so its common to find some of this errors."},{"line_number":40,"context_line":"* Make sure that:"},{"line_number":41,"context_line":"  * Commit message is formatted appropriately (check `Git Commit Messages`_ for more information on how a Git Commit message should be written.)"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_42a7700c","line":38,"updated":"2014-08-19 20:54:12.000000000","message":"Give code-style feedback.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":36,"context_line":"* Inspect the code. Is important that you consider all the good programming practices you know here."},{"line_number":37,"context_line":"* Give code location feedback. (Do you consider that some code should be better located in another place within the file, or maybe in another file? If so, suggest it the review comment and score with -1 if you think that it\u0027s that important.)"},{"line_number":38,"context_line":"* Give code style feedback. (Do you think that the code structure could be improved? Keep the DRY, YAGNI and KISS principles in mind.)"},{"line_number":39,"context_line":"* Give grammar/orthography feedback. Many of our contributors are not native English speakers, so its common to find some of this errors."},{"line_number":40,"context_line":"* Make sure that:"},{"line_number":41,"context_line":"  * Commit message is formatted appropriately (check `Git Commit Messages`_ for more information on how a Git Commit message should be written.)"},{"line_number":42,"context_line":"  * Coding style matches guidelines given in HACKING.rst"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_a292049d","line":39,"updated":"2014-08-19 20:54:12.000000000","message":"Give grammar and orthography feedback. Many of our contributors are not native English speakers, so it is common to find some errors of this type.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"* Give code style feedback. (Do you think that the code structure could be improved? Keep the DRY, YAGNI and KISS principles in mind.)"},{"line_number":39,"context_line":"* Give grammar/orthography feedback. Many of our contributors are not native English speakers, so its common to find some of this errors."},{"line_number":40,"context_line":"* Make sure that:"},{"line_number":41,"context_line":"  * Commit message is formatted appropriately (check `Git Commit Messages`_ for more information on how a Git Commit message should be written.)"},{"line_number":42,"context_line":"  * Coding style matches guidelines given in HACKING.rst"},{"line_number":43,"context_line":"  * Patch is not too big (some patches may need to be split to improve cohesion and/or reduce size)"},{"line_number":44,"context_line":"  * Patch does what the commit message promises"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_82c50890","line":41,"updated":"2014-08-19 20:54:12.000000000","message":"The commit message... information on how you should write a git commit message.)","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* Give grammar/orthography feedback. Many of our contributors are not native English speakers, so its common to find some of this errors."},{"line_number":40,"context_line":"* Make sure that:"},{"line_number":41,"context_line":"  * Commit message is formatted appropriately (check `Git Commit Messages`_ for more information on how a Git Commit message should be written.)"},{"line_number":42,"context_line":"  * Coding style matches guidelines given in HACKING.rst"},{"line_number":43,"context_line":"  * Patch is not too big (some patches may need to be split to improve cohesion and/or reduce size)"},{"line_number":44,"context_line":"  * Patch does what the commit message promises"},{"line_number":45,"context_line":"  * Unit and functional tests have been included and/or updated"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_223c3493","line":42,"updated":"2014-08-19 20:54:12.000000000","message":"The coding style matches the guideline given in HACKING.rst.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"* Make sure that:"},{"line_number":41,"context_line":"  * Commit message is formatted appropriately (check `Git Commit Messages`_ for more information on how a Git Commit message should be written.)"},{"line_number":42,"context_line":"  * Coding style matches guidelines given in HACKING.rst"},{"line_number":43,"context_line":"  * Patch is not too big (some patches may need to be split to improve cohesion and/or reduce size)"},{"line_number":44,"context_line":"  * Patch does what the commit message promises"},{"line_number":45,"context_line":"  * Unit and functional tests have been included and/or updated"},{"line_number":46,"context_line":"* If during the inspection you see a specific line you would like to bring up to discussion in the final review, leave feedback as an inline comment in Gerrit. This will make the review process easier. You can also see the `prefixes you can use`_ for Zaqar inline comments."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_a247641c","line":43,"updated":"2014-08-19 20:54:12.000000000","message":"The patch is not too big (you might need to split some patches to improve cohesion and/or reduce size).","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  * Commit message is formatted appropriately (check `Git Commit Messages`_ for more information on how a Git Commit message should be written.)"},{"line_number":42,"context_line":"  * Coding style matches guidelines given in HACKING.rst"},{"line_number":43,"context_line":"  * Patch is not too big (some patches may need to be split to improve cohesion and/or reduce size)"},{"line_number":44,"context_line":"  * Patch does what the commit message promises"},{"line_number":45,"context_line":"  * Unit and functional tests have been included and/or updated"},{"line_number":46,"context_line":"* If during the inspection you see a specific line you would like to bring up to discussion in the final review, leave feedback as an inline comment in Gerrit. This will make the review process easier. You can also see the `prefixes you can use`_ for Zaqar inline comments."},{"line_number":47,"context_line":"* Keep in mind the `Zaqar\u0027s Reviewer Guide`_ and be respectful when leaving feedback."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_625d4ce9","line":44,"updated":"2014-08-19 20:54:12.000000000","message":"The patch does what the commit message promises.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  * Coding style matches guidelines given in HACKING.rst"},{"line_number":43,"context_line":"  * Patch is not too big (some patches may need to be split to improve cohesion and/or reduce size)"},{"line_number":44,"context_line":"  * Patch does what the commit message promises"},{"line_number":45,"context_line":"  * Unit and functional tests have been included and/or updated"},{"line_number":46,"context_line":"* If during the inspection you see a specific line you would like to bring up to discussion in the final review, leave feedback as an inline comment in Gerrit. This will make the review process easier. You can also see the `prefixes you can use`_ for Zaqar inline comments."},{"line_number":47,"context_line":"* Keep in mind the `Zaqar\u0027s Reviewer Guide`_ and be respectful when leaving feedback."},{"line_number":48,"context_line":"* Hit the \"Review\" button in the web UI to publish your comments and assign a score."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_eed783eb","line":45,"updated":"2014-08-19 20:54:12.000000000","message":"Unit and functional tests are included and/or updated.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* Keep in mind the `Zaqar\u0027s Reviewer Guide`_ and be respectful when leaving feedback."},{"line_number":48,"context_line":"* Hit the \"Review\" button in the web UI to publish your comments and assign a score."},{"line_number":49,"context_line":"* Things to consider when leaving a score:"},{"line_number":50,"context_line":"  * You could score with -1 if you think that there are things that should be fixed. We have to be careful to not stall the cycle just because a few nits, so downvoting also depends on the current stage of the development cycle and the severity of the flaw you see."},{"line_number":51,"context_line":"  * You could give a score with a 0 if you are the author of the fix and you want respond to the reviewers comments, or if you are a reviewer and you want to point out some reminder for future developing (e.g. the deadline is the next day and the fix needs to be merged, but you want something to be improved)."},{"line_number":52,"context_line":"  * You can score with +1 if the fix works and you think that the code looks good, upvoting is your choice."},{"line_number":53,"context_line":"* Remember to leave any comment you think is important in the comment form, and when you are done just click \"Publish Comments\"."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_ce4ac7c4","line":50,"updated":"2014-08-19 20:54:12.000000000","message":"You can score with a -1 if you think that there are things to fix.","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"* Hit the \"Review\" button in the web UI to publish your comments and assign a score."},{"line_number":49,"context_line":"* Things to consider when leaving a score:"},{"line_number":50,"context_line":"  * You could score with -1 if you think that there are things that should be fixed. We have to be careful to not stall the cycle just because a few nits, so downvoting also depends on the current stage of the development cycle and the severity of the flaw you see."},{"line_number":51,"context_line":"  * You could give a score with a 0 if you are the author of the fix and you want respond to the reviewers comments, or if you are a reviewer and you want to point out some reminder for future developing (e.g. the deadline is the next day and the fix needs to be merged, but you want something to be improved)."},{"line_number":52,"context_line":"  * You can score with +1 if the fix works and you think that the code looks good, upvoting is your choice."},{"line_number":53,"context_line":"* Remember to leave any comment you think is important in the comment form, and when you are done just click \"Publish Comments\"."},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_6e88d3e7","line":51,"updated":"2014-08-19 20:54:12.000000000","message":"You can score with a 0 if you are the author of the fix and you want to respond to the .....","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":8803,"name":"Catherine Richardson","email":"catherine.richardson@rackspace.com","username":"cyrichardson"},"change_message_id":"b00328f0781a12bb47ef61fdbd9cf29c8ddb3db6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"  * You could score with -1 if you think that there are things that should be fixed. We have to be careful to not stall the cycle just because a few nits, so downvoting also depends on the current stage of the development cycle and the severity of the flaw you see."},{"line_number":51,"context_line":"  * You could give a score with a 0 if you are the author of the fix and you want respond to the reviewers comments, or if you are a reviewer and you want to point out some reminder for future developing (e.g. the deadline is the next day and the fix needs to be merged, but you want something to be improved)."},{"line_number":52,"context_line":"  * You can score with +1 if the fix works and you think that the code looks good, upvoting is your choice."},{"line_number":53,"context_line":"* Remember to leave any comment you think is important in the comment form, and when you are done just click \"Publish Comments\"."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"For more details on how to do a review, check out the Review section in the GerritWorkflow wiki."}],"source_content_type":"text/x-rst","patch_set":1,"id":"1abeadc6_6e5ff372","line":53,"updated":"2014-08-19 20:54:12.000000000","message":"Remember to leave any comment that you think is important in the comment form. When you are done, click \"Publish Comments\".","commit_id":"f67a9162f6f441b7eda6de3473d0aae864d83833"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Go to review.openstack.org and filter by `Open Zaqar fixes`_. Select a fix from the list to review."},{"line_number":20,"context_line":"Try to select an easy patch for your first review. That will help you to gain some confidence."},{"line_number":21,"context_line":"Download the patch to your local repository and test it."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   $ git review -d [review-id]"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_a7265614","line":21,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add ::","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The review-id is the number in the URL (check the screenshot for more details)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Example"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   $ git review -d 92979"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_e71ccec4","line":27,"updated":"2014-08-28 12:49:23.000000000","message":"NIT: Add ::","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. _`Open Zaqar fixes`: https://review.openstack.org/#/q/status:open+zaqar,n,z"},{"line_number":58,"context_line":".. _`Zaqar\u0027s Reviewer Guide`: https://wiki.openstack.org/wiki/Reviewer_Guide_%28Marconi%29"},{"line_number":59,"context_line":".. _`prefixes you can use`: https://wiki.openstack.org/wiki/Reviewer_Guide_%28Marconi%29#Use_Prefixes"},{"line_number":60,"context_line":".. _`Git Commit Messages`: https://wiki.openstack.org/wiki/GitCommitMessages"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_873ddadf","line":58,"updated":"2014-08-28 12:49:23.000000000","message":"https://wiki.openstack.org/wiki/Reviewer_Guide_%28Zaqar%29","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a8eabe0e7a23c53e03d17d65f6aca37d38f8fccc","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. _`Open Zaqar fixes`: https://review.openstack.org/#/q/status:open+zaqar,n,z"},{"line_number":58,"context_line":".. _`Zaqar\u0027s Reviewer Guide`: https://wiki.openstack.org/wiki/Reviewer_Guide_%28Marconi%29"},{"line_number":59,"context_line":".. _`prefixes you can use`: https://wiki.openstack.org/wiki/Reviewer_Guide_%28Marconi%29#Use_Prefixes"},{"line_number":60,"context_line":".. _`Git Commit Messages`: https://wiki.openstack.org/wiki/GitCommitMessages"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_10701e3f","line":58,"in_reply_to":"1abeadc6_873ddadf","updated":"2014-08-28 13:35:59.000000000","message":"https://wiki.openstack.org/wiki/Zaqar/Reviewer_guide","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"dbefae9b83792328c91066d39054d07c41e8292e","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. _`Open Zaqar fixes`: https://review.openstack.org/#/q/status:open+zaqar,n,z"},{"line_number":58,"context_line":".. _`Zaqar\u0027s Reviewer Guide`: https://wiki.openstack.org/wiki/Reviewer_Guide_%28Marconi%29"},{"line_number":59,"context_line":".. _`prefixes you can use`: https://wiki.openstack.org/wiki/Reviewer_Guide_%28Marconi%29#Use_Prefixes"},{"line_number":60,"context_line":".. _`Git Commit Messages`: https://wiki.openstack.org/wiki/GitCommitMessages"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_8714fa4d","line":59,"updated":"2014-08-28 12:49:23.000000000","message":"https://wiki.openstack.org/wiki/Reviewer_Guide_%28Zaqar%29#Use_Prefixes","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a8eabe0e7a23c53e03d17d65f6aca37d38f8fccc","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. _`Open Zaqar fixes`: https://review.openstack.org/#/q/status:open+zaqar,n,z"},{"line_number":58,"context_line":".. _`Zaqar\u0027s Reviewer Guide`: https://wiki.openstack.org/wiki/Reviewer_Guide_%28Marconi%29"},{"line_number":59,"context_line":".. _`prefixes you can use`: https://wiki.openstack.org/wiki/Reviewer_Guide_%28Marconi%29#Use_Prefixes"},{"line_number":60,"context_line":".. _`Git Commit Messages`: https://wiki.openstack.org/wiki/GitCommitMessages"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1abeadc6_f0a9e27c","line":59,"in_reply_to":"1abeadc6_8714fa4d","updated":"2014-08-28 13:35:59.000000000","message":"https://wiki.openstack.org/wiki/Zaqar/Reviewer_guide#Use_Prefixes","commit_id":"5066d7d397f29251cb5e0bb770b7d5538ea1340e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aaeb32260739967c23065bef2d4f958de6104764","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The review-id is the number in the URL (check the screenshot for more details)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Example:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   $ git review -d 92979"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1abeadc6_0e043a16","line":27,"updated":"2014-08-29 20:23:35.000000000","message":"Add another :","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"6f25a426d6a2445eb79db662f9e4514c639c3a52","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"The review-id is the number in the URL (check the screenshot for more details)."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Example:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"   $ git review -d 92979"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"fa98f980_7ec40c5f","line":27,"in_reply_to":"1abeadc6_0e043a16","updated":"2014-09-02 19:36:15.000000000","message":"Done","commit_id":"895540b760ad2df17ca8d7ec5f4b00c2462528d6"}]}
