)]}'
{"zaqar/queues/api/v1/response.py":[{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"fdc2ece47777cae2f170f99161cf7e36076720b6","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                                \u0027href\u0027: {"},{"line_number":159,"context_line":"                                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":160,"context_line":"                                    \u0027pattern\u0027: \u0027^/v1/\u0027"},{"line_number":161,"context_line":"                                    \u0027pools/[a-zA-Z0-9_-]{1,64}\\?\u0027"},{"line_number":162,"context_line":"                                }"},{"line_number":163,"context_line":"                            },"},{"line_number":164,"context_line":"                            \u0027required\u0027: [\u0027rel\u0027, \u0027href\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_407a25f2","line":161,"updated":"2014-09-24 01:44:02.000000000","message":"we\u0027d better add indent here","commit_id":"d67d89a95500d33054bd0b79ac5e159135345036"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"fdc2ece47777cae2f170f99161cf7e36076720b6","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                \u0027href\u0027: {"},{"line_number":174,"context_line":"                                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":175,"context_line":"                                    \u0027pattern\u0027: \u0027^/v1/\u0027"},{"line_number":176,"context_line":"                                    \u0027pools/[a-zA-Z0-9_-]{1,64}$\u0027"},{"line_number":177,"context_line":"                                },"},{"line_number":178,"context_line":"                                \u0027weight\u0027: {"},{"line_number":179,"context_line":"                                    \u0027type\u0027: \u0027number\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_20736116","line":176,"updated":"2014-09-24 01:44:02.000000000","message":"we\u0027d better add indent here","commit_id":"d67d89a95500d33054bd0b79ac5e159135345036"}],"zaqar/queues/api/v1_1/response.py":[{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"fdc2ece47777cae2f170f99161cf7e36076720b6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                                \u0027href\u0027: {"},{"line_number":178,"context_line":"                                    \u0027type\u0027: \u0027string\u0027,"},{"line_number":179,"context_line":"                                    \u0027pattern\u0027: \u0027^/v1\\.1/\u0027"},{"line_number":180,"context_line":"                                    \u0027pools/[a-zA-Z0-9_-]{1,64}\\?\u0027"},{"line_number":181,"context_line":"                                }"},{"line_number":182,"context_line":"                            },"},{"line_number":183,"context_line":"                            \u0027required\u0027: [\u0027rel\u0027, \u0027href\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_a0ecb190","line":180,"updated":"2014-09-24 01:44:02.000000000","message":"we\u0027d better add indent here","commit_id":"d67d89a95500d33054bd0b79ac5e159135345036"}],"zaqar/queues/storage/pooling.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"537b5528d0f7af10ef055e0bb5203fe613621aa1","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self._pool_catalog \u003d Catalog(conf, cache, control)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def is_alive(self):"},{"line_number":75,"context_line":"        cursor \u003d self._pool_catalog._pools_ctrl.list(limit\u003d0)"},{"line_number":76,"context_line":"        pools \u003d next(cursor)"},{"line_number":77,"context_line":"        return all(self._pool_catalog.get_driver(pool[\u0027name\u0027]).is_alive()"},{"line_number":78,"context_line":"                   for pool in pools)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_14f1ad94","line":75,"updated":"2014-10-08 17:35:37.000000000","message":"DSQ: Is limit\u003d0 part of the contract for all drivers, meaning if set to 0 they should return all pools (no paging)? If so, we will need a way of testing/verifying/ensuring all drivers behave the same way.\n\nIf some drivers do not support getting \"all\" pools at once, the is_alive call will need to call .list multiple times until no more results are returned.","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7cd01399e9102f2c34aa0e02ac1d9975c560c165","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self._pool_catalog \u003d Catalog(conf, cache, control)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def is_alive(self):"},{"line_number":75,"context_line":"        cursor \u003d self._pool_catalog._pools_ctrl.list(limit\u003d0)"},{"line_number":76,"context_line":"        pools \u003d next(cursor)"},{"line_number":77,"context_line":"        return all(self._pool_catalog.get_driver(pool[\u0027name\u0027]).is_alive()"},{"line_number":78,"context_line":"                   for pool in pools)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_da22e7b7","line":75,"in_reply_to":"baa201ad_14f1ad94","updated":"2014-10-08 23:44:34.000000000","message":"limit\u003d0 is wired. I prefer to call the .list multiple time. And I will make the change.","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"537b5528d0f7af10ef055e0bb5203fe613621aa1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # reachable or not"},{"line_number":84,"context_line":"        KPI[\u0027catalog_reachable\u0027] \u003d self.is_alive()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        cursor \u003d self._pool_catalog._pools_ctrl.list()"},{"line_number":87,"context_line":"        # Messages of each pool"},{"line_number":88,"context_line":"        for pool in next(cursor):"},{"line_number":89,"context_line":"            driver \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_74311959","line":86,"updated":"2014-10-08 17:35:37.000000000","message":"BUG: Same issue as above.","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"537b5528d0f7af10ef055e0bb5203fe613621aa1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return KPI"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def gc(self):"},{"line_number":95,"context_line":"        cursor \u003d self._pool_catalog._pools_ctrl.list()"},{"line_number":96,"context_line":"        for pool in next(cursor):"},{"line_number":97,"context_line":"            driver \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])"},{"line_number":98,"context_line":"            driver.gc()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_f43c2931","line":95,"updated":"2014-10-08 17:35:37.000000000","message":"Same issue as above.","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"537b5528d0f7af10ef055e0bb5203fe613621aa1","unresolved":false,"context_lines":[{"line_number":161,"context_line":"             limit\u003dstorage.DEFAULT_QUEUES_PER_PAGE, detailed\u003dFalse):"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        def all_pages():"},{"line_number":164,"context_line":"            cursor \u003d self._pool_catalog._pools_ctrl.list(limit\u003d0)"},{"line_number":165,"context_line":"            for pool in next(cursor):"},{"line_number":166,"context_line":"                yield next(self._pool_catalog.get_driver(pool[\u0027name\u0027])"},{"line_number":167,"context_line":"                           .queue_controller.list("}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_344311b0","line":164,"updated":"2014-10-08 17:35:37.000000000","message":"Same issue as above.","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"511ef14a52ba5b1651b5b0f172669fdc5aca3d13","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # reachable or not"},{"line_number":84,"context_line":"        KPI[\u0027catalog_reachable\u0027] \u003d self.is_alive()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        cursor \u003d self._pool_catalog._pools_ctrl.list()"},{"line_number":87,"context_line":"        # Messages of each pool"},{"line_number":88,"context_line":"        for pool in next(cursor):"},{"line_number":89,"context_line":"            driver \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_a65c17ef","line":86,"updated":"2014-10-09 18:04:57.000000000","message":"BUG: In the mongo driver, limit defaults to 10. Therefore, this health check will only collect stats for the first 10 pools.","commit_id":"030375fcc8600c1d26535540c3ae2a61c4cffa9f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c0cc934d8b7ecd93e208f41c279dacf1a2d9c151","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # reachable or not"},{"line_number":84,"context_line":"        KPI[\u0027catalog_reachable\u0027] \u003d self.is_alive()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        cursor \u003d self._pool_catalog._pools_ctrl.list()"},{"line_number":87,"context_line":"        # Messages of each pool"},{"line_number":88,"context_line":"        for pool in next(cursor):"},{"line_number":89,"context_line":"            driver \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_967bba7a","line":86,"in_reply_to":"baa201ad_a65c17ef","updated":"2014-10-09 23:53:19.000000000","message":"Done","commit_id":"030375fcc8600c1d26535540c3ae2a61c4cffa9f"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"511ef14a52ba5b1651b5b0f172669fdc5aca3d13","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return KPI"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def gc(self):"},{"line_number":95,"context_line":"        cursor \u003d self._pool_catalog._pools_ctrl.list()"},{"line_number":96,"context_line":"        for pool in next(cursor):"},{"line_number":97,"context_line":"            driver \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])"},{"line_number":98,"context_line":"            driver.gc()"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_c6703b76","line":95,"updated":"2014-10-09 18:04:57.000000000","message":"BUG: Same as above.","commit_id":"030375fcc8600c1d26535540c3ae2a61c4cffa9f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c0cc934d8b7ecd93e208f41c279dacf1a2d9c151","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return KPI"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def gc(self):"},{"line_number":95,"context_line":"        cursor \u003d self._pool_catalog._pools_ctrl.list()"},{"line_number":96,"context_line":"        for pool in next(cursor):"},{"line_number":97,"context_line":"            driver \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])"},{"line_number":98,"context_line":"            driver.gc()"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_b680be47","line":95,"in_reply_to":"baa201ad_c6703b76","updated":"2014-10-09 23:53:19.000000000","message":"Done","commit_id":"030375fcc8600c1d26535540c3ae2a61c4cffa9f"}],"zaqar/queues/storage/sqlalchemy/pools.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"511ef14a52ba5b1651b5b0f172669fdc5aca3d13","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        stmt \u003d sa.sql.select([tables.Pools]).where("},{"line_number":51,"context_line":"            tables.Pools.c.name \u003e marker"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        if limit \u003e 0:"},{"line_number":54,"context_line":"            stmt \u003d stmt.limit(limit)"},{"line_number":55,"context_line":"        cursor \u003d self._conn.execute(stmt)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_504ec197","line":53,"updated":"2014-10-09 18:04:57.000000000","message":"NOTE: I see here that setting limit to 0 will result in \"no limit\". However, I don\u0027t see the same check in the mongo driver...","commit_id":"030375fcc8600c1d26535540c3ae2a61c4cffa9f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c0cc934d8b7ecd93e208f41c279dacf1a2d9c151","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        stmt \u003d sa.sql.select([tables.Pools]).where("},{"line_number":51,"context_line":"            tables.Pools.c.name \u003e marker"},{"line_number":52,"context_line":"        )"},{"line_number":53,"context_line":"        if limit \u003e 0:"},{"line_number":54,"context_line":"            stmt \u003d stmt.limit(limit)"},{"line_number":55,"context_line":"        cursor \u003d self._conn.execute(stmt)"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_d6db827b","line":53,"in_reply_to":"baa201ad_504ec197","updated":"2014-10-09 23:53:19.000000000","message":"In the pymongo doc[1], when the limit\u003d0(default) it will return all the results. So it works without any check now.\n\n[1] http://api.mongodb.org/python/current/api/pymongo/collection.html#pymongo.collection.Collection.find","commit_id":"030375fcc8600c1d26535540c3ae2a61c4cffa9f"}],"zaqar/queues/transport/wsgi/v1_0/pools.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"537b5528d0f7af10ef055e0bb5203fe613621aa1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        ]"},{"line_number":98,"context_line":"        for entry in pools:"},{"line_number":99,"context_line":"            entry[\u0027href\u0027] \u003d request.path + \u0027/\u0027 + entry.pop(\u0027name\u0027)"},{"line_number":100,"context_line":"        results[\u0027pools\u0027] \u003d pools"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        response.content_location \u003d request.relative_uri"},{"line_number":103,"context_line":"        response.body \u003d transport_utils.to_json(results)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_94591d90","line":100,"updated":"2014-10-08 17:35:37.000000000","message":"NIT/STYLE: This section of the code could use a blank line (between L99 and L100) to make it more visually distinct. Another blank line before L98 would also aid in readability.","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7cd01399e9102f2c34aa0e02ac1d9975c560c165","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        ]"},{"line_number":98,"context_line":"        for entry in pools:"},{"line_number":99,"context_line":"            entry[\u0027href\u0027] \u003d request.path + \u0027/\u0027 + entry.pop(\u0027name\u0027)"},{"line_number":100,"context_line":"        results[\u0027pools\u0027] \u003d pools"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        response.content_location \u003d request.relative_uri"},{"line_number":103,"context_line":"        response.body \u003d transport_utils.to_json(results)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_4f347bfb","line":100,"in_reply_to":"baa201ad_94591d90","updated":"2014-10-08 23:44:34.000000000","message":"Done","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"}],"zaqar/queues/transport/wsgi/v1_1/pools.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"537b5528d0f7af10ef055e0bb5203fe613621aa1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        ]"},{"line_number":100,"context_line":"        for entry in pools:"},{"line_number":101,"context_line":"            entry[\u0027href\u0027] \u003d request.path + \u0027/\u0027 + entry.pop(\u0027name\u0027)"},{"line_number":102,"context_line":"        results[\u0027pools\u0027] \u003d pools"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        response.content_location \u003d request.relative_uri"},{"line_number":105,"context_line":"        response.body \u003d transport_utils.to_json(results)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_f4518962","line":102,"updated":"2014-10-08 17:35:37.000000000","message":"NIT/STYLE: Same comment as for v1_0/pools.py","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7cd01399e9102f2c34aa0e02ac1d9975c560c165","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        ]"},{"line_number":100,"context_line":"        for entry in pools:"},{"line_number":101,"context_line":"            entry[\u0027href\u0027] \u003d request.path + \u0027/\u0027 + entry.pop(\u0027name\u0027)"},{"line_number":102,"context_line":"        results[\u0027pools\u0027] \u003d pools"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        response.content_location \u003d request.relative_uri"},{"line_number":105,"context_line":"        response.body \u003d transport_utils.to_json(results)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_8f3ae3e4","line":102,"in_reply_to":"baa201ad_f4518962","updated":"2014-10-08 23:44:34.000000000","message":"Done","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"}],"zaqar/tests/queues/storage/base.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"511ef14a52ba5b1651b5b0f172669fdc5aca3d13","unresolved":false,"context_lines":[{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"            return n, w, u"},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"        res \u003d list(next(self.pools_controller.list()))"},{"line_number":1026,"context_line":"        self.assertEqual(len(res), 10)"},{"line_number":1027,"context_line":"        for entry in res:"},{"line_number":1028,"context_line":"            n, w, u \u003d _pool(entry[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"baa201ad_9002e96d","line":1025,"updated":"2014-10-09 18:04:57.000000000","message":"TEST: Please also verify that the marker is yielded","commit_id":"030375fcc8600c1d26535540c3ae2a61c4cffa9f"}],"zaqar/tests/queues/transport/wsgi/v1_1/test_pools.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"537b5528d0f7af10ef055e0bb5203fe613621aa1","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                 min(limit, count-limit))"},{"line_number":278,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_204)"},{"line_number":281,"context_line":"                self.assertTrue(len(next_result) \u003d\u003d 0)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"            self.assertEqual(len(pool_list), min(limit, count))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_d48ba5c0","line":280,"updated":"2014-10-08 17:35:37.000000000","message":"DQS. Something to discuss with Flavio, but to be consistent with other parts of the API, it seems like the response should be 200 OK with an empty list for \"pools\".\n\nDOC: The spec needs to be updated to reflect this (https://wiki.openstack.org/wiki/Zaqar/specs/api/v1.1#List_Pools)","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"95f12b4a4e2ab52f5365447dde046b71d9cd46d2","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                 min(limit, count-limit))"},{"line_number":278,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_204)"},{"line_number":281,"context_line":"                self.assertTrue(len(next_result) \u003d\u003d 0)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"            self.assertEqual(len(pool_list), min(limit, count))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_fc1320fe","line":280,"in_reply_to":"baa201ad_2166632a","updated":"2014-10-09 08:13:54.000000000","message":"I think it needs to be consistent with what we do for queues:\n\nhttps://wiki.openstack.org/wiki/Zaqar/specs/api/v1.1#List_Queues","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"54ad4887fa41e4083f57eb81fcb2b90af5d78889","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                 min(limit, count-limit))"},{"line_number":278,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_204)"},{"line_number":281,"context_line":"                self.assertTrue(len(next_result) \u003d\u003d 0)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"            self.assertEqual(len(pool_list), min(limit, count))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_2166632a","line":280,"in_reply_to":"baa201ad_4131a758","updated":"2014-10-09 07:53:49.000000000","message":"So all the list response(including message, queue, flavor) will be return 200 rather than 204. Right?\n\nThen what\u0027s the response will be like?\n\nJust pools property or both pools and links?\n\n    {\n        pools: [],\n        links: []\n    }\n\nor \n\n    {\n        pools: []\n    }","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"7cd01399e9102f2c34aa0e02ac1d9975c560c165","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                 min(limit, count-limit))"},{"line_number":278,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_204)"},{"line_number":281,"context_line":"                self.assertTrue(len(next_result) \u003d\u003d 0)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"            self.assertEqual(len(pool_list), min(limit, count))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_fa608bd0","line":280,"in_reply_to":"baa201ad_d48ba5c0","updated":"2014-10-08 23:44:34.000000000","message":"I will change the pool list response to meet the expectation.\n\nThe Doc will be updated after this patch is merged.\n\nbtw, what means by DQS. What is it short for?","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"1f5b1e90a4764a120bdab8d7877b3914dd5f17a5","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                                 min(limit, count-limit))"},{"line_number":278,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":279,"context_line":"            else:"},{"line_number":280,"context_line":"                self.assertEqual(self.srmock.status, falcon.HTTP_204)"},{"line_number":281,"context_line":"                self.assertTrue(len(next_result) \u003d\u003d 0)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"            self.assertEqual(len(pool_list), min(limit, count))"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_4131a758","line":280,"in_reply_to":"baa201ad_fa608bd0","updated":"2014-10-09 07:46:01.000000000","message":"I agree with Kurt w.r.t to the returned code. I think it should be 200 to be consistent.\n\n@Jefrrey `DSQ` is just an acronym we use to specify the comment is meant to open a discussion and it\u0027s not necessarily referring to something that is wrong with the patch. \n\nhttps://wiki.openstack.org/wiki/Zaqar/Reviewer_guide#Use_Prefixes","commit_id":"108d897d22c6bb8f3b7a0e83e7cff1d5971ca8dd"}]}