)]}'
{"zaqar/queues/api/v1_1/response.py":[{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"da55d47427e7cba6fe559bfbdd9abad722a8104b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                    \u0027type\u0027: \u0027string\u0027"},{"line_number":185,"context_line":"                                },"},{"line_number":186,"context_line":"                                \u0027group\u0027: {"},{"line_number":187,"context_line":"                                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]"},{"line_number":188,"context_line":"                                },"},{"line_number":189,"context_line":"                                \u0027options\u0027: {"},{"line_number":190,"context_line":"                                    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_a844e174","line":187,"updated":"2014-09-29 16:29:50.000000000","message":"Q: as far as i understand, if there is no group it defaults to returning None? Maybe then there is a point to make \u0027group\u0027 the required property?\n\nOr there are situations, when it will not include `group` in the response?","commit_id":"0dba961ba7951a4d6831eaa670464e3b972d7564"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ba3cf4c67c42c6f2cf6aaea64dc0efcc0fe425ba","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                                    \u0027type\u0027: \u0027string\u0027"},{"line_number":185,"context_line":"                                },"},{"line_number":186,"context_line":"                                \u0027group\u0027: {"},{"line_number":187,"context_line":"                                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027]"},{"line_number":188,"context_line":"                                },"},{"line_number":189,"context_line":"                                \u0027options\u0027: {"},{"line_number":190,"context_line":"                                    \u0027type\u0027: \u0027object\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ebf4f5d0","line":187,"in_reply_to":"baa201ad_a844e174","updated":"2014-10-01 08:34:07.000000000","message":"Done","commit_id":"0dba961ba7951a4d6831eaa670464e3b972d7564"}],"zaqar/queues/storage/mongodb/flavors.py":[{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"da55d47427e7cba6fe559bfbdd9abad722a8104b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    @utils.raises_conn_error"},{"line_number":95,"context_line":"    def create(self, name, pool, project\u003dNone, capabilities\u003dNone):"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # NOTE(flaper87): It\u0027s faster to call exists and raise an"},{"line_number":98,"context_line":"        # error than calling get and letting the controller raise"},{"line_number":99,"context_line":"        # the exception."},{"line_number":100,"context_line":"        if not list(self._pools_ctrl.get_group(pool)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_8bd8f754","line":97,"updated":"2014-09-29 16:29:50.000000000","message":"the comment is not very precise now, since we are not calling `exists` anymore.","commit_id":"0dba961ba7951a4d6831eaa670464e3b972d7564"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"4b1955e496c1615f215d6994c6be2e4d2bdd85bf","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    @utils.raises_conn_error"},{"line_number":95,"context_line":"    def create(self, name, pool, project\u003dNone, capabilities\u003dNone):"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # NOTE(flaper87): Check if there\u0027re are pools in this group."},{"line_number":98,"context_line":"        # Should there be a `group_exists` method?"},{"line_number":99,"context_line":"        if not list(self._pools_ctrl.get_group(pool)):"},{"line_number":100,"context_line":"            raise errors.PoolDoesNotExist(pool)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_da1d2b68","line":97,"updated":"2014-10-01 17:28:43.000000000","message":"\"there\u0027re are\" \u003d\u003d\u003e \"there are\"","commit_id":"7ff88fdeffacfa6a391f4fd92456d568051d9416"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fad44785837b09891e86580be2aa59111861eda1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    @utils.raises_conn_error"},{"line_number":95,"context_line":"    def create(self, name, pool, project\u003dNone, capabilities\u003dNone):"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        # NOTE(flaper87): Check if there\u0027re are pools in this group."},{"line_number":98,"context_line":"        # Should there be a `group_exists` method?"},{"line_number":99,"context_line":"        if not list(self._pools_ctrl.get_group(pool)):"},{"line_number":100,"context_line":"            raise errors.PoolDoesNotExist(pool)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_35139db9","line":97,"in_reply_to":"baa201ad_da1d2b68","updated":"2014-10-02 06:37:41.000000000","message":"Done","commit_id":"7ff88fdeffacfa6a391f4fd92456d568051d9416"}],"zaqar/queues/storage/mongodb/pools.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"4b1955e496c1615f215d6994c6be2e4d2bdd85bf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            flavor_ctl \u003d self.driver.flavors_controller"},{"line_number":121,"context_line":"            res \u003d list(flavor_ctl._list_by_pool(pool[\u0027group\u0027]))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            # NOTE(flaper87): If this is the last pool in the"},{"line_number":124,"context_line":"            # group and it\u0027s being used by a flavor, don\u0027t allow"},{"line_number":125,"context_line":"            # it to be deleted."},{"line_number":126,"context_line":"            if res and len(pools_group) \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_f45e8544","line":123,"updated":"2014-10-01 17:28:43.000000000","message":"Q. Do you mean \"only\" instead of \"last\"?","commit_id":"7ff88fdeffacfa6a391f4fd92456d568051d9416"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fad44785837b09891e86580be2aa59111861eda1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            flavor_ctl \u003d self.driver.flavors_controller"},{"line_number":121,"context_line":"            res \u003d list(flavor_ctl._list_by_pool(pool[\u0027group\u0027]))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"            # NOTE(flaper87): If this is the last pool in the"},{"line_number":124,"context_line":"            # group and it\u0027s being used by a flavor, don\u0027t allow"},{"line_number":125,"context_line":"            # it to be deleted."},{"line_number":126,"context_line":"            if res and len(pools_group) \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_d5f3319d","line":123,"in_reply_to":"baa201ad_f45e8544","updated":"2014-10-02 06:37:41.000000000","message":"Done","commit_id":"7ff88fdeffacfa6a391f4fd92456d568051d9416"}],"zaqar/queues/storage/pooling.py":[{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"da55d47427e7cba6fe559bfbdd9abad722a8104b","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                # option in the future."},{"line_number":457,"context_line":"                pools \u003d self._pools_ctrl.get_group(detailed\u003dTrue)"},{"line_number":458,"context_line":"                pool \u003d select.weighted(pools)"},{"line_number":459,"context_line":"                pool \u003d pool and pool[\u0027name\u0027] or None"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"                if not pool:"},{"line_number":462,"context_line":"                    raise errors.NoPoolFound()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_4bbb6f0e","line":459,"updated":"2014-09-29 16:29:50.000000000","message":"DRY: last two lines is identical in both branches. Maybe it is better to extract them from the if?","commit_id":"0dba961ba7951a4d6831eaa670464e3b972d7564"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ba3cf4c67c42c6f2cf6aaea64dc0efcc0fe425ba","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                # option in the future."},{"line_number":457,"context_line":"                pools \u003d self._pools_ctrl.get_group(detailed\u003dTrue)"},{"line_number":458,"context_line":"                pool \u003d select.weighted(pools)"},{"line_number":459,"context_line":"                pool \u003d pool and pool[\u0027name\u0027] or None"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"                if not pool:"},{"line_number":462,"context_line":"                    raise errors.NoPoolFound()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ab5cadee","line":459,"in_reply_to":"baa201ad_4bbb6f0e","updated":"2014-10-01 08:34:07.000000000","message":"I didn\u0027t do it because of the `if` in L460. We could have a closure that does this filtering but it doesn\u0027t seem worth it. We could also move the `if` outside and add an `if flavor is None` check but it doesn\u0027t seem worth it either.","commit_id":"0dba961ba7951a4d6831eaa670464e3b972d7564"}],"zaqar/queues/transport/wsgi/v1_1/pools.py":[{"author":{"_account_id":10777,"name":"Nataliia Uvarova","email":"grafinya.uvarova@gmail.com","username":"AAzza"},"change_message_id":"da55d47427e7cba6fe559bfbdd9abad722a8104b","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def on_patch(self, request, response, project_id, pool):"},{"line_number":190,"context_line":"        \"\"\"Allows one to update a pool\u0027s weight, uri, and/or options."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        This method expects the user to submit a JSON object"},{"line_number":193,"context_line":"        containing at least one of: \u0027uri\u0027, \u0027weight\u0027, \u0027options\u0027. If"},{"line_number":194,"context_line":"        none are found, the request is flagged as bad. There is also"},{"line_number":195,"context_line":"        strict format checking through the use of"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_6b74b39c","line":192,"updated":"2014-09-29 16:29:50.000000000","message":"This doc should be updated.","commit_id":"0dba961ba7951a4d6831eaa670464e3b972d7564"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ba3cf4c67c42c6f2cf6aaea64dc0efcc0fe425ba","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    def on_patch(self, request, response, project_id, pool):"},{"line_number":190,"context_line":"        \"\"\"Allows one to update a pool\u0027s weight, uri, and/or options."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"        This method expects the user to submit a JSON object"},{"line_number":193,"context_line":"        containing at least one of: \u0027uri\u0027, \u0027weight\u0027, \u0027options\u0027. If"},{"line_number":194,"context_line":"        none are found, the request is flagged as bad. There is also"},{"line_number":195,"context_line":"        strict format checking through the use of"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_6b30059f","line":192,"in_reply_to":"baa201ad_6b74b39c","updated":"2014-10-01 08:34:07.000000000","message":"Done","commit_id":"0dba961ba7951a4d6831eaa670464e3b972d7564"}]}
