)]}'
{"zaqar/queues/storage/sqlalchemy/queues.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4757ebea379066040e79b1b7a5f7f45bda548eaf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                       {\u0027name\u0027: rec[0], \u0027metadata\u0027: utils.json_decode(rec[1])})"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        yield it()"},{"line_number":56,"context_line":"        yield marker_name and marker_name[\u0027next\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_metadata(self, name, project):"},{"line_number":59,"context_line":"        if project is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_b75b7152","line":56,"updated":"2014-10-09 09:27:57.000000000","message":"The same with wsgi/v1_1/queues.py comments. Yield {} when there is no queue is reasonable?","commit_id":"665279416827ae6d6677e3fd7c96c89f085bcaed"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"cd4b038de6173ddb285cb52f0be89370a057e72b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                       {\u0027name\u0027: rec[0], \u0027metadata\u0027: utils.json_decode(rec[1])})"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        yield it()"},{"line_number":56,"context_line":"        yield marker_name and marker_name[\u0027next\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_metadata(self, name, project):"},{"line_number":59,"context_line":"        if project is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_1f4c4f76","line":56,"updated":"2014-10-09 13:38:48.000000000","message":"Actually, I don\u0027t like the syntactic sugar here. It is meaningless to yield a empty dict ( {} ) when there are no queues. Returning None is better.\n\nI suggest to yield the origin marker when possible. Something like below\n\n    marker_name \u003d {\"next\": marker}\n    ...\n    yield it()\n    yield marker_name[\u0027next\u0027]\n\nWhen marker(param) is None, it yield None\nWhen marker(param) is not None and queue list is empty, it yield the request marker param value\nWhen marker(param) is not None and queue list is not empty, it yield the last queue\u0027s name in the queue list.\n\nIn this way, we can also define the list() convention like above. \n \nReasonable?","commit_id":"8116f693b15e1282a98190549517ac3d5c6a9556"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b91b62dcea3ba3b2f55c51c3102cdd65f04b39b9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                       {\u0027name\u0027: rec[0], \u0027metadata\u0027: utils.json_decode(rec[1])})"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        yield it()"},{"line_number":56,"context_line":"        yield marker_name and marker_name[\u0027next\u0027]"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_metadata(self, name, project):"},{"line_number":59,"context_line":"        if project is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_6a575bcb","line":56,"in_reply_to":"baa201ad_1f4c4f76","updated":"2014-10-09 14:08:26.000000000","message":"I really don\u0027t mind it as is, the dict has already been instantiated and it also evaluates to false. I\u0027d prefer keeping it as-is because we need to get this merged before RC2","commit_id":"8116f693b15e1282a98190549517ac3d5c6a9556"}],"zaqar/queues/transport/wsgi/v1_1/queues.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4757ebea379066040e79b1b7a5f7f45bda548eaf","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        queues \u003d list(next(results))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # Got some. Prepare the response."},{"line_number":148,"context_line":"        kwargs[\u0027marker\u0027] \u003d next(results)"},{"line_number":149,"context_line":"        for each_queue in queues:"},{"line_number":150,"context_line":"            each_queue[\u0027href\u0027] \u003d req.path + \u0027/\u0027 + each_queue[\u0027name\u0027]"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_d77f15a9","line":148,"updated":"2014-10-09 09:27:57.000000000","message":"When the queues is empty, `next(results)` here will return {}. It is reasonable? I think the href will be like `?markder\u003d{}\u0026limit\u003d1`\n\nI\u0027d like the use/return the original maker value(from the request).","commit_id":"665279416827ae6d6677e3fd7c96c89f085bcaed"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"562473c7b86e1a965def6e19ca817ee127acc780","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        queues \u003d list(next(results))"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        # Got some. Prepare the response."},{"line_number":148,"context_line":"        kwargs[\u0027marker\u0027] \u003d next(results)"},{"line_number":149,"context_line":"        for each_queue in queues:"},{"line_number":150,"context_line":"            each_queue[\u0027href\u0027] \u003d req.path + \u0027/\u0027 + each_queue[\u0027name\u0027]"},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_f3498ab8","line":148,"in_reply_to":"baa201ad_d77f15a9","updated":"2014-10-09 11:40:12.000000000","message":"No, returning `{}` is definitely not good :(\n\n+1 for returning the original marker, let me do that!","commit_id":"665279416827ae6d6677e3fd7c96c89f085bcaed"}],"zaqar/tests/queues/transport/wsgi/v1_1/test_queue_lifecycle.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"aea17755f52d51b081a93bf21a5b75e34cc9607f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        link \u003d results[\u0027links\u0027][0]"},{"line_number":253,"context_line":"        self.assertEqual(\u0027next\u0027, link[\u0027rel\u0027])"},{"line_number":254,"context_line":"        href \u003d falcon.uri.parse_query_string(link[\u0027href\u0027])"},{"line_number":255,"context_line":"        self.assertNotIn(\u0027marker\u0027, href)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        # Payload exceeded"},{"line_number":258,"context_line":"        self.simulate_get(self.queue_path, headers\u003dheader,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_ba00ae36","line":255,"updated":"2014-10-09 15:44:03.000000000","message":"TEST: Please also check that results[\u0027queues\u0027] \u003d\u003d []","commit_id":"8116f693b15e1282a98190549517ac3d5c6a9556"}]}