)]}'
{"zaqar/common/transport/wsgi/helpers.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"20de906d9cbc045307619ef78f305c590cbc2a4b","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def process_request_id(req, resp, params):"},{"line_number":162,"context_line":"    request_id \u003d b\u0027req-\u0027 + str(uuid.uuid4()).encode(\u0027ascii\u0027)"},{"line_number":163,"context_line":"    p \u003d {}"},{"line_number":164,"context_line":"    p[\u0027req_id\u0027] \u003d request_id"},{"line_number":165,"context_line":"    p[\u0027req_method\u0027] \u003d req.method"},{"line_number":166,"context_line":"    p[\u0027req_uri\u0027] \u003d req.relative_uri"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_3f45da42","line":163,"updated":"2014-10-16 22:33:54.000000000","message":"NIT/IMHO: This is slightly more elegant, but really not a big deal (personal preference):\n\n    p \u003d {\n        \u0027req_id\u0027: request_id,\n        \u0027req_method\u0027: req.method,\n        \u0027req_uri\u0027: req.relative_uri,\n    }\n\nSTYLE: Regardless of the above, please avoid the use of single-character variable names (as noted in HACKING)","commit_id":"1258aa617463b2057d3290cfa64103a47b646965"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"20de906d9cbc045307619ef78f305c590cbc2a4b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    p[\u0027req_id\u0027] \u003d request_id"},{"line_number":165,"context_line":"    p[\u0027req_method\u0027] \u003d req.method"},{"line_number":166,"context_line":"    p[\u0027req_uri\u0027] \u003d req.relative_uri"},{"line_number":167,"context_line":"    LOG.debug(_(u\u0027{req_id} \u003e\u003e {req_method} {req_uri}\u0027).format(**p))"},{"line_number":168,"context_line":"    req.env[ENV_REQUEST_ID] \u003d request_id"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_7f884271","line":167,"updated":"2014-10-16 22:33:54.000000000","message":"Q. Is the format of this logline similar to what is used in other projects? I was just thinking it would be good to use something that operators are already familiar with...","commit_id":"1258aa617463b2057d3290cfa64103a47b646965"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"20de906d9cbc045307619ef78f305c590cbc2a4b","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"def process_response_id(req, resp):"},{"line_number":172,"context_line":"    resp.set_header(HTTP_RESP_HEADER_REQUEST_ID, req.env[ENV_REQUEST_ID])"},{"line_number":173,"context_line":"    p \u003d {}"},{"line_number":174,"context_line":"    p[\u0027req_id\u0027] \u003d req.env[ENV_REQUEST_ID]"},{"line_number":175,"context_line":"    p[\u0027resp_status\u0027] \u003d resp.status"},{"line_number":176,"context_line":"    LOG.debug(_(u\u0027{req_id} \u003c\u003c {resp_status}\u0027).format(**p))"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_bfa70a0a","line":173,"updated":"2014-10-16 22:33:54.000000000","message":"See above comment","commit_id":"1258aa617463b2057d3290cfa64103a47b646965"}],"zaqar/tests/functional/http.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f490dea6cd0d7a8e6a7825ab66bfff43591167b0","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        resp \u003d ResponseMock(srmock, wsgi_result)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if resp.ok:"},{"line_number":181,"context_line":"            assert resp.headers[\u0027x-openstack-request-id\u0027] is not None"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        return resp"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_173de68f","line":181,"updated":"2014-10-21 07:22:54.000000000","message":"I don\u0027t think this is enough. When the server raised 500, the request-id should also exist.","commit_id":"f6e479aeeb73415c677bb6d47a66dcafb6f3bb14"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"0aa12b6ff00a4e3f0d2bad6b0ce2ed38d785e703","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        resp \u003d ResponseMock(srmock, wsgi_result)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if resp.ok:"},{"line_number":181,"context_line":"            assert resp.headers[\u0027x-openstack-request-id\u0027] is not None"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        return resp"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_e27241e2","line":181,"in_reply_to":"9aa7fdbe_173de68f","updated":"2014-10-22 05:47:56.000000000","message":"currently,  I am using the generic way to deal with the request-id which Falcon\u0027s before/after hook,  and if the responder raises some exceptions ,then the after hook will not be executed, so there will be no request-id header.","commit_id":"f6e479aeeb73415c677bb6d47a66dcafb6f3bb14"}]}