)]}'
{"zaqar/storage/mongodb/subscriptions.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"78d308904e357fca063d624f058dda89748c2804","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                                                \u0027_id\u0027: 0})"},{"line_number":99,"context_line":"        if target_source is None:"},{"line_number":100,"context_line":"            raise errors.QueueDoesNotExist(target_source, project)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            subscription_id \u003d self._collection.insert({\u0027s\u0027: source,"},{"line_number":104,"context_line":"                                                       \u0027u\u0027: subscriber,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_33db011d","side":"PARENT","line":101,"updated":"2015-01-28 12:36:54.000000000","message":"mind reverting this change to avoid silly conflicts?","commit_id":"1b694eb485b8e7cf10502677f582fed970f7e71f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"478e611a0e828664b15a6d15e1bedea606c7ab98","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                                                \u0027_id\u0027: 0})"},{"line_number":99,"context_line":"        if target_source is None:"},{"line_number":100,"context_line":"            raise errors.QueueDoesNotExist(target_source, project)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        try:"},{"line_number":103,"context_line":"            subscription_id \u003d self._collection.insert({\u0027s\u0027: source,"},{"line_number":104,"context_line":"                                                       \u0027u\u0027: subscriber,"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_ca262a16","side":"PARENT","line":101,"in_reply_to":"fa81d914_33db011d","updated":"2015-01-30 03:05:17.000000000","message":"Done","commit_id":"1b694eb485b8e7cf10502677f582fed970f7e71f"}],"zaqar/storage/pooling.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"78d308904e357fca063d624f058dda89748c2804","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    def create(self, queue, subscriber, ttl, options, project\u003dNone):"},{"line_number":375,"context_line":"        control \u003d self._get_controller(queue, project)"},{"line_number":376,"context_line":"        if control:"},{"line_number":377,"context_line":"            return control.create(queue, subscriber,"},{"line_number":378,"context_line":"                                  ttl, options,"},{"line_number":379,"context_line":"                                  project\u003dproject)"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_d3038571","line":377,"updated":"2015-01-28 12:36:54.000000000","message":"OMG! Why wasn\u0027t this caught by the test suite?","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"478e611a0e828664b15a6d15e1bedea606c7ab98","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    def create(self, queue, subscriber, ttl, options, project\u003dNone):"},{"line_number":375,"context_line":"        control \u003d self._get_controller(queue, project)"},{"line_number":376,"context_line":"        if control:"},{"line_number":377,"context_line":"            return control.create(queue, subscriber,"},{"line_number":378,"context_line":"                                  ttl, options,"},{"line_number":379,"context_line":"                                  project\u003dproject)"},{"line_number":380,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_e0f4edd0","line":377,"in_reply_to":"fa81d914_d3038571","updated":"2015-01-30 03:05:17.000000000","message":"Because by default we don\u0027t test pooled config, unless adding a new test file under https://github.com/openstack/zaqar/tree/master/tests/unit/storage. pls correct me if i missed anything.","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"}],"zaqar/tests/unit/transport/wsgi/v2_0/test_subscriptions.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"19ee742f22d4376e2d320406aabfa3a30c45eb99","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        if marker:"},{"line_number":133,"context_line":"            query +\u003d \u0027\u0026marker\u003d{1}\u0027.format(marker)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        resp \u003d self.simulate_get(query, headers\u003dself.headers)"},{"line_number":136,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"        resp_doc \u003d jsonutils.loads(resp[0])"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_32e35a06","line":135,"updated":"2015-01-15 14:24:34.000000000","message":"In this mocked tests, we use `query_string\u003d\u0027limit\u003d10\u0027` to pass query strings to the wsgi call. This is the reason why the test currently doesn\u0027t work if you pass `?limit\u003d..`","commit_id":"da216b6551e241638f05fd0025bdb30caf0cb9fd"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"78d308904e357fca063d624f058dda89748c2804","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        if self.conf.pooling:"},{"line_number":32,"context_line":"            for i in range(2):"},{"line_number":33,"context_line":"                uri \u003d self.conf[\u0027drivers:management_store:mongodb\u0027].uri"},{"line_number":34,"context_line":"                doc \u003d {\u0027weight\u0027: 100, \u0027uri\u0027: uri}"},{"line_number":35,"context_line":"                self.simulate_put(self.url_prefix + \u0027/pools/\u0027 + str(i),"},{"line_number":36,"context_line":"                                  body\u003djsonutils.dumps(doc))"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_d3a46559","line":33,"updated":"2015-01-28 12:36:54.000000000","message":"mmh, this basically means we\u0027re not checking if an connection URI already exists in the databse... mmh.. this sounds bad :/\n\nCould you please file a bug for the above and avoid using the same URL twice here?\n\nAlso, this should be a base test for subscriptions, mind removing the mongodb specific reference? I believe we\u0027re using sqlalchemy for other tests","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"478e611a0e828664b15a6d15e1bedea606c7ab98","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        if self.conf.pooling:"},{"line_number":32,"context_line":"            for i in range(2):"},{"line_number":33,"context_line":"                uri \u003d self.conf[\u0027drivers:management_store:mongodb\u0027].uri"},{"line_number":34,"context_line":"                doc \u003d {\u0027weight\u0027: 100, \u0027uri\u0027: uri}"},{"line_number":35,"context_line":"                self.simulate_put(self.url_prefix + \u0027/pools/\u0027 + str(i),"},{"line_number":36,"context_line":"                                  body\u003djsonutils.dumps(doc))"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_48777e3a","line":33,"in_reply_to":"fa81d914_d3a46559","updated":"2015-01-30 03:05:17.000000000","message":"ok, I can see your point. I will file 2 bugs to address those issues.\n\nhttps://bugs.launchpad.net/zaqar/+bug/1416206\n\nhttps://bugs.launchpad.net/zaqar/+bug/1416208","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"78d308904e357fca063d624f058dda89748c2804","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        if self.conf.pooling:"},{"line_number":57,"context_line":"            for i in range(2):"},{"line_number":58,"context_line":"                self.simulate_delete(self.url_prefix + \u0027/pools/\u0027 + str(i),"},{"line_number":59,"context_line":"                                     headers\u003dself.headers)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.simulate_delete(self.queue_path)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_8e52c211","line":58,"updated":"2015-01-28 12:36:54.000000000","message":"Could you convert the things in this tearDown into cleanup steps?\n\n`self.addCleanup(self.simulate_delete, ..., ....)`\n\nThe above should happen right after the many `put` calls succeed.","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"478e611a0e828664b15a6d15e1bedea606c7ab98","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        if self.conf.pooling:"},{"line_number":57,"context_line":"            for i in range(2):"},{"line_number":58,"context_line":"                self.simulate_delete(self.url_prefix + \u0027/pools/\u0027 + str(i),"},{"line_number":59,"context_line":"                                     headers\u003dself.headers)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        self.simulate_delete(self.queue_path)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_40f22470","line":58,"in_reply_to":"fa81d914_8e52c211","updated":"2015-01-30 03:05:17.000000000","message":"Done","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"069e6728e296f9d0e5a3278c39aeced1a686042b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Catalyst IT Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may not"},{"line_number":4,"context_line":"# use this file except in compliance with the License.  You may obtain a copy"}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_03662eed","line":1,"updated":"2015-03-30 11:10:08.000000000","message":"2015","commit_id":"129119b530572526999154058c963ab324d25fc0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"659ccbc627dd3287e9a61c9f2e93930cfb8ad2dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Catalyst IT Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may not"},{"line_number":4,"context_line":"# use this file except in compliance with the License.  You may obtain a copy"}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_48d2f801","line":1,"in_reply_to":"da9b358b_03662eed","updated":"2015-03-30 21:45:21.000000000","message":"Done","commit_id":"129119b530572526999154058c963ab324d25fc0"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"069e6728e296f9d0e5a3278c39aeced1a686042b","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        super(SubscriptionsBaseTest, self).tearDown()"},{"line_number":57,"context_line":"        self._delete_subscription()"},{"line_number":58,"context_line":"        self.simulate_delete(self.queue_path)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _delete_subscription(self, sid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_435d56e8","line":57,"updated":"2015-03-30 11:10:08.000000000","message":"Could you move this into the `setUp` method as a cleanup step? (Use `addCleanup(...)`)","commit_id":"129119b530572526999154058c963ab324d25fc0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"659ccbc627dd3287e9a61c9f2e93930cfb8ad2dc","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def tearDown(self):"},{"line_number":56,"context_line":"        super(SubscriptionsBaseTest, self).tearDown()"},{"line_number":57,"context_line":"        self._delete_subscription()"},{"line_number":58,"context_line":"        self.simulate_delete(self.queue_path)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _delete_subscription(self, sid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_88e7e0e3","line":57,"in_reply_to":"da9b358b_435d56e8","updated":"2015-03-30 21:45:21.000000000","message":"Done","commit_id":"129119b530572526999154058c963ab324d25fc0"}],"zaqar/transport/validation.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c779fafe49c79108096e7bb019b2a37d5b87af02","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               deprecated_name\u003d\u0027claim_grace_max\u0027,"},{"line_number":60,"context_line":"               deprecated_group\u003d\u0027limits:transport\u0027),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    cfg.ListOpt(\u0027publisher_type\u0027, default\u003d[\u0027http\u0027],"},{"line_number":63,"context_line":"                deprecated_name\u003d\u0027publisher_type\u0027,"},{"line_number":64,"context_line":"                deprecated_group\u003d\u0027limits:transport\u0027),"},{"line_number":65,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_c60feddf","line":62,"updated":"2014-12-18 19:57:26.000000000","message":"NIT: It would be nice to put a help text with the options.","commit_id":"e83a68658ffa20324d758ac6fb2dfc66b47c9993"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c779fafe49c79108096e7bb019b2a37d5b87af02","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        \"\"\""},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if not subscription:"},{"line_number":289,"context_line":"            raise ValidationFailed(_(u\u0027No messages to enqueu.\u0027))"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        publisher \u003d subscription[\u0027publisher\u0027]"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_4603fdb7","line":289,"updated":"2014-12-18 19:57:26.000000000","message":"NIT: s/enqueu/enqueue","commit_id":"e83a68658ffa20324d758ac6fb2dfc66b47c9993"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c779fafe49c79108096e7bb019b2a37d5b87af02","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            raise ValidationFailed(msg, self._limits_conf.publisher_type)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        ttl \u003d subscription[\u0027ttl\u0027]"},{"line_number":302,"context_line":"        if not (MIN_CLAIM_TTL \u003c\u003d ttl):"},{"line_number":303,"context_line":"            msg \u003d _(u\u0027The TTL for a subscription\u0027"},{"line_number":304,"context_line":"                    \u0027 must be at least {0} seconds long.\u0027)"},{"line_number":305,"context_line":"            raise ValidationFailed(msg, MIN_CLAIM_TTL)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_06e73513","line":302,"updated":"2014-12-18 19:57:26.000000000","message":"NIT: s/if not (MIN_CLAIM_TTL \u003c\u003d ttl):/if ttl \u003c\u003d MIN_CLAIM_TTL:\n\nImproves readability a bit.","commit_id":"e83a68658ffa20324d758ac6fb2dfc66b47c9993"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"78d308904e357fca063d624f058dda89748c2804","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MIN_MESSAGE_TTL \u003d 60"},{"line_number":24,"context_line":"MIN_CLAIM_TTL \u003d 60"},{"line_number":25,"context_line":"MIN_SUBSCRIPTION_TTL \u003d 60"},{"line_number":26,"context_line":"MIN_CLAIM_GRACE \u003d 60"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"_TRANSPORT_LIMITS_OPTIONS \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_da4f1191","line":25,"updated":"2015-01-28 12:36:54.000000000","message":"do we really need to have ttl for subscription? Is there a way to disable it? If so, I believe the default should be disabled.","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"478e611a0e828664b15a6d15e1bedea606c7ab98","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"MIN_MESSAGE_TTL \u003d 60"},{"line_number":24,"context_line":"MIN_CLAIM_TTL \u003d 60"},{"line_number":25,"context_line":"MIN_SUBSCRIPTION_TTL \u003d 60"},{"line_number":26,"context_line":"MIN_CLAIM_GRACE \u003d 60"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"_TRANSPORT_LIMITS_OPTIONS \u003d ("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_80b5f1ef","line":25,"in_reply_to":"fa81d914_da4f1191","updated":"2015-01-30 03:05:17.000000000","message":"Done. And I will submit another patch for the db driver change.","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"78d308904e357fca063d624f058dda89748c2804","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               deprecated_name\u003d\u0027claim_grace_max\u0027,"},{"line_number":60,"context_line":"               deprecated_group\u003d\u0027limits:transport\u0027),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    cfg.ListOpt(\u0027subscriber_types\u0027, default\u003d[\u0027http\u0027]),"},{"line_number":63,"context_line":")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"_TRANSPORT_LIMITS_GROUP \u003d \u0027transport\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_5a096130","line":62,"updated":"2015-01-28 12:36:54.000000000","message":"mmh, I\u0027d like to have a better way to do this. Can we \"try\" to load the subscriber instance and if it fails to load then reply with a `ValidationError` ?\n\nKeeping the list in the config file will be hard, I\u0027d rather have it as we have the database drivers.","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"478e611a0e828664b15a6d15e1bedea606c7ab98","unresolved":false,"context_lines":[{"line_number":59,"context_line":"               deprecated_name\u003d\u0027claim_grace_max\u0027,"},{"line_number":60,"context_line":"               deprecated_group\u003d\u0027limits:transport\u0027),"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    cfg.ListOpt(\u0027subscriber_types\u0027, default\u003d[\u0027http\u0027]),"},{"line_number":63,"context_line":")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"_TRANSPORT_LIMITS_GROUP \u003d \u0027transport\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_40678425","line":62,"in_reply_to":"fa81d914_5a096130","updated":"2015-01-30 03:05:17.000000000","message":"Good point. Would you mind refactoring this after we get the subscriber code in?","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"069e6728e296f9d0e5a3278c39aeced1a686042b","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        self.subscription_patching(subscription)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def subscription_patching(self, subscription):"},{"line_number":304,"context_line":"        \"\"\"Restrictions on an update of subscription."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        :param subscription: dict of subscription"}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_43467624","line":303,"updated":"2015-03-30 11:10:08.000000000","message":"Should this validate that `ttl` is an `int`?","commit_id":"129119b530572526999154058c963ab324d25fc0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"659ccbc627dd3287e9a61c9f2e93930cfb8ad2dc","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        self.subscription_patching(subscription)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def subscription_patching(self, subscription):"},{"line_number":304,"context_line":"        \"\"\"Restrictions on an update of subscription."},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        :param subscription: dict of subscription"}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_08dcf010","line":303,"in_reply_to":"da9b358b_43467624","updated":"2015-03-30 21:45:21.000000000","message":"Done","commit_id":"129119b530572526999154058c963ab324d25fc0"}],"zaqar/transport/wsgi/driver.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c779fafe49c79108096e7bb019b2a37d5b87af02","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from zaqar.transport import validation"},{"line_number":29,"context_line":"from zaqar.transport.wsgi import v1_0"},{"line_number":30,"context_line":"from zaqar.transport.wsgi import v1_1"},{"line_number":31,"context_line":"from zaqar.transport.wsgi import v2_0"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"_WSGI_OPTIONS \u003d ("},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027bind\u0027, default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_067c951f","line":31,"updated":"2014-12-18 19:57:26.000000000","message":"w000000t v2_0!","commit_id":"e83a68658ffa20324d758ac6fb2dfc66b47c9993"}],"zaqar/transport/wsgi/v2_0/homedoc.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c779fafe49c79108096e7bb019b2a37d5b87af02","unresolved":false,"context_lines":[{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    }"},{"line_number":188,"context_line":"}"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"class Resource(object):"},{"line_number":192,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_66bf19ab","line":189,"updated":"2014-12-18 19:57:26.000000000","message":"Subscriptions are missing here.","commit_id":"e83a68658ffa20324d758ac6fb2dfc66b47c9993"}],"zaqar/transport/wsgi/v2_0/subscriptions.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c779fafe49c79108096e7bb019b2a37d5b87af02","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        except Exception as ex:"},{"line_number":53,"context_line":"            LOG.exception(ex)"},{"line_number":54,"context_line":"            description \u003d _(u\u0027Queue metadata could not be retrieved.\u0027)"},{"line_number":55,"context_line":"            raise wsgi_errors.HTTPServiceUnavailable(description)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        resp.body \u003d utils.to_json(resp_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_8604057f","line":54,"updated":"2014-12-18 19:57:26.000000000","message":"NIT: Subscriptions I guess :)","commit_id":"e83a68658ffa20324d758ac6fb2dfc66b47c9993"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"78d308904e357fca063d624f058dda89748c2804","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        except Exception as ex:"},{"line_number":54,"context_line":"            LOG.exception(ex)"},{"line_number":55,"context_line":"            description \u003d _(u\u0027Queue metadata could not be retrieved.\u0027)"},{"line_number":56,"context_line":"            raise wsgi_errors.HTTPServiceUnavailable(description)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        resp.body \u003d utils.to_json(resp_dict)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_751d5666","line":55,"updated":"2015-01-28 12:36:54.000000000","message":"I believe this error message needs to be updated. :)","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"478e611a0e828664b15a6d15e1bedea606c7ab98","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        except Exception as ex:"},{"line_number":54,"context_line":"            LOG.exception(ex)"},{"line_number":55,"context_line":"            description \u003d _(u\u0027Queue metadata could not be retrieved.\u0027)"},{"line_number":56,"context_line":"            raise wsgi_errors.HTTPServiceUnavailable(description)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        resp.body \u003d utils.to_json(resp_dict)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_60b72887","line":55,"in_reply_to":"fa81d914_751d5666","updated":"2015-01-30 03:05:17.000000000","message":"Done","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"78d308904e357fca063d624f058dda89748c2804","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        resp.status \u003d falcon.HTTP_204"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def on_patch(self, req, resp, project_id, queue_name, subscription_id):"},{"line_number":80,"context_line":"        LOG.debug(u\u0027Subscription PUT - subscription id: %(subscription_id)s,\u0027"},{"line_number":81,"context_line":"                  u\u0027 project: %(project)s, queue: %(queue)s\u0027,"},{"line_number":82,"context_line":"                  {\u0027subscription_id\u0027: subscription_id, \u0027project\u0027: project_id,"},{"line_number":83,"context_line":"                   \u0027queue\u0027: queue_name})"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_d5528212","line":80,"updated":"2015-01-28 12:36:54.000000000","message":"PATCH*","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"478e611a0e828664b15a6d15e1bedea606c7ab98","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        resp.status \u003d falcon.HTTP_204"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def on_patch(self, req, resp, project_id, queue_name, subscription_id):"},{"line_number":80,"context_line":"        LOG.debug(u\u0027Subscription PUT - subscription id: %(subscription_id)s,\u0027"},{"line_number":81,"context_line":"                  u\u0027 project: %(project)s, queue: %(queue)s\u0027,"},{"line_number":82,"context_line":"                  {\u0027subscription_id\u0027: subscription_id, \u0027project\u0027: project_id,"},{"line_number":83,"context_line":"                   \u0027queue\u0027: queue_name})"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa81d914_40c064e0","line":80,"in_reply_to":"fa81d914_d5528212","updated":"2015-01-30 03:05:17.000000000","message":"Done","commit_id":"5306d1fd8026bc77243a86f6c81a9e36df6ade63"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"069e6728e296f9d0e5a3278c39aeced1a686042b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Catalyst IT Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_23b01243","line":1,"updated":"2015-03-30 11:10:08.000000000","message":"2015","commit_id":"129119b530572526999154058c963ab324d25fc0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"659ccbc627dd3287e9a61c9f2e93930cfb8ad2dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Catalyst IT Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_c804c87f","line":1,"in_reply_to":"da9b358b_23b01243","updated":"2015-03-30 21:45:21.000000000","message":"Done","commit_id":"129119b530572526999154058c963ab324d25fc0"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"069e6728e296f9d0e5a3278c39aeced1a686042b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            self._validate.subscription_posting(document)"},{"line_number":170,"context_line":"            subscriber \u003d document[\u0027subscriber\u0027]"},{"line_number":171,"context_line":"            ttl \u003d int(document[\u0027ttl\u0027])"},{"line_number":172,"context_line":"            options \u003d document[\u0027options\u0027]"},{"line_number":173,"context_line":"            created \u003d self._subscription_controller.create(queue_name,"},{"line_number":174,"context_line":"                                                           subscriber,"}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_c3b6063d","line":171,"updated":"2015-03-30 11:10:08.000000000","message":"Should we catch value error here?","commit_id":"129119b530572526999154058c963ab324d25fc0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"659ccbc627dd3287e9a61c9f2e93930cfb8ad2dc","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            self._validate.subscription_posting(document)"},{"line_number":170,"context_line":"            subscriber \u003d document[\u0027subscriber\u0027]"},{"line_number":171,"context_line":"            ttl \u003d int(document[\u0027ttl\u0027])"},{"line_number":172,"context_line":"            options \u003d document[\u0027options\u0027]"},{"line_number":173,"context_line":"            created \u003d self._subscription_controller.create(queue_name,"},{"line_number":174,"context_line":"                                                           subscriber,"}],"source_content_type":"text/x-python","patch_set":15,"id":"da9b358b_48f9d87f","line":171,"in_reply_to":"da9b358b_c3b6063d","updated":"2015-03-30 21:45:21.000000000","message":"Done","commit_id":"129119b530572526999154058c963ab324d25fc0"}]}