)]}'
{"requirements-py3.txt":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"53c130c3dfcaa99050fbebb7b765528bfb219e99","unresolved":false,"context_lines":[{"line_number":20,"context_line":"oslo.config\u003e\u003d1.9.3,\u003c1.10.0  # Apache-2.0"},{"line_number":21,"context_line":"oslo.i18n\u003e\u003d1.5.0,\u003c1.6.0  # Apache-2.0"},{"line_number":22,"context_line":"oslo.log\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":23,"context_line":"oslo.utils\u003e\u003d1.6.0                       # Apache-2.0"},{"line_number":24,"context_line":"SQLAlchemy\u003e\u003d0.9.7,\u003c\u003d0.9.99"},{"line_number":25,"context_line":"enum34"},{"line_number":26,"context_line":"autobahn\u003e\u003d0.10.1  # MIT License"}],"source_content_type":"text/plain","patch_set":2,"id":"ba3cc151_ff620d3d","line":23,"updated":"2015-07-03 12:02:28.000000000","message":"This should probably be done in a separate patch.","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df89dd45bd2cdd424fad570d9654776c3fbaf46e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"oslo.config\u003e\u003d1.9.3,\u003c1.10.0  # Apache-2.0"},{"line_number":21,"context_line":"oslo.i18n\u003e\u003d1.5.0,\u003c1.6.0  # Apache-2.0"},{"line_number":22,"context_line":"oslo.log\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":23,"context_line":"oslo.utils\u003e\u003d1.6.0                       # Apache-2.0"},{"line_number":24,"context_line":"SQLAlchemy\u003e\u003d0.9.7,\u003c\u003d0.9.99"},{"line_number":25,"context_line":"enum34"},{"line_number":26,"context_line":"autobahn\u003e\u003d0.10.1  # MIT License"}],"source_content_type":"text/plain","patch_set":2,"id":"ba3cc151_c0108502","line":23,"in_reply_to":"ba3cc151_ff620d3d","updated":"2015-07-03 13:29:25.000000000","message":"It\u0027s there just to make the patch pass until the global requirements review is merged.","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"}],"requirements.txt":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"53c130c3dfcaa99050fbebb7b765528bfb219e99","unresolved":false,"context_lines":[{"line_number":20,"context_line":"oslo.i18n\u003e\u003d1.5.0,\u003c1.6.0  # Apache-2.0"},{"line_number":21,"context_line":"oslo.log\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":22,"context_line":"oslo.serialization\u003e\u003d1.4.0,\u003c1.5.0               # Apache-2.0"},{"line_number":23,"context_line":"oslo.utils\u003e\u003d1.6.0                       # Apache-2.0"},{"line_number":24,"context_line":"SQLAlchemy\u003e\u003d0.9.7,\u003c\u003d0.9.99"},{"line_number":25,"context_line":"enum34"},{"line_number":26,"context_line":"trollius\u003e\u003d1.0"}],"source_content_type":"text/plain","patch_set":2,"id":"ba3cc151_1f66d150","line":23,"updated":"2015-07-03 12:02:28.000000000","message":"Same here.","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df89dd45bd2cdd424fad570d9654776c3fbaf46e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"oslo.i18n\u003e\u003d1.5.0,\u003c1.6.0  # Apache-2.0"},{"line_number":21,"context_line":"oslo.log\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":22,"context_line":"oslo.serialization\u003e\u003d1.4.0,\u003c1.5.0               # Apache-2.0"},{"line_number":23,"context_line":"oslo.utils\u003e\u003d1.6.0                       # Apache-2.0"},{"line_number":24,"context_line":"SQLAlchemy\u003e\u003d0.9.7,\u003c\u003d0.9.99"},{"line_number":25,"context_line":"enum34"},{"line_number":26,"context_line":"trollius\u003e\u003d1.0"}],"source_content_type":"text/plain","patch_set":2,"id":"ba3cc151_80f7ddd1","line":23,"in_reply_to":"ba3cc151_1f66d150","updated":"2015-07-03 13:29:25.000000000","message":"ditto","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"}],"zaqar/common/configs.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"53c130c3dfcaa99050fbebb7b765528bfb219e99","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"_SIGNED_URL_OPTIONS \u003d ("},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027secret_key\u0027, default\u003dNone,"},{"line_number":51,"context_line":"               help\u003d(\u0027Secret key used to encrypt pre-signed URLs.\u0027)),"},{"line_number":52,"context_line":")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"_SIGNED_URL_GROUP \u003d \u0027signed_url\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_aac8c5a8","line":51,"updated":"2015-07-03 12:02:28.000000000","message":"We should set some constraint on the key, eg at least 16 characters. We might also want to have it base64 encoded, to allow more characters.","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"}],"zaqar/common/urls.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"53c130c3dfcaa99050fbebb7b765528bfb219e99","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # for thoughts."},{"line_number":50,"context_line":"    expires \u003d options.get(\u0027expires\u0027)"},{"line_number":51,"context_line":"    project \u003d options.get(\u0027project\u0027)"},{"line_number":52,"context_line":"    methods \u003d options.get(\u0027methods\u0027, [\u0027GET\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    if key is None:"},{"line_number":55,"context_line":"        raise ValueError(_LE(\u0027The `key` can\\\u0027t be None\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_aa3f6585","line":52,"updated":"2015-07-03 12:02:28.000000000","message":"Why aren\u0027t those explicit parameters of the function?","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df89dd45bd2cdd424fad570d9654776c3fbaf46e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # for thoughts."},{"line_number":50,"context_line":"    expires \u003d options.get(\u0027expires\u0027)"},{"line_number":51,"context_line":"    project \u003d options.get(\u0027project\u0027)"},{"line_number":52,"context_line":"    methods \u003d options.get(\u0027methods\u0027, [\u0027GET\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    if key is None:"},{"line_number":55,"context_line":"        raise ValueError(_LE(\u0027The `key` can\\\u0027t be None\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_801efd09","line":52,"in_reply_to":"ba3cc151_aa3f6585","updated":"2015-07-03 13:29:25.000000000","message":"no real reason. They are just optional, I can add them to the signature.","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"53c130c3dfcaa99050fbebb7b765528bfb219e99","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    expires_str \u003d expires.strftime(_DATE_FORMAT)"},{"line_number":73,"context_line":"    hmac_body \u003d (\u0027%(path)s\\\\n%(methods)s\\\\n%(project)s\\\\n%(expires)s\u0027 %"},{"line_number":74,"context_line":"                 {\u0027path\u0027: path, \u0027methods\u0027: \u0027,\u0027.join(methods),"},{"line_number":75,"context_line":"                  \u0027project\u0027: project, \u0027expires\u0027: expires_str})"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    return {\u0027path\u0027: path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_6afcfdb7","line":74,"updated":"2015-07-03 12:02:28.000000000","message":"We may want to sort methods so that the signature is the same. Or mention somewhere that the order matters.","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df89dd45bd2cdd424fad570d9654776c3fbaf46e","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    expires_str \u003d expires.strftime(_DATE_FORMAT)"},{"line_number":73,"context_line":"    hmac_body \u003d (\u0027%(path)s\\\\n%(methods)s\\\\n%(project)s\\\\n%(expires)s\u0027 %"},{"line_number":74,"context_line":"                 {\u0027path\u0027: path, \u0027methods\u0027: \u0027,\u0027.join(methods),"},{"line_number":75,"context_line":"                  \u0027project\u0027: project, \u0027expires\u0027: expires_str})"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    return {\u0027path\u0027: path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_40eb15dc","line":74,"in_reply_to":"ba3cc151_6afcfdb7","updated":"2015-07-03 13:29:25.000000000","message":"very good point, I prefer to sort it ourselves","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"53c130c3dfcaa99050fbebb7b765528bfb219e99","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027methods\u0027: methods,"},{"line_number":79,"context_line":"            \u0027project\u0027: project,"},{"line_number":80,"context_line":"            \u0027expires\u0027: expires_str,"},{"line_number":81,"context_line":"            \u0027signature\u0027: hmac.new(key, hmac_body, hashlib.sha1).hexdigest()}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_2a54b5c7","line":81,"updated":"2015-07-03 12:02:28.000000000","message":"Any reason not to use sha256?","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df89dd45bd2cdd424fad570d9654776c3fbaf46e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            \u0027methods\u0027: methods,"},{"line_number":79,"context_line":"            \u0027project\u0027: project,"},{"line_number":80,"context_line":"            \u0027expires\u0027: expires_str,"},{"line_number":81,"context_line":"            \u0027signature\u0027: hmac.new(key, hmac_body, hashlib.sha1).hexdigest()}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_a0a9c191","line":81,"in_reply_to":"ba3cc151_2a54b5c7","updated":"2015-07-03 13:29:25.000000000","message":"no reason, I just used what swift uses.\n\nShould we go with sha256 ? :)","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"d7c38b243fcb9339ad8094a3a399cb3023657517","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        the generated URL."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    methods \u003d methods or [\u0027GET\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if key is None:"},{"line_number":50,"context_line":"        raise ValueError(_LE(\u0027The `key` can\\\u0027t be None\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_305a58f3","line":47,"updated":"2015-07-07 23:35:52.000000000","message":"Is there any validation that all these are actual HTTP methods? I see you check that it\u0027s a list, but not that it has real methods.","commit_id":"ff71aad4fc2627ba89a900e5916d36edcae3ccb6"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"d7c38b243fcb9339ad8094a3a399cb3023657517","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        raise ValueError(_LE(\u0027The `path` can\\\u0027t be None\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    if not isinstance(methods, list):"},{"line_number":56,"context_line":"        raise ValueError(_LE(\u0027`methods` should be a list\u0027))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    # NOTE(flaper87): The default expiration time is 1day"},{"line_number":59,"context_line":"    # Evaluate whether this should be configurable. We may"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_50ea7c10","line":56,"updated":"2015-07-07 23:35:52.000000000","message":"s/should/must/","commit_id":"ff71aad4fc2627ba89a900e5916d36edcae3ccb6"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"d7c38b243fcb9339ad8094a3a399cb3023657517","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    if not isinstance(methods, list):"},{"line_number":56,"context_line":"        raise ValueError(_LE(\u0027`methods` should be a list\u0027))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    # NOTE(flaper87): The default expiration time is 1day"},{"line_number":59,"context_line":"    # Evaluate whether this should be configurable. We may"},{"line_number":60,"context_line":"    # also want to have a \"maximum\" expiration time. Food"},{"line_number":61,"context_line":"    # for thoughts."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_90e4843c","line":58,"updated":"2015-07-07 23:35:52.000000000","message":"This should absolutely be configurable. I think a default of 1 day isn\u0027t bad, but I can see operators wanting control over it. Leave it for another patch though, this one is big enough.","commit_id":"ff71aad4fc2627ba89a900e5916d36edcae3ccb6"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"d7c38b243fcb9339ad8094a3a399cb3023657517","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    methods.sort()"},{"line_number":72,"context_line":"    expires_str \u003d expires.strftime(_DATE_FORMAT)"},{"line_number":73,"context_line":"    hmac_body \u003d six.b(\u0027%(path)s\\\\n%(methods)s\\\\n%(project)s\\\\n%(expires)s\u0027 %"},{"line_number":74,"context_line":"                      {\u0027path\u0027: path, \u0027methods\u0027: \u0027,\u0027.join(methods),"},{"line_number":75,"context_line":"                       \u0027project\u0027: project, \u0027expires\u0027: expires_str})"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_3011f804","line":73,"updated":"2015-07-07 23:35:52.000000000","message":"A raw string would make this a little less hairy-looking.","commit_id":"ff71aad4fc2627ba89a900e5916d36edcae3ccb6"}],"zaqar/transport/wsgi/v2_0/urls.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"53c130c3dfcaa99050fbebb7b765528bfb219e99","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        diff \u003d set(document.keys()) - _KNOWN_KEYS"},{"line_number":53,"context_line":"        if diff:"},{"line_number":54,"context_line":"            msg \u003d six.text_type(_LE(\u0027Uknown keys: %s\u0027) % diff)"},{"line_number":55,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(msg)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        key \u003d self._conf.signed_url.secret_key"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_8a3dc12c","line":54,"updated":"2015-07-03 12:02:28.000000000","message":"Typo: Unknown.","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df89dd45bd2cdd424fad570d9654776c3fbaf46e","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        diff \u003d set(document.keys()) - _KNOWN_KEYS"},{"line_number":53,"context_line":"        if diff:"},{"line_number":54,"context_line":"            msg \u003d six.text_type(_LE(\u0027Uknown keys: %s\u0027) % diff)"},{"line_number":55,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(msg)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        key \u003d self._conf.signed_url.secret_key"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_008e6d2d","line":54,"in_reply_to":"ba3cc151_8a3dc12c","updated":"2015-07-03 13:29:25.000000000","message":"Done","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"53c130c3dfcaa99050fbebb7b765528bfb219e99","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(msg)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        key \u003d self._conf.signed_url.secret_key"},{"line_number":58,"context_line":"        path \u003d os.path.join(req.path[:-6], \u0027messages\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            data \u003d urls.create_signed_url(key, path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_4aec99ba","line":58,"updated":"2015-07-03 12:02:28.000000000","message":"Maybe I\u0027d do:\n\n\"%s/messages\" % (req.path.rsplit(\u0027/\u0027, 1)[0],)","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"df89dd45bd2cdd424fad570d9654776c3fbaf46e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            raise wsgi_errors.HTTPBadRequestAPI(msg)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        key \u003d self._conf.signed_url.secret_key"},{"line_number":58,"context_line":"        path \u003d os.path.join(req.path[:-6], \u0027messages\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        try:"},{"line_number":61,"context_line":"            data \u003d urls.create_signed_url(key, path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_2075b130","line":58,"in_reply_to":"ba3cc151_4aec99ba","updated":"2015-07-03 13:29:25.000000000","message":"That would involve more cloning of strings, afaict.","commit_id":"f0d90d5062d1d9554f8db863c8b3b2582d54477d"}]}
