)]}'
{"zaqar/notification/notifier.py":[{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"7c148b7651f4f80cda9bc500f7053c0a630aebfa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# task class. But obviously, it will introduce more processing cost. So now we"},{"line_number":31,"context_line":"# just use a dict to store the mapping to get a better performance."},{"line_number":32,"context_line":"SCHEME_TASK_MAPPING \u003d {\u0027http\u0027: webhook.WebhookTask,"},{"line_number":33,"context_line":"                       \u0027https\u0027: webhook.WebhookTask}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class NotifierDriver(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_0c78b1f1","line":33,"updated":"2015-07-20 18:17:27.000000000","message":"+1 for stevedore","commit_id":"16726c0ed94ad7107a6025a41cf5de1185135a5d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7c126aea1ee8f1d8f885bfdd6c1c550a11c8d05f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# task class. But obviously, it will introduce more processing cost. So now we"},{"line_number":31,"context_line":"# just use a dict to store the mapping to get a better performance."},{"line_number":32,"context_line":"SCHEME_TASK_MAPPING \u003d {\u0027http\u0027: webhook.WebhookTask,"},{"line_number":33,"context_line":"                       \u0027https\u0027: webhook.WebhookTask}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class NotifierDriver(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_7a277964","line":33,"updated":"2015-08-05 01:12:15.000000000","message":"Actually, can we do stevedore right away? I\u0027d like to avoid adding more technical debt and we already depend on stevedore anyway. It shouldn\u0027t take much to do it.","commit_id":"16726c0ed94ad7107a6025a41cf5de1185135a5d"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"a31a153a80c9da98f88adda21d76fe92cd235f57","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# task class. But obviously, it will introduce more processing cost. So now we"},{"line_number":31,"context_line":"# just use a dict to store the mapping to get a better performance."},{"line_number":32,"context_line":"SCHEME_TASK_MAPPING \u003d {\u0027http\u0027: webhook.WebhookTask,"},{"line_number":33,"context_line":"                       \u0027https\u0027: webhook.WebhookTask}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class NotifierDriver(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_c9f769d1","line":33,"updated":"2015-07-16 03:47:26.000000000","message":"believe it or not, I prefer stevedore way to this, :)\n\nthat said, sometimes we do run into trouble with stevedore.","commit_id":"16726c0ed94ad7107a6025a41cf5de1185135a5d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"3c35b20be101fbedd277a3a0b5eee5741e02fa37","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                          \u0027messages\u0027: messages}}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"                mgr \u003d driver.DriverManager(\u0027zaqar.notification.tasks\u0027,"},{"line_number":56,"context_line":"                                           s_type,"},{"line_number":57,"context_line":"                                           invoke_on_load\u003dTrue,"},{"line_number":58,"context_line":"                                           invoke_args\u003dinvoke_args,"},{"line_number":59,"context_line":"                                           invoke_kwds\u003dinvoke_kwds)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_42fb2647","line":56,"updated":"2015-08-07 13:40:12.000000000","message":"if s_type doesn\u0027t exist, this will fail to load the driver. Is that exception something we want to catch? or are we good with propagating it? Is it possible to pass a subscriber that is not valid?","commit_id":"a128dbc3acfb74fe07ea74e006c9ed8d2fec79e8"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6cffb1d675fad8963a2d5d4ba7a3fec4eb357720","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                          \u0027messages\u0027: messages}}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"                mgr \u003d driver.DriverManager(\u0027zaqar.notification.tasks\u0027,"},{"line_number":56,"context_line":"                                           s_type,"},{"line_number":57,"context_line":"                                           invoke_on_load\u003dTrue,"},{"line_number":58,"context_line":"                                           invoke_args\u003dinvoke_args,"},{"line_number":59,"context_line":"                                           invoke_kwds\u003dinvoke_kwds)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_8ee84718","line":56,"in_reply_to":"1a4dcd0f_42fb2647","updated":"2015-08-09 21:43:33.000000000","message":"The subscriber type is checked when creating the subscription, see https://github.com/openstack/zaqar/blob/master/zaqar/transport/validation.py#L321 So technically, the s_type should be exist.","commit_id":"a128dbc3acfb74fe07ea74e006c9ed8d2fec79e8"}]}