)]}'
{"zaqar/transport/wsgi/driver.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"4a0de580642656df96ef5cbec0adf018b293965b","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _error_handler(self, exc, request, response, params):"},{"line_number":121,"context_line":"        if isinstance(exc, falcon.HTTPError):"},{"line_number":122,"context_line":"            raise exc"},{"line_number":123,"context_line":"        LOG.exception(exc)"},{"line_number":124,"context_line":"        raise falcon.HTTPInternalServerError(\u0027Internal server error\u0027,"},{"line_number":125,"context_line":"                                             six.text_type(exc))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ab634fb0","line":122,"updated":"2015-09-11 10:05:31.000000000","message":"(nit): Before raise the HTTPError, should we log it for operator to debug?","commit_id":"c154d6b5b2d16734f70cf24ffbe9f6ea1ea03699"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"429861e5c08e3361d38d14626aa422d3a8373b02","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _error_handler(self, exc, request, response, params):"},{"line_number":121,"context_line":"        if isinstance(exc, falcon.HTTPError):"},{"line_number":122,"context_line":"            raise exc"},{"line_number":123,"context_line":"        LOG.exception(exc)"},{"line_number":124,"context_line":"        raise falcon.HTTPInternalServerError(\u0027Internal server error\u0027,"},{"line_number":125,"context_line":"                                             six.text_type(exc))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_95c15383","line":122,"in_reply_to":"da20952f_110dce3d","updated":"2015-09-13 07:20:29.000000000","message":"Ok, fair enough.","commit_id":"c154d6b5b2d16734f70cf24ffbe9f6ea1ea03699"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"b1ffb9ef7b800004243f4ceaee57ffbcce46633b","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _error_handler(self, exc, request, response, params):"},{"line_number":121,"context_line":"        if isinstance(exc, falcon.HTTPError):"},{"line_number":122,"context_line":"            raise exc"},{"line_number":123,"context_line":"        LOG.exception(exc)"},{"line_number":124,"context_line":"        raise falcon.HTTPInternalServerError(\u0027Internal server error\u0027,"},{"line_number":125,"context_line":"                                             six.text_type(exc))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_110dce3d","line":122,"in_reply_to":"da20952f_ab634fb0","updated":"2015-09-11 11:14:31.000000000","message":"HTTPErrors are part of the regular lifecycle of the application, so I don\u0027t think we want to log them. We can do that in another patch if  you want.","commit_id":"c154d6b5b2d16734f70cf24ffbe9f6ea1ea03699"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"e53eee448485cfa8aff96c9600d5964d8a3d72cd","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            raise exc"},{"line_number":123,"context_line":"        LOG.exception(exc)"},{"line_number":124,"context_line":"        raise falcon.HTTPInternalServerError(\u0027Internal server error\u0027,"},{"line_number":125,"context_line":"                                             six.text_type(exc))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def listen(self):"},{"line_number":128,"context_line":"        \"\"\"Self-host using \u0027bind\u0027 and \u0027port\u0027 from the WSGI config group.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_3914904b","line":125,"updated":"2015-09-10 21:12:26.000000000","message":"I\u0027m not a huge fan of sending tracebacks to callers outside of debug mode. Can this be turned off for prod deploys?","commit_id":"c154d6b5b2d16734f70cf24ffbe9f6ea1ea03699"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"c27aaa324eda567269ce1c3ae0e1c23960c147a2","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            raise exc"},{"line_number":123,"context_line":"        LOG.exception(exc)"},{"line_number":124,"context_line":"        raise falcon.HTTPInternalServerError(\u0027Internal server error\u0027,"},{"line_number":125,"context_line":"                                             six.text_type(exc))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def listen(self):"},{"line_number":128,"context_line":"        \"\"\"Self-host using \u0027bind\u0027 and \u0027port\u0027 from the WSGI config group.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e1d411ea","line":125,"in_reply_to":"da20952f_3914904b","updated":"2015-09-11 06:47:51.000000000","message":"It doesn\u0027t contain the traceback, just the error message. I don\u0027t think it would give out critical information","commit_id":"c154d6b5b2d16734f70cf24ffbe9f6ea1ea03699"},{"author":{"_account_id":12321,"name":"Ryan Brown","email":"rybrown@redhat.com","username":"ryansb"},"change_message_id":"7e4532ec420289bd0995b8baaa94b01b8a2f61c6","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            raise exc"},{"line_number":123,"context_line":"        LOG.exception(exc)"},{"line_number":124,"context_line":"        raise falcon.HTTPInternalServerError(\u0027Internal server error\u0027,"},{"line_number":125,"context_line":"                                             six.text_type(exc))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    def listen(self):"},{"line_number":128,"context_line":"        \"\"\"Self-host using \u0027bind\u0027 and \u0027port\u0027 from the WSGI config group.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4aae242f","line":125,"in_reply_to":"da20952f_e1d411ea","updated":"2015-09-11 14:16:57.000000000","message":"Fair enough, thanks for clarifying.","commit_id":"c154d6b5b2d16734f70cf24ffbe9f6ea1ea03699"}]}