)]}'
{"requirements.txt":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7f0cf3d62c5a1a4f9a70ac0b2a39e0afc32a8a52","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Babel\u003e\u003d1.3"},{"line_number":7,"context_line":"netaddr!\u003d0.7.16,\u003e\u003d0.7.12"},{"line_number":8,"context_line":"falcon\u003c0.2.0,\u003e\u003d0.1.6"},{"line_number":9,"context_line":"dogpile.cache\u003e\u003d0.5.4"},{"line_number":10,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0"},{"line_number":11,"context_line":"iso8601\u003e\u003d0.1.9"},{"line_number":12,"context_line":"keystonemiddleware\u003e\u003d2.0.0"}],"source_content_type":"text/plain","patch_set":2,"id":"ba15a1d1_ee1e4b0b","line":9,"updated":"2015-09-23 02:40:49.000000000","message":"(nit): oslo.cache has already included the dep for dogpile, so it\u0027s not necessary to add it explicitly. See https://github.com/openstack/oslo.cache/blob/master/requirements.txt#L6","commit_id":"acf9b3d59473b2f8704b9f502c3f5b99315ff12d"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"30c03fa706e9873bc4f7ca44676070d3dbd40ca3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Babel\u003e\u003d1.3"},{"line_number":7,"context_line":"netaddr!\u003d0.7.16,\u003e\u003d0.7.12"},{"line_number":8,"context_line":"falcon\u003c0.2.0,\u003e\u003d0.1.6"},{"line_number":9,"context_line":"dogpile.cache\u003e\u003d0.5.4"},{"line_number":10,"context_line":"jsonschema!\u003d2.5.0,\u003c3.0.0,\u003e\u003d2.0.0"},{"line_number":11,"context_line":"iso8601\u003e\u003d0.1.9"},{"line_number":12,"context_line":"keystonemiddleware\u003e\u003d2.0.0"}],"source_content_type":"text/plain","patch_set":2,"id":"ba15a1d1_286bd0ba","line":9,"in_reply_to":"ba15a1d1_ee1e4b0b","updated":"2015-09-23 09:46:07.000000000","message":"Done","commit_id":"acf9b3d59473b2f8704b9f502c3f5b99315ff12d"}],"zaqar/common/decorators.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7f0cf3d62c5a1a4f9a70ac0b2a39e0afc32a8a52","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                    # str format family."},{"line_number":116,"context_line":"                    packed_value \u003d msgpack.packb(value, use_bin_type\u003dTrue)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"                    if not self._cache.set(key, packed_value, ttl):"},{"line_number":119,"context_line":"                        LOG.warn(\u0027Failed to cache key: \u0027 + key)"},{"line_number":120,"context_line":"            else:"},{"line_number":121,"context_line":"                # NOTE(kgriffs): unpackb does not default to UTF-8,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_4e0657cf","side":"PARENT","line":118,"updated":"2015-09-23 02:40:49.000000000","message":"Would you mind explaining this more? Seems it\u0027s changing the logic. I assume this is a corresponding change for the new oslo_cache version. But it would be nice if you can double confirm.","commit_id":"d5e7f7340a39f6a52a8d1fd40c3c2a74980b4186"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"30c03fa706e9873bc4f7ca44676070d3dbd40ca3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                    # str format family."},{"line_number":116,"context_line":"                    packed_value \u003d msgpack.packb(value, use_bin_type\u003dTrue)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"                    if not self._cache.set(key, packed_value, ttl):"},{"line_number":119,"context_line":"                        LOG.warn(\u0027Failed to cache key: \u0027 + key)"},{"line_number":120,"context_line":"            else:"},{"line_number":121,"context_line":"                # NOTE(kgriffs): unpackb does not default to UTF-8,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_c8457443","side":"PARENT","line":118,"in_reply_to":"ba15a1d1_4e0657cf","updated":"2015-09-23 09:46:07.000000000","message":"Yeah the API just changed, it used to do the ttl on set, now it does it on get.","commit_id":"d5e7f7340a39f6a52a8d1fd40c3c2a74980b4186"}]}