)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"339d2f6aeb00962de1fbfdac9f4d45a068399a74","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently Zaqar will support more built-in/reserved"},{"line_number":10,"context_line":"attributes in queue."},{"line_number":11,"context_line":"We add two important attributes MaximumMessageSize and"},{"line_number":12,"context_line":"MessageRetentionPeriod."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So it\u0027s very useful for users that if they create a queue without"},{"line_number":15,"context_line":"metadata, when they query queue, Zaqar add those two attributes from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa0719c6_e169e6bf","line":12,"range":{"start_line":11,"start_character":32,"end_line":12,"end_character":22},"updated":"2016-03-22 22:15:42.000000000","message":"NIT: To make things more clear, I think it\u0027s better to replace these names to \u0027max_messages_post_size\u0027 and \u0027max_message_ttl\u0027, because these names are used in config and variables.","commit_id":"414150fd1b24d740ca0c15eab95e2861bfa9866a"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"f16c5fc8e5f0bb82f97e175088884cad42aebf73","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently Zaqar will support more built-in/reserved"},{"line_number":10,"context_line":"attributes in queue."},{"line_number":11,"context_line":"We add two important attributes MaximumMessageSize and"},{"line_number":12,"context_line":"MessageRetentionPeriod."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So it\u0027s very useful for users that if they create a queue without"},{"line_number":15,"context_line":"metadata, when they query queue, Zaqar add those two attributes from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da0c15f0_5610bc4e","line":12,"range":{"start_line":11,"start_character":32,"end_line":12,"end_character":22},"in_reply_to":"fa0719c6_e169e6bf","updated":"2016-03-25 01:58:31.000000000","message":"Sure.","commit_id":"414150fd1b24d740ca0c15eab95e2861bfa9866a"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"0138e7c4c908691d519e35d12918735061c5042b","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So it\u0027s very useful for users that if they create a queue without"},{"line_number":15,"context_line":"metadata, when they query queue, Zaqar add those two attributes from"},{"line_number":16,"context_line":"config to queue metadata and then return. That will not be stuck if config"},{"line_number":17,"context_line":"is changed and user also can know what value it is."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa0719c6_f52db3fe","line":16,"range":{"start_line":16,"start_character":68,"end_line":16,"end_character":74},"updated":"2016-03-24 16:20:18.000000000","message":"I suddently noticed that this line is wrapped incorrectly. Please fix it.","commit_id":"414150fd1b24d740ca0c15eab95e2861bfa9866a"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"f16c5fc8e5f0bb82f97e175088884cad42aebf73","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"So it\u0027s very useful for users that if they create a queue without"},{"line_number":15,"context_line":"metadata, when they query queue, Zaqar add those two attributes from"},{"line_number":16,"context_line":"config to queue metadata and then return. That will not be stuck if config"},{"line_number":17,"context_line":"is changed and user also can know what value it is."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"da0c15f0_3620a89b","line":16,"range":{"start_line":16,"start_character":68,"end_line":16,"end_character":74},"in_reply_to":"fa0719c6_f52db3fe","updated":"2016-03-25 01:58:31.000000000","message":"Done","commit_id":"414150fd1b24d740ca0c15eab95e2861bfa9866a"}],"zaqar/transport/wsgi/v2_0/queues.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"002996aa2aeef9fe80f2f777613013a30f22e8cc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            resp_dict \u003d self._queue_controller.get(queue_name,"},{"line_number":46,"context_line":"                                                   project\u003dproject_id)"},{"line_number":47,"context_line":"            queue_max_msg_size \u003d resp_dict.get(\u0027_max_messages_post_size\u0027, None)"},{"line_number":48,"context_line":"            queue_default_ttl \u003d resp_dict.get(\u0027_default_message_ttl\u0027, None)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        except storage_errors.DoesNotExist as ex:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_5293f9f9","line":47,"updated":"2016-03-03 22:05:07.000000000","message":"Why don\u0027t we put self._validate.get_limit_conf_value(\u0027max_messages_post_size\u0027) as the default value instead of None?","commit_id":"1f055c60c0f59897689134ffe6c2d0b47fee9947"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"62cc970629d9a81a47437b4afc27738ddcc06e7a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        try:"},{"line_number":45,"context_line":"            resp_dict \u003d self._queue_controller.get(queue_name,"},{"line_number":46,"context_line":"                                                   project\u003dproject_id)"},{"line_number":47,"context_line":"            queue_max_msg_size \u003d resp_dict.get(\u0027_max_messages_post_size\u0027, None)"},{"line_number":48,"context_line":"            queue_default_ttl \u003d resp_dict.get(\u0027_default_message_ttl\u0027, None)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        except storage_errors.DoesNotExist as ex:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_f12e798a","line":47,"in_reply_to":"7af24918_5293f9f9","updated":"2016-03-04 02:56:47.000000000","message":"Good catch! It\u0027s much better.","commit_id":"1f055c60c0f59897689134ffe6c2d0b47fee9947"}]}
