)]}'
{"zaqar/storage/mongodb/subscriptions.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6aca26b86a3765c3ffa003ea453a211479aeec10","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      \u0027s\u0027: source :: six.text_type"},{"line_number":46,"context_line":"      \u0027u\u0027: subscriber:: six.text_type"},{"line_number":47,"context_line":"      \u0027t\u0027: ttl:: int"},{"line_number":48,"context_line":"      \u0027e\u0027: expires: datetime.datetime"},{"line_number":49,"context_line":"      \u0027o\u0027: options :: dict"},{"line_number":50,"context_line":"      \u0027p\u0027: project :: six.text_type"},{"line_number":51,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_ddd060fa","line":48,"updated":"2016-03-06 22:07:26.000000000","message":"Good catch.","commit_id":"3419409cc2e0cb359081c76eaf968c148b27e59f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"6aca26b86a3765c3ffa003ea453a211479aeec10","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _basic_subscription(record, now):"},{"line_number":151,"context_line":"    # NOTE(Eva-i): \u0027e\u0027 (expires) field has changed it\u0027s format from int"},{"line_number":152,"context_line":"    # (timestamp) to datetime since patch 270464. If you will ever decide to"},{"line_number":153,"context_line":"    # use \u0027e\u0027 field, you probably should provide code compatibility with both"},{"line_number":154,"context_line":"    # formats to ensure Zaqar is working correctly even with old databases."}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_5d03b076","line":151,"updated":"2016-03-06 22:07:26.000000000","message":"(nit): Seems the note is not related to this change. If you\u0027re trying to explain why you\u0027re using oid to get the age, then pls reword it a bit. And it\u0027s better to use commit id to refer a change instead of a code review id. Thanks.","commit_id":"3419409cc2e0cb359081c76eaf968c148b27e59f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"678d74512498c838cc51ef3e7373fb70f644a669","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _basic_subscription(record, now):"},{"line_number":151,"context_line":"    # NOTE(Eva-i): \u0027e\u0027 (expires) field has changed it\u0027s format from int"},{"line_number":152,"context_line":"    # (timestamp) to datetime since patch 270464. If you will ever decide to"},{"line_number":153,"context_line":"    # use \u0027e\u0027 field, you probably should provide code compatibility with both"},{"line_number":154,"context_line":"    # formats to ensure Zaqar is working correctly even with old databases."}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_974ecc94","line":151,"in_reply_to":"1a122d0e_d0777806","updated":"2016-05-05 21:39:46.000000000","message":"If you will ever decide to use \u0027e\u0027 field, you probably should provide code compatibility with both formats to ensure Zaqar is working correctly even with old databases.\n\n-\u003e\n\nAny future change about xxx should make sure support xxx.","commit_id":"3419409cc2e0cb359081c76eaf968c148b27e59f"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"73bf9042cfb283695c462b5122e5ddee21821780","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _basic_subscription(record, now):"},{"line_number":151,"context_line":"    # NOTE(Eva-i): \u0027e\u0027 (expires) field has changed it\u0027s format from int"},{"line_number":152,"context_line":"    # (timestamp) to datetime since patch 270464. If you will ever decide to"},{"line_number":153,"context_line":"    # use \u0027e\u0027 field, you probably should provide code compatibility with both"},{"line_number":154,"context_line":"    # formats to ensure Zaqar is working correctly even with old databases."}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_d0777806","line":151,"in_reply_to":"5a18252c_44f3c19e","updated":"2016-05-03 22:21:28.000000000","message":"Okay, I\u0027ll use git commit id: 1d122b1671792aff0055ed5396111cd441fb8269.\n\nCan you please clarify how can I reword this note? What part of this note doesn\u0027t feel right for you?","commit_id":"3419409cc2e0cb359081c76eaf968c148b27e59f"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"a17c885431cc43b5f136620bcecef08525beeceb","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _basic_subscription(record, now):"},{"line_number":151,"context_line":"    # NOTE(Eva-i): \u0027e\u0027 (expires) field has changed it\u0027s format from int"},{"line_number":152,"context_line":"    # (timestamp) to datetime since patch 270464. If you will ever decide to"},{"line_number":153,"context_line":"    # use \u0027e\u0027 field, you probably should provide code compatibility with both"},{"line_number":154,"context_line":"    # formats to ensure Zaqar is working correctly even with old databases."}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_dd8860c9","line":151,"in_reply_to":"7af24918_5d03b076","updated":"2016-03-06 22:51:49.000000000","message":"I\u0027m not trying to explain why I\u0027m using oid to get age, but just providing a caution to the future Zaqarians about using \u0027e\u0027 field.\n\nYes, such caution should have probably been added in this change https://review.openstack.org/#/c/270464/.\n\nWhat would you like me to do: to remove the comment or just change or just change code review id to commit id?","commit_id":"3419409cc2e0cb359081c76eaf968c148b27e59f"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"5d26c083de3b15f23bfbbad33c194d4484279d2e","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _basic_subscription(record, now):"},{"line_number":151,"context_line":"    # NOTE(Eva-i): \u0027e\u0027 (expires) field has changed it\u0027s format from int"},{"line_number":152,"context_line":"    # (timestamp) to datetime since patch 270464. If you will ever decide to"},{"line_number":153,"context_line":"    # use \u0027e\u0027 field, you probably should provide code compatibility with both"},{"line_number":154,"context_line":"    # formats to ensure Zaqar is working correctly even with old databases."}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_44f3c19e","line":151,"in_reply_to":"7af24918_dd8860c9","updated":"2016-04-12 22:22:13.000000000","message":"Yep, it would be nice if you can reword this note a bit and replace the gerrit patch id with git commit id. Thanks.","commit_id":"3419409cc2e0cb359081c76eaf968c148b27e59f"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"a8c75cbadf81e701ffb7d20bcb0c841fab7497a5","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"def _basic_subscription(record, now):"},{"line_number":151,"context_line":"    # NOTE(Eva-i): \u0027e\u0027 (expires) field has changed it\u0027s format from int"},{"line_number":152,"context_line":"    # (timestamp) to datetime since patch 270464. If you will ever decide to"},{"line_number":153,"context_line":"    # use \u0027e\u0027 field, you probably should provide code compatibility with both"},{"line_number":154,"context_line":"    # formats to ensure Zaqar is working correctly even with old databases."}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_c909ccdf","line":151,"in_reply_to":"dab17558_974ecc94","updated":"2016-05-06 04:37:23.000000000","message":"Okay, thanks. I hope everything is alright now, but if not, please tell me.\nAnd I wanted to say sorry for delay from me. This made patch progressing slowly.","commit_id":"3419409cc2e0cb359081c76eaf968c148b27e59f"}]}