)]}'
{"zaqar/tests/unit/storage/base.py":[{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"b6013121a3d1e99e9f6dc0a6bb9ce0930448a5b2","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"                          project\u003dself.project,"},{"line_number":1137,"context_line":"                          **update_fields)"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"    def test_update_ttl(self):"},{"line_number":1140,"context_line":"        subscriber \u003d \u0027http://fake_1\u0027"},{"line_number":1141,"context_line":"        # The default value of ttl is 600"},{"line_number":1142,"context_line":"        s_id \u003d self.subscription_controller.create("}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_9b0a1920","line":1139,"range":{"start_line":1139,"start_character":8,"end_line":1139,"end_character":23},"updated":"2016-03-09 03:01:11.000000000","message":"Thank you for adding this test. \u003d) \n\nThough I\u0027m not sure L1159 will work for MongoDB driver. Let\u0027s see what jenkins will say.\n\nI\u0027m currently working now on \u0027test_expired_subscriptions\u0027 test case like the one for messages: https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/storage/base.py#L576","commit_id":"8d332ff6ae25c7df7c3dc8274fc213bf46d1f569"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"e91573da2bc5b2c06d55cd2fe2ad6dfa623bc514","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"                          project\u003dself.project,"},{"line_number":1137,"context_line":"                          **update_fields)"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"    @testing.is_slow(condition\u003dlambda self: self.gc_interval \u003e 1)"},{"line_number":1140,"context_line":"    def test_expired_subscriptions(self):"},{"line_number":1141,"context_line":"        longlive_id \u003d self.subscription_controller.create(self.source,"},{"line_number":1142,"context_line":"                                                          self.subscriber,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_99cca16b","line":1139,"updated":"2016-03-09 22:38:22.000000000","message":"I think the two test cases are a little bit heavy for unit test. I\u0027m happy to see they passed but I don\u0027t want to keep them in unit test. See http://logs.openstack.org/65/289665/5/check/gate-zaqar-python27/9fe0a3d/console.html#_2016-03-09_05_03_08_157\n\nSo could we add a TODO to note these two test cases will be moved to functional test or tempest test. Thanks.","commit_id":"dc3eacb0e69f32965d84bf6f75b60c785ae62ec9"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"1e1b99c1387e5432f8508d91d3a72ea88cc7459c","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"                          project\u003dself.project,"},{"line_number":1137,"context_line":"                          **update_fields)"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"    @testing.is_slow(condition\u003dlambda self: self.gc_interval \u003e 1)"},{"line_number":1140,"context_line":"    def test_expired_subscriptions(self):"},{"line_number":1141,"context_line":"        longlive_id \u003d self.subscription_controller.create(self.source,"},{"line_number":1142,"context_line":"                                                          self.subscriber,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_dc69f2fa","line":1139,"in_reply_to":"5aef4532_54e5c0d9","updated":"2016-03-10 01:44:49.000000000","message":"Also in another new patch I can make all slowest unit tests use mocks and add corresponding functional tests if they do not exist. How is this idea?","commit_id":"dc3eacb0e69f32965d84bf6f75b60c785ae62ec9"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"495e0e894a0f00d16c2f02aa30974289cb2dcef4","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"                          project\u003dself.project,"},{"line_number":1137,"context_line":"                          **update_fields)"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"    @testing.is_slow(condition\u003dlambda self: self.gc_interval \u003e 1)"},{"line_number":1140,"context_line":"    def test_expired_subscriptions(self):"},{"line_number":1141,"context_line":"        longlive_id \u003d self.subscription_controller.create(self.source,"},{"line_number":1142,"context_line":"                                                          self.subscriber,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_54e5c0d9","line":1139,"in_reply_to":"5aef4532_99cca16b","updated":"2016-03-09 23:10:41.000000000","message":"I don\u0027t want to make you sad by adding these tests.\n\nSomeone said that much of our unit tests are actually 100% unit tests.\nThis test is not 100% unit as well, because it doesn\u0027t mock pymongo/redis library, so it\u0027s slow.\n\nInstead of writing TODO I can transform this test to a full functional test, but I will need to create zaqar/tests/functional/wsgi/v2 directory.\n\nWould you like it?","commit_id":"dc3eacb0e69f32965d84bf6f75b60c785ae62ec9"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"a2187978227da34bcd4dccf579293c45e8906117","unresolved":false,"context_lines":[{"line_number":1155,"context_line":"                                                         project\u003dself.project)"},{"line_number":1156,"context_line":"        # NOTE(Eva-i): gc_interval is the known maximum time interval between"},{"line_number":1157,"context_line":"        # automatic resource expirations made by database back end."},{"line_number":1158,"context_line":"        for i in range(self.gc_interval):"},{"line_number":1159,"context_line":"            time.sleep(1)"},{"line_number":1160,"context_line":"            try:"},{"line_number":1161,"context_line":"                self.subscription_controller.get(self.queue_name, expired_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5aef4532_13c6ed47","line":1158,"updated":"2016-03-09 06:58:06.000000000","message":"IMO, this\u0027s the tempest\u0027s work. Only thing we need to do with unit test is that to ensure the ttl and expired is changed. and I think we could skip here now, then move it to tempest plugin in Newton.","commit_id":"dc3eacb0e69f32965d84bf6f75b60c785ae62ec9"}]}
