)]}'
{"zaqar/tests/tempest_plugin/plugin.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"d49b499fcde3a42587dff242bf7e119887801cc9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        base_path \u003d os.path.split(os.path.dirname("},{"line_number":27,"context_line":"            os.path.abspath(__file__)))[0]"},{"line_number":28,"context_line":"        base_path +\u003d \u0027/../..\u0027"},{"line_number":29,"context_line":"        test_dir \u003d \"zaqar/tests/tempest_plugin/tests\""},{"line_number":30,"context_line":"        full_test_dir \u003d os.path.join(base_path, test_dir)"},{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_5780318b","line":29,"updated":"2016-03-31 01:42:33.000000000","message":"why not update the test_dir to tempest_plugin/tests?","commit_id":"e7d833400fc5324630bde5c95581a2149f58f837"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"cb6aa46e3e01f2efeda6b9953f51fedcba248f41","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        base_path \u003d os.path.split(os.path.dirname("},{"line_number":27,"context_line":"            os.path.abspath(__file__)))[0]"},{"line_number":28,"context_line":"        base_path +\u003d \u0027/../..\u0027"},{"line_number":29,"context_line":"        test_dir \u003d \"zaqar/tests/tempest_plugin/tests\""},{"line_number":30,"context_line":"        full_test_dir \u003d os.path.join(base_path, test_dir)"},{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_d53f1985","line":29,"in_reply_to":"ba0121b8_1544f147","updated":"2016-03-31 02:36:06.000000000","message":"And your way works either. And I agree your way is more straightforward. But could you pls add a note to explain why we need this change? Then I\u0027m happy to +2 for this one.","commit_id":"e7d833400fc5324630bde5c95581a2149f58f837"},{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"90818d5cf16e0f7e385f696f9f11d3538f594175","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        base_path \u003d os.path.split(os.path.dirname("},{"line_number":27,"context_line":"            os.path.abspath(__file__)))[0]"},{"line_number":28,"context_line":"        base_path +\u003d \u0027/../..\u0027"},{"line_number":29,"context_line":"        test_dir \u003d \"zaqar/tests/tempest_plugin/tests\""},{"line_number":30,"context_line":"        full_test_dir \u003d os.path.join(base_path, test_dir)"},{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_daa90892","line":29,"in_reply_to":"ba0121b8_5780318b","updated":"2016-03-31 02:08:49.000000000","message":"Hi Fei Long, thanks for review.\n\nJust update test_dir won\u0027t fix the problem, base_path needs to point to top folder of zaqar.","commit_id":"e7d833400fc5324630bde5c95581a2149f58f837"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"3f5fd63dab00536201d37a58502066a6ed2f8a78","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        base_path \u003d os.path.split(os.path.dirname("},{"line_number":27,"context_line":"            os.path.abspath(__file__)))[0]"},{"line_number":28,"context_line":"        base_path +\u003d \u0027/../..\u0027"},{"line_number":29,"context_line":"        test_dir \u003d \"zaqar/tests/tempest_plugin/tests\""},{"line_number":30,"context_line":"        full_test_dir \u003d os.path.join(base_path, test_dir)"},{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_1544f147","line":29,"in_reply_to":"ba0121b8_5a9218f7","updated":"2016-03-31 02:30:47.000000000","message":"\"testr list-tests tempest_plugin\"\nwith \"testr list-tests zaqar\", you won\u0027t see anything. That\u0027s the thing i\u0027m trying to fix. We need to \u0027rename\u0027 tempest_plugin to zaqar for the test listing.","commit_id":"e7d833400fc5324630bde5c95581a2149f58f837"},{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"83b34e47527448e1b558f7adc99c8686fea116eb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        base_path \u003d os.path.split(os.path.dirname("},{"line_number":27,"context_line":"            os.path.abspath(__file__)))[0]"},{"line_number":28,"context_line":"        base_path +\u003d \u0027/../..\u0027"},{"line_number":29,"context_line":"        test_dir \u003d \"zaqar/tests/tempest_plugin/tests\""},{"line_number":30,"context_line":"        full_test_dir \u003d os.path.join(base_path, test_dir)"},{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_5a9218f7","line":29,"in_reply_to":"ba0121b8_da974838","updated":"2016-03-31 02:22:18.000000000","message":"That\u0027s odd, changing test_dir doesn\u0027t works for me. Are you using command \u0027testr list-tests zaqar\u0027 ?","commit_id":"e7d833400fc5324630bde5c95581a2149f58f837"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"3f61a6ad4a99ffee22af0cae4d6c0dc68446ce12","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        base_path \u003d os.path.split(os.path.dirname("},{"line_number":27,"context_line":"            os.path.abspath(__file__)))[0]"},{"line_number":28,"context_line":"        base_path +\u003d \u0027/../..\u0027"},{"line_number":29,"context_line":"        test_dir \u003d \"zaqar/tests/tempest_plugin/tests\""},{"line_number":30,"context_line":"        full_test_dir \u003d os.path.join(base_path, test_dir)"},{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_da974838","line":29,"in_reply_to":"ba0121b8_daa90892","updated":"2016-03-31 02:10:26.000000000","message":"Oh, really? Just tried and it works for me.","commit_id":"e7d833400fc5324630bde5c95581a2149f58f837"}]}