)]}'
{"devstack/gate/gate_hook.sh":[{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"5ce1fa90dfedfbf5eafe0866b615f72aee97ad09","unresolved":false,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"function run_tempest_tests() {"},{"line_number":40,"context_line":"    export BASE\u003d/opt/stack"},{"line_number":41,"context_line":"    export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":42,"context_line":"    sudo chmod -R a+rw /opt/stack/"},{"line_number":43,"context_line":"    cd $BASE/new/tempest/; sudo virtualenv .venv"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a18252c_9af892e7","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":26},"updated":"2016-04-12 23:28:31.000000000","message":"Hm, if I\u0027m not mistaken, BASE environment variable is already defined before this line, so maybe we shouldn\u0027t redefine it.","commit_id":"32e641f33ec5a681a54b2a7f9e2f76140703c7f0"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"e81ab8184c9ffef3cbc0ef8c68feaacd69782a75","unresolved":false,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"function run_tempest_tests() {"},{"line_number":40,"context_line":"    export BASE\u003d/opt/stack"},{"line_number":41,"context_line":"    export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":42,"context_line":"    sudo chmod -R a+rw /opt/stack/"},{"line_number":43,"context_line":"    cd $BASE/new/tempest/; sudo virtualenv .venv"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a18252c_bad10ed0","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":26},"in_reply_to":"5a18252c_5a943a36","updated":"2016-04-12 23:57:46.000000000","message":"Here: https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L120\nBut I\u0027m not sure.","commit_id":"32e641f33ec5a681a54b2a7f9e2f76140703c7f0"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"113c0a6700865087fd40c66c8d03a7762a88bd25","unresolved":false,"context_lines":[{"line_number":37,"context_line":"}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"function run_tempest_tests() {"},{"line_number":40,"context_line":"    export BASE\u003d/opt/stack"},{"line_number":41,"context_line":"    export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":42,"context_line":"    sudo chmod -R a+rw /opt/stack/"},{"line_number":43,"context_line":"    cd $BASE/new/tempest/; sudo virtualenv .venv"}],"source_content_type":"text/x-sh","patch_set":7,"id":"5a18252c_5a943a36","line":40,"range":{"start_line":40,"start_character":4,"end_line":40,"end_character":26},"in_reply_to":"5a18252c_9af892e7","updated":"2016-04-12 23:41:41.000000000","message":"Where?","commit_id":"32e641f33ec5a681a54b2a7f9e2f76140703c7f0"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"b6c6d5810e87be7d20f6460e02d0da99f6d1262c","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":41,"context_line":"    run_devstack_gate"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    cd $BASE/new/tempest/; sudo -E testr init"},{"line_number":44,"context_line":"    cd $BASE/new/tempest/; sudo -E tox -eall-plugin zaqar"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"function run_zaqarclient_tests() {"}],"source_content_type":"text/x-sh","patch_set":30,"id":"9abb7d3a_5470ec0a","line":44,"range":{"start_line":43,"start_character":4,"end_line":44,"end_character":57},"updated":"2016-06-02 01:54:08.000000000","message":"Hi. I have two questions:\n1. Is it needed to \"cd\" two times to \"$BASE/new/tempest/\"?\n2. Why we use \"sudo -E\"? Is it mandatory?","commit_id":"61ed3aa93bfc4f78cf23d633d8e1e5d9077b54eb"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"79300a4560899e3f5e86911b2e92eba4a0a35684","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":41,"context_line":"    run_devstack_gate"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    cd $BASE/new/tempest/; sudo -E testr init"},{"line_number":44,"context_line":"    cd $BASE/new/tempest/; sudo -E tox -eall-plugin zaqar"},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"function run_zaqarclient_tests() {"}],"source_content_type":"text/x-sh","patch_set":30,"id":"9abb7d3a_bf65b145","line":44,"range":{"start_line":43,"start_character":4,"end_line":44,"end_character":57},"in_reply_to":"9abb7d3a_5470ec0a","updated":"2016-06-02 02:31:54.000000000","message":"It\u0027s copy-paste.\n\nFor #1, I think we can just enter the path one time.\nFor #2, it can make sure we have permission to run the command. TBH, I\u0027m not sure if we can get rid of them. But we can give it a try.","commit_id":"61ed3aa93bfc4f78cf23d633d8e1e5d9077b54eb"}],"zaqar/storage/sqlalchemy/driver.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"350d2f932c42c6fc0e99fe8abe40ffac803bd614","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def close(self):"},{"line_number":78,"context_line":"        self.connection.close()"},{"line_number":79,"context_line":"        self.engine_connection.close()"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"},{"line_number":82,"context_line":"    def pools_controller(self):"}],"source_content_type":"text/x-python","patch_set":21,"id":"bab6814e_fb8f1fca","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":38},"updated":"2016-05-24 12:15:44.000000000","message":"It seems that the connection has never been closed?","commit_id":"5204d763e79bf77abf74e5260eb89d45db84cf91"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"9bf780ff88b73a12ea0665b308d910171555a49a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    # that acquires the connection to the DB for the desired scope and"},{"line_number":67,"context_line":"    # closes it once the operations are completed"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    # NOTE: This function is useless now, we should migrate to oslo.db asap."},{"line_number":70,"context_line":"    @decorators.lazy_property(write\u003dFalse)"},{"line_number":71,"context_line":"    def connection(self):"},{"line_number":72,"context_line":"        return self.engine.connect()"}],"source_content_type":"text/x-python","patch_set":24,"id":"9abb7d3a_03a1d094","line":69,"range":{"start_line":69,"start_character":6,"end_line":69,"end_character":11},"updated":"2016-05-28 08:32:37.000000000","message":"nit: should be TODO(wangxiyuan).","commit_id":"23c9f13be9a51d2b82e42367925cbacbc189c1f3"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"9bf780ff88b73a12ea0665b308d910171555a49a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        res \u003d session().execute(*args, **kwargs)"},{"line_number":79,"context_line":"        return res"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # NOTE: This function is useless now, we should migrate to oslo.db asap."},{"line_number":82,"context_line":"    def close(self):"},{"line_number":83,"context_line":"        self.connection.close()"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"9abb7d3a_a3b604da","line":81,"range":{"start_line":81,"start_character":6,"end_line":81,"end_character":10},"updated":"2016-05-28 08:32:37.000000000","message":"same as above.","commit_id":"23c9f13be9a51d2b82e42367925cbacbc189c1f3"}]}
