)]}'
{"zaqar/tests/unit/storage/base.py":[{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"09e69eaf2d6127bdf54faa1577d562d2e99b4612","unresolved":false,"context_lines":[{"line_number":975,"context_line":"        super(SubscriptionControllerTest, self).setUp()"},{"line_number":976,"context_line":"        self.subscription_controller \u003d self.driver.subscription_controller"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"        # Lets create a queue as the source of subscription"},{"line_number":979,"context_line":"        self.queue_controller \u003d self.driver.queue_controller"},{"line_number":980,"context_line":"        self.queue_controller.create(self.queue_name, project\u003dself.project)"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"        self.source \u003d self.queue_name"},{"line_number":983,"context_line":"        self.subscriber \u003d \u0027http://trigger.me\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_3eea0ead","line":980,"range":{"start_line":978,"start_character":0,"end_line":980,"end_character":75},"updated":"2016-05-25 03:08:54.000000000","message":"Now with lazy queues in subscriptions these lines can be removed and tests will still pass. Is it wrong that I didn\u0027t removed them?","commit_id":"07b9177d6de3e60a6c9479e05a47ebd5686828f9"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"d3d94df26993638fb0c33b8b356261e8aeeadfab","unresolved":false,"context_lines":[{"line_number":975,"context_line":"        super(SubscriptionControllerTest, self).setUp()"},{"line_number":976,"context_line":"        self.subscription_controller \u003d self.driver.subscription_controller"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"        # Lets create a queue as the source of subscription"},{"line_number":979,"context_line":"        self.queue_controller \u003d self.driver.queue_controller"},{"line_number":980,"context_line":"        self.queue_controller.create(self.queue_name, project\u003dself.project)"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"        self.source \u003d self.queue_name"},{"line_number":983,"context_line":"        self.subscriber \u003d \u0027http://trigger.me\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_35935dfc","line":980,"range":{"start_line":978,"start_character":0,"end_line":980,"end_character":75},"in_reply_to":"9abb7d3a_470f562e","updated":"2016-06-03 03:59:59.000000000","message":"Yes, I\u0027ll do it.","commit_id":"07b9177d6de3e60a6c9479e05a47ebd5686828f9"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a5c4470a109c86d588afa38e2e27bace9d782aca","unresolved":false,"context_lines":[{"line_number":975,"context_line":"        super(SubscriptionControllerTest, self).setUp()"},{"line_number":976,"context_line":"        self.subscription_controller \u003d self.driver.subscription_controller"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"        # Lets create a queue as the source of subscription"},{"line_number":979,"context_line":"        self.queue_controller \u003d self.driver.queue_controller"},{"line_number":980,"context_line":"        self.queue_controller.create(self.queue_name, project\u003dself.project)"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"        self.source \u003d self.queue_name"},{"line_number":983,"context_line":"        self.subscriber \u003d \u0027http://trigger.me\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_470f562e","line":980,"range":{"start_line":978,"start_character":0,"end_line":980,"end_character":75},"in_reply_to":"bab6814e_3eea0ead","updated":"2016-05-29 22:39:58.000000000","message":"Could we figure out a way to make sure subscriptions work w/ and w/o queue? Because we care about the both of the two cases.","commit_id":"07b9177d6de3e60a6c9479e05a47ebd5686828f9"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"a8bd45d8eb38ba03c5bd3400aea5668000b70a2e","unresolved":false,"context_lines":[{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    @ddt.data(True, False)"},{"line_number":997,"context_line":"    def test_list(self, precreate_queue):"},{"line_number":998,"context_line":"        self._precreate_queue(precreate_queue)"},{"line_number":999,"context_line":"        for s in six.moves.xrange(15):"},{"line_number":1000,"context_line":"            subscriber \u003d \u0027http://fake_{0}\u0027.format(s)"},{"line_number":1001,"context_line":"            s_id \u003d self.subscription_controller.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_5b427e3f","line":998,"range":{"start_line":998,"start_character":8,"end_line":998,"end_character":46},"updated":"2016-06-07 01:55:44.000000000","message":"FIY: I don\u0027t like much that I included this line and added \"precreate_queue\" argument in almost every test case. I tried to make a beautiful decorator which does the same thing, but failed. Maybe you know how to do it?\n\nThough maybe it\u0027s okay.","commit_id":"889ef93809a4f2cb895899f67f2f27b0f49d3aff"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"119063f6758ae0eea835f3e5aa9ce0eaf5eadb6e","unresolved":false,"context_lines":[{"line_number":995,"context_line":""},{"line_number":996,"context_line":"    @ddt.data(True, False)"},{"line_number":997,"context_line":"    def test_list(self, precreate_queue):"},{"line_number":998,"context_line":"        self._precreate_queue(precreate_queue)"},{"line_number":999,"context_line":"        for s in six.moves.xrange(15):"},{"line_number":1000,"context_line":"            subscriber \u003d \u0027http://fake_{0}\u0027.format(s)"},{"line_number":1001,"context_line":"            s_id \u003d self.subscription_controller.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_fa4c729f","line":998,"range":{"start_line":998,"start_character":8,"end_line":998,"end_character":46},"in_reply_to":"7aa08908_5b427e3f","updated":"2016-06-08 23:02:38.000000000","message":"It\u0027s ok for me.","commit_id":"889ef93809a4f2cb895899f67f2f27b0f49d3aff"}],"zaqar/transport/wsgi/v2_0/subscriptions.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"68f6911f67de92599e008b5d3a9b0c78a97dd18c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            document \u003d {}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        try:"},{"line_number":175,"context_line":"            self._validate.queue_identification(queue_name, project_id)"},{"line_number":176,"context_line":"            if not self._queue_controller.exists(queue_name, project_id):"},{"line_number":177,"context_line":"                self._queue_controller.create(queue_name, project\u003dproject_id)"},{"line_number":178,"context_line":"            self._validate.subscription_posting(document)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_827c5573","line":175,"range":{"start_line":175,"start_character":11,"end_line":175,"end_character":71},"updated":"2016-06-12 01:38:08.000000000","message":"this line is useless here. We have checked it at https://github.com/openstack/zaqar/blob/master/zaqar/transport/wsgi/driver.py#L100","commit_id":"87a973deb027858476f7478d3461d6082e247678"},{"author":{"_account_id":18683,"name":"Eva Balycheva","email":"ubershy@gmail.com","username":"eva"},"change_message_id":"a0265fc61869b847019ef63a9c0f1d58bb1c401b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            document \u003d {}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        try:"},{"line_number":175,"context_line":"            self._validate.queue_identification(queue_name, project_id)"},{"line_number":176,"context_line":"            if not self._queue_controller.exists(queue_name, project_id):"},{"line_number":177,"context_line":"                self._queue_controller.create(queue_name, project\u003dproject_id)"},{"line_number":178,"context_line":"            self._validate.subscription_posting(document)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_094d2899","line":175,"range":{"start_line":175,"start_character":11,"end_line":175,"end_character":71},"in_reply_to":"7aa08908_827c5573","updated":"2016-06-12 22:17:51.000000000","message":"Thank you. You are right, I will remove it now.","commit_id":"87a973deb027858476f7478d3461d6082e247678"}]}