)]}'
{"zaqar/bootstrap.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"75b5c371a0677e9ba606544741d62c9496e369bc","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.driver_conf \u003d self.conf[configs._DRIVER_GROUP]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log.register_options(conf)"},{"line_number":51,"context_line":"        log.setup(conf, \u0027zaqar\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.lazy_property(write\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_f71acb7b","line":50,"updated":"2016-06-08 22:30:30.000000000","message":"Why do we have to register the options at here again? Thanks.","commit_id":"142912e54f56ee7cc1745898170d808403fcc351"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"b32b00678534aaf1dc100065cf76ba5dd6f2b7a1","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.driver_conf \u003d self.conf[configs._DRIVER_GROUP]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log.register_options(conf)"},{"line_number":51,"context_line":"        log.setup(conf, \u0027zaqar\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.lazy_property(write\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_75c25386","line":50,"in_reply_to":"7aa08908_3a6c3a07","updated":"2016-06-08 23:11:08.000000000","message":"It is needed there because logging_context_format_string default is changed and for that config parameter must be registered first.\n\nThere are two code paths for zaqar startup which need to be take care of:\n* zaqar.transport.wsgi.app\n* zaqar.cmd.server\n\nand the whole issue with tempest CLI is only because of import zaqar.bootstrap in zaqar/__init__.py, just to have zaqar.Bootstrap shortcut!\nRemoving that would side-step the whole issue but I\u0027m not sure if zaqar.Bootstrap could be considered part of public API ?","commit_id":"142912e54f56ee7cc1745898170d808403fcc351"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a7693d4b06f0061340edad3ab5703f67c0dc501b","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.driver_conf \u003d self.conf[configs._DRIVER_GROUP]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log.register_options(conf)"},{"line_number":51,"context_line":"        log.setup(conf, \u0027zaqar\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.lazy_property(write\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_3a6c3a07","line":50,"in_reply_to":"7aa08908_3ae71aad","updated":"2016-06-08 22:58:06.000000000","message":"Thanks, then do we still need to set it at line 40 https://review.openstack.org/#/c/327268/3/zaqar/cmd/server.py ?","commit_id":"142912e54f56ee7cc1745898170d808403fcc351"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"8b32dada4d77d9a8c98d66835d1689218a856a53","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.driver_conf \u003d self.conf[configs._DRIVER_GROUP]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        log.register_options(conf)"},{"line_number":51,"context_line":"        log.setup(conf, \u0027zaqar\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @decorators.lazy_property(write\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_3ae71aad","line":50,"in_reply_to":"7aa08908_f71acb7b","updated":"2016-06-08 22:55:16.000000000","message":"log.setup is expecting logging options to be registered,\nin PS2 CI jobs there is traceback:\n\n  File \"/opt/stack/new/zaqar/zaqar/transport/wsgi/app.py\", line 39, in \u003cmodule\u003e\n    boot \u003d bootstrap.Bootstrap(conf)\n  File \"/opt/stack/new/zaqar/zaqar/bootstrap.py\", line 50, in __init__\n    log.setup(conf, \u0027zaqar\u0027)\n  File \"/usr/local/lib/python2.7/dist-packages/oslo_log/log.py\", line 251, in setup\n    if conf.log_config_append:\n  File \"/usr/local/lib/python2.7/dist-packages/oslo_config/cfg.py\", line 2185, in __getattr__\n    raise NoSuchOptError(name)\noslo_config.cfg.NoSuchOptError: no such option in group DEFAULT: log_config_append","commit_id":"142912e54f56ee7cc1745898170d808403fcc351"}],"zaqar/cmd/server.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ed2c0f502c8d5bfc52aaa12b0c2d9d92fc3ed152","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    conf \u003d cfg.CONF"},{"line_number":38,"context_line":"    # NOTE(eggmaster): register command line options for zaqar-server"},{"line_number":39,"context_line":"    conf.register_cli_opts(_CLI_OPTIONS)"},{"line_number":40,"context_line":"    log.register_options(conf)"},{"line_number":41,"context_line":"    # NOTE(jeffrey4l): Overwrite the default vaule for"},{"line_number":42,"context_line":"    # logging_context_format_string. Add project_id into it."},{"line_number":43,"context_line":"    conf.set_default(\u0027logging_context_format_string\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_d5e6a742","line":40,"updated":"2016-06-08 23:11:23.000000000","message":"I mean this line. this line code will be run again at line 49, the constructor of Bootstrap. So is it really necessary to keep this line? Thanks.","commit_id":"142912e54f56ee7cc1745898170d808403fcc351"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"29d7bab8aff265bc41531e2aa859e2c279da3e95","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    conf \u003d cfg.CONF"},{"line_number":38,"context_line":"    # NOTE(eggmaster): register command line options for zaqar-server"},{"line_number":39,"context_line":"    conf.register_cli_opts(_CLI_OPTIONS)"},{"line_number":40,"context_line":"    log.register_options(conf)"},{"line_number":41,"context_line":"    # NOTE(jeffrey4l): Overwrite the default vaule for"},{"line_number":42,"context_line":"    # logging_context_format_string. Add project_id into it."},{"line_number":43,"context_line":"    conf.set_default(\u0027logging_context_format_string\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_35ad6b9b","line":40,"in_reply_to":"7aa08908_95fc1fb9","updated":"2016-06-08 23:18:39.000000000","message":"Zaqar only has one process, the zaqar-server, so I think it should be fine.","commit_id":"142912e54f56ee7cc1745898170d808403fcc351"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"2a96a108bd9b73b91d74ec07d74e98f5c12dba73","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    conf \u003d cfg.CONF"},{"line_number":38,"context_line":"    # NOTE(eggmaster): register command line options for zaqar-server"},{"line_number":39,"context_line":"    conf.register_cli_opts(_CLI_OPTIONS)"},{"line_number":40,"context_line":"    log.register_options(conf)"},{"line_number":41,"context_line":"    # NOTE(jeffrey4l): Overwrite the default vaule for"},{"line_number":42,"context_line":"    # logging_context_format_string. Add project_id into it."},{"line_number":43,"context_line":"    conf.set_default(\u0027logging_context_format_string\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_95fc1fb9","line":40,"in_reply_to":"7aa08908_d5e6a742","updated":"2016-06-08 23:14:43.000000000","message":"We\u0027d have to get rid of conf.set_default below.\nCould this default be changed in Bootstrap for all zaqar processes or it is really only for zaqar-server only?","commit_id":"142912e54f56ee7cc1745898170d808403fcc351"}]}