)]}'
{"zaqar/api/v1/response.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b7031e8c577d557657103b14775ba6ff0a980008","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                \u0027required\u0027: [\u0027links\u0027, \u0027queues\u0027],"},{"line_number":112,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":113,"context_line":"            },"},{"line_number":114,"context_line":"            \u0027queue_stats\u0027: {"},{"line_number":115,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":116,"context_line":"                \u0027properties\u0027: {"},{"line_number":117,"context_line":"                    \u0027messages\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_c96ce537","line":114,"range":{"start_line":114,"start_character":13,"end_line":114,"end_character":24},"updated":"2016-09-07 01:27:29.000000000","message":"and this","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"52312256bdb0ac11b8ccea80e9e209fba9f4c8b1","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                \u0027required\u0027: [\u0027links\u0027, \u0027queues\u0027],"},{"line_number":112,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":113,"context_line":"            },"},{"line_number":114,"context_line":"            \u0027queue_stats\u0027: {"},{"line_number":115,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":116,"context_line":"                \u0027properties\u0027: {"},{"line_number":117,"context_line":"                    \u0027messages\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_e4e55038","line":114,"range":{"start_line":114,"start_character":13,"end_line":114,"end_character":24},"in_reply_to":"9a89bdaa_44543cfe","updated":"2016-09-07 01:48:41.000000000","message":"Yes, rename it to \u0027queue_get_stats\u0027 to keep the same with others seems the right way. Let\u0027s do it in the next patch.","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"8724498c38844cba3281f30202b0c90cba7cd08b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                \u0027required\u0027: [\u0027links\u0027, \u0027queues\u0027],"},{"line_number":112,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":113,"context_line":"            },"},{"line_number":114,"context_line":"            \u0027queue_stats\u0027: {"},{"line_number":115,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":116,"context_line":"                \u0027properties\u0027: {"},{"line_number":117,"context_line":"                    \u0027messages\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_44543cfe","line":114,"range":{"start_line":114,"start_character":13,"end_line":114,"end_character":24},"in_reply_to":"9a89bdaa_c96ce537","updated":"2016-09-07 01:36:15.000000000","message":"em, considered this, it looks like the \u0027queue_stats\u0027 is about a data structure returned to user as a response to the \u0027queue_get_stats\u0027 operation. It is an outstanding one.\n\nI\u0027d prefer leaving this to another patch. Actually, for consistency, I\u0027d prefer rename this to \u0027queue_get_stats\u0027 just like other data structures in this module. In other words, we clearly define each response by the request name for all responses.\n\nAt this stage, I\u0027m not sure if that renaming would cause some problems somewhere.","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"}],"zaqar/api/v1_1/response.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b7031e8c577d557657103b14775ba6ff0a980008","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":153,"context_line":"            },"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            \u0027queue_stats\u0027: {"},{"line_number":156,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":157,"context_line":"                \u0027properties\u0027: {"},{"line_number":158,"context_line":"                    \u0027messages\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_6958398b","line":155,"range":{"start_line":155,"start_character":13,"end_line":155,"end_character":24},"updated":"2016-09-07 01:27:29.000000000","message":"here","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b7031e8c577d557657103b14775ba6ff0a980008","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                    }"},{"line_number":273,"context_line":"                }"},{"line_number":274,"context_line":"            },"},{"line_number":275,"context_line":"            \u0027pool_detail\u0027: {"},{"line_number":276,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":277,"context_line":"                \u0027properties\u0027: {"},{"line_number":278,"context_line":"                    \u0027name\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_094a4dac","line":275,"range":{"start_line":275,"start_character":13,"end_line":275,"end_character":25},"updated":"2016-09-07 01:27:29.000000000","message":"here","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"8724498c38844cba3281f30202b0c90cba7cd08b","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                    }"},{"line_number":273,"context_line":"                }"},{"line_number":274,"context_line":"            },"},{"line_number":275,"context_line":"            \u0027pool_detail\u0027: {"},{"line_number":276,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":277,"context_line":"                \u0027properties\u0027: {"},{"line_number":278,"context_line":"                    \u0027name\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_a46a68b1","line":275,"range":{"start_line":275,"start_character":13,"end_line":275,"end_character":25},"in_reply_to":"9a89bdaa_094a4dac","updated":"2016-09-07 01:36:15.000000000","message":"this is the same. I have to figure out what this JSON structure is defining. Is it about the response of \u0027pool_get\u0027? Then we should rename it to \u0027pool_get\u0027. There is not such operation called \u0027pool_detail\u0027. Calling it \u0027pool_detail\u0027 may imply that there are \u0027pool_get\u0027 operation returning simplified version of pool properties and a dedicated \u0027pool_detail\u0027 operation yielding more details. Indeed, there are some services doing that ... stupid ... thing.","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"52312256bdb0ac11b8ccea80e9e209fba9f4c8b1","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                    }"},{"line_number":273,"context_line":"                }"},{"line_number":274,"context_line":"            },"},{"line_number":275,"context_line":"            \u0027pool_detail\u0027: {"},{"line_number":276,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":277,"context_line":"                \u0027properties\u0027: {"},{"line_number":278,"context_line":"                    \u0027name\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_04c4f45c","line":275,"range":{"start_line":275,"start_character":13,"end_line":275,"end_character":25},"in_reply_to":"9a89bdaa_a46a68b1","updated":"2016-09-07 01:48:41.000000000","message":"I got your point. Actually we use /pool/{pool_name} to get the pool ,and use /pool/{pool_name}?detailed\u003dTrue to get the pool\u0027s detail information. It\u0027s really a problem. So Could you please write a TODO here to highlight it. We can find a better way later.","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"}],"zaqar/api/v2/response.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b7031e8c577d557657103b14775ba6ff0a980008","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                \u0027additionalProperties\u0027: False,"},{"line_number":153,"context_line":"            },"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            \u0027queue_stats\u0027: {"},{"line_number":156,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":157,"context_line":"                \u0027properties\u0027: {"},{"line_number":158,"context_line":"                    \u0027messages\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_69cf5929","line":155,"range":{"start_line":155,"start_character":13,"end_line":155,"end_character":24},"updated":"2016-09-07 01:27:29.000000000","message":"here","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b7031e8c577d557657103b14775ba6ff0a980008","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                    }"},{"line_number":273,"context_line":"                }"},{"line_number":274,"context_line":"            },"},{"line_number":275,"context_line":"            \u0027pool_detail\u0027: {"},{"line_number":276,"context_line":"                \u0027type\u0027: \u0027object\u0027,"},{"line_number":277,"context_line":"                \u0027properties\u0027: {"},{"line_number":278,"context_line":"                    \u0027name\u0027: {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_a9dde1e1","line":275,"range":{"start_line":275,"start_character":13,"end_line":275,"end_character":24},"updated":"2016-09-07 01:27:29.000000000","message":"here","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"}],"zaqar/common/consts.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b7031e8c577d557657103b14775ba6ff0a980008","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRANSPORT_DRIVERS \u003d ("},{"line_number":16,"context_line":"    TRANSPORT_WSGI, TRANSPORT_WEBSOCKET,"},{"line_number":17,"context_line":") \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_89473d76","line":14,"updated":"2016-09-07 01:27:29.000000000","message":"As mentioned in other files, \"queue_stats\" and \"pool_detail\" are missed here.","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"8724498c38844cba3281f30202b0c90cba7cd08b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TRANSPORT_DRIVERS \u003d ("},{"line_number":16,"context_line":"    TRANSPORT_WSGI, TRANSPORT_WEBSOCKET,"},{"line_number":17,"context_line":") \u003d ("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_e4b71038","line":14,"in_reply_to":"9a89bdaa_89473d76","updated":"2016-09-07 01:36:15.000000000","message":"I left them out intentionally, because those two are not themselve operations. They seem to me like names of data structures to be returned by some related operations.","commit_id":"7b4743c27ad4825693c00a58c3873f6d274e0290"}]}
