)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"6fcb57759db625eda9c7b2f90fda6c7319965066","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t send confirmation notification if it\u0027s not enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently even though the \u0027require_confirmation\u0027 option is False,"},{"line_number":10,"context_line":"Zaqar will send the confirmation notification anyway, which isn\u0027t"},{"line_number":11,"context_line":"breaking the backward compatibility. This patch will fix it and"},{"line_number":12,"context_line":"add a test for that."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a629dbe_9917f750","line":10,"updated":"2016-11-07 20:58:46.000000000","message":"You mean *is* breaking the compatibility?","commit_id":"4799dd5c5e488cae38cd28697f252d40be040412"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"128c091d44fc39d29c425b858e759d16ed6152b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t send confirmation notification if it\u0027s not enabled"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently even though the \u0027require_confirmation\u0027 option is False,"},{"line_number":10,"context_line":"Zaqar will send the confirmation notification anyway, which isn\u0027t"},{"line_number":11,"context_line":"breaking the backward compatibility. This patch will fix it and"},{"line_number":12,"context_line":"add a test for that."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a629dbe_ad5f1571","line":10,"in_reply_to":"9a629dbe_9917f750","updated":"2016-11-07 23:11:58.000000000","message":"Good catch.","commit_id":"4799dd5c5e488cae38cd28697f252d40be040412"}],"zaqar/common/auth.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"6fcb57759db625eda9c7b2f90fda6c7319965066","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                 impersonation\u003dTrue,"},{"line_number":69,"context_line":"                                 role_names\u003droles,"},{"line_number":70,"context_line":"                                 expires_at\u003dexpires_at)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    return trust.id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_b9775bd3","line":71,"updated":"2016-11-07 20:58:46.000000000","message":"Changes in that file look unrelated, please remove them.","commit_id":"4799dd5c5e488cae38cd28697f252d40be040412"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"128c091d44fc39d29c425b858e759d16ed6152b2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                 impersonation\u003dTrue,"},{"line_number":69,"context_line":"                                 role_names\u003droles,"},{"line_number":70,"context_line":"                                 expires_at\u003dexpires_at)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    return trust.id"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_4d603936","line":71,"in_reply_to":"9a629dbe_b9775bd3","updated":"2016-11-07 23:11:58.000000000","message":"Done","commit_id":"4799dd5c5e488cae38cd28697f252d40be040412"}],"zaqar/notification/notifier.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"6fcb57759db625eda9c7b2f90fda6c7319965066","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # NOTE(flwang): If the confirmation feature isn\u0027t enabled, just do"},{"line_number":86,"context_line":"        # nothing."},{"line_number":87,"context_line":"        if conf.notification.require_confirmation is False:"},{"line_number":88,"context_line":"            return"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        key \u003d conf.signed_url.secret_key"},{"line_number":91,"context_line":"        if not key:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_594f1f92","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":18},"updated":"2016-11-07 20:58:46.000000000","message":"Please use self.require_confirmation, and do a regular boolean operation (if not self.require_confirmation:. Don\u0027t use identity).","commit_id":"4799dd5c5e488cae38cd28697f252d40be040412"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"128c091d44fc39d29c425b858e759d16ed6152b2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # NOTE(flwang): If the confirmation feature isn\u0027t enabled, just do"},{"line_number":86,"context_line":"        # nothing."},{"line_number":87,"context_line":"        if conf.notification.require_confirmation is False:"},{"line_number":88,"context_line":"            return"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        key \u003d conf.signed_url.secret_key"},{"line_number":91,"context_line":"        if not key:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_2d75c5f8","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":18},"in_reply_to":"9a629dbe_594f1f92","updated":"2016-11-07 23:11:58.000000000","message":"Done","commit_id":"4799dd5c5e488cae38cd28697f252d40be040412"}],"zaqar/tests/unit/notification/test_notifier.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"6fcb57759db625eda9c7b2f90fda6c7319965066","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        subscription \u003d [{\u0027subscriber\u0027: \u0027http://trigger_me\u0027,"},{"line_number":308,"context_line":"                         \u0027source\u0027: \u0027fake_queue\u0027, \u0027options\u0027: {}}]"},{"line_number":309,"context_line":"        ctlr \u003d mock.MagicMock()"},{"line_number":310,"context_line":"        ctlr.list \u003d mock.Mock(return_value\u003diter([subscription, {}]))"},{"line_number":311,"context_line":"        driver \u003d notifier.NotifierDriver(subscription_controller\u003dctlr)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        driver.send_confirm_notification(\u0027test_queue\u0027, subscription, self.conf,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_9940d758","line":310,"updated":"2016-11-07 20:58:46.000000000","message":"Why do you mean to mock list here?","commit_id":"4799dd5c5e488cae38cd28697f252d40be040412"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"128c091d44fc39d29c425b858e759d16ed6152b2","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        subscription \u003d [{\u0027subscriber\u0027: \u0027http://trigger_me\u0027,"},{"line_number":308,"context_line":"                         \u0027source\u0027: \u0027fake_queue\u0027, \u0027options\u0027: {}}]"},{"line_number":309,"context_line":"        ctlr \u003d mock.MagicMock()"},{"line_number":310,"context_line":"        ctlr.list \u003d mock.Mock(return_value\u003diter([subscription, {}]))"},{"line_number":311,"context_line":"        driver \u003d notifier.NotifierDriver(subscription_controller\u003dctlr)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        driver.send_confirm_notification(\u0027test_queue\u0027, subscription, self.conf,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_4d7919fc","line":310,"in_reply_to":"9a629dbe_9940d758","updated":"2016-11-07 23:11:58.000000000","message":"Done","commit_id":"4799dd5c5e488cae38cd28697f252d40be040412"}]}