)]}'
{"zaqar/api/v2/endpoints.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"bebb498613056fcecbaddc16b604d673649f1d1b","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        \"\"\""},{"line_number":234,"context_line":"        project_id \u003d req._headers.get(\u0027X-Project-ID\u0027)"},{"line_number":235,"context_line":"        queue_name \u003d req._body.get(\u0027queue_name\u0027)"},{"line_number":236,"context_line":"        resource_types \u003d req._body.get(\u0027resource_types\u0027)"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        LOG.debug(u\u0027Purge queue - queue: %(queue)s, \u0027"},{"line_number":239,"context_line":"                  u\u0027project: %(project)s\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_23252d08","line":236,"range":{"start_line":236,"start_character":0,"end_line":236,"end_character":56},"updated":"2016-12-16 06:42:38.000000000","message":"the resource_types is optional. the default value is [\u0027messages\u0027, \u0027subscriptions\u0027].","commit_id":"b34b626fe8f3db173005ded8731e25f286ce75ba"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"96deaa354ba6cc6ac863548c6c0cc996042910d8","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        try:"},{"line_number":244,"context_line":"            pop_limit \u003d 100"},{"line_number":245,"context_line":"            if \"messages\" in resource_types:"},{"line_number":246,"context_line":"                LOG.debug(\"Purge all messages under queue %s\" % queue_name)"},{"line_number":247,"context_line":"                resp \u003d self._pop_messages(req, queue_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_99762905","line":244,"range":{"start_line":244,"start_character":12,"end_line":244,"end_character":27},"updated":"2016-12-19 07:17:50.000000000","message":"this too. I think we could use one configure option in default group to avoid hardcode here.","commit_id":"5b1f9156c020bc12f82fe9d0e005422effbbf04c"}],"zaqar/transport/wsgi/v2_0/purge.py":[{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"96deaa354ba6cc6ac863548c6c0cc996042910d8","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            if \"messages\" in document[\u0027resource_types\u0027]:"},{"line_number":61,"context_line":"                pop_limit \u003d 100"},{"line_number":62,"context_line":"                LOG.debug(\"Purge all messages under queue %s\" % queue_name)"},{"line_number":63,"context_line":"                messages \u003d self._message_ctrl.pop(queue_name, pop_limit,"},{"line_number":64,"context_line":"                                                  project\u003dproject_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_d9026172","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":31},"updated":"2016-12-19 07:17:50.000000000","message":"Could we consider to set it as a config option?","commit_id":"5b1f9156c020bc12f82fe9d0e005422effbbf04c"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"2c111d30cb68b3c2d47f500fbafb75f920e81d1f","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            if \"messages\" in document[\u0027resource_types\u0027]:"},{"line_number":61,"context_line":"                pop_limit \u003d 100"},{"line_number":62,"context_line":"                LOG.debug(\"Purge all messages under queue %s\" % queue_name)"},{"line_number":63,"context_line":"                messages \u003d self._message_ctrl.pop(queue_name, pop_limit,"},{"line_number":64,"context_line":"                                                  project\u003dproject_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_fe8a7519","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":31},"in_reply_to":"1a6eadb0_2b903695","updated":"2016-12-20 00:36:42.000000000","message":"It make sense to me,  TODO will be nice.","commit_id":"5b1f9156c020bc12f82fe9d0e005422effbbf04c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"eb13bae6e71afc6cb3674f41e9a4403ded527437","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            if \"messages\" in document[\u0027resource_types\u0027]:"},{"line_number":61,"context_line":"                pop_limit \u003d 100"},{"line_number":62,"context_line":"                LOG.debug(\"Purge all messages under queue %s\" % queue_name)"},{"line_number":63,"context_line":"                messages \u003d self._message_ctrl.pop(queue_name, pop_limit,"},{"line_number":64,"context_line":"                                                  project\u003dproject_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_2b903695","line":61,"range":{"start_line":61,"start_character":16,"end_line":61,"end_character":31},"in_reply_to":"1a6eadb0_d9026172","updated":"2016-12-19 20:39:21.000000000","message":"I can see your point, but I\u0027m reluctant to add a config option for this. I didn\u0027t think about why I don\u0027t want to do this, now I\u0027m trying to summarize the reasons:\n\n1. It only impacts the deletion of messages.\n2. It\u0027s not easy to describe the effect of this option.\n3. Technically, there is no obvious benefit to change the value. For example, there are 100000 messages. Yes, that means you have to send 100 requests to delete all of them based on pop_limit\u003d100. You can set it with 1000 or 10000, but I\u0027m not sure if it could generate any other issue.\n\nHow about let\u0027s adding a TODO comment and revisit this in the future?","commit_id":"5b1f9156c020bc12f82fe9d0e005422effbbf04c"}]}