)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"13bd98fd39c16ca8cc869d50f650906f88bbdd87","unresolved":false,"context_lines":[{"line_number":10,"context_line":"instead of message database. As a result, it\u0027s not necessary now to look"},{"line_number":11,"context_line":"up pools to get the correct queue controller."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: # 1679888"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie20e0c611dc0756818e4612f33ebc2ab2ecd2990"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bff0334d_e138d6a0","line":13,"range":{"start_line":13,"start_character":13,"end_line":13,"end_character":14},"updated":"2017-04-11 07:13:08.000000000","message":"redundant space","commit_id":"ea64f2afb10178c7437758668be1d16bbb57fe0f"}],"zaqar/storage/pooling.py":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"abc43f2964718101796b4129da6bfe46b62ad52a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # however. If between the time we register a queue and go to"},{"line_number":216,"context_line":"        # look it up, the queue is deleted, then this assertion will"},{"line_number":217,"context_line":"        # fail."},{"line_number":218,"context_line":"        pool \u003d self._pool_catalog.lookup(name, project)"},{"line_number":219,"context_line":"        if not pool:"},{"line_number":220,"context_line":"            raise RuntimeError(\u0027Failed to register queue\u0027)"},{"line_number":221,"context_line":"        return self._queue_controller.create(name, metadata\u003dmetadata,"},{"line_number":222,"context_line":"                                             project\u003dproject)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _delete(self, name, project\u003dNone):"},{"line_number":225,"context_line":"        return self._queue_controller.delete(name, project)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_1136f204","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":61},"updated":"2017-04-06 09:04:16.000000000","message":"this change is reasonable for me. But why do you only add this for create? For other actions, don\u0027t they need to find the right pool first?","commit_id":"e2f033e7205d5e2b25c145b6d7e96cfff6310f89"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"46fb7e9a50f8d905203ab8da8bc4f45b38c2aa95","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # however. If between the time we register a queue and go to"},{"line_number":216,"context_line":"        # look it up, the queue is deleted, then this assertion will"},{"line_number":217,"context_line":"        # fail."},{"line_number":218,"context_line":"        pool \u003d self._pool_catalog.lookup(name, project)"},{"line_number":219,"context_line":"        if not pool:"},{"line_number":220,"context_line":"            raise RuntimeError(\u0027Failed to register queue\u0027)"},{"line_number":221,"context_line":"        return self._queue_controller.create(name, metadata\u003dmetadata,"},{"line_number":222,"context_line":"                                             project\u003dproject)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _delete(self, name, project\u003dNone):"},{"line_number":225,"context_line":"        return self._queue_controller.delete(name, project)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_ff0d693e","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":61},"in_reply_to":"bff0334d_1136f204","updated":"2017-04-07 07:54:53.000000000","message":"I think other actions in queue don\u0027t need to find the pool, since queue is stored in management database.","commit_id":"e2f033e7205d5e2b25c145b6d7e96cfff6310f89"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3eaadd9cfd3b05cfc28c62e895a7c014ceb58517","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # however. If between the time we register a queue and go to"},{"line_number":216,"context_line":"        # look it up, the queue is deleted, then this assertion will"},{"line_number":217,"context_line":"        # fail."},{"line_number":218,"context_line":"        pool \u003d self._pool_catalog.lookup(name, project)"},{"line_number":219,"context_line":"        if not pool:"},{"line_number":220,"context_line":"            raise RuntimeError(\u0027Failed to register queue\u0027)"},{"line_number":221,"context_line":"        return self._queue_controller.create(name, metadata\u003dmetadata,"},{"line_number":222,"context_line":"                                             project\u003dproject)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _delete(self, name, project\u003dNone):"},{"line_number":225,"context_line":"        return self._queue_controller.delete(name, project)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_124666c1","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":61},"in_reply_to":"bff0334d_b645c345","updated":"2017-04-11 06:56:46.000000000","message":"Oh, it\u0027s my mistake, I suppose we changed message, claimed and so on. Please forget it.","commit_id":"e2f033e7205d5e2b25c145b6d7e96cfff6310f89"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"93037dc0fbc56860799c01ed6074d85e46943e0e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        # however. If between the time we register a queue and go to"},{"line_number":216,"context_line":"        # look it up, the queue is deleted, then this assertion will"},{"line_number":217,"context_line":"        # fail."},{"line_number":218,"context_line":"        pool \u003d self._pool_catalog.lookup(name, project)"},{"line_number":219,"context_line":"        if not pool:"},{"line_number":220,"context_line":"            raise RuntimeError(\u0027Failed to register queue\u0027)"},{"line_number":221,"context_line":"        return self._queue_controller.create(name, metadata\u003dmetadata,"},{"line_number":222,"context_line":"                                             project\u003dproject)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _delete(self, name, project\u003dNone):"},{"line_number":225,"context_line":"        return self._queue_controller.delete(name, project)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_b645c345","line":222,"range":{"start_line":218,"start_character":0,"end_line":222,"end_character":61},"in_reply_to":"bff0334d_ff0d693e","updated":"2017-04-07 10:33:49.000000000","message":"Yes, correct.","commit_id":"e2f033e7205d5e2b25c145b6d7e96cfff6310f89"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"46fb7e9a50f8d905203ab8da8bc4f45b38c2aa95","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                             project\u003dproject)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _delete(self, name, project\u003dNone):"},{"line_number":225,"context_line":"        return self._queue_controller.delete(name, project)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _exists(self, name, project\u003dNone):"},{"line_number":228,"context_line":"        return self._queue_controller.exists(name, project\u003dproject)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_bf59215b","line":225,"range":{"start_line":225,"start_character":8,"end_line":225,"end_character":59},"updated":"2017-04-07 07:54:53.000000000","message":"Is there missing the deregister?  I think the relationship between queue and pool should be deleted too from catalogue.","commit_id":"e2f033e7205d5e2b25c145b6d7e96cfff6310f89"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"93037dc0fbc56860799c01ed6074d85e46943e0e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                             project\u003dproject)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def _delete(self, name, project\u003dNone):"},{"line_number":225,"context_line":"        return self._queue_controller.delete(name, project)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def _exists(self, name, project\u003dNone):"},{"line_number":228,"context_line":"        return self._queue_controller.exists(name, project\u003dproject)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_56579703","line":225,"range":{"start_line":225,"start_character":8,"end_line":225,"end_character":59},"in_reply_to":"bff0334d_bf59215b","updated":"2017-04-07 10:33:49.000000000","message":"Yep, we need the deregister. Will add it in next ps.","commit_id":"e2f033e7205d5e2b25c145b6d7e96cfff6310f89"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"13bd98fd39c16ca8cc869d50f650906f88bbdd87","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                                        project\u003dproject)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def _stats(self, name, project\u003dNone):"},{"line_number":248,"context_line":"        return self._queue_controller.stats(name, project\u003dproject)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class MessageController(storage.Message):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bff0334d_0de40b3b","line":248,"updated":"2017-04-11 07:13:08.000000000","message":"stats will look for the queue\u0027s message. So we should get the right pool first.","commit_id":"ea64f2afb10178c7437758668be1d16bbb57fe0f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"906d73e8ff08a0333a1f913e2cec507c53aa7844","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            return controller"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class QueueController(storage.Queue):"},{"line_number":162,"context_line":"    \"\"\"Routes operations to get the appropriate queue controller."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    :param pool_catalog: a catalog of available pools"}],"source_content_type":"text/x-python","patch_set":10,"id":"7ffa3b31_d81c0715","line":161,"updated":"2017-04-18 11:48:42.000000000","message":"when check this patch, I have a question out of mind: Since queue is now in management_database, why we still use it here, and why not we move it to control layer directly as pool/flavor does?Though I can see it\u0027s not a simple work, but maybe it\u0027s the right direction. Is there something I missed?","commit_id":"0dd1d299a9ddb9f1659d31f5c5efd0667966bd39"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"78d9c9faf3af55fe26c26465cd1e30fbdfeaf4c8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            return controller"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"class QueueController(storage.Queue):"},{"line_number":162,"context_line":"    \"\"\"Routes operations to get the appropriate queue controller."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    :param pool_catalog: a catalog of available pools"}],"source_content_type":"text/x-python","patch_set":10,"id":"5ff73747_15739fe9","line":161,"in_reply_to":"7ffa3b31_d81c0715","updated":"2017-04-23 23:21:53.000000000","message":"Could be. But I\u0027m not too sure because queue is different from pool and flavour. Zaqar needs to maintain the mapping/catalog between queue and pool. I can\u0027t see much benefits by moving this. And actually we have queue controller in controller level, see https://github.com/openstack/zaqar/blob/master/zaqar/storage/sqlalchemy/controllers.py#L22 This queue controller is mainly used to main the mapping.","commit_id":"0dd1d299a9ddb9f1659d31f5c5efd0667966bd39"},{"author":{"_account_id":8846,"name":"Hao Wang","display_name":"Hao Wang","email":"sxmatch1986@gmail.com","username":"sxmatch"},"change_message_id":"a574aeaf521914547f2a4ff74a859582562e9085","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        super(QueueController, self).__init__(None)"},{"line_number":170,"context_line":"        self._pool_catalog \u003d pool_catalog"},{"line_number":171,"context_line":"        self._mgt_queue_ctrl \u003d self._pool_catalog.control.queue_controller"},{"line_number":172,"context_line":"        self._get_controller \u003d self._pool_catalog.get_queue_controller"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def _list(self, project\u003dNone, marker\u003dNone,"},{"line_number":175,"context_line":"              limit\u003dstorage.DEFAULT_QUEUES_PER_PAGE, detailed\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":16,"id":"5ff73747_a53e5488","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":70},"updated":"2017-04-28 02:58:09.000000000","message":"So we still keep this","commit_id":"fe4f1e59aef60c43ae97fb8172b840d3b7ef066a"}]}
