)]}'
{"zaqar/storage/swift/driver.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"4e293b8f604a094d39463be79da0a958a71dd401","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            project_domain_name\u003dself.conf.project_domain_name,"},{"line_number":99,"context_line":"            auth_url\u003dself.conf.auth_url)"},{"line_number":100,"context_line":"        self.session \u003d keystone_session.Session(auth\u003dself.auth)"},{"line_number":101,"context_line":"        self.url \u003d self.session.get_endpoint(service_type\u003d\u0027object-store\u0027)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def __getattr__(self, attr):"},{"line_number":104,"context_line":"        client \u003d swiftclient.Connection(preauthurl\u003dself.url,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_0a4723be","line":101,"updated":"2017-04-12 09:00:41.000000000","message":"You need to keep the auth check in getattr, don\u0027t create it in init. It\u0027s too soon at that point.","commit_id":"a5fcbd5abfeaa3874f151f8d81077f90741fe9cb"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"3aff9bea2c7c7fb0a286c1385f66971e4acb1246","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            self._init_auth()"},{"line_number":108,"context_line":"        client \u003d swiftclient.Connection(session\u003dself.session,"},{"line_number":109,"context_line":"                                        insecure\u003dself.conf.insecure)"},{"line_number":110,"context_line":"        return getattr(client, attr)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bff0334d_cb701a43","line":110,"updated":"2017-04-12 11:33:44.000000000","message":"nit, not actually a problem but why not just save the client, rather than the session:\n\nif self._client is None: \n   auth \u003d generic.Password(...)\n   session \u003d keystone_session.Session(auth\u003dauth)\n   self._client \u003d swiftClient.Connection(...)\n\nreturn getattr(self._client, attr)","commit_id":"dcd7f10a3cf6103b7c3e0e36b3e666c9b6bffc0f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3206bbba04cb05e947aebdc235dd6d8b38ace9bc","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            self._init_auth()"},{"line_number":108,"context_line":"        client \u003d swiftclient.Connection(session\u003dself.session,"},{"line_number":109,"context_line":"                                        insecure\u003dself.conf.insecure)"},{"line_number":110,"context_line":"        return getattr(client, attr)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ff52f3f_ab0494c7","line":110,"in_reply_to":"bff0334d_cb701a43","updated":"2017-04-13 06:28:01.000000000","message":"If so, I guess we\u0027ll have the same problem again:\nhttps://review.openstack.org/#/c/444671/\n\nCorrect me if i\u0027m wrong.","commit_id":"dcd7f10a3cf6103b7c3e0e36b3e666c9b6bffc0f"}]}
