)]}'
{"marconi/queues/transport/wsgi/driver.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"d615ca6dfb2192c25b82321c0c050fad3fcb464b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def _extract_project_id(req, resp, params):"},{"line_number":54,"context_line":"    params[\u0027project_id\u0027] \u003d req.get_header(\u0027X-PROJECT-ID\u0027)"},{"line_number":55,"context_line":"    if params[\u0027project_id\u0027] is None:"},{"line_number":56,"context_line":"        raise falcon.HTTPBadRequest(\u0027Missing header\u0027,"},{"line_number":57,"context_line":"            u\u0027\u0027\u0027"},{"line_number":58,"context_line":"Headers X-PROJECT-ID is missing; specify the header X-PROJECT-ID"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FaU8%3D","line":55,"updated":"2013-09-27 08:02:16.000000000","message":"FYI, None is a valid case but \"\" isn\u0027t.\n\nIf the project ID is not present, we assume to be working on a single tenant deployment, if it is then we\u0027ll use that as a tenant but, if it is present and empty we simply don\u0027t know what to do.\n\nTBH, I don\u0027t know how falcon behaves on empty headers or if that is even possible.","commit_id":"4e44d329fec4e51702793060107eed835a56e007"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7520674c93c23d72b3bb2f5426f8a8b4d290f6f4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    if params[\u0027project_id\u0027] \u003d\u003d \"\":"},{"line_number":56,"context_line":"        raise falcon.HTTPBadRequest(\u0027Missing header\u0027,"},{"line_number":57,"context_line":"            u\u0027\u0027\u0027"},{"line_number":58,"context_line":"X-PROJECT-ID cannot be an empty string. Specify the right header X-PROJECT-ID"},{"line_number":59,"context_line":"and retry.\u0027\u0027\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FaKQ%3D","line":58,"updated":"2013-09-27 09:29:28.000000000","message":"Could you please move this into a variable and mark it for translation? See L129","commit_id":"df5a3e9795efd8d2cfc025b487f7636b9633de52"},{"author":{"_account_id":8083,"name":"Francesco Vollero","email":"fvollero@redhat.com","username":"fvollero"},"change_message_id":"022b14be906bc2b63953f6f6bd92b377d23c7b46","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    if params[\u0027project_id\u0027] \u003d\u003d \"\":"},{"line_number":56,"context_line":"        raise falcon.HTTPBadRequest(\u0027Missing header\u0027,"},{"line_number":57,"context_line":"            u\u0027\u0027\u0027"},{"line_number":58,"context_line":"X-PROJECT-ID cannot be an empty string. Specify the right header X-PROJECT-ID"},{"line_number":59,"context_line":"and retry.\u0027\u0027\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FaG4%3D","line":58,"in_reply_to":"AAAAS3%2F%2FaKQ%3D","updated":"2013-09-27 09:42:37.000000000","message":"Sure thing, but this have to be done on L46 as well :)","commit_id":"df5a3e9795efd8d2cfc025b487f7636b9633de52"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a785f48845495d343310935605476a45bc974679","unresolved":false,"context_lines":[{"line_number":53,"context_line":"def _extract_project_id(req, resp, params):"},{"line_number":54,"context_line":"    params[\u0027project_id\u0027] \u003d req.get_header(\u0027X-PROJECT-ID\u0027)"},{"line_number":55,"context_line":"    if params[\u0027project_id\u0027] \u003d\u003d \"\":"},{"line_number":56,"context_line":"        raise falcon.HTTPBadRequest(\u0027Missing header\u0027,"},{"line_number":57,"context_line":"                                    _(u\u0027\u0027\u0027"},{"line_number":58,"context_line":"X-PROJECT-ID cannot be an empty string. Specify the right header X-PROJECT-ID"},{"line_number":59,"context_line":"and retry.\u0027\u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FZbs%3D","line":56,"updated":"2013-09-27 14:55:32.000000000","message":"Could you change \u0027Missing header\u0027 to \u0027Empty project header not allowed\u0027?","commit_id":"dce1f76b7494c099b00ad063bdb9ea139e95f051"}],"tests/unit/queues/transport/wsgi/test_queue_lifecycle.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a785f48845495d343310935605476a45bc974679","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.wsgi_cfg \u003d config.namespace("},{"line_number":37,"context_line":"            \u0027drivers:transport:wsgi\u0027).from_options()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def test_empty_project_id(self):"},{"line_number":40,"context_line":"        path \u003d \u0027/v1/queues/gumshoe\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.simulate_get(path, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FZbE%3D","line":39,"updated":"2013-09-27 14:55:32.000000000","message":"Sweet tests!","commit_id":"dce1f76b7494c099b00ad063bdb9ea139e95f051"}]}