)]}'
{"marconi/queues/bootstrap.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"49687c5b70180a3cfe633584627210f0da6c64c6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            lookup_storage \u003d self._shard_manager.lookup_storage"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            def lookup_storage(queue, project\u003dNone):"},{"line_number":87,"context_line":"                return self._solitary_storage"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            mgr \u003d driver.DriverManager(\u0027marconi.queues.transport\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F3dU%3D","line":87,"updated":"2013-10-08 18:50:24.000000000","message":"I like this. Nice use of a closure for lazy evaluation!","commit_id":"c0bf88034d8e324535671440e4f4653a36bf9f6e"}],"marconi/queues/storage/__init__.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"49687c5b70180a3cfe633584627210f0da6c64c6","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"_STORAGE_LIMITS_OPTIONS \u003d ["},{"line_number":14,"context_line":"    cfg.IntOpt(\u0027default_queue_paging\u0027, default\u003d10,"},{"line_number":15,"context_line":"               help\u003d\u0027Default message pagination size\u0027),"},{"line_number":16,"context_line":"    cfg.IntOpt(\u0027default_message_paging\u0027, default\u003d10,"},{"line_number":17,"context_line":"               help\u003d\u0027Default message pagination size\u0027)"},{"line_number":18,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F3dM%3D","line":15,"updated":"2013-10-08 18:50:24.000000000","message":"As in the previous patch, typo: message -\u003e queue in help text.","commit_id":"c0bf88034d8e324535671440e4f4653a36bf9f6e"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"f9ee357b3b47c56304c45d414534b5d7d09da7d1","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"_STORAGE_LIMITS_OPTIONS \u003d ["},{"line_number":9,"context_line":"    cfg.IntOpt(\u0027default_queue_paging\u0027, default\u003d10,"},{"line_number":10,"context_line":"               help\u003d\u0027Default queue pagination size\u0027),"},{"line_number":11,"context_line":"    cfg.IntOpt(\u0027default_message_paging\u0027, default\u003d10,"},{"line_number":12,"context_line":"               help\u003d\u0027Default message pagination size\u0027)"},{"line_number":13,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F2jM%3D","line":10,"updated":"2013-10-09 13:09:44.000000000","message":"Confirmed fixed, as promised from last patch.","commit_id":"4a4e7ed5581a7cd1760e73683379dda87ed8f4ad"}],"marconi/queues/storage/mongodb/driver.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"710932cad3022acb8bf7788e6da558aa22c19fd3","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class Driver(storage.DriverBase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # TODO(kgriffs): SHARDING - Accept options as kwargs, vs"},{"line_number":33,"context_line":"    # loading directly from config"},{"line_number":34,"context_line":"    def __init__(self, uri):"},{"line_number":35,"context_line":"        # TODO(kgriffs): SHARDING - Make use of uri and kwargs"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fp8k%3D","line":32,"updated":"2013-10-11 16:49:56.000000000","message":"What about just making drivers accept a `config` instance as a positional argument and move this __init__ under storage.DriverBase ? I think drivers should accept a config either way, and they most likely will when we\u0027ll get rid of the global config instance.","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"26f09e8b8d58ab6e4f22f9b2521fe4382885a8e2","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class Driver(storage.DriverBase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # TODO(kgriffs): SHARDING - Accept options as kwargs, vs"},{"line_number":33,"context_line":"    # loading directly from config"},{"line_number":34,"context_line":"    def __init__(self, uri):"},{"line_number":35,"context_line":"        # TODO(kgriffs): SHARDING - Make use of uri and kwargs"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fpx0%3D","line":32,"in_reply_to":"AAAATH%2F%2Fp8k%3D","updated":"2013-10-11 17:29:09.000000000","message":"I guess I was biased by thinking in terms of configuration coming from the sharding catalog, rather than an INI file. If we were to switch to just passing in a conf instance, I suppose the catalog could create that conf instance manually from the shard catalog document.","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cba11c99b103c081351204d8aa032cd07e6bfb71","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class Driver(storage.DriverBase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # TODO(kgriffs): SHARDING - Accept options as kwargs, vs"},{"line_number":33,"context_line":"    # loading directly from config"},{"line_number":34,"context_line":"    def __init__(self, uri):"},{"line_number":35,"context_line":"        # TODO(kgriffs): SHARDING - Make use of uri and kwargs"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FoBg%3D","line":32,"in_reply_to":"AAAATH%2F%2FpkA%3D","updated":"2013-10-12 07:06:17.000000000","message":"I like the default options idea. As for the configuration, I think it would be good to stick to oslo.config, for example, we could pass to that static method Marconi\u0027s current config object and make it return a `GroupAttr` that will be then passed to the constructor. GroupAttr is what you get when you access a configuration group from a ConfigOpts instance. This will limit the options a `Driver` can access down to the ones it actually needs. There are no difference in the way ConfigOpts and GroupAttr are used.\n\nThe above allows external drivers to register their options and take advantage of Marconi config files. We can also build (or let the drivers build) custom ConfigOpts instance. This will avoid using `DottedDict`\n\nI was planning something similar for the \u0027get rid of globals\u0027 work but I\u0027m happy with adding that to this patch and the fact that we\u0027re already discussing it. Plus, I like this idea more than the one I had in mine - using the constructor itself.","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"cbcb0e1753a8648042031afb38890baa721e0364","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class Driver(storage.DriverBase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # TODO(kgriffs): SHARDING - Accept options as kwargs, vs"},{"line_number":33,"context_line":"    # loading directly from config"},{"line_number":34,"context_line":"    def __init__(self, uri):"},{"line_number":35,"context_line":"        # TODO(kgriffs): SHARDING - Make use of uri and kwargs"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FpkA%3D","line":32,"in_reply_to":"AAAATH%2F%2FpuQ%3D","updated":"2013-10-11 18:14:31.000000000","message":"Another thought I discussed with Kurt off line - to make this something we can count on all storage drivers providing, we can make it `default_options` a static method and an abstract property that all storage drivers must implement.","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"935999ded8e14a9ea648c942c591a495a67caa3f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class Driver(storage.DriverBase):"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    # TODO(kgriffs): SHARDING - Accept options as kwargs, vs"},{"line_number":33,"context_line":"    # loading directly from config"},{"line_number":34,"context_line":"    def __init__(self, uri):"},{"line_number":35,"context_line":"        # TODO(kgriffs): SHARDING - Make use of uri and kwargs"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FpuQ%3D","line":32,"in_reply_to":"AAAATH%2F%2Fpx0%3D","updated":"2013-10-11 17:43:06.000000000","message":"Using duck typing, the conf instance and the dictionary can be treated identically. If we query the admin API for a shard\u0027s information, we\u0027d get back something like:\n\n    {\n      \"uri\": \"mongodb://localhost:27017\",\n      \"options\": {\n        \"partitions\": 4,\n        \"max_attempts\": 100\n      }\n    }\n\nThe options portion is what we\u0027d traditionally find in the INI file for a storage driver\u0027s configuration, e.g., [queues:drivers:storage:mongodb], minus the essentials like address and port, which is encoded in the URI.\n\nSo... storage_driver(self, uri, options) \u003d\u003e instance.","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"}],"marconi/queues/storage/sharding.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"49687c5b70180a3cfe633584627210f0da6c64c6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def _init_shard(shard_id):"},{"line_number":28,"context_line":"        # TODO(kgriffs): SHARDING - Figure out name and config"},{"line_number":29,"context_line":"        driver_name \u003d \u0027[insert_driver_name]\u0027"},{"line_number":30,"context_line":"        options \u003d {}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        return self.create_storage(driver_name, **options)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F3cs%3D","line":30,"updated":"2013-10-08 18:50:24.000000000","message":"This is likely the place where we\u0027ll add in some of the proxy logic. We\u0027ll use some the lookup details to fetch a catalogue/partitions entry that tells us:\n\n* connection string (redis://localhost:6379, mongodb://localhost:27017)\n* any relevant options: \u0027options\u0027: {...}\n\nSomething like that.","commit_id":"c0bf88034d8e324535671440e4f4653a36bf9f6e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"710932cad3022acb8bf7788e6da558aa22c19fd3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self._shard_catalog \u003d shard_catalog"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __getattr__(self, name):"},{"line_number":62,"context_line":"        # import pdb;pdb.set_trace()"},{"line_number":63,"context_line":"        # NOTE(kgriffs): Use a closure trick to avoid"},{"line_number":64,"context_line":"        # some attr lookups each time foward() is called."},{"line_number":65,"context_line":"        lookup \u003d self._shard_catalog.lookup"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fp8I%3D","line":62,"updated":"2013-10-11 16:49:56.000000000","message":"pdb :)","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"26f09e8b8d58ab6e4f22f9b2521fe4382885a8e2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self._shard_catalog \u003d shard_catalog"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def __getattr__(self, name):"},{"line_number":62,"context_line":"        # import pdb;pdb.set_trace()"},{"line_number":63,"context_line":"        # NOTE(kgriffs): Use a closure trick to avoid"},{"line_number":64,"context_line":"        # some attr lookups each time foward() is called."},{"line_number":65,"context_line":"        lookup \u003d self._shard_catalog.lookup"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fpxo%3D","line":62,"in_reply_to":"AAAATH%2F%2Fp8I%3D","updated":"2013-10-11 17:29:09.000000000","message":"Done","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8a89a7ab2f553a0c7c4efe9e32529f2ba7feaa29","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self._ctrl_property_name \u003d self._resource_name + \u0027_controller\u0027"},{"line_number":71,"context_line":"        self._shard_catalog \u003d shard_catalog"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __getattr__(self, name):"},{"line_number":74,"context_line":"        # NOTE(kgriffs): Use a closure trick to avoid"},{"line_number":75,"context_line":"        # some attr lookups each time foward() is called."},{"line_number":76,"context_line":"        lookup \u003d self._shard_catalog.lookup"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FWqk%3D","line":73,"updated":"2013-10-17 13:15:55.000000000","message":"Could you use the cahced_getattr decorator here? :D","commit_id":"7a497c68e04a89dd3b2f468d5e14a85d52183c8f"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"a1c9f759103f97d87ce8563821cb6b0eebf14373","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self._ctrl_property_name \u003d self._resource_name + \u0027_controller\u0027"},{"line_number":71,"context_line":"        self._shard_catalog \u003d shard_catalog"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __getattr__(self, name):"},{"line_number":74,"context_line":"        # NOTE(kgriffs): Use a closure trick to avoid"},{"line_number":75,"context_line":"        # some attr lookups each time foward() is called."},{"line_number":76,"context_line":"        lookup \u003d self._shard_catalog.lookup"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FVqk%3D","line":73,"in_reply_to":"AAAATH%2F%2FWqk%3D","updated":"2013-10-17 15:30:55.000000000","message":"Done","commit_id":"7a497c68e04a89dd3b2f468d5e14a85d52183c8f"}],"marconi/queues/storage/utils.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"710932cad3022acb8bf7788e6da558aa22c19fd3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from marconi.common import exceptions"},{"line_number":21,"context_line":"from marconi.openstack.common import log"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CFG \u003d cfg.CONF"},{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fp60%3D","line":23,"updated":"2013-10-11 16:49:56.000000000","message":"Is this actually being used?","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"26f09e8b8d58ab6e4f22f9b2521fe4382885a8e2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from marconi.common import exceptions"},{"line_number":21,"context_line":"from marconi.openstack.common import log"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CFG \u003d cfg.CONF"},{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FpxI%3D","line":23,"in_reply_to":"AAAATH%2F%2Fp60%3D","updated":"2013-10-11 17:29:09.000000000","message":"Nope, let me remove that cruft.","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"710932cad3022acb8bf7788e6da558aa22c19fd3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def load_driver(uri, options\u003d{}):"},{"line_number":28,"context_line":"    \"\"\"Loads a storage driver and returns it."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    The driver\u0027s initializer will be passed the URI as it\u0027s only"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fp7E%3D","line":27,"updated":"2013-10-11 16:49:56.000000000","message":"What about `load_storage_driver` ?","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"26f09e8b8d58ab6e4f22f9b2521fe4382885a8e2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def load_driver(uri, options\u003d{}):"},{"line_number":28,"context_line":"    \"\"\"Loads a storage driver and returns it."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    The driver\u0027s initializer will be passed the URI as it\u0027s only"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FpxE%3D","line":27,"in_reply_to":"AAAATH%2F%2Fp7E%3D","updated":"2013-10-11 17:29:09.000000000","message":"Done","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"}],"marconi/queues/transport/wsgi/queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"a9a5bdc007dcefb34d459c79098c31ad23779903","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            self.shard_manager.register(queue_name, project_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            controller \u003d self._queue_ctrl(queue_name, project_id)"},{"line_number":43,"context_line":"            created \u003d controller.create(queue_name, project\u003dproject_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2F1SQ%3D","line":40,"updated":"2013-10-09 08:37:33.000000000","message":"IMHO, the transport layer shouldn\u0027t know anything about the whether the storage layer is being sharded or not. I\u0027ve an idea about how we can avoid adding this here.\n\nhttps://blueprints.launchpad.net/marconi/+spec/storage-pipeline","commit_id":"4a4e7ed5581a7cd1760e73683379dda87ed8f4ad"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"7d09660d51f138f8e88ae965d7d0f25da462369c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            self.shard_manager.register(queue_name, project_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            controller \u003d self._queue_ctrl(queue_name, project_id)"},{"line_number":43,"context_line":"            created \u003d controller.create(queue_name, project\u003dproject_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fywg%3D","line":40,"in_reply_to":"AAAATH%2F%2F1SQ%3D","updated":"2013-10-09 18:31:51.000000000","message":"I actually like this idea; it\u0027s something that we explored doing for validation, and using it for other things (e.g., sharding) seems like a good way to go. \n\nLet me play with this idea re this patch; I think that having a hard-wired proxy \"filter driver\" would be a good proof of concept of the more general, dynamic filter pipeline idea. I could implement that now in this patch, and then we could swap it out for the real pipeline stuff later.","commit_id":"4a4e7ed5581a7cd1760e73683379dda87ed8f4ad"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"480e2689a1f100f7efeb6278f1e71b068e36f8e1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                  {\u0027queue\u0027: queue_name, \u0027project\u0027: project_id})"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            self.shard_manager.register(queue_name, project_id)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"            controller \u003d self._queue_ctrl(queue_name, project_id)"},{"line_number":43,"context_line":"            created \u003d controller.create(queue_name, project\u003dproject_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fz0c%3D","line":40,"in_reply_to":"AAAATH%2F%2F1SQ%3D","updated":"2013-10-09 14:38:54.000000000","message":"I\u0027m looking forward to your POC on this, as we discussed this morning, Flavio.","commit_id":"4a4e7ed5581a7cd1760e73683379dda87ed8f4ad"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"480e2689a1f100f7efeb6278f1e71b068e36f8e1","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            # shard catalog, since then we have to try to keep"},{"line_number":111,"context_line":"            # metadata in sync between two data stores."},{"line_number":112,"context_line":"            controller \u003d self._queue_ctrl(None, project_id)"},{"line_number":113,"context_line":"            results \u003d controller.list(project\u003dproject_id, **kwargs)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        except validate.ValidationFailed as ex:"},{"line_number":116,"context_line":"            raise wsgi_exceptions.HTTPBadRequestAPI(six.text_type(ex))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2Fz0k%3D","line":113,"updated":"2013-10-09 14:38:54.000000000","message":"Concurrent shard query + sequential merge has its own challenges, but I think it\u0027s the right way to go. I don\u0027t think it\u0027s okay to collocate all of a project\u0027s queues on a single shard. \n\nIt\u0027s roughly a matter of grabbing LIMIT queues from each shard under this project namespace, sorting them, jump to the MARKER, take the first LIMIT queues from the result set at that point, setting the return marker to be the last item in this set, and done!\n\neventlet.GreenPile will probably come in handy here to allow for concurrent queries without hanging the worker.\n\n    tasks \u003d map(query, shards)\n    tasks.joinall()\n\nJust some thoughts.","commit_id":"4a4e7ed5581a7cd1760e73683379dda87ed8f4ad"}],"tests/etc/wsgi_sqlite_sharded.conf":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"575be81d25561a97439bd1b5129a41dba67caf5d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"[queues:drivers:transport:wsgi]"},{"line_number":11,"context_line":"bind \u003d 0.0.0.0"},{"line_number":12,"context_line":"port \u003d 8888"},{"line_number":13,"context_line":"workers \u003d 20"}],"source_content_type":"text/plain","patch_set":9,"id":"AAAATH%2F%2FYas%3D","line":13,"updated":"2013-10-16 21:23:40.000000000","message":"Could you explain the workers field? It doesn\u0027t seem like anything in this patch uses it. YAGNI?\n\nIf you believe it should stay in for this patch, could you leave a note with the rationale for it?","commit_id":"7a497c68e04a89dd3b2f468d5e14a85d52183c8f"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"a1c9f759103f97d87ce8563821cb6b0eebf14373","unresolved":false,"context_lines":[{"line_number":10,"context_line":"[queues:drivers:transport:wsgi]"},{"line_number":11,"context_line":"bind \u003d 0.0.0.0"},{"line_number":12,"context_line":"port \u003d 8888"},{"line_number":13,"context_line":"workers \u003d 20"}],"source_content_type":"text/plain","patch_set":9,"id":"AAAATH%2F%2FVo4%3D","line":13,"in_reply_to":"AAAATH%2F%2FWrY%3D","updated":"2013-10-17 15:30:55.000000000","message":"Copy-paste bug. :)\n\nLet me remove it from this config. We can take it out of the others in a separate patch.","commit_id":"7a497c68e04a89dd3b2f468d5e14a85d52183c8f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8a89a7ab2f553a0c7c4efe9e32529f2ba7feaa29","unresolved":false,"context_lines":[{"line_number":10,"context_line":"[queues:drivers:transport:wsgi]"},{"line_number":11,"context_line":"bind \u003d 0.0.0.0"},{"line_number":12,"context_line":"port \u003d 8888"},{"line_number":13,"context_line":"workers \u003d 20"}],"source_content_type":"text/plain","patch_set":9,"id":"AAAATH%2F%2FWrY%3D","line":13,"in_reply_to":"AAAATH%2F%2FYas%3D","updated":"2013-10-17 13:15:55.000000000","message":"This looks like a left over from the old, gunicorn based, implementation. See: https://github.com/openstack/marconi/blob/master/tests/etc/wsgi_sqlite.conf#L12","commit_id":"7a497c68e04a89dd3b2f468d5e14a85d52183c8f"}],"tests/unit/queues/storage/test_shard_catalog.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"710932cad3022acb8bf7788e6da558aa22c19fd3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        conf_file \u003d \u0027etc/wsgi_sqlite_sharded.conf\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":32,"context_line":"        conf(project\u003d\u0027marconi\u0027, prog\u003d\u0027marconi-queues\u0027, args\u003d[],"},{"line_number":33,"context_line":"             default_config_files\u003d[conf_file])"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        lookup \u003d sharding.Catalog(conf).lookup"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fp6M%3D","line":32,"updated":"2013-10-11 16:49:56.000000000","message":"No need to pass project and prog. I\u0027m afraid this may cause some issues if there are marconi files present in the filesystem. Let oslo.config make these up and just pass the default_config_file which will be read anyway.","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"26f09e8b8d58ab6e4f22f9b2521fe4382885a8e2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        conf_file \u003d \u0027etc/wsgi_sqlite_sharded.conf\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":32,"context_line":"        conf(project\u003d\u0027marconi\u0027, prog\u003d\u0027marconi-queues\u0027, args\u003d[],"},{"line_number":33,"context_line":"             default_config_files\u003d[conf_file])"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        lookup \u003d sharding.Catalog(conf).lookup"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2Fpw8%3D","line":32,"in_reply_to":"AAAATH%2F%2Fp6M%3D","updated":"2013-10-11 17:29:09.000000000","message":"Done","commit_id":"6dab39149f40544e380fcd183b172a865f17bddf"}],"tests/unit/queues/transport/wsgi/test_messages.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8a89a7ab2f553a0c7c4efe9e32529f2ba7feaa29","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    config_filename \u003d \u0027wsgi_sqlite.conf\u0027"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"class MessagesSQLiteShardedTests(MessagesBaseTest):"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    config_filename \u003d \u0027wsgi_sqlite_sharded.conf\u0027"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FWMc%3D","line":422,"updated":"2013-10-17 13:15:55.000000000","message":"What about mongodb ?","commit_id":"7a497c68e04a89dd3b2f468d5e14a85d52183c8f"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"a1c9f759103f97d87ce8563821cb6b0eebf14373","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    config_filename \u003d \u0027wsgi_sqlite.conf\u0027"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"class MessagesSQLiteShardedTests(MessagesBaseTest):"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    config_filename \u003d \u0027wsgi_sqlite_sharded.conf\u0027"},{"line_number":425,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATH%2F%2FVhs%3D","line":422,"in_reply_to":"AAAATH%2F%2FWMc%3D","updated":"2013-10-17 15:30:55.000000000","message":"Done","commit_id":"7a497c68e04a89dd3b2f468d5e14a85d52183c8f"}]}
