)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a8ba08cc44986145edc92b258d4156e93a5d52a4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"applies both at the transport layer and the storage layer. Part of the"},{"line_number":23,"context_line":"rationale behind this is to simplify unit testing. The other part of"},{"line_number":24,"context_line":"this is that an admin should be able to do everything a normal user"},{"line_number":25,"context_line":"can do in addition to their special functions."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"A test suite has been added that exercises the functionality from the"},{"line_number":28,"context_line":"transport side of the shard registry resource."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATX%2F%2F%2BE4%3D","line":25,"updated":"2013-10-23 14:30:46.000000000","message":"Here\u0027s that admin/public interface change I\u0027ve been promising. It simplifies a lot of things.","commit_id":"6e1d4acb3008c9b9f7f814e8e5227d7827c67581"}],"marconi/common/schemas/shards.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a8ba08cc44986145edc92b258d4156e93a5d52a4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"# uri validator as per rfc3987"},{"line_number":32,"context_line":"patch_uri \u003d {"},{"line_number":33,"context_line":"    \u0027type\u0027: \u0027object\u0027, \u0027properties\u0027: {"},{"line_number":34,"context_line":"        \u0027uri\u0027: {"},{"line_number":35,"context_line":"            \u0027type\u0027: \u0027string\u0027"},{"line_number":36,"context_line":"        },"},{"line_number":37,"context_line":"        \u0027additionalProperties\u0027: False"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATX%2F%2F%2BEw%3D","line":34,"updated":"2013-10-23 14:30:46.000000000","message":"As per feedback given by Kurt in a previous review: location -\u003e uri","commit_id":"6e1d4acb3008c9b9f7f814e8e5227d7827c67581"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"ca70c962fa8ffe70ce531382763c626e31e9ddad","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# NOTE(cpp-cabrera): a string valid for use in a URI"},{"line_number":30,"context_line":"# TODO(cpp-cabrera): perhaps validate this further using jsonschema\u0027s"},{"line_number":31,"context_line":"# uri validator as per rfc3987"},{"line_number":32,"context_line":"patch_uri \u003d {"},{"line_number":33,"context_line":"    \u0027type\u0027: \u0027object\u0027, \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F0OA%3D","line":30,"updated":"2013-10-28 15:55:25.000000000","message":"+1 for additional validation","commit_id":"9e2b771676883075df864b3b07eb522bf85a1499"}],"marconi/queues/storage/base.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        raise NotImplementedError"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"class AdminControllerBase(object):"},{"line_number":377,"context_line":"    \"\"\"Top-level class for controllers."},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    :param driver: Instance of the driver"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FoCY%3D","side":"PARENT","line":376,"updated":"2013-10-31 09:07:41.000000000","message":"+1","commit_id":"5624bf1a1459fb271c6c4dfa87d04eaf070978f6"}],"marconi/queues/storage/mongodb/shards.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"ca70c962fa8ffe70ce531382763c626e31e9ddad","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        cursor \u003d self._col.find(query, fields\u003d_field_spec(detailed),"},{"line_number":62,"context_line":"                                limit\u003dlimit)"},{"line_number":63,"context_line":"        for entry in cursor:"},{"line_number":64,"context_line":"            yield _normalize(entry, detailed)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @utils.raises_conn_error"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F0Ns%3D","line":63,"updated":"2013-10-28 15:55:25.000000000","message":"utils.HookedCursor?","commit_id":"9e2b771676883075df864b3b07eb522bf85a1499"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"fabe68a00f9c0c23c20020482d7d5b469789a553","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        cursor \u003d self._col.find(query, fields\u003d_field_spec(detailed),"},{"line_number":62,"context_line":"                                limit\u003dlimit)"},{"line_number":63,"context_line":"        for entry in cursor:"},{"line_number":64,"context_line":"            yield _normalize(entry, detailed)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @utils.raises_conn_error"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F0DU%3D","line":63,"in_reply_to":"AAAATn%2F%2F0Ns%3D","updated":"2013-10-28 16:13:23.000000000","message":"Done","commit_id":"9e2b771676883075df864b3b07eb522bf85a1499"}],"marconi/queues/transport/base.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    :param storage: The storage driver"},{"line_number":33,"context_line":"    :type storage: marconi.queues.storage.base.DriverBase"},{"line_number":34,"context_line":"    :param cache: caching object"},{"line_number":35,"context_line":"    :type cache: marconi.common.cache.backends.BaseCache"},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, conf, storage, cache, control):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FoBs%3D","line":35,"updated":"2013-10-31 09:07:41.000000000","message":"Missing control docstring!","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"b4779f2a499b4a82c23428270a79fcbde45fef18","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    :param storage: The storage driver"},{"line_number":33,"context_line":"    :type storage: marconi.queues.storage.base.DriverBase"},{"line_number":34,"context_line":"    :param cache: caching object"},{"line_number":35,"context_line":"    :type cache: marconi.common.cache.backends.BaseCache"},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, conf, storage, cache, control):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FnSk%3D","line":35,"in_reply_to":"AAAATn%2F%2FoBs%3D","updated":"2013-10-31 12:52:21.000000000","message":"Done","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"}],"marconi/queues/transport/wsgi/admin/driver.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"c0a031121c93f1fb1bc554bbca870900c666c528","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            (\u0027/shards/{shard}\u0027,"},{"line_number":33,"context_line":"             shards.Resource(self._storage.shards_controller)),"},{"line_number":34,"context_line":"            (\u0027/health\u0027,"},{"line_number":35,"context_line":"             health.Resource())"},{"line_number":36,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATX%2F%2F9p8%3D","line":35,"updated":"2013-10-23 15:43:10.000000000","message":"This is silly - there\u0027s no need to load the health resource twice. I\u0027ll remove this line after review.","commit_id":"6e1d4acb3008c9b9f7f814e8e5227d7827c67581"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"ca70c962fa8ffe70ce531382763c626e31e9ddad","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            (\u0027/shards/{shard}\u0027,"},{"line_number":34,"context_line":"             shards.Resource(shards_controller)),"},{"line_number":35,"context_line":"            (\u0027/health\u0027,"},{"line_number":36,"context_line":"             health.Resource())"},{"line_number":37,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F0K8%3D","line":36,"updated":"2013-10-28 15:55:25.000000000","message":"Thought: maybe we can have an admin resource or pass \"admin\u003dtrue\" to the initializer, which would enable some kind of \"verbose\" health mode.","commit_id":"9e2b771676883075df864b3b07eb522bf85a1499"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"fabe68a00f9c0c23c20020482d7d5b469789a553","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            (\u0027/shards/{shard}\u0027,"},{"line_number":34,"context_line":"             shards.Resource(shards_controller)),"},{"line_number":35,"context_line":"            (\u0027/health\u0027,"},{"line_number":36,"context_line":"             health.Resource())"},{"line_number":37,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F0Ew%3D","line":36,"in_reply_to":"AAAATn%2F%2F0K8%3D","updated":"2013-10-28 16:13:23.000000000","message":"That might help the situation behind deeper health checks, as well. Let\u0027s keep this in mind when we come to tackle the problem of better health checking. :)","commit_id":"9e2b771676883075df864b3b07eb522bf85a1499"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class Driver(public_driver.Driver):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, conf, storage, cache, control):"},{"line_number":25,"context_line":"        super(Driver, self).__init__(conf, storage, cache, control)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FoBc%3D","line":24,"updated":"2013-10-31 09:07:41.000000000","message":"We can get rid of this __init__","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"b4779f2a499b4a82c23428270a79fcbde45fef18","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class Driver(public_driver.Driver):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, conf, storage, cache, control):"},{"line_number":25,"context_line":"        super(Driver, self).__init__(conf, storage, cache, control)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FnSg%3D","line":24,"in_reply_to":"AAAATn%2F%2FoBc%3D","updated":"2013-10-31 12:52:21.000000000","message":"Done","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"}],"marconi/queues/transport/wsgi/driver.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self._init_routes()"},{"line_number":58,"context_line":"        self._init_middleware()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @property"},{"line_number":61,"context_line":"    def before_hooks(self):"},{"line_number":62,"context_line":"        \"\"\"Exposed to facilitate unit testing.\"\"\""},{"line_number":63,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FoAw%3D","line":60,"updated":"2013-10-31 09:07:41.000000000","message":"What about using lazy_property here? Unless I\u0027m missing something, it looks like the returned value here could be cached.","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"b4779f2a499b4a82c23428270a79fcbde45fef18","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self._init_routes()"},{"line_number":58,"context_line":"        self._init_middleware()"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @property"},{"line_number":61,"context_line":"    def before_hooks(self):"},{"line_number":62,"context_line":"        \"\"\"Exposed to facilitate unit testing.\"\"\""},{"line_number":63,"context_line":"        return ["}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FnSY%3D","line":60,"in_reply_to":"AAAATn%2F%2FoAw%3D","updated":"2013-10-31 12:52:21.000000000","message":"Done","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"}],"marconi/queues/transport/wsgi/public/driver.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class Driver(driver.DriverBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, conf, storage, cache, control):"},{"line_number":29,"context_line":"        super(Driver, self).__init__(conf, storage, cache, control)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FoAs%3D","line":28,"updated":"2013-10-31 09:07:41.000000000","message":"We can get rid of this __init__","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"b4779f2a499b4a82c23428270a79fcbde45fef18","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class Driver(driver.DriverBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def __init__(self, conf, storage, cache, control):"},{"line_number":29,"context_line":"        super(Driver, self).__init__(conf, storage, cache, control)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FnSU%3D","line":28,"in_reply_to":"AAAATn%2F%2FoAs%3D","updated":"2013-10-31 12:52:21.000000000","message":"Done","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"}],"marconi/queues/transport/wsgi/shards.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a8ba08cc44986145edc92b258d4156e93a5d52a4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    :param shards_controller: means to interact with storage"},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":"    def __init__(self, shards_controller):"},{"line_number":57,"context_line":"        self._ctrl \u003d shards_controller"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def on_get(self, request, response, **kwargs):"},{"line_number":60,"context_line":"        \"\"\"Returns a shard listing as objects embedded in an array:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATX%2F%2F%2BCw%3D","line":57,"updated":"2013-10-23 14:30:46.000000000","message":"Here we go - integrating the storage layer with the transport!","commit_id":"6e1d4acb3008c9b9f7f814e8e5227d7827c67581"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a8ba08cc44986145edc92b258d4156e93a5d52a4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"\"\"Returns a shard listing as objects embedded in an array:"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        ["},{"line_number":63,"context_line":"            {\"href\": \"\", \"weight\": 100, \"uri\": \"\"},"},{"line_number":64,"context_line":"            ..."},{"line_number":65,"context_line":"        ]"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATX%2F%2F%2BCc%3D","line":63,"updated":"2013-10-23 14:30:46.000000000","message":"In this patch, I also change from using \u0027name\u0027 to \u0027href\u0027.","commit_id":"6e1d4acb3008c9b9f7f814e8e5227d7827c67581"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a8ba08cc44986145edc92b258d4156e93a5d52a4","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        # remove the name entry - it isn\u0027t needed on GET"},{"line_number":122,"context_line":"        data[\u0027href\u0027] \u003d request.path"},{"line_number":123,"context_line":"        del data[\u0027name\u0027]"},{"line_number":124,"context_line":"        response.body \u003d json.dumps(data, ensure_ascii\u003dFalse)"},{"line_number":125,"context_line":"        response.content_location \u003d request.relative_uri"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATX%2F%2F%2BCM%3D","line":123,"updated":"2013-10-23 14:30:46.000000000","message":"Oops - the comment above should be one line lower to make it more clear that it refers to the \u0027del\u0027 statement.","commit_id":"6e1d4acb3008c9b9f7f814e8e5227d7827c67581"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"ca70c962fa8ffe70ce531382763c626e31e9ddad","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{"},{"line_number":23,"context_line":"    \"name\": string,"},{"line_number":24,"context_line":"    \"weight\": integer,"},{"line_number":25,"context_line":"    \"uri\": string::uri"},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Furthermore, depending on the underlying storage type of shard being"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F0Kg%3D","line":25,"updated":"2013-10-28 15:55:25.000000000","message":"w00t! Love this change.","commit_id":"9e2b771676883075df864b3b07eb522bf85a1499"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"ca70c962fa8ffe70ce531382763c626e31e9ddad","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def __init__(self, shards_controller):"},{"line_number":56,"context_line":"        self._ctrl \u003d shards_controller"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def on_get(self, request, response, **kwargs):"},{"line_number":59,"context_line":"        \"\"\"Returns a shard listing as objects embedded in an array:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F0KQ%3D","line":58,"updated":"2013-10-28 15:55:25.000000000","message":"It would be great to have a comment about kwargs being ignored, to avoid confusion when it is immediately overwritten below.","commit_id":"9e2b771676883075df864b3b07eb522bf85a1499"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"fabe68a00f9c0c23c20020482d7d5b469789a553","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def __init__(self, shards_controller):"},{"line_number":56,"context_line":"        self._ctrl \u003d shards_controller"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def on_get(self, request, response, **kwargs):"},{"line_number":59,"context_line":"        \"\"\"Returns a shard listing as objects embedded in an array:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2F0Fo%3D","line":58,"in_reply_to":"AAAATn%2F%2F0KQ%3D","updated":"2013-10-28 16:13:23.000000000","message":"Ooohh, nice catch! With all this rebasing, that\u0027s a sign of the cruft catching up to me. :/","commit_id":"9e2b771676883075df864b3b07eb522bf85a1499"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def __init__(self, shards_controller):"},{"line_number":56,"context_line":"        self._ctrl \u003d shards_controller"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def on_get(self, request, response, **kwargs):"},{"line_number":59,"context_line":"        \"\"\"Returns a shard listing as objects embedded in an array:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FoAk%3D","line":58,"updated":"2013-10-31 09:07:41.000000000","message":"Do we need **kwargs here?\n\nIf yes, I think we should document it.","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"b4779f2a499b4a82c23428270a79fcbde45fef18","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def __init__(self, shards_controller):"},{"line_number":56,"context_line":"        self._ctrl \u003d shards_controller"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def on_get(self, request, response, **kwargs):"},{"line_number":59,"context_line":"        \"\"\"Returns a shard listing as objects embedded in an array:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FnRQ%3D","line":58,"in_reply_to":"AAAATn%2F%2FoAk%3D","updated":"2013-10-31 12:52:21.000000000","message":"Yeah, it\u0027s needed until we eliminate the proxy, since all of the queues routes take project_id and none of the proxy routes do. It\u0027s a touch of inconsistency I introduced while working on the proxy. I\u0027ll docstring it up for now, but once we start removing the proxy, we can come back to this and \u0027kwargs -\u003e project_id\u0027.","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        response.status \u003d falcon.HTTP_201"},{"line_number":146,"context_line":"        response.location \u003d request.path"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def on_delete(self, request, response, shard, **kwargs):"},{"line_number":149,"context_line":"        \"\"\"Deregisters a shard."},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        :returns: HTTP | 204"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FoAA%3D","line":148,"updated":"2013-10-31 09:07:41.000000000","message":"ditto","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        self._ctrl.delete(shard)"},{"line_number":155,"context_line":"        response.status \u003d falcon.HTTP_204"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def on_patch(self, request, response, shard, **kwargs):"},{"line_number":158,"context_line":"        \"\"\"Allows one to update a shard\u0027s weight, uri, and/or options."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        This method expects the user to submit a JSON object"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2Fn%2F8%3D","line":157,"updated":"2013-10-31 09:07:41.000000000","message":"ditto","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"}],"setup.cfg":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a8ba08cc44986145edc92b258d4156e93a5d52a4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"marconi.queues.admin.storage \u003d"},{"line_number":35,"context_line":"    sqlite \u003d marconi.queues.storage.sqlite.driver:AdminDriver"},{"line_number":36,"context_line":"    mongodb \u003d marconi.queues.storage.mongodb.driver:AdminDriver"},{"line_number":37,"context_line":"    faulty \u003d marconi.tests.faulty_storage:AdminDriver"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"marconi.queues.public.transport \u003d"},{"line_number":40,"context_line":"    wsgi \u003d marconi.queues.transport.wsgi.public.driver:Driver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"AAAATX%2F%2F%2BB8%3D","line":37,"updated":"2013-10-23 14:30:46.000000000","message":"This is important. Making the faulty driver a first class citizen fixes some *really* wonky behavior in our unit test suite. Doing setattr magic led to a subtle bug that led me in circles for hours (faulty driver was used every where!). Now, the unit test suite *just works*.","commit_id":"6e1d4acb3008c9b9f7f814e8e5227d7827c67581"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":29,"context_line":"marconi.queues.data.storage \u003d"},{"line_number":30,"context_line":"    sqlite \u003d marconi.queues.storage.sqlite.driver:DataDriver"},{"line_number":31,"context_line":"    mongodb \u003d marconi.queues.storage.mongodb.driver:DataDriver"},{"line_number":32,"context_line":"    faulty \u003d marconi.tests.faulty_storage:DataDriver"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"marconi.queues.control.storage \u003d"},{"line_number":35,"context_line":"    sqlite \u003d marconi.queues.storage.sqlite.driver:ControlDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":17,"id":"AAAATn%2F%2Fn%2Fs%3D","line":32,"updated":"2013-10-31 09:07:41.000000000","message":"I put some thoughts here and I definitely agree with this. As part of shipping tests bases along with Marconi, I think it\u0027s a good thing to make it easier for external transports to load / use the faulty driver for testing.\n\n+1","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"b4779f2a499b4a82c23428270a79fcbde45fef18","unresolved":false,"context_lines":[{"line_number":29,"context_line":"marconi.queues.data.storage \u003d"},{"line_number":30,"context_line":"    sqlite \u003d marconi.queues.storage.sqlite.driver:DataDriver"},{"line_number":31,"context_line":"    mongodb \u003d marconi.queues.storage.mongodb.driver:DataDriver"},{"line_number":32,"context_line":"    faulty \u003d marconi.tests.faulty_storage:DataDriver"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"marconi.queues.control.storage \u003d"},{"line_number":35,"context_line":"    sqlite \u003d marconi.queues.storage.sqlite.driver:ControlDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":17,"id":"AAAATn%2F%2FnQ0%3D","line":32,"in_reply_to":"AAAATn%2F%2Fn%2Fs%3D","updated":"2013-10-31 12:52:21.000000000","message":"I\u0027m pretty happy about this. It got rid of the silly error involving setattr and \u0027faulty\u0027. :P","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"}],"tests/unit/queues/transport/wsgi/base.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"a8ba08cc44986145edc92b258d4156e93a5d52a4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                           group\u003ddriver._WSGI_GROUP)"},{"line_number":37,"context_line":"        self.wsgi_cfg \u003d conf[driver._WSGI_GROUP]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        conf.admin_mode \u003d True"},{"line_number":40,"context_line":"        self.boot \u003d bootstrap.Bootstrap(conf)"},{"line_number":41,"context_line":"        self.app \u003d self.boot.transport.app"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATX%2F%2F%2BB4%3D","line":39,"updated":"2013-10-23 14:30:46.000000000","message":"For the unit tests, use admin_mode to enable access to all the interfaces.","commit_id":"6e1d4acb3008c9b9f7f814e8e5227d7827c67581"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":97,"context_line":"class TestBaseFaulty(TestBase):"},{"line_number":98,"context_line":"    \"\"\"This test ensures we aren\u0027t letting any exceptions go unhandled.\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        super(TestBaseFaulty, self).setUp()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2Fn%2Fg%3D","line":100,"updated":"2013-10-31 09:07:41.000000000","message":"We can get rid of both setUp and tearDown methods.","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"b4779f2a499b4a82c23428270a79fcbde45fef18","unresolved":false,"context_lines":[{"line_number":97,"context_line":"class TestBaseFaulty(TestBase):"},{"line_number":98,"context_line":"    \"\"\"This test ensures we aren\u0027t letting any exceptions go unhandled.\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        super(TestBaseFaulty, self).setUp()"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FnR0%3D","line":100,"in_reply_to":"AAAATn%2F%2Fn%2Fg%3D","updated":"2013-10-31 12:52:21.000000000","message":"Done","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"}],"tests/unit/queues/transport/wsgi/test_shards.py":[{"author":{"_account_id":6943,"name":"Zhihao Yuan","email":"zhihao.yuan@rackspace.com","username":"zyuan"},"change_message_id":"d6333d1373ca59228a5626e07b1abc427f1219f6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    args \u003d [(base + str(i), i,"},{"line_number":69,"context_line":"             str(i), {str(i): i})"},{"line_number":70,"context_line":"            for i in range(count)]"},{"line_number":71,"context_line":"    for path, weight, uri, option in args:"},{"line_number":72,"context_line":"        doc \u003d {\u0027weight\u0027: weight, \u0027uri\u0027: uri, \u0027options\u0027: option}"},{"line_number":73,"context_line":"        test.simulate_put(path, body\u003djson.dumps(doc))"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATH%2F%2FUn8%3D","line":71,"updated":"2013-10-17 18:50:32.000000000","message":"Still thinking whether this `option` is useful.  Should we starts with something simple?","commit_id":"80c93f0e7d5ccbff6929f54647926e0ca13b916a"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"534a2a17672484516b682709fa3523a495689fcf","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_404)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _shard_expect(self, shard, xhref, xweight, xuri):"},{"line_number":156,"context_line":"        print(shard, xhref, xweight, xuri)"},{"line_number":157,"context_line":"        self.assertIn(\u0027href\u0027, shard)"},{"line_number":158,"context_line":"        self.assertEqual(shard[\u0027href\u0027], xhref)"},{"line_number":159,"context_line":"        self.assertIn(\u0027weight\u0027, shard)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FwvY%3D","line":156,"updated":"2013-10-29 13:10:08.000000000","message":"Leftover print statements. :/ Removing.","commit_id":"60a1f4ea5f40e38fa7072181a2db107571508240"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"359e06300f1ca04e2d38e6c689c722db4bbb8709","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                       query_string\u003d\u0027?marker\u003d3\u0027)"},{"line_number":279,"context_line":"            self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":280,"context_line":"            shard_list \u003d json.loads(result[0])[\u0027shards\u0027]"},{"line_number":281,"context_line":"            print(shard_list)"},{"line_number":282,"context_line":"            self.assertEqual(len(shard_list), 6)"},{"line_number":283,"context_line":"            path, weight, uri \u003d expected[4][:3]"},{"line_number":284,"context_line":"            self._shard_expect(shard_list[0], path, weight, uri)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2Fyww%3D","line":281,"updated":"2013-10-28 23:19:43.000000000","message":"Did you mean to leave this print in?","commit_id":"60a1f4ea5f40e38fa7072181a2db107571508240"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"534a2a17672484516b682709fa3523a495689fcf","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                       query_string\u003d\u0027?marker\u003d3\u0027)"},{"line_number":279,"context_line":"            self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":280,"context_line":"            shard_list \u003d json.loads(result[0])[\u0027shards\u0027]"},{"line_number":281,"context_line":"            print(shard_list)"},{"line_number":282,"context_line":"            self.assertEqual(len(shard_list), 6)"},{"line_number":283,"context_line":"            path, weight, uri \u003d expected[4][:3]"},{"line_number":284,"context_line":"            self._shard_expect(shard_list[0], path, weight, uri)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FwvU%3D","line":281,"in_reply_to":"AAAATn%2F%2Fyww%3D","updated":"2013-10-29 13:10:08.000000000","message":"Nope. I\u0027ll remove it soon. Good catch!","commit_id":"60a1f4ea5f40e38fa7072181a2db107571508240"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39e14017af0f885ca3a582f237f2de5de88b66ff","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    :type uri: six.text_type"},{"line_number":39,"context_line":"    :type options: dict"},{"line_number":40,"context_line":"    :returns: (name, weight, uri, options)"},{"line_number":41,"context_line":"    :rtype: see above"},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":"    doc \u003d {\u0027weight\u0027: weight, \u0027uri\u0027: uri, \u0027options\u0027: options}"},{"line_number":44,"context_line":"    path \u003d \u0027/v1/shards/\u0027 + name"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2Fn%2Fc%3D","line":41,"updated":"2013-10-31 09:07:41.000000000","message":"LOL @ \u0027I already told you this\u0027","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"b4779f2a499b4a82c23428270a79fcbde45fef18","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    :type uri: six.text_type"},{"line_number":39,"context_line":"    :type options: dict"},{"line_number":40,"context_line":"    :returns: (name, weight, uri, options)"},{"line_number":41,"context_line":"    :rtype: see above"},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":"    doc \u003d {\u0027weight\u0027: weight, \u0027uri\u0027: uri, \u0027options\u0027: options}"},{"line_number":44,"context_line":"    path \u003d \u0027/v1/shards/\u0027 + name"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2FnRo%3D","line":41,"in_reply_to":"AAAATn%2F%2Fn%2Fc%3D","updated":"2013-10-31 12:52:21.000000000","message":":P - Though I I *could\u0027ve* been all like (six.text_type, int, six.text_type, dict) here. :D","commit_id":"2989ee5950145d9c0097f495975783c7211aa456"}]}
