)]}'
{"zaqar/tests/tempest_plugin/tests/v2/test_queues_negative.py":[{"author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"change_message_id":"9b88428b8b3b58f92b708328231cfb4f82fbae78","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        queue_name \u003d \u0027 \u0027"},{"line_number":51,"context_line":"        self.assertRaises(lib_exc.UnexpectedResponseCode,"},{"line_number":52,"context_line":"                          self.client.create_queue,"},{"line_number":53,"context_line":"                          queue_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u00273ca0e180-c770-4922-8a48-9563c484aaed\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_bbe1d69d","side":"PARENT","line":53,"updated":"2017-10-16 09:21:40.000000000","message":"we may not delete this test, we can use UnexpectedContentType instead of UnexpectedResponseCode. thanks","commit_id":"5e6dd90b6b97d32e5490b9ee8ad9605d17dded02"},{"author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"change_message_id":"f369de927575cb3967134bd1b5009de07ff43ac1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        queue_name \u003d \u0027 \u0027"},{"line_number":51,"context_line":"        self.assertRaises(lib_exc.UnexpectedResponseCode,"},{"line_number":52,"context_line":"                          self.client.create_queue,"},{"line_number":53,"context_line":"                          queue_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u00273ca0e180-c770-4922-8a48-9563c484aaed\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_e138b4a0","side":"PARENT","line":53,"in_reply_to":"5f4e5783_56c999a9","updated":"2017-10-16 15:34:28.000000000","message":"understand, that is OK, thanks. by the way, It seems that grenade and tripleo CI has broken.","commit_id":"5e6dd90b6b97d32e5490b9ee8ad9605d17dded02"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"522188e137552773b7d510c48a42e26ca8943a79","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        queue_name \u003d \u0027 \u0027"},{"line_number":51,"context_line":"        self.assertRaises(lib_exc.UnexpectedResponseCode,"},{"line_number":52,"context_line":"                          self.client.create_queue,"},{"line_number":53,"context_line":"                          queue_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u00273ca0e180-c770-4922-8a48-9563c484aaed\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f4e5783_56c999a9","side":"PARENT","line":53,"in_reply_to":"5f4e5783_bbe1d69d","updated":"2017-10-16 09:33:32.000000000","message":"I just try to write my opinion here:\nFor this test, the request url actually is http://ip/messaging/v2/queues/ . So Zaqar will return 405 obviously by default.\n\nBut when use Apache proxy, the UnexpectedContentType error is raised by Apache, not Zaqar. If we just change error code here, although jenkins can be happy, the user who don\u0027t use Apache proxy will meet error when he run this test locally.\n\nSo IMO, we can remove this useless 405 error test directly, rather than leaving such misleading test here.","commit_id":"5e6dd90b6b97d32e5490b9ee8ad9605d17dded02"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"d4334d9a15fd3e8e1c723571e63bf6f5e8a5ab96","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        queue_name \u003d \u0027 \u0027"},{"line_number":51,"context_line":"        self.assertRaises(lib_exc.UnexpectedResponseCode,"},{"line_number":52,"context_line":"                          self.client.create_queue,"},{"line_number":53,"context_line":"                          queue_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u00273ca0e180-c770-4922-8a48-9563c484aaed\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_35955a41","side":"PARENT","line":53,"updated":"2017-10-20 07:30:06.000000000","message":"What\u0027s happening with this test?","commit_id":"3ce441061815ec5de8f7f2ddb3f1fe61f912bed0"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e85cf32d4f15b0773ff71f25ebfc2ba5e741ff30","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        queue_name \u003d \u0027 \u0027"},{"line_number":51,"context_line":"        self.assertRaises(lib_exc.UnexpectedResponseCode,"},{"line_number":52,"context_line":"                          self.client.create_queue,"},{"line_number":53,"context_line":"                          queue_name)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @decorators.attr(type\u003d[\u0027negative\u0027])"},{"line_number":56,"context_line":"    @decorators.idempotent_id(\u00273ca0e180-c770-4922-8a48-9563c484aaed\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_d5a726a7","side":"PARENT","line":53,"in_reply_to":"3f4b6375_35955a41","updated":"2017-10-20 07:57:30.000000000","message":"Copy the previous comment here:\nFor this test, the request url actually is http://ip/messaging/v2/queues/ . So Zaqar will return 405 obviously by default.\nBut when use Apache proxy, the UnexpectedContentType error is raised by Apache, not Zaqar. If we just change error code here, although jenkins can be happy, the user who don\u0027t use Apache proxy will meet error when he run this test locally.\nSo IMO, we can remove this useless 405 error test directly, rather than leaving such misleading test here.","commit_id":"3ce441061815ec5de8f7f2ddb3f1fe61f912bed0"}],"zaqar/transport/wsgi/app.py":[{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"f7352c878aa65cd9d9c04326f5c1c38d26f6527d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"gmr.TextGuruMeditation.setup_autorun(version, conf\u003dconf)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def build_wsgi():"},{"line_number":48,"context_line":"    boot \u003d bootstrap.Bootstrap(conf)"},{"line_number":49,"context_line":"    conf.drivers.transport \u003d \u0027wsgi\u0027"},{"line_number":50,"context_line":"    application \u003d boot.transport.app"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_fefe9a03","line":47,"updated":"2017-10-19 13:09:23.000000000","message":"This is not backward compatible, you should keep this module this way.","commit_id":"e50f71e60d38c0d2ab228bce57ef69c469949fef"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"e85cf32d4f15b0773ff71f25ebfc2ba5e741ff30","unresolved":false,"context_lines":[{"line_number":44,"context_line":"gmr.TextGuruMeditation.setup_autorun(version, conf\u003dconf)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def build_wsgi():"},{"line_number":48,"context_line":"    boot \u003d bootstrap.Bootstrap(conf)"},{"line_number":49,"context_line":"    conf.drivers.transport \u003d \u0027wsgi\u0027"},{"line_number":50,"context_line":"    application \u003d boot.transport.app"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_309b2fca","line":47,"in_reply_to":"3f4b6375_fefe9a03","updated":"2017-10-20 07:57:30.000000000","message":"yeah.","commit_id":"e50f71e60d38c0d2ab228bce57ef69c469949fef"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"d4334d9a15fd3e8e1c723571e63bf6f5e8a5ab96","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \"\"\"Another way used by setup.cfg to initialize WSGI app\"\"\""},{"line_number":54,"context_line":"    boot \u003d bootstrap.Bootstrap(conf)"},{"line_number":55,"context_line":"    conf.drivers.transport \u003d \u0027wsgi\u0027"},{"line_number":56,"context_line":"    application \u003d boot.transport.app"},{"line_number":57,"context_line":"    # Keep the old name for compatibility"},{"line_number":58,"context_line":"    app \u003d application"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    return app"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f4b6375_d5c4c661","line":60,"range":{"start_line":56,"start_character":0,"end_line":60,"end_character":14},"updated":"2017-10-20 07:30:06.000000000","message":"You can simply write\n\nreturn boot.transport.app","commit_id":"6198f6c2bec4a8896654c88e9dc348b1bf2a0c7b"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"f51debe5b105a77ac074fc8e63d89893cb8f5cdc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    \"\"\"Another way used by setup.cfg to initialize WSGI app\"\"\""},{"line_number":54,"context_line":"    boot \u003d bootstrap.Bootstrap(conf)"},{"line_number":55,"context_line":"    conf.drivers.transport \u003d \u0027wsgi\u0027"},{"line_number":56,"context_line":"    return boot.transport.app"}],"source_content_type":"text/x-python","patch_set":12,"id":"3f4b6375_466a6eb3","line":56,"updated":"2017-10-20 09:22:48.000000000","message":"Sorry that was a dumb suggestion. We already do all the thing in the module, you can simply do:\n\nreturn application\n\nOtherwise, you should create a new module and move that function in there.","commit_id":"4ca5eb08d5c6c18d2e347914b8620d7b2ce22ce9"}]}
