)]}'
{"zaqar/transport/validation.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"28383d2af5fe8ad7b89694006fdd392d1b4c2bbd","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            msg \u003d _(u\u0027_default_message_ttl must be integer.\u0027)"},{"line_number":351,"context_line":"            raise ValidationFailed(msg)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if queue_default_ttl is not None:"},{"line_number":354,"context_line":"            if not (MIN_MESSAGE_TTL \u003c\u003d queue_default_ttl \u003c\u003d"},{"line_number":355,"context_line":"                    self._limits_conf.max_message_ttl):"},{"line_number":356,"context_line":"                msg \u003d _(u\u0027_default_message_ttl can not exceed {0} \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_7894d7e8","line":353,"updated":"2017-10-31 20:44:04.000000000","message":"I don\u0027t think it\u0027s a correct Zaqar need to support. Either 0 TTL or 0 message size is not valid.","commit_id":"1675cbbca71241d87bf96f66d6d9d057a31f350c"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"3573a2659c1378100596c879dc48c1e75c91190b","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            msg \u003d _(u\u0027_default_message_ttl must be integer.\u0027)"},{"line_number":351,"context_line":"            raise ValidationFailed(msg)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if queue_default_ttl is not None:"},{"line_number":354,"context_line":"            if not (MIN_MESSAGE_TTL \u003c\u003d queue_default_ttl \u003c\u003d"},{"line_number":355,"context_line":"                    self._limits_conf.max_message_ttl):"},{"line_number":356,"context_line":"                msg \u003d _(u\u0027_default_message_ttl can not exceed {0} \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_99b792d9","line":353,"in_reply_to":"3f4b6375_7894d7e8","updated":"2017-11-01 01:39:42.000000000","message":"But if we do not check, we can not prevent the user to set 0, and 0 is not in the valid range.","commit_id":"1675cbbca71241d87bf96f66d6d9d057a31f350c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"1f3584c551e471866f8dbd23195df4ade3a1de94","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            msg \u003d _(u\u0027_default_message_ttl must be integer.\u0027)"},{"line_number":351,"context_line":"            raise ValidationFailed(msg)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if queue_default_ttl is not None:"},{"line_number":354,"context_line":"            if not (MIN_MESSAGE_TTL \u003c\u003d queue_default_ttl \u003c\u003d"},{"line_number":355,"context_line":"                    self._limits_conf.max_message_ttl):"},{"line_number":356,"context_line":"                msg \u003d _(u\u0027_default_message_ttl can not exceed {0} \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_b44933b8","line":353,"in_reply_to":"3f4b6375_99b792d9","updated":"2017-11-01 02:41:34.000000000","message":"Please figure it out if I missed something. At line 354, Zaqar will check the range for TTL.\n\nAt line 368, Zaqar will check the range for message size.","commit_id":"1675cbbca71241d87bf96f66d6d9d057a31f350c"},{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"706a412f4ff742f9f11eef739ad89d708da05451","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            msg \u003d _(u\u0027_default_message_ttl must be integer.\u0027)"},{"line_number":351,"context_line":"            raise ValidationFailed(msg)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if queue_default_ttl is not None:"},{"line_number":354,"context_line":"            if not (MIN_MESSAGE_TTL \u003c\u003d queue_default_ttl \u003c\u003d"},{"line_number":355,"context_line":"                    self._limits_conf.max_message_ttl):"},{"line_number":356,"context_line":"                msg \u003d _(u\u0027_default_message_ttl can not exceed {0} \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_309e6cb8","line":353,"in_reply_to":"3f4b6375_b44933b8","updated":"2017-11-01 04:59:14.000000000","message":"If the value is zero, it will skip this check.","commit_id":"1675cbbca71241d87bf96f66d6d9d057a31f350c"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"9f8fe3660a7ec20ce98ee7944a5a42bd5362e2ee","unresolved":false,"context_lines":[{"line_number":382,"context_line":"            msg \u003d _(u\u0027_dead_letter_queue_messages_ttl must be integer.\u0027)"},{"line_number":383,"context_line":"            raise ValidationFailed(msg)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        if dlq_ttl and not (MIN_MESSAGE_TTL \u003c\u003d dlq_ttl \u003c\u003d"},{"line_number":386,"context_line":"                            self._limits_conf.max_message_ttl):"},{"line_number":387,"context_line":"            msg \u003d _(u\u0027The TTL for a message may not exceed {0} seconds, \u0027"},{"line_number":388,"context_line":"                    \u0027and must be at least {1} seconds long.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_ffad3f9b","line":385,"range":{"start_line":385,"start_character":11,"end_line":385,"end_character":18},"updated":"2017-11-01 08:45:28.000000000","message":"here as well IMO.","commit_id":"0ae660504e1bc3c4f0786022717d02bd66f5fd66"}]}