)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"da5d32ffed8b3f942b18def8601d33a3f05cb11c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kgriffs \u003ckurt.griffiths@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-14 16:27:57 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(queues): Global config used everywhere"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch modifies the queues code to use manually instantiated configs"},{"line_number":10,"context_line":"rather than the global config. This will allow for more flexibility in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2Ff4U%3D","line":7,"updated":"2013-10-15 13:31:30.000000000","message":"We need to improve a bit our triaging process, there was a blueprint remove-global-config for this and I had some work done. Not big deal, TBH, I\u0027m just saying this to help newcomers and avoid overlapping work.","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"b1d826899d9a54f212d5e8ef35a309b01ee84882","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kgriffs \u003ckurt.griffiths@rackspace.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-14 16:27:57 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(queues): Global config used everywhere"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch modifies the queues code to use manually instantiated configs"},{"line_number":10,"context_line":"rather than the global config. This will allow for more flexibility in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2Fd8U%3D","line":7,"in_reply_to":"AAAATH%2F%2Ff4U%3D","updated":"2013-10-15 20:03:44.000000000","message":"Ah crap, I\u0027m sorry. I looked for the blueprint but somehow missed it. My fault. I should have checked with you for sure since I had a vague recollection you were working on this.\n\nOne thing we should figure out is how to keep everyone more aware of new blueprints as they are created, and subsequently worked on so we avoid rework. Let\u0027s discuss in the next team mtg.","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"da5d32ffed8b3f942b18def8601d33a3f05cb11c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"rather than the global config. This will allow for more flexibility in"},{"line_number":11,"context_line":"configuring components. For example, the up-and-coming sharding feature"},{"line_number":12,"context_line":"can construct configs based on the shard catalog rather than the local"},{"line_number":13,"context_line":"INI file. Also, this change will make testing easier."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1afa8ab8c7e6dd9a017f4a9e3a3b1fadbeb32806"},{"line_number":16,"context_line":"Closes-Bug: #1239725"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FfjU%3D","line":13,"updated":"2013-10-15 13:31:30.000000000","message":"The patch seems to do more than just removing the config instance. For example, it also moves table creation away from the controllers in the sqlite backend.\n\nDo you mind adding that here as well?","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"b1d826899d9a54f212d5e8ef35a309b01ee84882","unresolved":false,"context_lines":[{"line_number":10,"context_line":"rather than the global config. This will allow for more flexibility in"},{"line_number":11,"context_line":"configuring components. For example, the up-and-coming sharding feature"},{"line_number":12,"context_line":"can construct configs based on the shard catalog rather than the local"},{"line_number":13,"context_line":"INI file. Also, this change will make testing easier."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1afa8ab8c7e6dd9a017f4a9e3a3b1fadbeb32806"},{"line_number":16,"context_line":"Closes-Bug: #1239725"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2Fd8I%3D","line":13,"in_reply_to":"AAAATH%2F%2FfjU%3D","updated":"2013-10-15 20:03:44.000000000","message":"Yeah, this work was originally part of the sharding stuff and I split it out - forgot that the sqlite stuff ended up in this patch. I\u0027ll update the commit.","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"}],"marconi/common/transport/wsgi/helpers.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"f7d20cb7a7750b7df77a3e09dc3d09b1e5c3749f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"and retry.\u0027\u0027\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_queue_name(validate, req, resp, params):"},{"line_number":47,"context_line":"    \"\"\"Hook for validating the queue name sepecified in requests."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Validation is short-circuited if \u0027queue_name\u0027 does not"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fe%2FI%3D","line":46,"updated":"2013-10-15 15:51:08.000000000","message":"What is validate? Could you add docstrings for this?","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"b1d826899d9a54f212d5e8ef35a309b01ee84882","unresolved":false,"context_lines":[{"line_number":43,"context_line":"and retry.\u0027\u0027\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def validate_queue_name(validate, req, resp, params):"},{"line_number":47,"context_line":"    \"\"\"Hook for validating the queue name sepecified in requests."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Validation is short-circuited if \u0027queue_name\u0027 does not"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fd8A%3D","line":46,"in_reply_to":"AAAATH%2F%2Fe%2FI%3D","updated":"2013-10-15 20:03:44.000000000","message":"Done","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"}],"marconi/queues/bootstrap.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"da5d32ffed8b3f942b18def8601d33a3f05cb11c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if config_file is not None:"},{"line_number":47,"context_line":"            default_file \u003d [config_file]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.conf \u003d cfg.ConfigOpts()"},{"line_number":50,"context_line":"        self.conf.register_opts(_DRIVER_OPTIONS, group\u003d_DRIVER_GROUP)"},{"line_number":51,"context_line":"        self.driver_conf \u003d self.conf[_DRIVER_GROUP]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Ff1E%3D","line":49,"updated":"2013-10-15 13:31:30.000000000","message":"This unfortunately won\u0027t work, yet. The reason is that we won\u0027t be able to register CLI options until this instance is created, which means that commands like `marconi-server -d -v` will be broken by this patch. \n\nOne way to workaround this issue is to have just 1 global instance - perhaps defined here - and use that unique global instance. This will allow us to, at least, change current API and support upcoming APIs. The other way would be to change Bootstrap constructor and make it accept a ConfigOpts instance instead of config_file and cli_args and let it use that instance instead of creating one. This new instance could be created in the command module. \n\nI personally prefer the second one.","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"783f16c6900511e84a084ac0dbed2dc253201588","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if config_file is not None:"},{"line_number":47,"context_line":"            default_file \u003d [config_file]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.conf \u003d cfg.ConfigOpts()"},{"line_number":50,"context_line":"        self.conf.register_opts(_DRIVER_OPTIONS, group\u003d_DRIVER_GROUP)"},{"line_number":51,"context_line":"        self.driver_conf \u003d self.conf[_DRIVER_GROUP]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fd3Y%3D","line":49,"in_reply_to":"AAAATH%2F%2Fd7c%3D","updated":"2013-10-15 20:05:31.000000000","message":"Actually, can I do this as a followup patch on top of the sharding one? It will make life easier since the rebasing will be tricky in this case.","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"b1d826899d9a54f212d5e8ef35a309b01ee84882","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if config_file is not None:"},{"line_number":47,"context_line":"            default_file \u003d [config_file]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.conf \u003d cfg.ConfigOpts()"},{"line_number":50,"context_line":"        self.conf.register_opts(_DRIVER_OPTIONS, group\u003d_DRIVER_GROUP)"},{"line_number":51,"context_line":"        self.driver_conf \u003d self.conf[_DRIVER_GROUP]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fd7c%3D","line":49,"in_reply_to":"AAAATH%2F%2Ff1E%3D","updated":"2013-10-15 20:03:44.000000000","message":"Ah, good catch. I forgot about that. Let me take a stab at the second option.","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"f7d20cb7a7750b7df77a3e09dc3d09b1e5c3749f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if config_file is not None:"},{"line_number":47,"context_line":"            default_file \u003d [config_file]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        self.conf \u003d cfg.ConfigOpts()"},{"line_number":50,"context_line":"        self.conf.register_opts(_DRIVER_OPTIONS, group\u003d_DRIVER_GROUP)"},{"line_number":51,"context_line":"        self.driver_conf \u003d self.conf[_DRIVER_GROUP]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fe%2B0%3D","line":49,"in_reply_to":"AAAATH%2F%2Ff1E%3D","updated":"2013-10-15 15:51:08.000000000","message":"Good thoughts, Flavio. Seems like the global configuration migration is trickier than I expected!","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"}],"tests/unit/queues/transport/wsgi/base.py":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"f7d20cb7a7750b7df77a3e09dc3d09b1e5c3749f","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"class TestBaseFaulty(TestBase):"},{"line_number":98,"context_line":"    \"\"\"This test ensures we aren\u0027t letting any exceptions go unhandled.\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        self._storage_backup \u003d marconi.Bootstrap.storage"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fe9g%3D","line":98,"updated":"2013-10-15 15:51:08.000000000","message":"Thanks for this docstring!","commit_id":"d43f0752c83c9e76ac00bf266e2e01add000683d"}]}
