)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"abe7ec0e2d8fc4753b35878fa34b1b1f59d56e36","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-12-11 10:59:10 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added two files that will stage communication"},{"line_number":8,"context_line":"between the transport and API layers."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I2d67a15fa8c6aef23ebcde6a71dda3fcb723873a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F9Uxo%3D","line":8,"updated":"2013-12-12 16:46:42.000000000","message":"Could you change the commit message so it uses the following format\n\n    feat: added Response/Request objects\n\n    Lengthier explanation goes here.\n\n    Change-Id: auto-inserted by git review\n\nThe subject line (the first line) should be less than 50 characters.\n\nThanks!","commit_id":"990fc040fad949a6e2329c324346f5f56bf085af"}],"marconi/common/request.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ff123b4baa21e97d96d17a4873e93cee89e6861b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    req \u003d Request(**kwargs)"},{"line_number":43,"context_line":"    auth_backend \u003d auth.get_backend(**(auth_opts or {}))"},{"line_number":44,"context_line":"    # TODO(flaper87): Do something smarter"},{"line_number":45,"context_line":"    # to get the api_version."},{"line_number":46,"context_line":"    req \u003d auth_backend.authenticate(1, req)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9RTA%3D","line":43,"updated":"2013-12-13 09:09:54.000000000","message":"I think your changes got lost somewhere. :D\n\nYou still need to address some of my comments in the previous patch-set.","commit_id":"990fc040fad949a6e2329c324346f5f56bf085af"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"f3b66c217e0be79aff457244976a8e36cd3254af","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def deserialized_body(self, content):"},{"line_number":83,"context_line":"        if content is not None:"},{"line_number":84,"context_line":"            self.content \u003d json.dumps(content)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9BAk%3D","line":84,"updated":"2013-12-17 17:06:37.000000000","message":"I think what you want here is `return json.dumps(content). Also, you could add a return None at the end of the method.","commit_id":"b0d1fb557897319e32ba13bdd7033e2826fcdc8f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0d0ea6c1b71f94e9d77e90e6e885c88fe0b44a2c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        self.params \u003d params or {}"},{"line_number":57,"context_line":"        self.headers \u003d headers or {}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.lazy_property"},{"line_number":60,"context_line":"    def deserialized_body(self):"},{"line_number":61,"context_line":"        if self.content is not None:"},{"line_number":62,"context_line":"            return json.dumps(self.content)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8mTQ%3D","line":59,"updated":"2013-12-24 15:04:19.000000000","message":"It\u0027s a callable decorator: @decorators.lazy_property()","commit_id":"ca1247ce702f5ea9b5a82c4c2211dcb9f4cec0d3"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0d0ea6c1b71f94e9d77e90e6e885c88fe0b44a2c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.headers \u003d headers or {}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @decorators.lazy_property"},{"line_number":60,"context_line":"    def deserialized_body(self):"},{"line_number":61,"context_line":"        if self.content is not None:"},{"line_number":62,"context_line":"            return json.dumps(self.content)"},{"line_number":63,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F8mUQ%3D","line":60,"updated":"2013-12-24 15:04:19.000000000","message":"I\u0027d call it `deserialized_content` to make it consistent with `self.content`","commit_id":"ca1247ce702f5ea9b5a82c4c2211dcb9f4cec0d3"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"506945e09ec001dab3b411888be890defb4ed1bc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    @decorators.lazy_property()"},{"line_number":60,"context_line":"    def deserialized_content(self):"},{"line_number":61,"context_line":"        if self.content is not None:"},{"line_number":62,"context_line":"            return json.dumps(self.content)"},{"line_number":63,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2FyS4%3D","line":62,"updated":"2013-12-31 16:52:24.000000000","message":"I think you meant `json.loads`","commit_id":"1c3a1f936f529ac06e399637bfd10f064efc2d08"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"5d94f27a07753a518446574b019e2b4e85d9369f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class Request(object):"},{"line_number":23,"context_line":"    \"\"\"General data for a Marconi request"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    The idea is to be declarative i.e. specify *what* is desired. It\u0027s up to"},{"line_number":26,"context_line":"    the respective transport to turn this into a layer-specific request."}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F3OY%3D","line":23,"updated":"2014-01-07 14:51:10.000000000","message":"Could you please update the docstring and explain what this class (and the response one) are intended for?","commit_id":"138dbfc1c7b2840c379c4925c80e95c2e9df93ce"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"3afbd5b1b5eaa378194d80e6918e8890bfbc3672","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    *NOTE:* This implementation is not definitive and may change."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    :param endpoint: Server\u0027s endpoint"},{"line_number":31,"context_line":"    :type endpoint: str"},{"line_number":32,"context_line":"    :param operation: Operation to issue on the endpoint, i.e:"},{"line_number":33,"context_line":"        - get_queues"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F%2FCU%3D","line":30,"updated":"2014-01-05 03:15:46.000000000","message":"How is this class going to be used? It looks like something that belongs in python-marconiclient at first glance... Do we envision the server making requests to other services, and therefore needing a destination server endpoint?","commit_id":"138dbfc1c7b2840c379c4925c80e95c2e9df93ce"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"5d94f27a07753a518446574b019e2b4e85d9369f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    *NOTE:* This implementation is not definitive and may change."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    :param endpoint: Server\u0027s endpoint"},{"line_number":31,"context_line":"    :type endpoint: str"},{"line_number":32,"context_line":"    :param operation: Operation to issue on the endpoint, i.e:"},{"line_number":33,"context_line":"        - get_queues"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2F3Ow%3D","line":30,"in_reply_to":"AAAAUH%2F%2F%2FCU%3D","updated":"2014-01-07 14:51:10.000000000","message":"No, it just represents an incoming request. it\u0027s a common \u0027type\u0027 for transports to send requests to the API layer.\n\ntransport (Translate\u0027s network request into Request) -\u003e API Layer","commit_id":"138dbfc1c7b2840c379c4925c80e95c2e9df93ce"}],"marconi/queues/transport/request.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7593f332dd10322638d086e7e4147e1c6403d506","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    req \u003d Request(**kwargs)"},{"line_number":43,"context_line":"    auth_backend \u003d auth.get_backend(**(auth_opts or {}))"},{"line_number":44,"context_line":"    # TODO(flaper87): Do something smarter"},{"line_number":45,"context_line":"    # to get the api_version."},{"line_number":46,"context_line":"    req \u003d auth_backend.authenticate(1, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9bSU%3D","line":43,"updated":"2013-12-11 16:48:52.000000000","message":"I think you want to get rid of this","commit_id":"c1bd615c14bab8464761f761b78ba7778f067387"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7593f332dd10322638d086e7e4147e1c6403d506","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    req \u003d auth_backend.authenticate(1, req)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    if data is not None:"},{"line_number":49,"context_line":"        req.content \u003d json.dumps(data)"},{"line_number":50,"context_line":"    return req"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9bRc%3D","line":49,"updated":"2013-12-11 16:48:52.000000000","message":"We should maybe move this under request and have a cached property called `deserialized_body`.\n\nThis will need some testing :D","commit_id":"c1bd615c14bab8464761f761b78ba7778f067387"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"e919083a0e5bcaae913c39dc2b8271819fc57633","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    req \u003d auth_backend.authenticate(1, req)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    if data is not None:"},{"line_number":49,"context_line":"        req.content \u003d json.dumps(data)"},{"line_number":50,"context_line":"    return req"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9azA%3D","line":49,"in_reply_to":"AAAATn%2F9bRc%3D","updated":"2013-12-11 18:33:27.000000000","message":"lines 43-49?","commit_id":"c1bd615c14bab8464761f761b78ba7778f067387"}],"tests/unit/common/test_request.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"506945e09ec001dab3b411888be890defb4ed1bc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def test_request_deserialized(self):"},{"line_number":28,"context_line":"        data \u003d \u0027{\"data\": \"tons of GBs\"}\u0027"},{"line_number":29,"context_line":"        req \u003d request.Request(content\u003ddata)"},{"line_number":30,"context_line":"        self.assertIsInstance(req.deserialized_content, str)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAT3%2F%2FySg%3D","line":30,"updated":"2013-12-31 16:52:24.000000000","message":"It should be an instance of dict since you\u0027re deserializing it, right?\n\nRead my comment about `loads` in the request module.","commit_id":"1c3a1f936f529ac06e399637bfd10f064efc2d08"}]}
