)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"4a2aed274e64bafc60e40dba5716842c13de3d93","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Performance Indicator) of the target Marconi server."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"docImpact"},{"line_number":14,"context_line":"bp/detailed-health"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6b281132e2fef8ce65ce54b9d6be297571f8b170"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAVn%2F%2Fr7U%3D","line":14,"updated":"2014-03-04 17:31:58.000000000","message":"Partially-implements: blueprint detailed-health","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"8b137e0abacf6923464015b3c74e4fb514892f89","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Performance Indicator) of the target Marconi server."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"docImpact"},{"line_number":14,"context_line":"bp/detailed-health"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6b281132e2fef8ce65ce54b9d6be297571f8b170"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAVn%2F%2Fryg%3D","line":14,"in_reply_to":"AAAAVn%2F%2Fr7U%3D","updated":"2014-03-04 18:20:38.000000000","message":"Done","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"}],"marconi/queues/storage/base.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38fac942d7321ff631d2f4da79473a9579cecd7a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        raise NotImplementedError"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @abc.abstractmethod"},{"line_number":69,"context_line":"    def health(self):"},{"line_number":70,"context_line":"        \"\"\"Returns KPI about server health.\"\"\""},{"line_number":71,"context_line":"        raise NotImplementedError"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fb80%3D","line":69,"updated":"2014-02-26 16:40:07.000000000","message":"what do you think about having a default implementation of this method that calls a private implementation that has to be (guess what?) implemented by the subclasses?\n\nExample:\n\n    def health(self):\n        # do CPU / mem stuff here\n        backend_health \u003d self._health()\n        return process_health + backend_health\n\n    @abc.abstractmethod\n    def _health(self):\n        raise NotImplementedError\n\n\nTBH, I\u0027m not sure this method has to be abstract. Are there backends that may not be able to export some of these KPIs ?","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"917fb9b24941b1b29fe98adfc0a72a33996eefbe","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        raise NotImplementedError"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @abc.abstractmethod"},{"line_number":69,"context_line":"    def health(self):"},{"line_number":70,"context_line":"        \"\"\"Returns KPI about server health.\"\"\""},{"line_number":71,"context_line":"        raise NotImplementedError"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fbxo%3D","line":69,"in_reply_to":"AAAAU3%2F%2Fb80%3D","updated":"2014-02-26 17:01:21.000000000","message":"I was just thinking that we should factor out the localhost metrics from the ones that come from storage. As a first iteration, we can calculate CPU and memory KPI\u0027s inline. In a second iteration, I think it would be great to have a KPI driver model with a simple reference driver.","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"938c7578f5e1915c7549ec0f6d1a806c109ecb64","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        raise NotImplementedError"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @abc.abstractmethod"},{"line_number":69,"context_line":"    def health(self):"},{"line_number":70,"context_line":"        \"\"\"Returns KPI about server health.\"\"\""},{"line_number":71,"context_line":"        raise NotImplementedError"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F9Q8%3D","line":69,"in_reply_to":"AAAAU3%2F%2Fbxo%3D","updated":"2014-02-27 06:10:18.000000000","message":"That\u0027s really I want to do originally, but after discussed with flaper87, he suggested me implement a basic model at the first stage. I will dive into it to figure out if we can make it in Icehouse. Thanks for the comments, guys.","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33c9d82bd7e00d9c42b863c400da9fa7175f37fe","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        raise NotImplementedError"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @abc.abstractmethod"},{"line_number":69,"context_line":"    def health(self):"},{"line_number":70,"context_line":"        \"\"\"Returns KPI about server health.\"\"\""},{"line_number":71,"context_line":"        raise NotImplementedError"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F3v4%3D","line":69,"in_reply_to":"AAAAVX%2F%2F8FE%3D","updated":"2014-02-27 17:21:57.000000000","message":"Thanks for the comments. I will follow up your first suggestion and let\u0027s discuss the pluggable health driver.","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e906cc72a8d446b6b1925e5bdf7b53be6c2a198e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        raise NotImplementedError"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @abc.abstractmethod"},{"line_number":69,"context_line":"    def health(self):"},{"line_number":70,"context_line":"        \"\"\"Returns KPI about server health.\"\"\""},{"line_number":71,"context_line":"        raise NotImplementedError"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F8FE%3D","line":69,"in_reply_to":"AAAAVX%2F%2F9Q8%3D","updated":"2014-02-27 08:47:28.000000000","message":"At a first thought, when talking with flwang, I agreed that a plugin based model would be nice but I\u0027m now wondering what the real benefit of that would be. I mean, with the above suggestion each driver will be able to provide custom KPI\u0027s. If there are multiple drivers in use, then the ShardDriver is responsible to collect and structure them all.\n\nBesides the health provided by the driver base and each storage driver, what else would be useful?\n\nAn *awful* hack I can think of is that folks could have a non-op driver and let that collect some stats for them by basically just implementing the `health` method.\n\nThat said, I\u0027m also worried about making marconi *tooooo* pluggable but I don\u0027t think it is, yet.","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # NOTE(flwang): KPI of local Marconi server process. Though they are"},{"line_number":74,"context_line":"        # placed at here, it\u0027s reasonable from the logic perspective of"},{"line_number":75,"context_line":"        # Marconi architecture."},{"line_number":76,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":77,"context_line":"        overall_health[\u0027cpu_util\u0027] \u003d p.get_cpu_percent()"},{"line_number":78,"context_line":"        overall_health[\u0027memory_util\u0027] \u003d p.get_memory_percent()"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuXU%3D","line":76,"updated":"2014-03-04 14:36:31.000000000","message":"Did you take a look at executils ?","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"4a2aed274e64bafc60e40dba5716842c13de3d93","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # NOTE(flwang): KPI of local Marconi server process. Though they are"},{"line_number":74,"context_line":"        # placed at here, it\u0027s reasonable from the logic perspective of"},{"line_number":75,"context_line":"        # Marconi architecture."},{"line_number":76,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":77,"context_line":"        overall_health[\u0027cpu_util\u0027] \u003d p.get_cpu_percent()"},{"line_number":78,"context_line":"        overall_health[\u0027memory_util\u0027] \u003d p.get_memory_percent()"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fr5g%3D","line":76,"in_reply_to":"AAAAVn%2F%2Ftjk%3D","updated":"2014-03-04 17:31:58.000000000","message":"I\u0027m +1 for using psutil to achieve this.\n\nAs Fei mentioned, processutils (managed subprocess execution) and excutils (exception management) don\u0027t help us solve the KPI problem.\n\npsutil is also a part of requirements: https://github.com/openstack/requirements/blob/master/global-requirements.txt#L66","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"561e60d12fc7b887501ffe2374a6d4da272debae","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # NOTE(flwang): KPI of local Marconi server process. Though they are"},{"line_number":74,"context_line":"        # placed at here, it\u0027s reasonable from the logic perspective of"},{"line_number":75,"context_line":"        # Marconi architecture."},{"line_number":76,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":77,"context_line":"        overall_health[\u0027cpu_util\u0027] \u003d p.get_cpu_percent()"},{"line_number":78,"context_line":"        overall_health[\u0027memory_util\u0027] \u003d p.get_memory_percent()"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Ftjk%3D","line":76,"in_reply_to":"AAAAVn%2F%2FuXU%3D","updated":"2014-03-04 16:31:25.000000000","message":"Did you mean processutils? I did based on your suggestion. But seems it\u0027s just like a shell command wrapper, not very intuitive like psutil. Please let me know if I missed anything. Thanks.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @abc.abstractmethod"},{"line_number":89,"context_line":"    def _health(self):"},{"line_number":90,"context_line":"        \"\"\"Returns KPI about backend storage health.\"\"\""},{"line_number":91,"context_line":"        raise NotImplementedError"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @abc.abstractproperty"},{"line_number":94,"context_line":"    def queue_controller(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuXw%3D","line":91,"updated":"2014-03-04 14:36:31.000000000","message":"Does this need to be abstract? What if there are storage that don\u0027t need to implement this method? \n\nWhat about keeping it empty in the base class?","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"4a2aed274e64bafc60e40dba5716842c13de3d93","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @abc.abstractmethod"},{"line_number":89,"context_line":"    def _health(self):"},{"line_number":90,"context_line":"        \"\"\"Returns KPI about backend storage health.\"\"\""},{"line_number":91,"context_line":"        raise NotImplementedError"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @abc.abstractproperty"},{"line_number":94,"context_line":"    def queue_controller(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fr5E%3D","line":91,"in_reply_to":"AAAAVn%2F%2FtjE%3D","updated":"2014-03-04 17:31:58.000000000","message":"+1 for empty default implementation","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"561e60d12fc7b887501ffe2374a6d4da272debae","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @abc.abstractmethod"},{"line_number":89,"context_line":"    def _health(self):"},{"line_number":90,"context_line":"        \"\"\"Returns KPI about backend storage health.\"\"\""},{"line_number":91,"context_line":"        raise NotImplementedError"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    @abc.abstractproperty"},{"line_number":94,"context_line":"    def queue_controller(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FtjE%3D","line":91,"in_reply_to":"AAAAVn%2F%2FuXw%3D","updated":"2014-03-04 16:31:25.000000000","message":"Make sense for me.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"fce7d062b22f42764f28d0adc96608c82e040f75","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # NOTE(flwang): KPI of local Marconi server process. Though they are"},{"line_number":74,"context_line":"        # placed at here, it\u0027s reasonable from the logic perspective of"},{"line_number":75,"context_line":"        # Marconi architecture."},{"line_number":76,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":77,"context_line":"        overall_health[\u0027cpu_util\u0027] \u003d p.get_cpu_percent()"},{"line_number":78,"context_line":"        overall_health[\u0027memory_util\u0027] \u003d p.get_memory_percent()"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a1371a2_4a11d7ab","line":76,"updated":"2014-04-28 21:05:24.000000000","message":"Given that production deployments are likely to use a worker pool of processes (using Gunicorn or uWSGI, for example), I think it would work better to get the overall system metrics instead of those for the current process.\n\nI was looking at the psutil docs and found the following functions which look like they would do the trick:\n\n    \u003e\u003e\u003e psutil.cpu_percent(1.0)\n    4.5\n    \u003e\u003e\u003e psutil.virtual_memory().percent\n    63.8","commit_id":"66233d47d8b5a3a1703143feb9124ce793f0955a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"b2a2d846ed67a82e4cf4cc15a41d4550660d6aac","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        # NOTE(flwang): KPI of local Marconi server process. Though they are"},{"line_number":74,"context_line":"        # placed at here, it\u0027s reasonable from the logic perspective of"},{"line_number":75,"context_line":"        # Marconi architecture."},{"line_number":76,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":77,"context_line":"        overall_health[\u0027cpu_util\u0027] \u003d p.get_cpu_percent()"},{"line_number":78,"context_line":"        overall_health[\u0027memory_util\u0027] \u003d p.get_memory_percent()"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad9bd40_6c3979a3","line":76,"in_reply_to":"3a1371a2_4a11d7ab","updated":"2014-05-07 07:23:05.000000000","message":"It\u0027s a good point. Thanks for poking me from the operations view.","commit_id":"66233d47d8b5a3a1703143feb9124ce793f0955a"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"fce7d062b22f42764f28d0adc96608c82e040f75","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # placed at here, it\u0027s reasonable from the logic perspective of"},{"line_number":75,"context_line":"        # Marconi architecture."},{"line_number":76,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":77,"context_line":"        overall_health[\u0027cpu_util\u0027] \u003d p.get_cpu_percent()"},{"line_number":78,"context_line":"        overall_health[\u0027memory_util\u0027] \u003d p.get_memory_percent()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # NOTE(flwang): KPI extracted from different storage backend,"}],"source_content_type":"text/x-python","patch_set":6,"id":"facab960_820e3a33","line":77,"updated":"2014-04-28 21:05:24.000000000","message":"What do you think about dropping this down into a subdocument? For example:\n\n    \"utilization\": {\n        \"cpu\": 24.6,\n        \"memory\": 68.2\n    }\n\nThat being said, a better metric than CPU percentage is load average. (See also: http://www.linuxjournal.com/article/9001)\n\nThis could be done with the procfs module, but that won\u0027t work for developers running on MacBooks. For that, you need to shell out, i.e.: \"sysctl vm.loadavg\".\n\nHow about using load average instead of cpu percent? That would yield a report like this:\n\n    {\n        \"memory_utilization\": 68.2,\n        \"cpu_load\": [3.16, 2.10, 1.84],\n        \"backend_health\" : {\n            ...\n        }\n    }","commit_id":"66233d47d8b5a3a1703143feb9124ce793f0955a"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"906f30c5c53c9d7555bd028aeac02f2527b6ee08","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # placed at here, it\u0027s reasonable from the logic perspective of"},{"line_number":75,"context_line":"        # Marconi architecture."},{"line_number":76,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":77,"context_line":"        overall_health[\u0027cpu_util\u0027] \u003d p.get_cpu_percent()"},{"line_number":78,"context_line":"        overall_health[\u0027memory_util\u0027] \u003d p.get_memory_percent()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # NOTE(flwang): KPI extracted from different storage backend,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_29e146fe","line":77,"in_reply_to":"9ad9bd40_ecfae9bb","updated":"2014-05-15 16:20:09.000000000","message":"Got some feedback from system admins / operators at the summit. They want to just use their own tools (nagios, sensu, etc.) for monitoring system metrics like CPU. They would like us to focus instead on things like the following:\n\n1. Total number of messages stored for all queues in a given backend partition.\n\n2. average transactions/sec or per-request latency over the last few minutes (give numbers for each window: 30 seconds, 1 minute, and 5 minutes).\n\n3. Verify full functionality (perform a test that excercises all endpoints: post a message, list it, claim it, delete it). I guess operators do this in their own monitoring tools but they would like if we could do it for them instead.\n\nWe should discuss further on IRC / mailing list...","commit_id":"66233d47d8b5a3a1703143feb9124ce793f0955a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"b2a2d846ed67a82e4cf4cc15a41d4550660d6aac","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # placed at here, it\u0027s reasonable from the logic perspective of"},{"line_number":75,"context_line":"        # Marconi architecture."},{"line_number":76,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":77,"context_line":"        overall_health[\u0027cpu_util\u0027] \u003d p.get_cpu_percent()"},{"line_number":78,"context_line":"        overall_health[\u0027memory_util\u0027] \u003d p.get_memory_percent()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # NOTE(flwang): KPI extracted from different storage backend,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad9bd40_ecfae9bb","line":77,"in_reply_to":"facab960_820e3a33","updated":"2014-05-07 07:23:05.000000000","message":"It makes sense for me.","commit_id":"66233d47d8b5a3a1703143feb9124ce793f0955a"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # _health() will be implemented by different storage driver."},{"line_number":75,"context_line":"        backend_health \u003d self._health()"},{"line_number":76,"context_line":"        if backend_health:"},{"line_number":77,"context_line":"            overall_health.update(backend_health)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return overall_health"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_cc184121","line":77,"updated":"2014-07-16 18:15:34.000000000","message":"Q. Why not just return backend_health directly? Are you planning on adding other data to overall_health?","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        # _health() will be implemented by different storage driver."},{"line_number":75,"context_line":"        backend_health \u003d self._health()"},{"line_number":76,"context_line":"        if backend_health:"},{"line_number":77,"context_line":"            overall_health.update(backend_health)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return overall_health"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_a09ea205","line":77,"in_reply_to":"baada198_cc184121","updated":"2014-07-17 00:06:08.000000000","message":"Yes, based on my initial design, I was planning to add some process/worker KPI at here. And with this way, the overall health can be extended gracefully.","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        FAIL \u003d \u0027FAIL\u0027"},{"line_number":100,"context_line":"        msg \u003d lambda s: {\u0027ttl\u0027: 600, \u0027body\u0027: {\u0027event\u0027: \u0027progress_%s\u0027 % s}}"},{"line_number":101,"context_line":"        messages \u003d [msg(i) for i in range(100)]"},{"line_number":102,"context_line":"        metadata \u003d {\u0027ttl\u0027: 60, \u0027grace\u0027: 300}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # create queue"},{"line_number":105,"context_line":"        created_queue \u003d self.queue_controller.create(queue, project)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_4c98b16a","line":102,"updated":"2014-07-16 18:15:34.000000000","message":"NIT: \"metadata\" is pretty generic. Perhaps rename to hint this is for creating claims?","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        FAIL \u003d \u0027FAIL\u0027"},{"line_number":100,"context_line":"        msg \u003d lambda s: {\u0027ttl\u0027: 600, \u0027body\u0027: {\u0027event\u0027: \u0027progress_%s\u0027 % s}}"},{"line_number":101,"context_line":"        messages \u003d [msg(i) for i in range(100)]"},{"line_number":102,"context_line":"        metadata \u003d {\u0027ttl\u0027: 60, \u0027grace\u0027: 300}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        # create queue"},{"line_number":105,"context_line":"        created_queue \u003d self.queue_controller.create(queue, project)"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_a0aa2283","line":102,"in_reply_to":"baada198_4c98b16a","updated":"2014-07-17 00:06:08.000000000","message":"Done","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        if created_queue:"},{"line_number":108,"context_line":"            op_status[\u0027create_queue\u0027] \u003d OK"},{"line_number":109,"context_line":"            # post messages"},{"line_number":110,"context_line":"            msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":111,"context_line":"                                                   client, project)"},{"line_number":112,"context_line":"            if msg_ids:"},{"line_number":113,"context_line":"                op_status[\u0027post_messages\u0027] \u003d OK"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_35a49c07","line":110,"updated":"2014-07-16 18:15:34.000000000","message":"BUG: Wrap in try..except to handle backend socket error or whatever.","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        if created_queue:"},{"line_number":108,"context_line":"            op_status[\u0027create_queue\u0027] \u003d OK"},{"line_number":109,"context_line":"            # post messages"},{"line_number":110,"context_line":"            msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":111,"context_line":"                                                   client, project)"},{"line_number":112,"context_line":"            if msg_ids:"},{"line_number":113,"context_line":"                op_status[\u0027post_messages\u0027] \u003d OK"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_807b5ef3","line":110,"in_reply_to":"baada198_35a49c07","updated":"2014-07-17 00:06:08.000000000","message":"Done","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                                   client, project)"},{"line_number":112,"context_line":"            if msg_ids:"},{"line_number":113,"context_line":"                op_status[\u0027post_messages\u0027] \u003d OK"},{"line_number":114,"context_line":"                c_id, c_msgs \u003d self.claim_controller.create(queue, metadata,"},{"line_number":115,"context_line":"                                                            project)"},{"line_number":116,"context_line":"                # claim messages"},{"line_number":117,"context_line":"                if c_id and c_msgs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_753ff4b5","line":114,"updated":"2014-07-16 18:15:34.000000000","message":"BUG: Wrap in try..except to handle backend socket error or whatever.\n\nSTYLE/NIT: It wouldn\u0027t hurt to spell out claim to aid in readability (e.g., \"claim_id\", \"claim_msgs\")","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                                   client, project)"},{"line_number":112,"context_line":"            if msg_ids:"},{"line_number":113,"context_line":"                op_status[\u0027post_messages\u0027] \u003d OK"},{"line_number":114,"context_line":"                c_id, c_msgs \u003d self.claim_controller.create(queue, metadata,"},{"line_number":115,"context_line":"                                                            project)"},{"line_number":116,"context_line":"                # claim messages"},{"line_number":117,"context_line":"                if c_id and c_msgs:"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_40d5c6e3","line":114,"in_reply_to":"baada198_753ff4b5","updated":"2014-07-17 00:06:08.000000000","message":"TBH, all you suggested was my initial implement :) but then I rename those variables to make it more clear. Because I\u0027m  not really like this 70+ lines method :-)","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                                           project,"},{"line_number":135,"context_line":"                                                           claim\u003dc_id)"},{"line_number":136,"context_line":"                        op_status[\u0027delete_messages\u0027] \u003d OK"},{"line_number":137,"context_line":"                    except Exception:"},{"line_number":138,"context_line":"                        op_status[\u0027delete_messages\u0027] \u003d FAIL"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"                # delete claim"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_95bf28fc","line":137,"updated":"2014-07-16 18:15:34.000000000","message":"IMO: What do you think about logging the exception with a UUID, and then including that UUID in op_status somehow? If an operator sees a failure, that would let them go look in the logs to figure out what happened. I think this is better than returning exception details in the request, since that could lead to a security vulnerability.","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                                           project,"},{"line_number":135,"context_line":"                                                           claim\u003dc_id)"},{"line_number":136,"context_line":"                        op_status[\u0027delete_messages\u0027] \u003d OK"},{"line_number":137,"context_line":"                    except Exception:"},{"line_number":138,"context_line":"                        op_status[\u0027delete_messages\u0027] \u003d FAIL"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"                # delete claim"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_60780af9","line":137,"in_reply_to":"baada198_95bf28fc","updated":"2014-07-17 00:06:08.000000000","message":"Yep, that\u0027s a good idea. And I\u0027m going to add the time for successful action to show a basic performance outlook for the cloud admin.","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"73013506e0d8d6a38f56b6168802d84657f60ec6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        project \u003d \u0027fake_project\u0027"},{"line_number":97,"context_line":"        queue \u003d \u0027fake_queue\u0027"},{"line_number":98,"context_line":"        client \u003d \u0027fake_client\u0027"},{"line_number":99,"context_line":"        OK \u003d \u0027OK(in {0}s)\u0027"},{"line_number":100,"context_line":"        FAIL \u003d \u0027FAIL(refer: {0})\u0027"},{"line_number":101,"context_line":"        msg \u003d lambda s: {\u0027ttl\u0027: 600, \u0027body\u0027: {\u0027event\u0027: \u0027progress_%s\u0027 % s}}"},{"line_number":102,"context_line":"        messages \u003d [msg(i) for i in range(100)]"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_ee091996","line":99,"updated":"2014-07-18 18:14:39.000000000","message":"DSQ: It may be easier for monitoring tools to parse fully structured response data, e.g., to ship to graphite, if this is all JSONified. What do you think? For example:\n\n    \"post_messages\": {\"succeeded\": true, \"seconds\": 0.011513}","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7eb3c8a883580a5592fe11aed23995dfff0f08c3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        project \u003d \u0027fake_project\u0027"},{"line_number":97,"context_line":"        queue \u003d \u0027fake_queue\u0027"},{"line_number":98,"context_line":"        client \u003d \u0027fake_client\u0027"},{"line_number":99,"context_line":"        OK \u003d \u0027OK(in {0}s)\u0027"},{"line_number":100,"context_line":"        FAIL \u003d \u0027FAIL(refer: {0})\u0027"},{"line_number":101,"context_line":"        msg \u003d lambda s: {\u0027ttl\u0027: 600, \u0027body\u0027: {\u0027event\u0027: \u0027progress_%s\u0027 % s}}"},{"line_number":102,"context_line":"        messages \u003d [msg(i) for i in range(100)]"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_906896f6","line":99,"in_reply_to":"baada198_ee091996","updated":"2014-07-20 22:30:34.000000000","message":"Make sense for me.","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"73013506e0d8d6a38f56b6168802d84657f60ec6","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # NOTE (flwang): Using time.clock() instead of timeit, because timeit"},{"line_number":106,"context_line":"        # will make the method calling complicated."},{"line_number":107,"context_line":"        start \u003d time.clock()"},{"line_number":108,"context_line":"        # create queue"},{"line_number":109,"context_line":"        created_queue \u003d self.queue_controller.create(queue, project)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_89725748","line":107,"updated":"2014-07-18 18:14:39.000000000","message":"DSQ: On Linux, time.clock() measures CPU time. However, I think wall time is more useful when monitoring a production system. In fact, timeit actually uses time.time() except on Windows. \n\nSee also: http://www.pythoncentral.io/measure-time-in-python-time-time-vs-time-clock/","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7eb3c8a883580a5592fe11aed23995dfff0f08c3","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # NOTE (flwang): Using time.clock() instead of timeit, because timeit"},{"line_number":106,"context_line":"        # will make the method calling complicated."},{"line_number":107,"context_line":"        start \u003d time.clock()"},{"line_number":108,"context_line":"        # create queue"},{"line_number":109,"context_line":"        created_queue \u003d self.queue_controller.create(queue, project)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_b0691afa","line":107,"in_reply_to":"baada198_89725748","updated":"2014-07-20 22:30:34.000000000","message":"Reasonable.","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"709ee26848fcbc2506710f772e9f4372e724c5a2","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                start \u003d time.clock()"},{"line_number":116,"context_line":"                msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":117,"context_line":"                                                       client, project)"},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                op_status[\u0027post_messages\u0027] \u003d FAIL.format(queue)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            if msg_ids:"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_0de4ccaa","line":118,"updated":"2014-07-17 13:36:42.000000000","message":"Do we want to log the exception in the FAIL?","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7eb3c8a883580a5592fe11aed23995dfff0f08c3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                start \u003d time.clock()"},{"line_number":116,"context_line":"                msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":117,"context_line":"                                                       client, project)"},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                op_status[\u0027post_messages\u0027] \u003d FAIL.format(queue)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            if msg_ids:"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_b0403a60","line":118,"in_reply_to":"baada198_090f273a","updated":"2014-07-20 22:30:34.000000000","message":"I can see your point. Just trying for find a good approach to do that.","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"75faec38c528be0cac3e34ec78d673ca2694d141","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                start \u003d time.clock()"},{"line_number":116,"context_line":"                msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":117,"context_line":"                                                       client, project)"},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                op_status[\u0027post_messages\u0027] \u003d FAIL.format(queue)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            if msg_ids:"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_d149788f","line":118,"in_reply_to":"baada198_0de4ccaa","updated":"2014-07-17 21:32:29.000000000","message":"I would say no. Because:\n\n1. It may leak security vulnerability. Though I don\u0027t really concern this, given this is an admin operation.\n\n2. I don\u0027t want to print all the trace to mess the format. I think it\u0027s enough to give some key info to help the admin identify the problem.","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"73013506e0d8d6a38f56b6168802d84657f60ec6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                start \u003d time.clock()"},{"line_number":116,"context_line":"                msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":117,"context_line":"                                                       client, project)"},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                op_status[\u0027post_messages\u0027] \u003d FAIL.format(queue)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            if msg_ids:"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_090f273a","line":118,"in_reply_to":"baada198_48c76445","updated":"2014-07-18 18:14:39.000000000","message":"An alternative would be to log the exception along with a UUID, and then put that same UUID in the FAIL info. IMO, it would also be helpful to see how long it took for the request to come back (in case things are stalling for a long time and maybe timing out, it would be good to quantify that to aid in diagnostics/alerting). \n\nFor example:\n\n   \"delete_claim\": { \n         \"succeeded\": false, \n         \"seconds\": 4.2, \n         \"ref\": \"9A420354-0092-47D3-A06B-AAA5B121991B\"\n   }","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":8092,"name":"Sriram Madapusi Vasudevan","email":"sriram1991mv@gmail.com","username":"thesriram"},"change_message_id":"227e328881d71ca3ae075f7cba5c14d1454f2769","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                start \u003d time.clock()"},{"line_number":116,"context_line":"                msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":117,"context_line":"                                                       client, project)"},{"line_number":118,"context_line":"            except Exception:"},{"line_number":119,"context_line":"                op_status[\u0027post_messages\u0027] \u003d FAIL.format(queue)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"            if msg_ids:"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_48c76445","line":118,"in_reply_to":"baada198_d149788f","updated":"2014-07-18 12:51:17.000000000","message":"Fair Enough.","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"512596b74a287693758a926423c66fd4cba0338b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        start \u003d time.time()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def _handle_status(operation, succeeded, start_time, ex\u003dNone):"},{"line_number":109,"context_line":"            ref \u003d str(uuid.uuid4()) if not succeeded else \u0027\u0027"},{"line_number":110,"context_line":"            if ex:"},{"line_number":111,"context_line":"                LOG.exception(ex, extra\u003d{\u0027instance_uuid\u0027: ref})"},{"line_number":112,"context_line":"            status \u003d status_template(succeeded, time.time() - start_time, ref)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_e06e36c7","line":109,"updated":"2014-07-22 00:49:53.000000000","message":"IMO: May be a little cleaner to set to None (which will become null in JSON), or the most idiomatic thing to do would be to simply omit the field altogether. I don\u0027t think this should block the merge, but something to consider.","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ded46ba38680b6d2395cedccb12cbc09299b80f5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        start \u003d time.time()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        def _handle_status(operation, succeeded, start_time, ex\u003dNone):"},{"line_number":109,"context_line":"            ref \u003d str(uuid.uuid4()) if not succeeded else \u0027\u0027"},{"line_number":110,"context_line":"            if ex:"},{"line_number":111,"context_line":"                LOG.exception(ex, extra\u003d{\u0027instance_uuid\u0027: ref})"},{"line_number":112,"context_line":"            status \u003d status_template(succeeded, time.time() - start_time, ref)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_ee905d44","line":109,"in_reply_to":"baada198_e06e36c7","updated":"2014-07-25 06:55:41.000000000","message":"Done","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"512596b74a287693758a926423c66fd4cba0338b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            created_queue \u003d self.queue_controller.create(queue, project)"},{"line_number":119,"context_line":"        except Exception as e:"},{"line_number":120,"context_line":"            _handle_status(\u0027create_queue\u0027, False, start, e)"},{"line_number":121,"context_line":"        if created_queue:"},{"line_number":122,"context_line":"            _handle_status(\u0027create_queue\u0027, True, start)"},{"line_number":123,"context_line":"            # post messages"},{"line_number":124,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_40b6023f","line":121,"updated":"2014-07-22 00:49:53.000000000","message":"STYLE: Precede with a blank line to visually group the try...except above","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ded46ba38680b6d2395cedccb12cbc09299b80f5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            created_queue \u003d self.queue_controller.create(queue, project)"},{"line_number":119,"context_line":"        except Exception as e:"},{"line_number":120,"context_line":"            _handle_status(\u0027create_queue\u0027, False, start, e)"},{"line_number":121,"context_line":"        if created_queue:"},{"line_number":122,"context_line":"            _handle_status(\u0027create_queue\u0027, True, start)"},{"line_number":123,"context_line":"            # post messages"},{"line_number":124,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_0e983169","line":121,"in_reply_to":"baada198_40b6023f","updated":"2014-07-25 06:55:41.000000000","message":"Done","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                start \u003d time.time()"},{"line_number":127,"context_line":"                msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":128,"context_line":"                                                       client, project)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                _handle_status(\u0027post_messages\u0027, False, start, e)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            if msg_ids:"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_63ae0231","line":129,"updated":"2014-08-01 09:25:33.000000000","message":"Are these to catch `QueueDoesNotExist` or similar errors? Do we need to log these exceptions?","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                start \u003d time.time()"},{"line_number":127,"context_line":"                msg_ids \u003d self.message_controller.post(queue, messages,"},{"line_number":128,"context_line":"                                                       client, project)"},{"line_number":129,"context_line":"            except Exception as e:"},{"line_number":130,"context_line":"                _handle_status(\u0027post_messages\u0027, False, start, e)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"            if msg_ids:"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_c43858d6","line":129,"in_reply_to":"baada198_63ae0231","updated":"2014-08-19 06:18:02.000000000","message":"I think so. And all the exceptions will be logged by _handle_status().","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                _handle_status(\u0027post_messages\u0027, True, start)"},{"line_number":134,"context_line":"                claim_id, claim_msgs \u003d None, None"},{"line_number":135,"context_line":"                try:"},{"line_number":136,"context_line":"                    start \u003d time.time()"},{"line_number":137,"context_line":"                    claim_id, claim_msgs \u003d (self.claim_controller.create(queue,"},{"line_number":138,"context_line":"                                            claim_metadata, project))"},{"line_number":139,"context_line":"                    _handle_status(\u0027claim_messages\u0027, True, start)"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_ee77599d","line":136,"updated":"2014-08-01 09:25:33.000000000","message":"Could these try/except be put in a single function? For example, we could make `_handle_status` something like:\n\n  _handle_status(op, callable):\n    try:\n      start \u003d time.time()\n      callable()\n      succeeded \u003d True\n    except ...:\n        ...\n      succeeded \u003d False\n\n    ref \u003d str(uuid.uuid4()) if not succeeded else None\n    ...\n\nand then call it like:\n\n  par \u003d functools.partial(self.queue_controller.create, ...)\n  _handle_status(\u0027create_queue\u0027, par)","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                _handle_status(\u0027post_messages\u0027, True, start)"},{"line_number":134,"context_line":"                claim_id, claim_msgs \u003d None, None"},{"line_number":135,"context_line":"                try:"},{"line_number":136,"context_line":"                    start \u003d time.time()"},{"line_number":137,"context_line":"                    claim_id, claim_msgs \u003d (self.claim_controller.create(queue,"},{"line_number":138,"context_line":"                                            claim_metadata, project))"},{"line_number":139,"context_line":"                    _handle_status(\u0027claim_messages\u0027, True, start)"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_444c4876","line":136,"in_reply_to":"baada198_ee77599d","updated":"2014-08-19 06:18:02.000000000","message":"It\u0027s a good idea.","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"}],"marconi/queues/storage/mongodb/driver.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"917fb9b24941b1b29fe98adfc0a72a33996eefbe","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def health(self):"},{"line_number":71,"context_line":"        KPI \u003d {}"},{"line_number":72,"context_line":"        # CPU utilization of Marconi server"},{"line_number":73,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":74,"context_line":"        KPI[\u0027cpu_utilization\u0027] \u003d p.get_cpu_percent()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Number of active shards"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fbxg%3D","line":73,"updated":"2014-02-26 17:01:21.000000000","message":"Can we factor out this cpu_utilization logic per my comment in base.py and add memory usage?","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38fac942d7321ff631d2f4da79473a9579cecd7a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def health(self):"},{"line_number":71,"context_line":"        KPI \u003d {}"},{"line_number":72,"context_line":"        # CPU utilization of Marconi server"},{"line_number":73,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":74,"context_line":"        KPI[\u0027cpu_utilization\u0027] \u003d p.get_cpu_percent()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Number of active shards"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FcCk%3D","line":73,"updated":"2014-02-26 16:40:07.000000000","message":"I\u0027d prefer using https://github.com/openstack/oslo-incubator/blob/master/openstack/common/processutils.py instead of psutil.","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33c9d82bd7e00d9c42b863c400da9fa7175f37fe","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def health(self):"},{"line_number":71,"context_line":"        KPI \u003d {}"},{"line_number":72,"context_line":"        # CPU utilization of Marconi server"},{"line_number":73,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":74,"context_line":"        KPI[\u0027cpu_utilization\u0027] \u003d p.get_cpu_percent()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Number of active shards"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F3vE%3D","line":73,"in_reply_to":"AAAAU3%2F%2Fbxg%3D","updated":"2014-02-27 17:21:57.000000000","message":"Done","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33c9d82bd7e00d9c42b863c400da9fa7175f37fe","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def health(self):"},{"line_number":71,"context_line":"        KPI \u003d {}"},{"line_number":72,"context_line":"        # CPU utilization of Marconi server"},{"line_number":73,"context_line":"        p \u003d psutil.Process(os.getpid())"},{"line_number":74,"context_line":"        KPI[\u0027cpu_utilization\u0027] \u003d p.get_cpu_percent()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Number of active shards"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F3to%3D","line":73,"in_reply_to":"AAAAU3%2F%2FcCk%3D","updated":"2014-02-27 17:21:57.000000000","message":"With psutil, we can easy to get the cpu util and memory util. After reviewed the code of processutil, seems it can\u0027t do that easily. Please correct me if I missed anything.","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except pymongo.errors.PyMongoError:"},{"line_number":65,"context_line":"            return False"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _health(self):"},{"line_number":68,"context_line":"        KPI \u003d {}"},{"line_number":69,"context_line":"        # Number of active shards"},{"line_number":70,"context_line":"        db_name \u003d self.mongodb_conf.database"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuU0%3D","line":67,"updated":"2014-03-04 14:36:31.000000000","message":"What about also getting info from mongodb\u0027s server status? There are some interesting metrics and statuses there.\n\nhttp://docs.mongodb.org/manual/reference/server-status/","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"561e60d12fc7b887501ffe2374a6d4da272debae","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except pymongo.errors.PyMongoError:"},{"line_number":65,"context_line":"            return False"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _health(self):"},{"line_number":68,"context_line":"        KPI \u003d {}"},{"line_number":69,"context_line":"        # Number of active shards"},{"line_number":70,"context_line":"        db_name \u003d self.mongodb_conf.database"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Ftg0%3D","line":67,"in_reply_to":"AAAAVn%2F%2FuU0%3D","updated":"2014-03-04 16:31:25.000000000","message":"Cool, so can I say that we can return different information from different backends? Or we need to define a common KPI name like \u0027server_status\u0027 and make its value is a dict/json.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        KPI \u003d {}"},{"line_number":69,"context_line":"        # Number of active shards"},{"line_number":70,"context_line":"        db_name \u003d self.mongodb_conf.database"},{"line_number":71,"context_line":"        shards_count \u003d self.connection[db_name].shards.count()"},{"line_number":72,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":73,"context_line":"        return KPI"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuVM%3D","line":71,"updated":"2014-03-04 14:36:31.000000000","message":"Some of these actions require you to have admin access to the database. Did you try this with non admin mongodb users?","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"561e60d12fc7b887501ffe2374a6d4da272debae","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        KPI \u003d {}"},{"line_number":69,"context_line":"        # Number of active shards"},{"line_number":70,"context_line":"        db_name \u003d self.mongodb_conf.database"},{"line_number":71,"context_line":"        shards_count \u003d self.connection[db_name].shards.count()"},{"line_number":72,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":73,"context_line":"        return KPI"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Ftgo%3D","line":71,"in_reply_to":"AAAAVn%2F%2FuVM%3D","updated":"2014-03-04 16:31:25.000000000","message":"Good point","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Number of active shards"},{"line_number":70,"context_line":"        db_name \u003d self.mongodb_conf.database"},{"line_number":71,"context_line":"        shards_count \u003d self.connection[db_name].shards.count()"},{"line_number":72,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":73,"context_line":"        return KPI"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @decorators.lazy_property(write\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuUY%3D","line":72,"updated":"2014-03-04 14:36:31.000000000","message":"This is assuming mongodb servers are sharded. I\u0027d like to avoid doing that, instead we could rely on what mongodb outputs as server status.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"8b137e0abacf6923464015b3c74e4fb514892f89","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Number of active shards"},{"line_number":70,"context_line":"        db_name \u003d self.mongodb_conf.database"},{"line_number":71,"context_line":"        shards_count \u003d self.connection[db_name].shards.count()"},{"line_number":72,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":73,"context_line":"        return KPI"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @decorators.lazy_property(write\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FrPQ%3D","line":72,"in_reply_to":"AAAAVn%2F%2Fr28%3D","updated":"2014-03-04 18:20:38.000000000","message":"After discussed with kgriffs, will leverage the is_alive to indicate if the backend storage is reachable. And will add the active shards in the future.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"4a2aed274e64bafc60e40dba5716842c13de3d93","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Number of active shards"},{"line_number":70,"context_line":"        db_name \u003d self.mongodb_conf.database"},{"line_number":71,"context_line":"        shards_count \u003d self.connection[db_name].shards.count()"},{"line_number":72,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":73,"context_line":"        return KPI"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @decorators.lazy_property(write\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fr28%3D","line":72,"in_reply_to":"AAAAVn%2F%2Ftfg%3D","updated":"2014-03-04 17:31:58.000000000","message":"Fei,\n\nWhat Flavio was saying is that Marconi isn\u0027t always run in sharded mode, and sharding information won\u0027t be present when run in non-sharded mode.\n\nI think you\u0027ll need to check the configuration object and make \u0027active_shards\u0027 a visible KPI iff sharding is enabled.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"561e60d12fc7b887501ffe2374a6d4da272debae","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # Number of active shards"},{"line_number":70,"context_line":"        db_name \u003d self.mongodb_conf.database"},{"line_number":71,"context_line":"        shards_count \u003d self.connection[db_name].shards.count()"},{"line_number":72,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":73,"context_line":"        return KPI"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @decorators.lazy_property(write\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Ftfg%3D","line":72,"in_reply_to":"AAAAVn%2F%2FuUY%3D","updated":"2014-03-04 16:31:25.000000000","message":"Did you mean don\u0027t return the active shards number at the 1st stage? And leverage the output of mongo server status, is it?","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"c69bb7289d558f4a4785507c21aa6322acd0adbe","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            return False"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {\u0027free\u0027: 0,"},{"line_number":95,"context_line":"                                 \u0027claimed\u0027: 0,"},{"line_number":96,"context_line":"                                 \u0027total\u0027: 0}"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_4cb746d8","line":93,"updated":"2014-07-14 08:18:26.000000000","message":"storage_reachable  ?","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"67ea0981412a67377916ed2a810df34b9ddd0a5b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            return False"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {\u0027free\u0027: 0,"},{"line_number":95,"context_line":"                                 \u0027claimed\u0027: 0,"},{"line_number":96,"context_line":"                                 \u0027total\u0027: 0}"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_62231505","line":93,"in_reply_to":"baada198_4cb746d8","updated":"2014-07-14 21:19:10.000000000","message":"It\u0027s implement in base class.","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"0c3278edd9b6338f4c64697965bff8197dc04ae2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            return False"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {\u0027free\u0027: 0,"},{"line_number":95,"context_line":"                                 \u0027claimed\u0027: 0,"},{"line_number":96,"context_line":"                                 \u0027total\u0027: 0}"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_1209c030","line":93,"in_reply_to":"baada198_62231505","updated":"2014-07-15 02:00:25.000000000","message":"I saw it was added in the sqlalchemy driver but not here.\nand I thought base class just need to call the _health \nanyway, I am ok with that it\u0027s WIP. Thanks","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"c69bb7289d558f4a4785507c21aa6322acd0adbe","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {\u0027free\u0027: 0,"},{"line_number":95,"context_line":"                                 \u0027claimed\u0027: 0,"},{"line_number":96,"context_line":"                                 \u0027total\u0027: 0}"},{"line_number":97,"context_line":"        KPI[\u0027operation_status\u0027] \u003d {\u0027create_pool\u0027: None,"},{"line_number":98,"context_line":"                                   \u0027post_messages\u0027: None,"},{"line_number":99,"context_line":"                                   \u0027claim_messages\u0027: None}"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_ecc1fa80","line":97,"updated":"2014-07-14 08:18:26.000000000","message":"is the \u0027create_pool\u0027 for pools that had been created? \nif so then maybe \u0027pools_created\u0027 seems to be better and the same for \u0027post_messages\u0027, \u0027claim_messages\u0027","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"67ea0981412a67377916ed2a810df34b9ddd0a5b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {\u0027free\u0027: 0,"},{"line_number":95,"context_line":"                                 \u0027claimed\u0027: 0,"},{"line_number":96,"context_line":"                                 \u0027total\u0027: 0}"},{"line_number":97,"context_line":"        KPI[\u0027operation_status\u0027] \u003d {\u0027create_pool\u0027: None,"},{"line_number":98,"context_line":"                                   \u0027post_messages\u0027: None,"},{"line_number":99,"context_line":"                                   \u0027claim_messages\u0027: None}"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_028259c7","line":97,"in_reply_to":"baada198_ecc1fa80","updated":"2014-07-14 21:19:10.000000000","message":"This patch is working in progress as I marked. I need to discuss the operation_status KPI with the others.","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"c69bb7289d558f4a4785507c21aa6322acd0adbe","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            msg_count_t \u003d msg_col.find().count()"},{"line_number":106,"context_line":"            KPI[\u0027message_amount\u0027][\u0027total\u0027] +\u003d msg_count_t"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        KPI[\u0027message_amount\u0027][\u0027free\u0027] \u003d (KPI[\u0027message_amount\u0027][\u0027total\u0027] -"},{"line_number":109,"context_line":"                                         KPI[\u0027message_amount\u0027][\u0027claimed\u0027])"},{"line_number":110,"context_line":"        return KPI"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_6c3dea8e","line":108,"updated":"2014-07-14 08:18:26.000000000","message":"will the expired messages be counted in?","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"67ea0981412a67377916ed2a810df34b9ddd0a5b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            msg_count_t \u003d msg_col.find().count()"},{"line_number":106,"context_line":"            KPI[\u0027message_amount\u0027][\u0027total\u0027] +\u003d msg_count_t"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        KPI[\u0027message_amount\u0027][\u0027free\u0027] \u003d (KPI[\u0027message_amount\u0027][\u0027total\u0027] -"},{"line_number":109,"context_line":"                                         KPI[\u0027message_amount\u0027][\u0027claimed\u0027])"},{"line_number":110,"context_line":"        return KPI"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_225cbd7c","line":108,"in_reply_to":"baada198_6c3dea8e","updated":"2014-07-14 21:19:10.000000000","message":"Expired messages will be removed automatically, am I missing anything?","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        except pymongo.errors.PyMongoError:"},{"line_number":90,"context_line":"            return False"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_d501a007","line":92,"updated":"2014-07-16 18:15:34.000000000","message":"IMO: What do you think about renaming to this function to get_kpis or something similar?","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        except pymongo.errors.PyMongoError:"},{"line_number":90,"context_line":"            return False"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_c06f16fb","line":92,"in_reply_to":"baada198_d501a007","updated":"2014-07-17 00:06:08.000000000","message":"How about _get_health_status? Because KPI is not a really well-known acronym, and KPI is most like focusing on the performance. But at here, we really care about if it\u0027s alive and good. Thoughts?","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"},{"line_number":96,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {\u0027free\u0027: 0,"},{"line_number":97,"context_line":"                                 \u0027claimed\u0027: 0,"},{"line_number":98,"context_line":"                                 \u0027total\u0027: 0}"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_a035ccdc","line":96,"updated":"2014-07-16 18:15:34.000000000","message":"IMO: Perhaps rename to \"message_volume\" ? For some reason \"amount\" doesn\u0027t sound quite right to me.","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"},{"line_number":96,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {\u0027free\u0027: 0,"},{"line_number":97,"context_line":"                                 \u0027claimed\u0027: 0,"},{"line_number":98,"context_line":"                                 \u0027total\u0027: 0}"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_a025c25d","line":96,"in_reply_to":"baada198_a035ccdc","updated":"2014-07-17 00:06:08.000000000","message":"Done","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 \u0027total\u0027: 0}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        for msg_col in [db.messages for db in self.message_databases]:"},{"line_number":101,"context_line":"            msg_count_c \u003d msg_col.find({\u0027c.id\u0027: {\u0027$ne\u0027: None}}).count()"},{"line_number":102,"context_line":"            KPI[\u0027message_amount\u0027][\u0027claimed\u0027] +\u003d msg_count_c"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            msg_count_t \u003d msg_col.find().count()"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_20ed3c26","line":101,"updated":"2014-07-16 18:15:34.000000000","message":"STYLE: avoid single-character abbreviations\n\nIMO: I think something like \"num_claimed\" would be more readable than \"msg_count_c\". I.e., msg_count_c would be read as \"message_count_claimed\", which sounds a bit awkward to me...","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                                 \u0027total\u0027: 0}"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        for msg_col in [db.messages for db in self.message_databases]:"},{"line_number":101,"context_line":"            msg_count_c \u003d msg_col.find({\u0027c.id\u0027: {\u0027$ne\u0027: None}}).count()"},{"line_number":102,"context_line":"            KPI[\u0027message_amount\u0027][\u0027claimed\u0027] +\u003d msg_count_c"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            msg_count_t \u003d msg_col.find().count()"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_60364ab6","line":101,"in_reply_to":"baada198_20ed3c26","updated":"2014-07-17 00:06:08.000000000","message":"Done","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        for msg_col in [db.messages for db in self.message_databases]:"},{"line_number":101,"context_line":"            msg_count_c \u003d msg_col.find({\u0027c.id\u0027: {\u0027$ne\u0027: None}}).count()"},{"line_number":102,"context_line":"            KPI[\u0027message_amount\u0027][\u0027claimed\u0027] +\u003d msg_count_c"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            msg_count_t \u003d msg_col.find().count()"},{"line_number":105,"context_line":"            KPI[\u0027message_amount\u0027][\u0027total\u0027] +\u003d msg_count_t"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_80f6088f","line":102,"updated":"2014-07-16 18:15:34.000000000","message":"DRY: Consider factoring out lookups on \u0027message_amount\u0027. One way (but by no means the only way) to do this would be to define a dict and then assign it when it is complete:\n\n    message_amount \u003d {\u0027free\u0027: 0, \u0027claimed\u0027: 0, \u0027total\u0027: 0}\n\n    ...\n\n\n    KPI[\u0027message_amount\u0027] \u003d message_amount","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        for msg_col in [db.messages for db in self.message_databases]:"},{"line_number":101,"context_line":"            msg_count_c \u003d msg_col.find({\u0027c.id\u0027: {\u0027$ne\u0027: None}}).count()"},{"line_number":102,"context_line":"            KPI[\u0027message_amount\u0027][\u0027claimed\u0027] +\u003d msg_count_c"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            msg_count_t \u003d msg_col.find().count()"},{"line_number":105,"context_line":"            KPI[\u0027message_amount\u0027][\u0027total\u0027] +\u003d msg_count_t"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_802efe40","line":102,"in_reply_to":"baada198_80f6088f","updated":"2014-07-17 00:06:08.000000000","message":"Done","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            msg_count_c \u003d msg_col.find({\u0027c.id\u0027: {\u0027$ne\u0027: None}}).count()"},{"line_number":102,"context_line":"            KPI[\u0027message_amount\u0027][\u0027claimed\u0027] +\u003d msg_count_c"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            msg_count_t \u003d msg_col.find().count()"},{"line_number":105,"context_line":"            KPI[\u0027message_amount\u0027][\u0027total\u0027] +\u003d msg_count_t"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        KPI[\u0027message_amount\u0027][\u0027free\u0027] \u003d (KPI[\u0027message_amount\u0027][\u0027total\u0027] -"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_60457416","line":104,"updated":"2014-07-16 18:15:34.000000000","message":"STYLE: See above comment.","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            msg_count_c \u003d msg_col.find({\u0027c.id\u0027: {\u0027$ne\u0027: None}}).count()"},{"line_number":102,"context_line":"            KPI[\u0027message_amount\u0027][\u0027claimed\u0027] +\u003d msg_count_c"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"            msg_count_t \u003d msg_col.find().count()"},{"line_number":105,"context_line":"            KPI[\u0027message_amount\u0027][\u0027total\u0027] +\u003d msg_count_t"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        KPI[\u0027message_amount\u0027][\u0027free\u0027] \u003d (KPI[\u0027message_amount\u0027][\u0027total\u0027] -"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_80399ea5","line":104,"in_reply_to":"baada198_60457416","updated":"2014-07-17 00:06:08.000000000","message":"Done","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"73013506e0d8d6a38f56b6168802d84657f60ec6","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        except pymongo.errors.PyMongoError:"},{"line_number":90,"context_line":"            return False"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_5468d2b9","line":92,"updated":"2014-07-18 18:14:39.000000000","message":"STYLE: I\u0027m OK with keeping the name as-is, since not everyone is familiar with the term KPI, as you pointed out.","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"},{"line_number":96,"context_line":"        message_volume \u003d {\u0027free\u0027: 0, \u0027claimed\u0027: 0, \u0027total\u0027: 0}"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_ce80d54b","line":94,"updated":"2014-08-01 09:25:33.000000000","message":"Could this one be moved to the base class?","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"},{"line_number":96,"context_line":"        message_volume \u003d {\u0027free\u0027: 0, \u0027claimed\u0027: 0, \u0027total\u0027: 0}"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_6476aca4","line":94,"in_reply_to":"baada198_ce80d54b","updated":"2014-08-19 06:18:02.000000000","message":"Yes, we could. But I would prefer to keep it here. Since I would like to keep all the storage related health KPI in storage driver level and keep those coming transport level KPI in base.py. Hope it make some senses for you. Cheers.","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"},{"line_number":96,"context_line":"        message_volume \u003d {\u0027free\u0027: 0, \u0027claimed\u0027: 0, \u0027total\u0027: 0}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        for msg_col in [db.messages for db in self.message_databases]:"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_0e772d8f","line":95,"updated":"2014-08-01 09:25:33.000000000","message":"ditto","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def _health(self):"},{"line_number":93,"context_line":"        KPI \u003d {}"},{"line_number":94,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":95,"context_line":"        KPI[\u0027operation_status\u0027] \u003d self._get_operation_status()"},{"line_number":96,"context_line":"        message_volume \u003d {\u0027free\u0027: 0, \u0027claimed\u0027: 0, \u0027total\u0027: 0}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        for msg_col in [db.messages for db in self.message_databases]:"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_846900c2","line":95,"in_reply_to":"baada198_0e772d8f","updated":"2014-08-19 06:18:02.000000000","message":"I would say no because the operation_status should be collected from the node level instead of catalog level, IMHO. Though they may work as the same, but I prefer to keep it here to make logic at pooling.py more clear. Cheers.","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"}],"marconi/queues/storage/mongodb/queues.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"# Copyright 2014 Catalyst IT Ltd"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_ced1b530","line":2,"updated":"2014-08-01 09:25:33.000000000","message":"no need to change this file","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Red Hat, Inc."},{"line_number":2,"context_line":"# Copyright 2014 Catalyst IT Ltd"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_21dbc6ea","line":2,"in_reply_to":"baada198_ced1b530","updated":"2014-08-19 06:18:02.000000000","message":"Done","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"}],"marconi/queues/storage/pooling.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        KPI \u003d {}"},{"line_number":81,"context_line":"        # Leverage the is_alive to indicate if the backend storage is"},{"line_number":82,"context_line":"        # reachable or not"},{"line_number":83,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":84,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {}"},{"line_number":85,"context_line":"        KPI[\u0027operation_status\u0027] \u003d {}"},{"line_number":86,"context_line":"        # Messages of each pool"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_9b6d999c","line":83,"updated":"2014-07-16 18:15:34.000000000","message":"IMO: I think using the same key in the pool meta-driver as used to report this for real drivers could be confusing. What about \"catalog_reachable\" or something like that?","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        KPI \u003d {}"},{"line_number":81,"context_line":"        # Leverage the is_alive to indicate if the backend storage is"},{"line_number":82,"context_line":"        # reachable or not"},{"line_number":83,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":84,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {}"},{"line_number":85,"context_line":"        KPI[\u0027operation_status\u0027] \u003d {}"},{"line_number":86,"context_line":"        # Messages of each pool"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_408a2665","line":83,"in_reply_to":"baada198_9b6d999c","updated":"2014-07-17 00:06:08.000000000","message":"Done","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        # Leverage the is_alive to indicate if the backend storage is"},{"line_number":82,"context_line":"        # reachable or not"},{"line_number":83,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":84,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {}"},{"line_number":85,"context_line":"        KPI[\u0027operation_status\u0027] \u003d {}"},{"line_number":86,"context_line":"        # Messages of each pool"},{"line_number":87,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_5b45c115","line":84,"updated":"2014-07-16 18:15:34.000000000","message":"NIT: I think we can remove this and the following if they are empty; when working with JSON is is typical to leave out fields if they are \"empty\" or \"null\".","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        # Leverage the is_alive to indicate if the backend storage is"},{"line_number":82,"context_line":"        # reachable or not"},{"line_number":83,"context_line":"        KPI[\u0027storage_reachable\u0027] \u003d self.is_alive()"},{"line_number":84,"context_line":"        KPI[\u0027message_amount\u0027] \u003d {}"},{"line_number":85,"context_line":"        KPI[\u0027operation_status\u0027] \u003d {}"},{"line_number":86,"context_line":"        # Messages of each pool"},{"line_number":87,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_208ff276","line":84,"in_reply_to":"baada198_5b45c115","updated":"2014-07-17 00:06:08.000000000","message":"Done","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"af5910665081172678516cb879f6ff1764db3f59","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Messages of each pool"},{"line_number":87,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"},{"line_number":88,"context_line":"            h \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])._health()"},{"line_number":89,"context_line":"            KPI[\u0027message_amount\u0027][pool[\u0027name\u0027]] \u003d h[\u0027message_amount\u0027]"},{"line_number":90,"context_line":"            KPI[\u0027operation_status\u0027][pool[\u0027name\u0027]] \u003d h[\u0027operation_status\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return KPI"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_3b6d6dcd","line":89,"updated":"2014-07-16 18:15:34.000000000","message":"DSQ: I think it may make more sense to move pools up one level in the hierarchy, since IMO operators tend to think more top-down in terms of managing a large system. E.g.,:\n\n    {\n        \"storage_reachable\": True,\n        \"pools\": {\n            \"LON-REDIS-01\": {\n                \"message_volume\": {\n                    ...\n                },\n                \"operation_status\": {\n                    \"...\"\n                }\n            },\n            \"LON-REDIS-02\": {\n                \"message_volume\": {\n                    ...\n                },\n                \"operation_status\": {\n                    \"...\"\n                }\n            },\n            \"LON-MONGODB-01\": {\n                \"message_volume\": {\n                    ...\n                },\n                \"operation_status\": {\n                    \"...\"\n                }\n            }\n        }\n    }","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"086d1e820a19b452d36652459b697965543a5c47","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Messages of each pool"},{"line_number":87,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"},{"line_number":88,"context_line":"            h \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])._health()"},{"line_number":89,"context_line":"            KPI[\u0027message_amount\u0027][pool[\u0027name\u0027]] \u003d h[\u0027message_amount\u0027]"},{"line_number":90,"context_line":"            KPI[\u0027operation_status\u0027][pool[\u0027name\u0027]] \u003d h[\u0027operation_status\u0027]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return KPI"}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_e0db3a7b","line":89,"in_reply_to":"baada198_3b6d6dcd","updated":"2014-07-17 00:06:08.000000000","message":"Yep,  make sense.","commit_id":"3e3bb0bd620cb58d9e6525804bdc1a8bac141f54"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"73013506e0d8d6a38f56b6168802d84657f60ec6","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # Messages of each pool"},{"line_number":86,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"},{"line_number":87,"context_line":"            h \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])._health()"},{"line_number":88,"context_line":"            KPI[pool[\u0027name\u0027]] \u003d {}"},{"line_number":89,"context_line":"            KPI[pool[\u0027name\u0027]][\u0027message_volume\u0027] \u003d h[\u0027message_volume\u0027]"},{"line_number":90,"context_line":"            KPI[pool[\u0027name\u0027]][\u0027operation_status\u0027] \u003d h[\u0027operation_status\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_94b50a34","line":87,"updated":"2014-07-18 18:14:39.000000000","message":"STYLE: No single-letter variable names except for mathematical formulae. Thanks!","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7eb3c8a883580a5592fe11aed23995dfff0f08c3","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # Messages of each pool"},{"line_number":86,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"},{"line_number":87,"context_line":"            h \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])._health()"},{"line_number":88,"context_line":"            KPI[pool[\u0027name\u0027]] \u003d {}"},{"line_number":89,"context_line":"            KPI[pool[\u0027name\u0027]][\u0027message_volume\u0027] \u003d h[\u0027message_volume\u0027]"},{"line_number":90,"context_line":"            KPI[pool[\u0027name\u0027]][\u0027operation_status\u0027] \u003d h[\u0027operation_status\u0027]"}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_10ad6631","line":87,"in_reply_to":"baada198_94b50a34","updated":"2014-07-20 22:30:34.000000000","message":"Done","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"73013506e0d8d6a38f56b6168802d84657f60ec6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # Messages of each pool"},{"line_number":86,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"},{"line_number":87,"context_line":"            h \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])._health()"},{"line_number":88,"context_line":"            KPI[pool[\u0027name\u0027]] \u003d {}"},{"line_number":89,"context_line":"            KPI[pool[\u0027name\u0027]][\u0027message_volume\u0027] \u003d h[\u0027message_volume\u0027]"},{"line_number":90,"context_line":"            KPI[pool[\u0027name\u0027]][\u0027operation_status\u0027] \u003d h[\u0027operation_status\u0027]"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_b465aeb0","line":88,"updated":"2014-07-18 18:14:39.000000000","message":"DRY: What do you think about simply assigning the health dict directly?\n\n    KPI[pool[\u0027name\u0027]] \u003d h","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"7eb3c8a883580a5592fe11aed23995dfff0f08c3","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        # Messages of each pool"},{"line_number":86,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"},{"line_number":87,"context_line":"            h \u003d self._pool_catalog.get_driver(pool[\u0027name\u0027])._health()"},{"line_number":88,"context_line":"            KPI[pool[\u0027name\u0027]] \u003d {}"},{"line_number":89,"context_line":"            KPI[pool[\u0027name\u0027]][\u0027message_volume\u0027] \u003d h[\u0027message_volume\u0027]"},{"line_number":90,"context_line":"            KPI[pool[\u0027name\u0027]][\u0027operation_status\u0027] \u003d h[\u0027operation_status\u0027]"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"baada198_7063021a","line":88,"in_reply_to":"baada198_b465aeb0","updated":"2014-07-20 22:30:34.000000000","message":"Done","commit_id":"3fa85688827511cc06c49e0fc70ce54654325c61"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        KPI \u003d {}"},{"line_number":81,"context_line":"        # Leverage the is_alive to indicate if the backend storage is"},{"line_number":82,"context_line":"        # reachable or not"},{"line_number":83,"context_line":"        KPI[\u0027catalog_reachable\u0027] \u003d self.is_alive()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # Messages of each pool"},{"line_number":86,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_ae964147","line":83,"updated":"2014-08-01 09:25:33.000000000","message":"What about operation_status ?","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        KPI \u003d {}"},{"line_number":81,"context_line":"        # Leverage the is_alive to indicate if the backend storage is"},{"line_number":82,"context_line":"        # reachable or not"},{"line_number":83,"context_line":"        KPI[\u0027catalog_reachable\u0027] \u003d self.is_alive()"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # Messages of each pool"},{"line_number":86,"context_line":"        for pool in self._pool_catalog._pools_ctrl.list():"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_e1d46ebc","line":83,"in_reply_to":"baada198_ae964147","updated":"2014-08-19 06:18:02.000000000","message":"operation_status has been used to indicate the status of those message/queue operations. This one is used to indicate if all pool nodes are alive.","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"}],"marconi/queues/storage/sharding.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def _health(self):"},{"line_number":82,"context_line":"        KPI \u003d {}"},{"line_number":83,"context_line":"        # Number of active shards"},{"line_number":84,"context_line":"        shards_count \u003d len(self._shard_catalog._shards_ctrl.list(limit\u003d0))"},{"line_number":85,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":86,"context_line":"        return KPI"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuTw%3D","line":84,"updated":"2014-03-04 14:36:31.000000000","message":"you may want to do something similar to what `is_alive` does. That is, calling `health` on each data driver","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"561e60d12fc7b887501ffe2374a6d4da272debae","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def _health(self):"},{"line_number":82,"context_line":"        KPI \u003d {}"},{"line_number":83,"context_line":"        # Number of active shards"},{"line_number":84,"context_line":"        shards_count \u003d len(self._shard_catalog._shards_ctrl.list(limit\u003d0))"},{"line_number":85,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":86,"context_line":"        return KPI"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fsas%3D","line":84,"in_reply_to":"AAAAVn%2F%2FuTw%3D","updated":"2014-03-04 16:31:25.000000000","message":"Hmm... I can see your point, but I think it depends the KPI. As for the number of active shards, any concerns about current implement?","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"}],"marconi/queues/storage/sqlalchemy/driver.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        KPI \u003d {}"},{"line_number":117,"context_line":"        # Number of active shards"},{"line_number":118,"context_line":"        shards_count \u003d int(self.get(\u0027\u0027\u0027select count(*) from Shards\u0027\u0027\u0027)[0])"},{"line_number":119,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":120,"context_line":"        return KPI"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FuNk%3D","line":119,"updated":"2014-03-04 14:36:31.000000000","message":"this is probably relevant just for the ShardDriver","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"4a2aed274e64bafc60e40dba5716842c13de3d93","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        KPI \u003d {}"},{"line_number":117,"context_line":"        # Number of active shards"},{"line_number":118,"context_line":"        shards_count \u003d int(self.get(\u0027\u0027\u0027select count(*) from Shards\u0027\u0027\u0027)[0])"},{"line_number":119,"context_line":"        KPI[\u0027active_shards\u0027] \u003d shards_count"},{"line_number":120,"context_line":"        return KPI"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fr1A%3D","line":119,"in_reply_to":"AAAAVn%2F%2FuNk%3D","updated":"2014-03-04 17:31:58.000000000","message":"That\u0027s correct. Could you remove \u0027active_shards\u0027 from the KPI here, or only make it present in the case that sharding is enabled?","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"512596b74a287693758a926423c66fd4cba0338b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        KPI[\u0027message_volume\u0027][\u0027claimed\u0027] \u003d int(msg_count_claimed[0])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        msg_count_total \u003d self.get(\u0027SELECT COUNT(*) FROM MESSAGES\u0027)"},{"line_number":135,"context_line":"        KPI[\u0027message_volume\u0027][\u0027total\u0027] \u003d int(msg_count_total[0])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        KPI[\u0027message_volume\u0027][\u0027free\u0027] \u003d (KPI[\u0027message_volume\u0027][\u0027total\u0027] -"},{"line_number":138,"context_line":"                                         KPI[\u0027message_volume\u0027][\u0027claimed\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_00732a80","line":135,"updated":"2014-07-22 00:49:53.000000000","message":"DRY: Rather than calling KPI[\u0027message_volume\u0027] over and over again, you can do what you did in the mongo driver and have a direct ref to the dict, then set it once when it is built out...","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"512596b74a287693758a926423c66fd4cba0338b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        KPI[\u0027message_volume\u0027][\u0027claimed\u0027] \u003d int(msg_count_claimed[0])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        msg_count_total \u003d self.get(\u0027SELECT COUNT(*) FROM MESSAGES\u0027)"},{"line_number":135,"context_line":"        KPI[\u0027message_volume\u0027][\u0027total\u0027] \u003d int(msg_count_total[0])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        KPI[\u0027message_volume\u0027][\u0027free\u0027] \u003d (KPI[\u0027message_volume\u0027][\u0027total\u0027] -"},{"line_number":138,"context_line":"                                         KPI[\u0027message_volume\u0027][\u0027claimed\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_a0627eaa","line":135,"updated":"2014-07-22 00:49:53.000000000","message":"DRY: Rather than calling KPI[\u0027message_volume\u0027] over and over again, you can do what you did in the mongo driver and have a direct ref to the dict, then set it once when it is built out...","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ded46ba38680b6d2395cedccb12cbc09299b80f5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        KPI[\u0027message_volume\u0027][\u0027claimed\u0027] \u003d int(msg_count_claimed[0])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        msg_count_total \u003d self.get(\u0027SELECT COUNT(*) FROM MESSAGES\u0027)"},{"line_number":135,"context_line":"        KPI[\u0027message_volume\u0027][\u0027total\u0027] \u003d int(msg_count_total[0])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        KPI[\u0027message_volume\u0027][\u0027free\u0027] \u003d (KPI[\u0027message_volume\u0027][\u0027total\u0027] -"},{"line_number":138,"context_line":"                                         KPI[\u0027message_volume\u0027][\u0027claimed\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_6e752d32","line":135,"in_reply_to":"baada198_00732a80","updated":"2014-07-25 06:55:41.000000000","message":"Done","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ded46ba38680b6d2395cedccb12cbc09299b80f5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        KPI[\u0027message_volume\u0027][\u0027claimed\u0027] \u003d int(msg_count_claimed[0])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        msg_count_total \u003d self.get(\u0027SELECT COUNT(*) FROM MESSAGES\u0027)"},{"line_number":135,"context_line":"        KPI[\u0027message_volume\u0027][\u0027total\u0027] \u003d int(msg_count_total[0])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        KPI[\u0027message_volume\u0027][\u0027free\u0027] \u003d (KPI[\u0027message_volume\u0027][\u0027total\u0027] -"},{"line_number":138,"context_line":"                                         KPI[\u0027message_volume\u0027][\u0027claimed\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_8e744137","line":135,"in_reply_to":"baada198_a0627eaa","updated":"2014-07-25 06:55:41.000000000","message":"Done","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"}],"marconi/queues/transport/wsgi/v1_1/health.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38fac942d7321ff631d2f4da79473a9579cecd7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 IBM Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FcBg%3D","line":2,"updated":"2014-02-26 16:40:07.000000000","message":"All rights reserved is not needed. Also, pls add IBM\u0027s line below RAX\u0027s","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33c9d82bd7e00d9c42b863c400da9fa7175f37fe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 IBM Corp."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F3u4%3D","line":2,"in_reply_to":"AAAAU3%2F%2FcBg%3D","updated":"2014-02-27 17:21:57.000000000","message":"Done","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38fac942d7321ff631d2f4da79473a9579cecd7a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# limitations under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from marconi.openstack.common.gettextutils import _"},{"line_number":19,"context_line":"import marconi.openstack.common.log as logging"},{"line_number":20,"context_line":"from marconi.queues.transport import utils"},{"line_number":21,"context_line":"from marconi.queues.transport.wsgi import errors as wsgi_errors"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fb%2Bg%3D","line":19,"updated":"2014-02-26 16:40:07.000000000","message":"could you make this `from .... import log as logging` ?","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33c9d82bd7e00d9c42b863c400da9fa7175f37fe","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# limitations under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from marconi.openstack.common.gettextutils import _"},{"line_number":19,"context_line":"import marconi.openstack.common.log as logging"},{"line_number":20,"context_line":"from marconi.queues.transport import utils"},{"line_number":21,"context_line":"from marconi.queues.transport.wsgi import errors as wsgi_errors"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F3us%3D","line":19,"in_reply_to":"AAAAU3%2F%2Fb%2Bg%3D","updated":"2014-02-27 17:21:57.000000000","message":"Done","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"38fac942d7321ff631d2f4da79473a9579cecd7a","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"            resp.content_location \u003d req.path"},{"line_number":38,"context_line":"            resp.body \u003d utils.to_json(resp_dict)"},{"line_number":39,"context_line":"            # status defaults to 200"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        except Exception as ex:"},{"line_number":42,"context_line":"            LOG.exception(ex)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2FcBQ%3D","line":39,"updated":"2014-02-26 16:40:07.000000000","message":"this comment is not needed","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"33c9d82bd7e00d9c42b863c400da9fa7175f37fe","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"            resp.content_location \u003d req.path"},{"line_number":38,"context_line":"            resp.body \u003d utils.to_json(resp_dict)"},{"line_number":39,"context_line":"            # status defaults to 200"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        except Exception as ex:"},{"line_number":42,"context_line":"            LOG.exception(ex)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2F3uc%3D","line":39,"in_reply_to":"AAAAU3%2F%2FcBQ%3D","updated":"2014-02-27 17:21:57.000000000","message":"Done","commit_id":"39b887f25c2be418aa6b7685434d1e28cecf13ad"},{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"c69bb7289d558f4a4785507c21aa6322acd0adbe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Rackspace, Inc."},{"line_number":2,"context_line":"# Copyright 2014 IBM Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may not"},{"line_number":5,"context_line":"# use this file except in compliance with the License.  You may obtain a copy"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_4cd4a61f","line":2,"updated":"2014-07-14 08:18:26.000000000","message":"should we also append the 2014 for Rackspace?  \n\nI mean 2013,2014 Rackspace, Inc.\n\nand still IBM?","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"67ea0981412a67377916ed2a810df34b9ddd0a5b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Rackspace, Inc."},{"line_number":2,"context_line":"# Copyright 2014 IBM Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may not"},{"line_number":5,"context_line":"# use this file except in compliance with the License.  You may obtain a copy"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_42dd31df","line":2,"in_reply_to":"baada198_4cd4a61f","updated":"2014-07-14 21:19:10.000000000","message":"I think I should remove the Rackspace and add my current company.\n\nAnd because most of the work is done when I was working for IBM. So that\u0027s why I prefer to keep the IBM copyright. I\u0027m not sure if it\u0027s a best practice, TBH.","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Rackspace, Inc."},{"line_number":2,"context_line":"# Copyright 2014 IBM Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may not"},{"line_number":5,"context_line":"# use this file except in compliance with the License.  You may obtain a copy"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_0e7d6d1e","line":2,"updated":"2014-08-01 09:25:33.000000000","message":"IBM ?","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Rackspace, Inc."},{"line_number":2,"context_line":"# Copyright 2014 IBM Corp."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may not"},{"line_number":5,"context_line":"# use this file except in compliance with the License.  You may obtain a copy"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_a18196c3","line":2,"in_reply_to":"baada198_0e7d6d1e","updated":"2014-08-19 06:18:02.000000000","message":"Done","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"}],"marconi/tests/functional/base.py":[{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"337c95a0e5e4b79d9b7170abddcbcb0d58086bb1","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            self.client \u003d http.Client()"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            if self.server_class \u003d\u003d MarconiAdminServer:"},{"line_number":85,"context_line":"                self.mconf.pooling \u003d True"},{"line_number":86,"context_line":"                self.mconf.admin_mode \u003d True"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_2b05b80f","line":84,"updated":"2014-07-25 06:58:30.000000000","message":"I think there are something wrong or just mess with our current functional test, when enabling the admin and pool. So I\u0027m changing it a little bit to make it works. \n\nAnd I also opened a bug to track this issue about pool functional test, see https://bugs.launchpad.net/marconi/+bug/1348453","commit_id":"9eba5f13d9d9f3a7123a2ac4ec39bc4e951f04a4"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            self.client \u003d http.Client()"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            if self.server_class \u003d\u003d MarconiAdminServer:"},{"line_number":85,"context_line":"                self.mconf.pooling \u003d True"},{"line_number":86,"context_line":"                self.mconf.admin_mode \u003d True"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_8ebeddad","line":84,"updated":"2014-08-01 09:25:33.000000000","message":"NIT: `inspect.isclass` would probably be better, nothing important.","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"1c4cfc16ba8329bd53ba130ce8e3e352f8870925","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            self.client \u003d http.Client()"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            if self.server_class \u003d\u003d MarconiAdminServer:"},{"line_number":85,"context_line":"                self.mconf.pooling \u003d True"},{"line_number":86,"context_line":"                self.mconf.admin_mode \u003d True"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1abeadc6_c600de03","line":84,"in_reply_to":"baada198_6114de9e","updated":"2014-08-20 08:27:28.000000000","message":"(facepalm) I meant to say `issubclass` not `isclass`","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            self.client \u003d http.Client()"},{"line_number":83,"context_line":"        else:"},{"line_number":84,"context_line":"            if self.server_class \u003d\u003d MarconiAdminServer:"},{"line_number":85,"context_line":"                self.mconf.pooling \u003d True"},{"line_number":86,"context_line":"                self.mconf.admin_mode \u003d True"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_6114de9e","line":84,"in_reply_to":"baada198_8ebeddad","updated":"2014-08-19 06:18:02.000000000","message":"inspect.isclass() is used to check if the param is a class or not, but here, we need to check if the class is the one we want. See https://docs.python.org/2/library/inspect.html#inspect.isclass","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"}],"marconi/tests/queues/transport/wsgi/test_health.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class TestHealth(base.TestBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestHealth, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def tearDown(self):"},{"line_number":32,"context_line":"        super(TestHealth, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Ftto%3D","line":29,"updated":"2014-03-04 14:36:31.000000000","message":"no need to have it here, nor the `tearDown` one.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"561e60d12fc7b887501ffe2374a6d4da272debae","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class TestHealth(base.TestBase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(TestHealth, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def tearDown(self):"},{"line_number":32,"context_line":"        super(TestHealth, self).tearDown()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FsZo%3D","line":29,"in_reply_to":"AAAAVn%2F%2Ftto%3D","updated":"2014-03-04 16:31:25.000000000","message":"Done","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6944,"name":"Allele Dev","email":"cpp.cabrera@gmail.com","username":"cpp-cabrera"},"change_message_id":"4a2aed274e64bafc60e40dba5716842c13de3d93","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        body \u003d self.simulate_get(path)"},{"line_number":37,"context_line":"        health_KPI \u003d json.loads(body[0])"},{"line_number":38,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":39,"context_line":"        self.assertIsNotNone(health_KPI[\u0027active_shards\u0027])"},{"line_number":40,"context_line":"        self.assertIsNotNone(health_KPI[\u0027cpu_util\u0027])"},{"line_number":41,"context_line":"        self.assertIsNotNone(health_KPI[\u0027memory_util\u0027])"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2Fr0U%3D","line":39,"updated":"2014-03-04 17:31:58.000000000","message":"as per previous feedback, \u0027active_shards\u0027 should not always be present.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"54c6ce977af2187858a2317e51f541578417d9cb","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    config_file \u003d \u0027wsgi_mongodb.conf\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @testing.requires_mongodb"},{"line_number":54,"context_line":"    def setUp(self):"},{"line_number":55,"context_line":"        super(TestHealthMongoDB, self).setUp()"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FttE%3D","line":53,"updated":"2014-03-04 14:36:31.000000000","message":"I *think* this decorator could also go in the class definition, I could be wrong, though.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"561e60d12fc7b887501ffe2374a6d4da272debae","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    config_file \u003d \u0027wsgi_mongodb.conf\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @testing.requires_mongodb"},{"line_number":54,"context_line":"    def setUp(self):"},{"line_number":55,"context_line":"        super(TestHealthMongoDB, self).setUp()"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FsZs%3D","line":53,"in_reply_to":"AAAAVn%2F%2FttE%3D","updated":"2014-03-04 16:31:25.000000000","message":"I\u0027m just following the style from the other implements. I will confirm that.","commit_id":"d16116ddaa64c9b5debfeabbc5dea93ec90659ef"}],"marconi/tests/queues/transport/wsgi/v1_1/test_health.py":[{"author":{"_account_id":10634,"name":"Peng Fei Wang","email":"wpf710@gmail.com","username":"wpf"},"change_message_id":"c69bb7289d558f4a4785507c21aa6322acd0adbe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_cccef682","line":2,"updated":"2014-07-14 08:18:26.000000000","message":"Still IBM?","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"67ea0981412a67377916ed2a810df34b9ddd0a5b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_428b71c2","line":2,"in_reply_to":"baada198_cccef682","updated":"2014-07-14 21:19:10.000000000","message":"Done","commit_id":"9273d0a058e72f65ade62d3e55913821a4b6ba28"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"512596b74a287693758a926423c66fd4cba0338b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":39,"context_line":"        self.assertTrue(health[\u0027storage_reachable\u0027])"},{"line_number":40,"context_line":"        self.assertIsNotNone(health[\u0027message_volume\u0027])"},{"line_number":41,"context_line":"        for op in health[\u0027operation_status\u0027].keys():"},{"line_number":42,"context_line":"            self.assertTrue(health[\u0027operation_status\u0027][op][\u0027succeeded\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @mock.patch.object(sql.driver.DataDriver, \u0027get\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_86d11259","line":41,"updated":"2014-07-22 00:49:53.000000000","message":"NIT: calling keys() is not necessary when iterating over a dict, is it?","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ded46ba38680b6d2395cedccb12cbc09299b80f5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.assertEqual(self.srmock.status, falcon.HTTP_200)"},{"line_number":39,"context_line":"        self.assertTrue(health[\u0027storage_reachable\u0027])"},{"line_number":40,"context_line":"        self.assertIsNotNone(health[\u0027message_volume\u0027])"},{"line_number":41,"context_line":"        for op in health[\u0027operation_status\u0027].keys():"},{"line_number":42,"context_line":"            self.assertTrue(health[\u0027operation_status\u0027][op][\u0027succeeded\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @mock.patch.object(sql.driver.DataDriver, \u0027get\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_ceb479d6","line":41,"in_reply_to":"baada198_86d11259","updated":"2014-07-25 06:55:41.000000000","message":"Done","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @mock.patch.object(sql.driver.DataDriver, \u0027get\u0027)"},{"line_number":45,"context_line":"    def test_message_volume(self, mock_driver_get):"},{"line_number":46,"context_line":"        def _get(sql):"},{"line_number":47,"context_line":"            if sql \u003d\u003d \u0027SELECT COUNT(*) FROM MESSAGES\u0027:"},{"line_number":48,"context_line":"                return [2]"},{"line_number":49,"context_line":"            else:"},{"line_number":50,"context_line":"                return [1]"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_ee15999b","line":47,"range":{"start_line":47,"start_character":15,"end_line":47,"end_character":18},"updated":"2014-08-01 09:25:33.000000000","message":"Mind adding a fixme here mentioning `disable-sqlalchemy-as-pool` ? We need to clean this up after deprecating sqlalchemy","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @mock.patch.object(sql.driver.DataDriver, \u0027get\u0027)"},{"line_number":45,"context_line":"    def test_message_volume(self, mock_driver_get):"},{"line_number":46,"context_line":"        def _get(sql):"},{"line_number":47,"context_line":"            if sql \u003d\u003d \u0027SELECT COUNT(*) FROM MESSAGES\u0027:"},{"line_number":48,"context_line":"                return [2]"},{"line_number":49,"context_line":"            else:"},{"line_number":50,"context_line":"                return [1]"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_8107326f","line":47,"in_reply_to":"baada198_ee15999b","updated":"2014-08-19 06:18:02.000000000","message":"Done","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"}],"tests/functional/wsgi/v1_1/test_health.py":[{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"9807e5cd78d309638f10ec02de6d0637211f42ca","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        {"},{"line_number":37,"context_line":"            \u0027name\u0027: \"mongo_pool_1\","},{"line_number":38,"context_line":"            \u0027weight\u0027: 10,"},{"line_number":39,"context_line":"            \u0027uri\u0027: \"mongodb://127.0.0.1:27017\""},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"    )"},{"line_number":42,"context_line":"    def test_health_with_pool(self, params):"}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_dee38ed6","line":39,"updated":"2014-07-29 21:51:38.000000000","message":"BUG: Generally we don\u0027t require mongo to be present to test marconi; can you support testing with sqla pool as well, and make mongo optional? Other tests have used the requires_mongodb decorator or referenced SKIP_MONGODB_TESTS (both are in marconi/marconi/tests/helpers.py)","commit_id":"9eba5f13d9d9f3a7123a2ac4ec39bc4e951f04a4"},{"author":{"_account_id":6427,"name":"Kurt Griffiths","email":"kurt.griffiths@rackspace.com","username":"kgriffs"},"change_message_id":"e35a5fb37ae3dd943ecf420285f951412d726b1b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        {"},{"line_number":37,"context_line":"            \u0027name\u0027: \"pool_1\","},{"line_number":38,"context_line":"            \u0027weight\u0027: 10,"},{"line_number":39,"context_line":"            \u0027uri\u0027: \"sqlite:///:memory:\""},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"    )"},{"line_number":42,"context_line":"    def test_health_with_pool(self, params):"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_2f3d36bd","line":39,"updated":"2014-07-30 17:45:27.000000000","message":"IMO: I think it is OK that only sqla is tested here.  mongodb _health endpoint is covered in unit test. Here we just need to check that the aggregation logic is working (i.e., the logic that queries each pool and combines the results into a list), so it shouldn\u0027t matter which driver we use.","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"fdf0de751fd79f45c94d8e8c4faa66f7d6eb91e9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        {"},{"line_number":37,"context_line":"            \u0027name\u0027: \"pool_1\","},{"line_number":38,"context_line":"            \u0027weight\u0027: 10,"},{"line_number":39,"context_line":"            \u0027uri\u0027: \"sqlite:///:memory:\""},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"    )"},{"line_number":42,"context_line":"    def test_health_with_pool(self, params):"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_6efd093b","line":39,"in_reply_to":"baada198_2f3d36bd","updated":"2014-08-01 09:25:33.000000000","message":"This will need to be updated when sqlalchemy will be fully deprecated. Mind adding a note mentioning `disable-sqlalchemy-as-pool` ?","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"a3ef1702c88effddc64cf08a3649c181928f7f61","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        {"},{"line_number":37,"context_line":"            \u0027name\u0027: \"pool_1\","},{"line_number":38,"context_line":"            \u0027weight\u0027: 10,"},{"line_number":39,"context_line":"            \u0027uri\u0027: \"sqlite:///:memory:\""},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"    )"},{"line_number":42,"context_line":"    def test_health_with_pool(self, params):"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_c124ca0f","line":39,"in_reply_to":"baada198_6efd093b","updated":"2014-08-19 06:18:02.000000000","message":"Done","commit_id":"657e02ddbadc9ee1b771930d4e181e8b2b2e0e4b"}],"tests/functional/wsgi/v1_1/test_queues.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"c4186bd0334539d780120e43f967d798fc1ca5d2","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.assertEqual(result.status_code, 400)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    test_list_queue_invalid_limit.tags \u003d [\u0027negative\u0027]"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_check_queue_exists(self):"},{"line_number":242,"context_line":"        \"\"\"Checks if queue exists.\"\"\""},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_3eba9471","line":240,"updated":"2014-07-23 19:14:07.000000000","message":"Can you replace the test_check_health with a new test?","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ded46ba38680b6d2395cedccb12cbc09299b80f5","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        self.assertEqual(result.status_code, 400)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    test_list_queue_invalid_limit.tags \u003d [\u0027negative\u0027]"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_check_queue_exists(self):"},{"line_number":242,"context_line":"        \"\"\"Checks if queue exists.\"\"\""},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_8e1e01ba","line":240,"in_reply_to":"baada198_3eba9471","updated":"2014-07-25 06:55:41.000000000","message":"It\u0027s renamed from /ping, the old health check. Based on the new /health implement, I don\u0027t think it\u0027s appropriate to put it at here continually.","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"}],"tests/functional/wsgi/v1_1/test_shards.py":[{"author":{"_account_id":7498,"name":"Malini Kamalambal","email":"malini.kamalambal@rackspace.com","username":"malini-pk"},"change_message_id":"c4186bd0334539d780120e43f967d798fc1ca5d2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from marconi.tests.functional import base"},{"line_number":18,"context_line":"from marconi.tests.functional import helpers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"},{"line_number":22,"context_line":"class TestShards(base.V1_1FunctionalTestBase):"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_3e8d342b","line":20,"updated":"2014-07-23 19:14:07.000000000","message":"This is probably what we discussed in IRC - do we need @testing.requires_mongodb for this?","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ded46ba38680b6d2395cedccb12cbc09299b80f5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from marconi.tests.functional import base"},{"line_number":18,"context_line":"from marconi.tests.functional import helpers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"},{"line_number":22,"context_line":"class TestShards(base.V1_1FunctionalTestBase):"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"baada198_b02a138f","line":20,"in_reply_to":"baada198_3e8d342b","updated":"2014-07-25 06:55:41.000000000","message":"I will create a separate test file for health.","commit_id":"8964454d20eca7ad7f5c7cc269367cf93309c241"}],"zaqar/queues/storage/base.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"679eb05135708eb37292470baad2697e73856f60","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def health(self):"},{"line_number":78,"context_line":"        \"\"\"Return the health status of service.\"\"\""},{"line_number":79,"context_line":"        overall_health \u003d {}"},{"line_number":80,"context_line":"        # NOTE(flwang): KPI extracted from different storage backends,"},{"line_number":81,"context_line":"        # _health() will be implemented by different storage drivers."},{"line_number":82,"context_line":"        backend_health \u003d self._health()"}],"source_content_type":"text/x-python","patch_set":17,"id":"1abeadc6_c985ee5a","line":79,"updated":"2014-08-22 14:29:24.000000000","message":"Is overall_health really needed? backend_health could be returned directly or {} if it\u0027s empty. Not a blocker though :)","commit_id":"13df51be82fcac8cdb0e8d4e77824a5ddb81fea7"}]}
